D21218: Create new icon for Knights based on Anjuta's icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:5a2dfb5804ba: Create new icon for Knights based on Anjuta's icon (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21218?vs=58105&id=58109#toc REPOSITORY R266 Breeze Icon

D21218: Create new icon for Knights based on Anjuta's icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg, ndavis Cc: ndavis, ognarb, kd

D21218: Create new icon for Knights based on Anjuta's icon

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg, ndavis Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

ngraham added a comment. Thanks! REPOSITORY R266 Breeze Icons BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg, ndavis Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

ngraham updated this revision to Diff 58105. ngraham added a comment. Optimize with `scour` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21218?vs=58096&id=58105 BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https://phabricator

D21219: Don't try to index SQL database dumps

This revision was automatically updated to reflect the committed changes. Closed by commit R293:60418cff50ad: Don't try to index SQL database dumps (authored by ngraham). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21219?vs=58097&id=58104 REVISION DETAIL h

D21218: Create new icon for Knights based on Anjuta's icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Once you've optimized the SVGs, I'll approve this. https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISIO

D21219: Don't try to index SQL database dumps

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH dont-try-to-index-database-dumps (branched from master) REVISION DETAIL https://phabricator.kde.org/D21219 To: ngraham, #frameworks, bruns, mgallien Cc: kde-frameworks-devel, #ba

D21219: Don't try to index SQL database dumps

ngraham created this revision. ngraham added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY These contain no useful indexable data and can be huge, contribu

D21218: Create new icon for Knights based on Anjuta's icon

ngraham retitled this revision from "Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point" to "Create new icon for Knights based on Anjuta's icon". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ngraham updated this revision to Diff 58096. ngraham added a comment. New Knights icon based on Anjuta's REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21218?vs=58092&id=58096 BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https:

D20169: Add profile support interface for TerminalInterface

mschiller updated this revision to Diff 58095. mschiller added a comment. - Remove install of profileinterface REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=58094&id=58095 BRANCH terminal-interface-profiles (branched from master) REVISION DETAI

D20169: Add profile support interface for TerminalInterface

mschiller updated this revision to Diff 58094. mschiller added a comment. Move the interface to TerminalInterfaceV2 REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56697&id=58094 BRANCH terminal-interface-profiles (branched from master) REVISION

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ndavis added a comment. In D21218#465340 , @ognarb wrote: > Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. I think this is probably better and might

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ognarb added a comment. Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: ognarb, kde-frameworks-de

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Anjuta's icon depicts a knight-looking horse. However Anjuta is unmaintained and abandon

D21197: [KCoreDirLister] Remove assert in reinsert method

ngraham added reviewers: Frameworks, pino, elvisangelaccio, apol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21197 To: chinmoyr, dfaure, #frameworks, pino, elvisangelaccio, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Needs a rebase on master and the @since strings adjusted, but otherwise looks good to me. INLINE COMMENTS > global.h:248 > ERR_PASSWD_SERVER = KJob::UserDefinedError + 72, ///< retu

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/105/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 May 2019 15:30:51 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 May 2019 15:29:47 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compati

D20983: Exclude .gcode and virtual machine files from indexing consideration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:7f9ecb88253c: Exclude .gcode and virtual machine files from indexing consideration (authored by ngraham). REPOSITORY

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/104/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 May 2019 15:12:39 + Build duration: 18 min and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/97/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 May 2019 15:12:39 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compati

Re: Deprecating KDEWebKit?

On 5/1/19 1:39 PM, Volker Krause wrote: - Should we remove KDEWebKit from the default frameworks module set in kdesrc- build, so that especially newcomers aren't confused by the common but harmless build error caused by it? Applications actually needing it could still pull it in via an explicit d

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/108/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 15:15:33 + Build duration: 3 min 18 sec and counting JUnit Tests Na

D21155: Truncate long filname before creating a link

dfaure added a comment. The first issue is solved by the use of NAME_MAX (the code doesn't actually hardcode 255), but indeed those are bytes, so this has to use QFile::encodeName() (to get to QByteArray), truncate, then QFile::decodeName() (to get back to QString). But what if this cuts in

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/107/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 15:12:39 + Build duration: 2 min 41 sec and counting JUnit Tests Na

D21172: FrameSvg: also clear mask cache on clearCache()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f008615e3710: FrameSvg: also clear mask cache on clearCache() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21172?vs=579

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6af447a84867: FrameSvgPrivate::generateBackground: generate background also if reqp != p (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabri

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8899389c9f67: FrameSvg: make hasElementPrefix() also handle prefix with trailing - (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.

D21155: Truncate long filname before creating a link

bruns added a comment. This has several issues: - 255 is only a typical value, it can be more or less, see https://en.wikipedia.org/wiki/Comparison_of_file_systems#Limits - exFAT can store 255 UTF-16 characters - eCryptFS can only use ~140 bytes (remainder is used for mangling/pre

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixgeneratebackground REVISION DETAIL https://phabricator.kde.org/D21175 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH makehaselementprefixmatchexpectation REVISION DETAIL https://phabricator.kde.org/D21174 To: kossebau, #plasma, mart Cc: apol, kde-frameworks-devel, michaelh, ngr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/103/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 May 2019 13:39:40 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compat

D21204: Ensure no trailing slash in mountpoint read from fstab file.

ngraham added reviewers: bruns, Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D21204: Ensure no trailing slash in mountpoint read from fstab file.

bruns added inline comments. INLINE COMMENTS > fstabhandling.cpp:168 > > +// strips last slash > +if (mountpoint.at(mountpoint.length() -1) == '/') { This is a litlle bit scarce ... > apol wrote in fstabhandling.cpp:170 > you can call mountpoint.chop(2) for the same ef

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/102/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 May 2019 13:15:23 + Build duration: 24 min and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/106/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 13:30:33 + Build duration: 7 min 50 sec and counting JUnit Tests Na

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 May 2019 13:21:26 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/105/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 13:15:26 + Build duration: 14 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 May 2019 13:15:26 + Build duration: 5 min 54 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/103/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 12:25:41 + Build duration: 51 min and counting JUnit Tests Name: projectroot Fai

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

This revision was automatically updated to reflect the committed changes. Closed by commit R242:193775def6a0: FrameSvg: prevent crash when calling mask() with no frame yet created (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1bc1994dfe6b: FrameSvgItem: emit maskChanged also from geometryChanged() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 14 May 2019 12:14:13 + Build duration: 49 min and counting JUnit Tests Name: projectroot

D20595: Implement set_window_geometry

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6da6c7c7e090: Implement set_window_geometry (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20595?vs=56357&id=58071#toc REPOSITORY R127 KWayland CHANGES SINCE L

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 May 2019 12:14:14 + Build duration: 39 min and counting BUILD ARTIFACTS abi-compatibility-r

D21204: Ensure no trailing slash in mountpoint read from fstab file.

apol added inline comments. INLINE COMMENTS > fstabhandling.cpp:169 > +// strips last slash > +if (mountpoint.at(mountpoint.length() -1) == '/') { > +mountpoint = mountpoint.left(mountpoint.length() - 2); mountpoint.endsWith(QLatin1Char('/')) > fstabhandl

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH emitmaskchangedalsoonsizechange REVISION DETAIL https://phabricator.kde.org/D21201 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH donotcrashformask REVISION DETAIL https://phabricator.kde.org/D21200 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/37/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 May 2019 12:14:18 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-r

D21155: Truncate long filname before creating a link

This revision was automatically updated to reflect the committed changes. Closed by commit R241:092beaf6fbab: Truncate long filname before creating a link (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21155?vs=57929&id=58069 REVISION DETA

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. I would prefer using TerminalInterfaceV2 in the current file instead of a new file. It would make using it much easier to use, document, etc and when kf6 comes out, easier to re-combine. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D201

D20595: Implement set_window_geometry

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D20595 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

davidedmundson added a comment. marking inline comments as done REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20595 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven abandoned this revision. meven added a comment. Abandoned n favor of D21204 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 406242 CCBUG: 390691 FIXED-IN: 5.59 REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricato