D22107: Add MediaTransport API

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > a2dp-codecs.h:33 > #define A2DP_CODEC_MPEG240x02 > -#define A2DP_CODEC_ATRAC 0x03 > +#define A2DP_CODEC_ATRAC 0x04 >

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 27 Jun 2019 03:15:45 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 27 Jun 2019 03:15:45 + Build duration: 8 min 26 sec and counting BUILD ARTIFACTS

D22105: WIP : Fix SFTP Plugin of KIO for Windows

andriusr added inline comments. INLINE COMMENTS > kio_sftp.cpp:2257 > +#ifdef Q_OS_WIN > +// TODO ADD CODE FOR HANDLING FILETYPE - SYMLINK IN WIN > +#else I'm not sure what is intended to achieve here, the remote file _can_ be a symlink, and IIRC when we had sftp on dolphin in

D22108: [TabBar] Remove exterior margins

filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma, ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22108: [TabBar] Remove exterior margins

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY This allows us to glide active tabbar indicators on lines, which we cannot do now in Kickoff due to this limitation in

D22107: Add MediaTransport API

mweichselbaumer added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt BRANCH mediatransport REVISION DETAIL https://phabricator.kde.org/D22107 AFFECTED FILES

D22102: Implement apply-on-double-click for all grid view KCM delegates

pino added a comment. In D22102#486968 , @davidedmundson wrote: > From the old review: > > pino: > > -1 for this: > > hidden feature > it does not make sense when the general paradigm is OK/Apply/Cancel, so we are

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth requested changes to this revision. vonreth added a comment. This revision now requires changes to proceed. We also should add a maintainer for review INLINE COMMENTS > CMakeLists.txt:12 > > -set(QT_MIN_VERSION "5.8.0") > +set(QT_MIN_VERSION "5.10.0") > set(KF5_MIN_VERSION

D22102: Implement apply-on-double-click for all grid view KCM delegates

davidedmundson added a comment. From the old review: pino: -1 for this: hidden feature it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 created this revision. brute4s99 added reviewers: albertvaka, vonreth, sredman. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY CAUTION : Still WIP. The main

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/71/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 26 Jun 2019 15:11:19 + Build duration: 12 min and counting JUnit Tests

D22102: Implement apply-on-double-click for all grid view KCM delegates

filipf added a comment. Generally +1, but let's disable it for destructive kcms. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22102 To: ngraham, #plasma, #vdg, mart, broulik Cc: filipf, mglb, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D12992: New elisa icon

mgallien added a comment. In D12992#486880 , @lshoravi wrote: > Using @abetts prototype: No blockers, incorporating the given teal and green colours given by mgallien is TODO. > > Otherwise, the blocker would be to find what visual profile

D12992: New elisa icon

lshoravi added a comment. Using @abetts prototype: No blockers, incorporating the given teal and green colours given by mgallien is TODO. Otherwise, the blocker would be to find what visual profile Elisa has so that we can work around that. REPOSITORY R266 Breeze Icons REVISION

D12992: New elisa icon

ngraham added a comment. There is no timeframe. :) I was just hoping this doesn't get abandoned, because it looks rally nice. What are the remaining blockers, currently? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60689. leinir added a comment. - Fill the width in the dialog's sidebar with Button - Use the knsrc file's Name attr for title (already translated) - Indent the comments by their depth (this is imperfect, but...) REPOSITORY R304 KNewStuff CHANGES

D12992: New elisa icon

lshoravi added a comment. Doable! What timeframe are we thinking? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: abetts, paullesur, januz, mgallien, alex-l, andreask, kde-frameworks-devel, mnesbitt, LeGast00n,

D22102: Implement apply-on-double-click for all grid view KCM delegates

mglb added a comment. > Look-and-feel User accidentally doubleclicks item and all their look-related settings are gone. Has to configure everything again. > Splash Screen User accidentally doubleclicks item, nothing visible happens, gets suprised on next login. Since the

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham created this revision. ngraham added reviewers: Plasma, VDG, mart, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is a better-implemented alternative to D18571

D22093: Don't show progress window for jobs that don't report progress

ngraham added a comment. I find myself agreeing with @apol. Here's an idea: - Don't show the progress window at all for 500 milliseconds, like Plasma's Notifications. This will prevent it from unnecessarily showing up for very quick transfers when you're sending a small file via a fast

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 10 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22095: Fix CMake add_custom_command() paren highlighting

turbov added a comment. I would say all commands w/ `COMMAND` named parameter need that. Also, `add_custrom_target` and `execute_process`... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting, cullmann Cc:

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60676. meven added a comment. Allow to find data accross all activities using ?activity=any REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60653=60676 BRANCH recents-docs-ioslave REVISION

D22082: WIP Add an ioslave to access KActivityStat data

meven added a comment. In D22082#486782 , @ivan wrote: > I'd add support for `HighScoredFirst` and `RecentlyCreatedFirst`. Maybe the protocol could be something like "used:/" or something. Adding sorting options is on my todo-list, I

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

This revision was automatically updated to reflect the committed changes. Closed by commit R159:b45c34ecfeb1: Fix a crash in KactivityTestApp when Result has strings with non-ASCII (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D22082: WIP Add an ioslave to access KActivityStat data

ivan added a comment. I'd add support for `HighScoredFirst` and `RecentlyCreatedFirst`. Maybe the protocol could be something like "used:/" or something. It should also support getting items for the current activity, or all recently used items. REPOSITORY R159 KActivities Statistics

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D22091 REVISION DETAIL https://phabricator.kde.org/D22091 To: meven, ivan, broulik, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh,

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

meven updated this revision to Diff 60674. meven added a comment. Clean leftover declaration REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22091?vs=60652=60674 BRANCH arcpatch-D22091 REVISION DETAIL https://phabricator.kde.org/D22091