D22425: personsmodel: Add phoneNumber

jbbgameich updated this revision to Diff 61686. jbbgameich added a comment. Put PhoneNumberRole after GroupsRole REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22425?vs=61671&id=61686 BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAI

D22339: Make sure solid backends are reentrant

bruns added a comment. This is inacceptable! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22339: Make sure solid backends are reentrant

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R245:00abb4839abe: Make sure solid backends are reentrant (authored by apol). REPOSITORY R245 Solid CHANGES SINCE LAST

D22425: personsmodel: Add phoneNumber

apol added a comment. Other than that LGTM INLINE COMMENTS > personsmodel.h:60 > +UserRole = Qt::UserRole + 0x1000, ///< in case it's needed to > extend, use this one to start from > +PhoneNumberRole > }; Put it after GroupsRole REPOSITORY R307 KPeople REVISION DETA

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 13 Jul 2019 00:42:27 + Build duration: 6 min 1 sec and counting JUnit Tests Name: projectroo

D22425: personsmodel: Add phoneNumber

bshah added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: New framework: KCalCore

On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > With the 19.08 release approaching (and thus the deadline for incompatible > changes if we go ahead with this plan), I'd like to raise this again for > getting to a decision :) > > Summary of what happened in the past weeks: > - the

D22425: personsmodel: Add phoneNumber

jbbgameich added a reviewer: KDE PIM. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

jbbgameich added a reviewer: Plasma: Mobile. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

jbbgameich updated this revision to Diff 61671. jbbgameich added a comment. fix indentation REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22425?vs=61670&id=61671 BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAIL https://phabricat

D22425: personsmodel: Add phoneNumber

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY This is intended to provide shared code for plasma-phone-components and spacebar. TEST PLAN The phoneNumber ca

D22421: generate list of data files on the fly

ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. Nice! Thx Harald! REPOSITORY R264 KApiDox BRANCH master REVISION DETAIL https://phabricator.kde.org/D22421 To: sitter, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeG

Re: New framework: KCalCore

With the 19.08 release approaching (and thus the deadline for incompatible changes if we go ahead with this plan), I'd like to raise this again for getting to a decision :) Summary of what happened in the past weeks: - the Person/Attendee slicing issue was fixed by making both independent types

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#494702 , @rjvbb wrote: > Please check the earlier discussion; IIRC there is a reliability problem with that signal, and I did try reverting to its use before coming up with the current solution. I read

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. Please check the earlier discussion; IIRC there is a reliability problem with that signal, and I did try reverting to its use before coming up with the current solution. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevel

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. While trying to understand the problem, I found that perhaps we could still revert to using the `aboutToHide` signal, with proper boundaroes. So alternative solution proposal up as D22424 REPOSITORY R32 KDevelop REVISION DE

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

cfeck added inline comments. INLINE COMMENTS > kbusyindicatorwidget.h:52 > + * > + * @since 5.60.0 > + */ 5.61.0 > kbusyindicatorwidgettest.cpp:43 > + > +auto toggle = new QPushButton(QStringLiteral("Toggle Visibile"), > &window); > + typo REPOSITORY R236 KWidgetsAddons BRANCH maste

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61659. sitter added a comment. - add simple example code + image - add @since tag - override event REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61603&id=61659 BRANCH master REVISION DETAIL htt

D22421: generate list of data files on the fly

sitter added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D22421 To: sitter, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D22421: generate list of data files on the fly

sitter created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous list was woefully insufficent and not including half the things necessary for

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nxiss7 requested review of this revision. REVISION SUMMARY Some Android FTP server applications don't implement lower-case "list" command thus KIO can't connect to server and fail

D21660: remove dbus for windows build and change audio dep logic

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:40 > +if (NOT ANDROID) > +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) > +else () Move it down to the audio logic, the if check is the same REPOSITORY R289 KNotifications BRANCH arcpatch-D

D21660: remove dbus for windows build and change audio dep logic

brute4s99 retitled this revision from "remove dbus and change audio dep logic" to "remove dbus for windows build and change audio dep logic". REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc

D21660: remove dbus and change audio dep logic

brute4s99 retitled this revision from "change audio dep logic wrt win32" to "remove dbus and change audio dep logic". brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, b

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61639. brute4s99 added a comment. no more dbus on Windows build of KNotifications REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61422&id=61639 BRANCH arcpatch-D21660_1 REVISION DETAIL https://ph

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > But this is KNotifications, not KDE Connect. So we need DBus for > KNotifications on Windows? ah, yeah we could bypass DBus on Windows in KNotifications REPOSITORY R289 KNotifications BRANCH arcpa

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61638. leinir added a comment. - A small spacer item for the entry details page - Documentation++ - Show a passive notification in the dialog when messages are posted REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D22414: Fix build due to missing QVector include

This revision was automatically updated to reflect the committed changes. Closed by commit R290:886f7f4004e5: Fix build due to missing QVector include (authored by dvratil). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22414?vs=61631&id=61634 REVISION DETA

D22414: Fix build due to missing QVector include

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D22414 To: dvratil, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

This revision was automatically updated to reflect the committed changes. Closed by commit R244:95e9d5f22ea3: Fix build after 0b2fe3cf21 (authored by dvratil). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22413?vs=61628&id=61633 REVISION DETAIL https:

D22413: Fix build after 0b2fe3cf21

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kstringhandler.cpp:346 > int length = 0; > auto chrs = text.toUcs4(); > for (auto chr : chrs) { for the reference, `toUcs4()` returns a `QVector` REPO

D22414: Fix build due to missing QVector include

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY I get 'implicit instantiation of undefined template 'QVector' when building against

D22413: Fix build after 0b2fe3cf21

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY QVector is not unused in kstringhandler.cpp TEST PLAN kcoreaddons master builds aga