KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 03:33:48 + Build duration: 1 hr 4 min and counting JUnit Tests

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 03:33:13 + Build duration: 1 hr 1 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 03:32:58 + Build duration: 1 hr 1 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 03:32:32 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/17/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 03:32:58 + Build duration: 48 min and counting CONSOLE OUTPUT [...truncated 1018

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 03:33:58 + Build duration: 46 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/21/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 03:33:48 + Build duration: 39 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 03:33:13 + Build duration: 37 min and counting CONSOLE OUTPUT [...truncated 477

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/7/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 03:32:32 + Build duration: 36 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 328 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/328/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 03:32:58 + Build duration: 31 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.11 - Build # 101 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.11/101/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 03:33:13 + Build duration: 30 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/144/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 03:33:50 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 WindowsMSVCQt5.11 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20WindowsMSVCQt5.11/60/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 03:32:32 + Build duration: 26 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 03:32:32 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 149 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/149/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 03:32:58 + Build duration: 11 min and counting CONSOLE OUTPUT [...truncated 881

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/47/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 03:33:13 + Build duration: 8 min 35 sec and counting CONSOLE OUTPUT [...truncated

D22670: Change Highlight to ButtonFocus

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works fine with no visual changes, as expected. Matches D22647 which has already landed in the same upcoming Frameworks 5.61 release, so let's go for

D22689: Replace QString::null with QString

nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This breaks building Okular for me [ 0%] Automatic MOC for target urldetecttest [ 0%] Automatic MOC for target okular [ 0%] Automatic MOC for target okularcore

D22689: Replace QString::null with QString

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY A comment suggests to deprecate/remove it for KF6, but there's no

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer added a comment. I'm not sure if its beneficial to use `cmake_parse_arguments` here. It seems like it would make the macro harder to understand compared to the current change. I'm also not entirely sure how it would work? I haven't worked with `cmake_parse_arguments` before.

D22699: Support passing target to ecm_qt_declare_logging_category

apol added a comment. How about pass it as a TARGET argument using CMakeParseArguments. You can see documentation about it here: https://cmake.org/cmake/help/latest/command/cmake_parse_arguments.html +1 to the change, I really dislike using variables for this. REPOSITORY R240 Extra

D22689: Replace QString::null with QString

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22701: [kfileutils] Add isExecutableFile from KRun

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY isExecutableFile is a useful function independent of KRun. Move it

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer created this revision. daandemeyer added a reviewer: alexmerry. daandemeyer added a project: Frameworks. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. Herald added a project: Build System. daandemeyer requested review of this revision. REVISION SUMMARY Same as

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer updated this revision to Diff 62434. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22698?vs=62433=62434 REVISION DETAIL https://phabricator.kde.org/D22698 AFFECTED FILES cmake/KF5I18nMacros.cmake.in To: daandemeyer Cc: kde-frameworks-devel,

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer created this revision. daandemeyer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. daandemeyer requested review of this revision. REVISION SUMMARY Modern CMake encourages using targets as much as possible instead of macros. This patch makes it possible

Re: KCrash - test_crasher spins in a loop on Windows

On Wed, Jul 24, 2019 at 2:27 AM David Faure wrote: > > On mercredi 17 avril 2019 08:52:23 CEST Ben Cooksley wrote: > > On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > > > Hi all, > > > > > > Currently we have an issue where the test_crasher test will endlessly > > > fork itself while trying to

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500953 , @davidhurka wrote: > What does `fill:currentColor` mean, by the way? The current color is determined by the color class. There has to be a `fill`, so we set it to `currentColor`. INLINE

D22670: Change Highlight to ButtonFocus

ndavis retitled this revision from "Change Highlight to ButtonFocus, improve stylesheet support" to "Change Highlight to ButtonFocus". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D22670: Change Highlight to ButtonFocus, improve stylesheet support

ndavis updated this revision to Diff 62427. ndavis added a comment. Remove extra changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22670?vs=62363=62427 BRANCH focus-color (branched from master) REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/20/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 23 Jul 2019 17:42:50 + Build duration: 9 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/143/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Jul 2019 17:42:50 + Build duration: 5 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 23 Jul 2019 17:42:51 + Build duration: 3 min 47 sec and counting JUnit Tests

D22687: KService: remove broken concept of global sycoca database

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. 1 ?? 0x770c0593 2 ??

D22687: KService: remove broken concept of global sycoca database

sitter added a comment. Mh, ksycocatest actually regressed for me. 2: * Start testing of KSycocaTest * 2: Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0) 2: QDEBUG :

D22687: KService: remove broken concept of global sycoca database

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22687 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22083: introduce concept of header and footer for kpageview

ngraham added a task: T11279: Unify settings windows' sidebar appearance. REPOSITORY R236 KWidgetsAddons BRANCH mart/pageviewfooter REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg, ngraham Cc: hpereiradacosta, cfeck, ndavis, ngraham,

D22694: Add KDevelop files to gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1b51aadb61c: Add KDevelop files to gitignore (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22694?vs=62423=62425 REVISION DETAIL

D22693: [tags] Fix coding style

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9c9f6b758c2c: [tags] Fix coding style (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22693?vs=62422=62426 REVISION DETAIL

D22693: [tags] Fix coding style

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cs REVISION DETAIL https://phabricator.kde.org/D22693 To: nicolasfella, #baloo, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov,

D22694: Add KDevelop files to gitignore

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I feel like there should be some kind of global, KDE-wide repo where this kind of thing can live. Still, +1. REPOSITORY R293 Baloo BRANCH gi REVISION DETAIL

D22694: Add KDevelop files to gitignore

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R293 Baloo BRANCH gi REVISION DETAIL

D22693: [tags] Fix coding style

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R293 Baloo BRANCH cs REVISION DETAIL

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6961fdbd7b83: Link against KIOCore instead of KIOWidgets in kioslaves (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22683?vs=62391=62421

D7446: [Places panel] Revamp the Recently Saved section

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham retitled this revision from "Add kio recentlyused:/ to access KactivitytStats data" to "Add kio recentlyused:/ to access KActivityStats data". REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ngraham accepted this revision. ngraham added a comment. LGTM now. Very nice work. @ndavis, are you happy too? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel, ngraham,

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 62417. meven added a comment. Remove the current option to filter on curent application as it does not work REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62298=62417 BRANCH arcpatch-D22144 REVISION

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH kiow REVISION DETAIL https://phabricator.kde.org/D22683 To: nicolasfella, #baloo, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D22670: Change Highlight to ButtonFocus, improve stylesheet support

ngraham added a comment. I hate to be That Guy, but... The two changes in this patch seem unrelated to one another and should probably be done separately. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22670 To: ndavis, #vdg, #plasma,

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. meven edited the test plan for this revision. meven added a dependency: D22144: Add kio recentlyused:/ to access KactivitytStats data. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik,

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a dependent revision: D7446: [Places panel] Revamp the Recently Saved section. REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. What does `fill:currentColor` mean, by the way? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62415. davidhurka added a comment. - Remove color attributes, which were added by scour-icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62411=62415 BRANCH add-icons-for-pagelayouts REVISION

D22365: KNotification macOS native support by NSNotificationCenter

Inoki updated this revision to Diff 62414. Inoki marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22365?vs=61487=62414 REVISION DETAIL https://phabricator.kde.org/D22365 AFFECTED FILES src/CMakeLists.txt src/knotificationmanager.cpp

D22365: KNotification macOS native support by NSNotificationCenter

Inoki marked 16 inline comments as done. Inoki added inline comments. INLINE COMMENTS > broulik wrote in notifybymacosnotificationcenter.h:14 > Add `override` Which one? > broulik wrote in notifybymacosnotificationcenter.mm:61 > We have a "default action" concept now where clicking the popup

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#500913 , @ngraham wrote: > With your awesome new `recentlyused:/` ioslave, I find myself wondering if the old `timeline:/` ioslaves even still have value, and if it makes sense to have them in the Places Panel by

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. I assume that `fill="currentColor"` also doesn’t work as expected, fixing that now... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62411. davidhurka added a comment. - Fix id=current-color-scheme attributes which were removed by scour-icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62332=62411 BRANCH

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 23 Jul 2019 14:59:36 + Build duration: 6 min 12 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 23 Jul 2019 14:59:37 + Build duration: 6 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Jul 2019 14:59:37 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS

D22689: Replace QString::null with QString

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D22689 AFFECTED FILES cmake/kf5i18nuic.cmake

D22685: Fix failing autotest

This revision was automatically updated to reflect the committed changes. Closed by commit R278:14998613603c: Fix failing autotest (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22685?vs=62406=62407 REVISION DETAIL

D22685: Fix failing autotest

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH fix-autotest REVISION DETAIL https://phabricator.kde.org/D22685 To: zzag, #kwin, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22685: Fix failing autotest

zzag updated this revision to Diff 62406. zzag added a comment. Make hostnames in testClientMachine unique. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22685?vs=62404=62406 BRANCH fix-autotest REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. With your awesome new `recentlyused:/` ioslave, I find myself wondering if the old `timeline:/` ioslaves even still have value, and if it makes sense to have them in the Places Panel by default. REPOSITORY R241 KIO REVISION DETAIL

D22685: Fix failing autotest

zzag retitled this revision from "Fix failing autotests" to "Fix failing autotest". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22685 To: zzag, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22685: Fix failing autotests

zzag updated this revision to Diff 62404. zzag added a comment. Check initial value of group leader. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22685?vs=62399=62404 BRANCH fix-autotest REVISION DETAIL https://phabricator.kde.org/D22685

D22687: KService: remove broken concept of global sycoca database

dfaure created this revision. dfaure added a reviewer: sitter. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The implementation was very bad (it would delete your

D20007: Add GetProcessList for retrieving the list of currently active processes

dfaure added a comment. The CI isn't happy with this code. FreeBSD fails: https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/lastCompletedBuild/testReport/projectroot/autotests/kprocesslisttest/ Windows fails:

Re: KCrash - test_crasher spins in a loop on Windows

On mercredi 17 avril 2019 08:52:23 CEST Ben Cooksley wrote: > On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > > Hi all, > > > > Currently we have an issue where the test_crasher test will endlessly > > fork itself while trying to setup it's conditions to run. > > > > This leads to an issue

D22685: Fix failing autotests

zzag updated this revision to Diff 62399. zzag added a comment. Simplify a bit REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22685?vs=62397=62399 BRANCH fix-autotest REVISION DETAIL https://phabricator.kde.org/D22685 AFFECTED FILES

D22685: Fix failing autotests

zzag edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22685 To: zzag, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22685: Fix failing autotests

zzag edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22685 To: zzag, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22685: Fix failing autotests

zzag updated this revision to Diff 62397. zzag added a comment. Require XCB::ICCCM in autotests/CMakeLists.txt REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22685?vs=62396=62397 BRANCH fix-autotest REVISION DETAIL

D22685: Fix failing autotests

zzag created this revision. zzag added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY KWindowInfoX11Testsome fails because some parts of QXcbWindow were changed in Qt

D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default

This revision was automatically updated to reflect the committed changes. Closed by commit R240:d53f6e220d0d: Provide a more sensible CMAKE_INSTALL_PREFIX default (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kiow REVISION DETAIL https://phabricator.kde.org/D22683 To: nicolasfella, #baloo, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov,

D22682: Compile package structure plugins into expected subdirectory

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22682 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22676 To: apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default

apol marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22676 To: apol Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default

apol updated this revision to Diff 62392. apol added a comment. address cgiboudeaux's comments REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22676?vs=62376=62392 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22676 AFFECTED

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

nicolasfella retitled this revision from "[kioslaves/tags] Link against KIOCore instead of KIOWidgets" to "Link against KIOCore instead of KIOWidgets in kioslaves". nicolasfella edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22683

D22683: [kioslaves/tags] Link against KIOCore instead of KIOWidgets

nicolasfella updated this revision to Diff 62391. nicolasfella added a comment. - Do the same for timeline REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22683?vs=62389=62391 BRANCH kiow REVISION DETAIL https://phabricator.kde.org/D22683 AFFECTED

D22682: Compile package structure plugins into expected subdirectory

davidedmundson updated this revision to Diff 62390. davidedmundson added a comment. stupid arc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22682?vs=62388=62390 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22682

D22683: [kioslaves/tags] Link against KIOCore instead of KIOWidgets

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The Tags ioslave doesn't need KIOWidgets, KIOCore is enough TEST

D22682: Compile package structure plugins into expected subdirectory

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This means they're found by unit tests pre-installation TEST

D22657: Use non-deprecated suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R495:0a10698cb5c0: Use non-deprecated suggestName (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22657?vs=62331=62385 REVISION

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol added a comment. In D22580#499015 , @cgiboudeaux wrote: > KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir. > > Running prefix.sh is useful even if

D22667: Make the default build type "Debug" when compiling a git checkout.

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22667 To: dfaure, kde-buildsystem, cgiboudeaux Cc: cgiboudeaux, apol, kde-frameworks-devel, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22667: Make the default build type "Debug" when compiling a git checkout.

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Good idea REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22667 To: dfaure, kde-buildsystem, cgiboudeaux Cc: cgiboudeaux,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 23 Jul 2019 10:00:22 + Build duration: 2 min 19 sec and counting JUnit Tests Name:

D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:429 > > - > +if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT) > +get_filename_component(_ecm_prefix "${ECM_DIR}/../../../" ABSOLUTE) Might be worth adding that this only works with CMake >= 3.7 >

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62383. brute4s99 added a comment. let's put a pin in this for a while until I get a better solution for DBus on Windows REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62069=62383 BRANCH

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 77 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/77/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 23 Jul 2019 09:28:36 + Build duration: 14 min and counting JUnit Tests

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. sorry about that. I'll find a better solution that doesn't break builds  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: aspotashev, bcooksley, apol, nicolasfella,

  1   2   >