D23336: KDirOperator: Add follow new directories option

dhaumann added a comment. What I still miss in the description is what problem is solved? A bug? A nice feature? Where will this be used? To me as someone not using KDirOperator every day this is rather unclear. INLINE COMMENTS > kdiroperator.h:507 > + */ > +bool

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 24 Aug 2019 04:04:51 + Build duration: 2 min 15 sec and counting JUnit Tests Name:

D17737: [CopyJob] Create clones in btrf/xfs mount

ossi added a comment. In D17737#517736 , @thiago wrote: > QFile::copy already implements FICLONE, sendfile() and Darwin's clonefile(). yes, and an api that is utterly unsuitable for interactive applications. ;) if you just meant it

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 24 Aug 2019 03:51:09 + Build duration: 2 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 100 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 03:05:19 + Build duration: 12 min and counting BUILD ARTIFACTS

D23336: KDirOperator: Add follow new directories option

ngraham added reviewers: dfaure, cfeck, pino. ngraham added a comment. Hmm, I think this makes more sense now. #frameworks people, what say ye? REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks, dfaure, cfeck,

D23388: add a border for the toolbars WIP

apol added a comment. I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol

D23367: make the sizing of the toolbuttons more coherent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3887f5ec9152: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

ngraham added a comment. Huge +1 on the visuals. I'll let someone else review this for technical correctness. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n,

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

ngraham added a comment. Before-and-after pictures would be appreciated. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I see, that's just a test. LGTM! REPOSITORY R242 Plasma Framework (Library) BRANCH toolbutton-icon-sizing (branched from master) REVISION DETAIL

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh retitled this revision from "add a border for the toolbars" to "add a border for the toolbars WIP". camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol

D23388: add a border for the toolbars

camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this is mostly mean for the QQC2 apps running on PlaMo and using

D17737: [CopyJob] Create clones in btrf/xfs mount

thiago added a comment. QFile::copy already implements FICLONE, sendfile() and Darwin's clonefile(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, #frameworks, thiago, ossi Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23385: More porting from QRegExp to QRegularExpression

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH port-qregexp REVISION DETAIL https://phabricator.kde.org/D23385 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D23385: More porting from QRegExp to QRegularExpression

dhaumann updated this revision to Diff 64443. dhaumann added a comment. - Add static and const where applicable REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23385?vs=64441=64443 BRANCH port-qregexp REVISION DETAIL

D23367: make the sizing of the toolbuttons more coherent

camiloh added a comment. In D23367#517658 , @ngraham wrote: > Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? My intention with

D23385: More porting from QRegExp to QRegularExpression

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I would tend to make more stuff "static const QRegularExpression", given QRegularExpression unlike QRegExp has not the issue of storing matches inside itself. REPOSITORY

D23373: KTextEditor: Fix left border flicker when switching between documents

This revision was automatically updated to reflect the committed changes. Closed by commit R39:42e7714a0184: KTextEditor: Fix left border flicker when switching between documents (authored by daandemeyer, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23385: More porting from QRegExp to QRegularExpression

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Less deprecated QRegExp usage. TEST PLAN -

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added inline comments. INLINE COMMENTS > file_unix.cpp:263 > +clone_created = ioctl(dest_file.handle(), FICLONE, > src_file.handle()) != -1; > +//qDebug() << "Clone created:" << clone_created;" > +#endif nitpick - wrong indentation REPOSITORY R241 KIO REVISION DETAIL

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew created this revision. feverfew added reviewers: fvogt, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. TEST PLAN Make sure kded module is installed and loaded. Use dolphin and observe that

D23367: make the sizing of the toolbuttons more coherent

ngraham added a comment. Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh,

D23336: KDirOperator: Add follow new directories option

daandemeyer updated this revision to Diff 64436. daandemeyer added a comment. Remove extra unnecessary '&' CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23336?vs=64418=64436 REVISION DETAIL https://phabricator.kde.org/D23336 AFFECTED FILES src/filewidgets/kdiroperator.cpp

D23381: Allow splitting lists using ;

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY This is what the standard says is the separator: The multiple values should be separated

D22968: Make it possible to modify contacts

bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstracteditablecontact.h:31 > + * > + * @since 5.60 > + * @internal Since 5.62 > persondata.h:103 > > +Q_SCRIPTABLE bool setContactCustomProperty(const

D23367: make the sizing of the toolbuttons more coherent

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64432. camiloh marked an inline comment as done. camiloh added a comment. if parent is nto visible then children are not visible. fix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23367: make the sizing of the toolbuttons more coherent

camiloh marked an inline comment as done. camiloh added inline comments. INLINE COMMENTS > apol wrote in ToolButton.qml:56 > That's always the case, isn't it? if a parent isn't visible, an item will > never be visible. yes. you're right. REPOSITORY R242 Plasma Framework (Library) REVISION

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64426. leinir added a comment. - Switch to a slightly different avatar display method - Rejig the lamdba slightly, with less indirection (and more working) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D23373: KTextEditor: Fix left border flicker when switching between documents

cullmann added a comment. Given we use setAttribute(Qt::WA_StaticContents); I think using this additional attribute is fine. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23373 To: daandemeyer, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel,

D23373: KTextEditor: Fix left border flicker when switching between documents

daandemeyer added a comment. According to the documentation they should both achieve the same effect. However, `Qt::WA_OpaquePaintEvent` takes precedence if both are used. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23373 To: daandemeyer, #ktexteditor,

D23373: KTextEditor: Fix left border flicker when switching between documents

dhaumann added a comment. Looks good. Still, can the same be achieved with setAutoFillBackground(false)? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23373 To: daandemeyer, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel,

D23371: Markdown: multiple improvements and fixes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for the very detailed description in the review request, very much appreciated. The improvements are numerous, therefore please commit. REPOSITORY R216 Syntax Highlighting

D23336: KDirOperator: Add follow new directories option

daandemeyer updated this revision to Diff 64418. daandemeyer added a comment. When selecting directories, only disable following directories if a tree view is used (normal or detail). CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23336?vs=64332=64418 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 23 Aug 2019 13:01:59 + Build duration: 8 min 3 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 22 Aug 2019 12:12:49 + Build duration: 1 day 0 hr and counting JUnit Tests Name: projectroot

Re: Unified git commit message guideline

On Sunday, 11 August 2019 23:52:55 CEST Roman Gilg wrote: > After looking around a bit what I found to be very interesting was the > Conventional Commits specification[1]. It is based on the AngularJS > commit message policy, which is imo a very well formulated policy. Please make sure to

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64413. leinir added a comment. - Work up the NewStuffItem layout a touch... - Less explicit layouting (and more QtLayouts) - Re-enable use of the (now more usable) score from the comments model REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D23373: KTextEditor: Fix left border flicker when switching between documents

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. KateIconBorder::paintBorder seems to take care to paint the complete background, // Paint background over full width... p.fillRect(lnX, y, w, h, iconBarColor); >

D23373: KTextEditor: Fix left border flicker when switching between documents

cullmann added a comment. Hmm, I thought one can enable that safely, if the widget paintEvent paints the full background anyways itself. I think that should be ok for the iconborder but must take a look myself again ;=) REPOSITORY R39 KTextEditor REVISION DETAIL

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 5 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64406. meven added a comment. Fix date parameter passing REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64403=64406 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED

D23372: Add operator |= for Query Terms

ivan added a comment. You can also use `set*/add*` member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say `set*/add*` is a

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:29 > You should also set LIBRARY_OUTPUT_DIRECTORY, see > https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled This will be the first ioslave in kio-extras using it... Some of the ioslave even

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64403. meven marked 15 inline comments as done. meven added a comment. Fix documentation, CMakeLists.txt, a couple of code fix REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64347=64403 BRANCH

D23367: make the sizing of the toolbuttons more coherent

apol added inline comments. INLINE COMMENTS > ToolButton.qml:56 > +anchors.centerIn: parent > +visible: parent.visible > +height: Kirigami.Units.iconSizes.smallMedium That's always the case, isn't it? if a parent isn't visible, an item will never

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > This is maybe not Qt but the locale defintion files which are probably distro > specific. I just checked on SLES and on openSuse. > > for ukrainian: > > LC_TIME=uk_UA.UTF-8 locale mon > >

D23372: Add operator |= for Query Terms

meven added a comment. In D23372#517378 , @ivan wrote: > This is something I did have initally in kastats, it was killed because while this is tempting > > query |= Type(types); > > > it ruins the idea of the chaning API because it

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > yurchor wrote in kxmlgui_unittest.cpp:1089 > AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer > (Ukrainian) > > F7273188: cal.png > > https://bugs.kde.org/show_bug.cgi?id=256952 > >

D23372: Add operator |= for Query Terms

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. This is something I did have initally in kastats, it was killed because while this is tempting query |= Type(types); it ruins the idea of the chaning API because it can

D23373: KTextEditor: Fix left border flicker when switching between documents

daandemeyer created this revision. daandemeyer added a reviewer: KTextEditor. daandemeyer added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. daandemeyer requested review of this revision. REVISION SUMMARY See

D23371: Markdown: multiple improvements and fixes

nibags edited the summary of this revision. nibags added reviewers: cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D23371: Markdown: multiple improvements and fixes

nibags added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D23119: Fix dates being on the wrong locale when setting an application language individually

yurchor added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > there is no declension in Russian for the nominative case. The name of the > month is январь and not января, but it is первого января (on January 1st) and > not первого январь. > >

D23372: Add operator |= for Query Terms

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY With it, we can now write : query |= Type(types); instead of : query = query |

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

This revision was automatically updated to reflect the committed changes. Closed by commit R266:34ae5675f36b: Krita has split from Calligra and now uses Krita name instead of calligrakrita (authored by davidre). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23371: Markdown: multiple improvements and fixes

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-markdown REVISION DETAIL https://phabricator.kde.org/D23371

D17737: [CopyJob] Create clones in btrf/xfs mount

chinmoyr edited reviewers, added: thiago, ossi; removed: davidedmundson. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, #frameworks, thiago, ossi, davidedmundson Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > ltoscano wrote in kxmlgui_unittest.cpp:1089 > Declensions: > https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension there is no declension in Russian for the nominative case. The name of the month is январь and not

D9175: Migrate some more QRegExps to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R39:74a77b06db27: Migrate some more QRegExps to QRegularExpression (authored by dhaumann, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D9175: Migrate some more QRegExps to QRegularExpression

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH arcpatch-D9175 REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,