D24150: Fix crash on exit in kio_file

hwti added a comment. In D24150#536169 , @dfaure wrote: > I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 by removing the ::exit() call (which

D24150: Fix crash on exit in kio_file

dfaure added a comment. I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 by removing the ::exit() call (which appears in the backtrace of that bug report). This being said, I'm not objecting

D24150: Fix crash on exit in kio_file

hwti updated this revision to Diff 66633. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24150?vs=66630=66633 REVISION DETAIL https://phabricator.kde.org/D24150 AFFECTED FILES src/ioslaves/file/file.cpp To: hwti, cfeck, dfaure, broulik Cc: aacid, kde-frameworks-devel, LeGast00n,

D24150: Fix crash on exit in kio_file

hwti added a comment. In D24150#536113 , @aacid wrote: > why the void? do you get a warning otherwise? No, but it is used in several places in the repository (and in Qt), so I suppose it might generate one depending on the compiler.

D24150: Fix crash on exit in kio_file

aacid added a comment. why the void? do you get a warning otherwise? Also a comment in that line quoting the Qt docs "Note that you should not delete codecs yourself: once created they become Qt's responsibility." makes sense IMHO otherwise someone will move it back to the old code to

D24150: Fix crash on exit in kio_file

ahmadsamir added reviewers: dfaure, broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24150 To: hwti, cfeck, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

hwti created this revision. hwti added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hwti requested review of this revision. REVISION SUMMARY All QTextCodec are deleted by QCoreGlobalData on exit, so they must be allocated on the heap.

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added a comment. In D23119#519676 , @asemke wrote: > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:1044 > Actually, I was wrong. > I talked to the head of the LLVM/clang development team at Apple and he told > me that returning a const value has zero effect whatsoever. I.e. in the > version of your patch

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 22 Sep 2019 14:28:21 + Build duration: 3 min 12 sec and counting JUnit Tests

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

This revision was automatically updated to reflect the committed changes. Closed by commit R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend (authored by arojas). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/97/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 22 Sep 2019 13:30:40 + Build duration: 8 min 30 sec and counting JUnit Tests Name:

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

This revision was automatically updated to reflect the committed changes. Closed by commit R302:22132a50c4a8: Deprecate the global [Small|Desktop|Bar]Icon() methods (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66606=66617

D24138: Port away from deprecated KIconThemes methods

This revision was automatically updated to reflect the committed changes. Closed by commit R241:371522fd31e9: Port away from deprecated KIconThemes methods (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24138?vs=66607=66616 REVISION DETAIL

D21235: Add handling of fuseiso filesystem type

bruns added a comment. In D21235#535861 , @hallas wrote: > I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would like to use the `KMountPoint`

D24138: Port away from deprecated KIconThemes methods

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24138 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24136 To: vkrause, dfaure Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. Given we always needs to patch Qt for this, shall we not use this workaround in our code instead? I think the other "it always hangs" stuff in Qt bug https://bugreports.qt.io/browse/QTBUG-49870 got fixed. Would this patch here making patching Qt not needed for

D24138: Port away from deprecated KIconThemes methods

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24138 AFFECTED

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause updated this revision to Diff 66606. vkrause added a comment. Actually use KICONTHEMES_NO_DEPRECATED correctly. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66605=66606 BRANCH master REVISION DETAIL

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause updated this revision to Diff 66605. vkrause added a comment. Use KICONTHEMES_NO_DEPRECATED. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66592=66605 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24136 AFFECTED

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24136 To: vkrause, dfaure Cc: dfaure, ngraham, kde-frameworks-devel,

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause added a comment. In D24136#535818 , @dfaure wrote: > kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon. > (and that's all I can find in all of KF5) Right, usage is fortunately not very wide-spread anymore. Before

D21235: Add handling of fuseiso filesystem type

hallas added a comment. I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would like to use the `KMountPoint` class, but this class currently resides in KIO which Solid doesn't depend on. But,