D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel 
hwti added a comment.


  In D24150#536169 , @dfaure wrote:
  
  > I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 
 by 
removing the ::exit() call (which appears in the backtrace of that bug report).
  >
  > This being said, I'm not objecting to this patch, but I am wondering if you 
can still experience this crash with a kio that includes my commit above (from 
Sep 6).
  
  
  QCoreGlobalData destructor is called on any exit, even when returning from 
main (but there is an exit call in kdeinit5 anyway).
  If there is no other possible exit() call before the kdemain function in 
file.cpp returns, then you avoided the issue for Qt >= 5.12 : destroying the 
QTextCodec unregisters it, so it isn't in the list any more when 
QCoreGlobalData destructor is called.
  But older Qt versions do not have this logic, so QCoreGlobalData destructor 
often crashes when trying to call the LegacyTextCodec destructor, since the 
object has already been destroyed and is above the stack pointer. Even if it 
doesn't crash, free() would then be called on a stack address.

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread David Faure 
dfaure added a comment.


  I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 
 by 
removing the ::exit() call (which appears in the backtrace of that bug report).
  
  This being said, I'm not objecting to this patch, but I am wondering if you 
can still experience this crash with a kio that includes my commit above (from 
Sep 6).

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel 
hwti updated this revision to Diff 66633.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24150?vs=66630=66633

REVISION DETAIL
  https://phabricator.kde.org/D24150

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel 
hwti added a comment.


  In D24150#536113 , @aacid wrote:
  
  > why the void? do you get a warning otherwise?
  
  
  No, but it is used in several places in the repository (and in Qt), so I 
suppose it might generate one depending on the compiler.
  
  > Also a comment in that line quoting the Qt docs "Note that you should not 
delete codecs yourself: once created they become Qt's responsibility." makes 
sense IMHO otherwise someone will move it back to the old code to not have a 
leak
  
  OK, done (but the void should already show that not storing it in a variable, 
so not deleting it, is deliberate).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Albert Astals Cid 
aacid added a comment.


  why the void? do you get a warning otherwise?
  
  Also a comment in that line quoting the Qt docs "Note that you should not 
delete codecs yourself: once created they become Qt's responsibility." makes 
sense IMHO otherwise someone will move it back to the old code to not have a 
leak

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Ahmad Samir 
ahmadsamir added reviewers: dfaure, broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel 
hwti created this revision.
hwti added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hwti requested review of this revision.

REVISION SUMMARY
  All QTextCodec are deleted by QCoreGlobalData on exit, so they must be 
allocated on the heap.
  Before Qt 5.12, it is even not allowed to delete them.
  
  BUG: 408797

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24150

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: hwti, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-09-22 Thread Alexander Semke 
asemke added a comment.


  In D23119#519676 , @asemke wrote:
  
  > The original problem in LabPlot was reported by a windows user. The 
proposed fix won't fix the problem on windows. I think the only way to get the 
proper strings on Windows is to get the current language of the application, to 
create a QLocale with the proper language and to use QLocale::toString(const 
QDateTime , const QString )... If this is correct, then we're 
are back to my original question I asked on IRC/Matrix - how to determine the 
current application language?
  
  
  @aacid I solved this problem in 7a10577b52504f6466ecaaedefc8db8d84ffc3d9 
. 
This is not really nice but it works and I accept this hack, at least as a 
temporary solution, since we want to do the next release of LabPlot soon...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-09-22 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:1044
> Actually, I was wrong.
> I talked to the head of the LLVM/clang development team at Apple and he told 
> me that returning a const value has zero effect whatsoever. I.e. in the 
> version of your patch where you were returning a const value, the range for 
> would *still* call the non-const begin() and end(). Good thing I made you 
> change that :-)
> 
> His plan is to make a future version of the C++ standard deprecate const 
> arguments and const return values in function declarations. (toplevel const 
> only, const-ref is fine of course).

Noted. :)
(Thanks for sharing).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

2019-09-22 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 22 Sep 2019 14:28:21 +
 Build duration:
3 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-22 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R239:ec475441f61e: Support NetworkManager 1.20 and do actually 
compile the NM backend (authored by arojas).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24020?vs=66288=66624

REVISION DETAIL
  https://phabricator.kde.org/D24020

AFFECTED FILES
  cmake/modules/FindNetworkManager.cmake
  src/solid-networkstatus/kded/CMakeLists.txt
  src/solid-networkstatus/kded/networkmanagerstatus.h

To: arojas, #frameworks, dfaure
Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 97 - Still Unstable!

2019-09-22 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/97/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 22 Sep 2019 13:30:40 +
 Build duration:
8 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:22132a50c4a8: Deprecate the global 
[Small|Desktop|Bar]Icon() methods (authored by vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66606=66617

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24138: Port away from deprecated KIconThemes methods

2019-09-22 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:371522fd31e9: Port away from deprecated KIconThemes 
methods (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24138?vs=66607=66616

REVISION DETAIL
  https://phabricator.kde.org/D24138

AFFECTED FILES
  src/filewidgets/kimagefilepreview.cpp
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/widgets/ksslinfodialog.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

2019-09-22 Thread Stefan Brüns 
bruns added a comment.


  In D21235#535861 , @hallas wrote:
  
  > I have been resurrecting this patch again :) and have run into an issue I 
need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would 
like to use the `KMountPoint` class, but this class currently resides in KIO 
which Solid doesn't depend on. But, KIO actually depends on Solid so would it 
be an option to move this class from KIO to Solid?
  
  
  What do you gain by using KMountPoints? Solid already has code for parsing 
fstab style files.

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24138: Port away from deprecated KIconThemes methods

2019-09-22 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24138

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D2545: Cleanup KSharedUiServerProxy before qApp exists

2019-09-22 Thread Christoph Cullmann 
cullmann added a comment.


  Given we always needs to patch Qt for this, shall we not use this workaround 
in our code instead?
  I think the other "it always hangs" stuff in Qt bug 
https://bugreports.qt.io/browse/QTBUG-49870 got fixed.
  Would this patch here making patching Qt not needed for Windows?

REVISION DETAIL
  https://phabricator.kde.org/D2545

To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D24138: Port away from deprecated KIconThemes methods

2019-09-22 Thread Volker Krause 
vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24138

AFFECTED FILES
  src/filewidgets/kimagefilepreview.cpp
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/widgets/ksslinfodialog.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread Volker Krause 
vkrause updated this revision to Diff 66606.
vkrause added a comment.


  Actually use KICONTHEMES_NO_DEPRECATED correctly.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66605=66606

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread Volker Krause 
vkrause updated this revision to Diff 66605.
vkrause added a comment.


  Use KICONTHEMES_NO_DEPRECATED.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66592=66605

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread Volker Krause 
vkrause added a task: T11654: Deprecate 
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of 
KIconLoader or QIcon API.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-22 Thread Volker Krause 
vkrause added a comment.


  In D24136#535818 , @dfaure wrote:
  
  > kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
  >  (and that's all I can find in all of KF5)
  
  
  Right, usage is fortunately not very wide-spread anymore. Before porting the 
remaining users I just wanted to be sure there are no objections to the general 
idea.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21235: Add handling of fuseiso filesystem type

2019-09-22 Thread David Hallas 
hallas added a comment.


  I have been resurrecting this patch again :) and have run into an issue I 
need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would 
like to use the `KMountPoint` class, but this class currently resides in KIO 
which Solid doesn't depend on. But, KIO actually depends on Solid so would it 
be an option to move this class from KIO to Solid?

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns