D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmoduleloader.cpp:101
>  } else {
>  KQuickAddons::ConfigModule *cm = 
> factory->create(nullptr, args2);
>  if (!cm) {

Easier fix is likely to wrap that into a std::unique_ptr here and calling 
release() on it when creating the KCModuleQml later on. Would be even better to 
change KCModuleQml to take a std::unique_ptr in the ctor and use a unique_ptr 
internally (AFAICT it's not public API so doable).

That's admittedly more intrusive change though but at least would make some of 
that ownership issues more explicit and easier to track.

> kcmoduleloader.cpp:107
>  return reportError(report, i18n("Error loading QML 
> file."), cm->errorString(), parent);
> +delete cm;
>  }

This is unreachable code. You want to delete before the reportError call but 
after the cm->errorString() call.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24716

To: davidedmundson, #plasma, ervin
Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24600: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24600

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24611: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24611

To: kossebau, #frameworks, bruns, mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24495: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R284 KCompletion

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24495

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24707: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24707

To: kossebau, #frameworks, drosca, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24710: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R301 KEmoticons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24710

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24599: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R270:76460e89854f: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24599?vs=67805&id=68105

REVISION DETAIL
  https://phabricator.kde.org/D24599

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kcodecs.cpp
  src/kcodecs.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24643: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R268:b6a1e260c42a: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24643?vs=67925&id=68104#toc

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24643?vs=67925&id=68104

REVISION DETAIL
  https://phabricator.kde.org/D24643

AFFECTED FILES
  CMakeLists.txt
  autotests/kglobalshortcuttest.cpp
  src/CMakeLists.txt
  src/kglobalaccel.cpp
  src/kglobalaccel.h
  src/kglobalaccel_p.h
  src/runtime/CMakeLists.txt
  src/runtime/kglobalaccel_interface.h
  src/runtime/kglobalacceld.cpp
  src/runtime/kglobalacceld.h

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23927#548607 , @kossebau wrote:
  
  > Any chance you could pik this up and complete? Thing is, the deprecated API 
is also still used internally,so anything but deprecated. Actually the new API 
calls the "deprecated" one.
  
  
  Hmpf, I mixed up signatures and added "#if 
KWIDGETSADDONS_BUILD_DEPRECATED_SINCE(5, 63)" to the wrong method, all fine 
there, sorry for that noise.
  
  Still, complain about the API consistency still holds, please consider fixing 
it :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Any chance you could pik this up and complete? Thing is, the deprecated API 
is also still used internally,so anything but deprecated. Actually the new API 
calls the "deprecated" one.
  
  I just tried to adapt the code to the new deprecation macros (forgot that 
this change has slipped in since I did D24468 
 and landed it).
  But I failed due to this reason, as #if 
KWIDGETSADDONS_BUILD_DEPRECATED_SINCE(5, 63) cannot be used for 
KTitleWidget::setPixmap() implementation due to that.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[David Edmundson]

davidedmundson updated this revision to Diff 68096.
davidedmundson added a comment.


  Slightly refactor so the teardown order deletes the QML content and then 
  deletes the parent window which is a bit more logical.
  
  Now kscreen KCM doesn't crash even with the extra prompts

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24716?vs=68092&id=68096

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24716

AFFECTED FILES
  src/kcmoduleloader.cpp
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24665: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:31f044e50811: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24665?vs=67980&id=68095#toc

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24665?vs=67980&id=68095

REVISION DETAIL
  https://phabricator.kde.org/D24665

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/deprecatedtest.cpp
  src/CMakeLists.txt
  src/karchive.h
  src/kfilterdev.h

To: kossebau, #frameworks, dfaure
Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24495: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 68093.
kossebau added a comment.


  add some missed deprecations

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24495?vs=67734&id=68093

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24495

AFFECTED FILES
  CMakeLists.txt
  autotests/klineedit_unittest.cpp
  src/CMakeLists.txt
  src/kcombobox.cpp
  src/kcombobox.h
  src/kcompletion.h
  src/kcompletionbase.h
  src/kcompletionbox.h
  src/klineedit.cpp
  src/klineedit.h
  src/ksortablelist.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good. Can't use the new deprecation syntax until D24684 
 is in.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24675

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  When we create a KQuickAddons::ConfigModule  in the factory we didn't
  set a parent. It is passed to the wrapper KCModuleQML, and even though
  the wrapper is memory manager the ConfigModule object itself was not.
  
  This lead to another crash as the KAboutData is deleted twice, which was
  fixed with an explicit copy

TEST PLAN
  qDebug inside the colours KCM destructor
  It now appears when changing tabs

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24716

AFFECTED FILES
  src/kcmoduleloader.cpp
  src/kcmoduleqml.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  In D24568#548490 , @dfaure wrote:
  
  > Do we want these, found in 
https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format?
  >
  >   # We use template< without space.
  >   SpaceAfterTemplateKeyword: false
  >  
  >   # macros for which the opening brace stays attached.
  >   ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, 
QBENCHMARK, QBENCHMARK_ONCE ]
  >  
  >   # Break constructor initializers before the colon and after the commas.
  >   BreakConstructorInitializers: BeforeColon
  >
  
  
  added that
  
  > In general, I'm curious why we're not using qt5's clang-format file, with 
our only difference (braces for single-line statements) on top?
  
  I was more comfortable tweaking the file I created some years ago (and 
updated for all clang-format versions since then) that should be close to the 
kdelibs style than trying to take a look in detail at the other one, to be 
honest ;=)

INLINE COMMENTS

> dfaure wrote in KDEClangFormat.cmake:76
> I wonder if people compiling KF5 modules (and not necessarily planning on 
> contributing) need to be annoyed with such a warning. Maybe we could still 
> define the clang-format target and make it print an error?

Yeah, I think some message on running the target will be less annoying.

> dfaure wrote in clang-format.cmake:43
> I'm confused because here it says "true" will group via empty lines, while 
> https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says `the SortInclude 
> feature of clang-format does not re-order includes separated by empty lines`. 
> Maybe different versions of clang-format? Or I misunderstand something?

Perhaps my comment is not understandable.
true means clang-format will sort stuff inside #include groups (aka #include 
lines without empty lines in-between)
Will alter the comment.

> dfaure wrote in clang-format.cmake:49
> https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says 
> `PointerBindsToType: false`, what's the difference?

My file is for some recent clang, whereas PointerBindsToType seems to be 
ancient, see:

https://releases.llvm.org/3.4/tools/clang/docs/ClangFormatStyleOptions.html 
(there you still have that)

http://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html 
(here I can only find the variant I use)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann updated this revision to Diff 68091.
cullmann marked 4 inline comments as done.
cullmann added a comment.


  - fix coding style issue, we don't want indented case labels
  - add initial docs
  - adjust style
  - just tell the user it will not work

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=67797&id=68091

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann, #frameworks, dfaure
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 16 Oct 2019 21:04:52 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24665: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24665

To: kossebau, #frameworks, dfaure
Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobuidelegateextension.h:279
> + */
> +virtual bool askPrivilegeOperationConfirmation(const QString 
> &warningCaption,
> +   const QString 
> &warningMessage,

Sorry, you can't add a new virtual method to an exported+installed class.

BIC rules (where "rules" is a noun, not a verb...) ;-)

Possible solutions:

- creating a new, separate, type of extension, say 
`JobUiDelegatePrivilegeExtension`. This requires adding another defautFoo() and 
setFoo() method like this file has at the bottom.
- creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
with a KF6 TODO to merge it with JobUiDelegateExtension. Then you can 
dynamic_cast the result of `defaultJobUiDelegateExtension()` to V2 to see if 
the extension implements V2.

> slavebase.h:956
> +/**
> + * @deprecated since 5.64
> + */

`, use requestPrivilegeOperation(QString)`

> file_unix.cpp:81
>  
> +static QString actionDetails(ActionType actionType, QVariantList args)
> +{

`const QVariantList &`

> file_unix.cpp:87
> +action = i18n("Change File Permissions");
> +detail = i18n("New Permissions : %1", args[1].toInt());
> +break;

no space before ':' in English

> file_unix.cpp:91
> +action = i18n("Change File Owner");
> +detail = i18n("New Owner : UID=%1, GID=%2", args[1].toInt(), 
> args[2].toInt());
> +break;

same

> file_unix.cpp:121
> +default:
> +action = i18n("Unknown Action");
> +break;

weird indentation

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24598: Update elisa icon

[Nathaniel Graham]

ngraham added a comment.


  Let's get this in!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 16 Oct 2019 20:14:27 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autotests.Re

D24598: Update elisa icon

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.


  Thanks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24568: Provide clang-format target with a KDE Frameworks style file

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I like the idea very much.

INLINE COMMENTS

> KDEClangFormat.cmake:76
> +else()
> +message(STATUS "Could not set up the clang-format target as the 
> clang-format executable is missing.")
> +endif()

I wonder if people compiling KF5 modules (and not necessarily planning on 
contributing) need to be annoyed with such a warning. Maybe we could still 
define the clang-format target and make it print an error?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[David Faure]

dfaure added a comment.


  Do we want these, found in 
https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format?
  
# We use template< without space.
SpaceAfterTemplateKeyword: false

# macros for which the opening brace stays attached.
ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, 
QBENCHMARK, QBENCHMARK_ONCE ]

# Break constructor initializers before the colon and after the commas.
BreakConstructorInitializers: BeforeColon
  
  In general, I'm curious why we're not using qt5's clang-format file, with our 
only difference (braces for single-line statements) on top?

INLINE COMMENTS

> clang-format.cmake:42
> +
> +# sematics shall be grouped via empty lines
> +SortIncludes: true

Typo: semantics

> clang-format.cmake:43
> +# sematics shall be grouped via empty lines
> +SortIncludes: true
> +

I'm confused because here it says "true" will group via empty lines, while 
https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says `the SortInclude 
feature of clang-format does not re-order includes separated by empty lines`. 
Maybe different versions of clang-format? Or I misunderstand something?

> clang-format.cmake:49
> +# CrlInstruction *a;
> +PointerAlignment: Right
> +

https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says `PointerBindsToType: 
false`, what's the difference?

> clang-format.cmake:75
> +
> +# don't break tenary ops
> +BreakBeforeTernaryOperators: false

typo: ternary

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24651: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R279:04dd50d62842: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R279 ThreadWeaver

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24651?vs=67937&id=68083

REVISION DETAIL
  https://phabricator.kde.org/D24651

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/collection.cpp
  src/collection.h

To: kossebau, #frameworks, mirko, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24682: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D24682

To: kossebau, #frameworks, vkrause

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[David Faure]

dfaure added a comment.


  OK, next step is to consider writing that separate class now rather than 
hoping to dump that task on a random future reader of the TODO ;-)
  At least, starting it is the best way to find out how feasible it is.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24710: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KEmoticons to hide deprecated API up to a given version 
or silence deprecation warnings after a given version, using
- -DKEMOTICONS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKEMOTICONS_NO_DEPRECATED
- -DKEMOTICONS_DEPRECATED_WARNINGS_SINCE
- -DKEMOTICONS_NO_DEPRECATED_WARNINGS
  
  or (once enabled when all KF modules are done)
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KEmoticons optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

REPOSITORY
  R301 KEmoticons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24710

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/kemoticonsprovider.cpp
  src/core/kemoticonsprovider.h
  src/core/kemoticonstheme.cpp
  src/core/kemoticonstheme.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ed5d288ae908: Icons for windy weather (authored by 
cblack).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24537?vs=68079&id=68080

REVISION DETAIL
  https://phabricator.kde.org/D24537

AFFECTED FILES
  icons-dark/applets/48/weather-clear-wind-night.svg
  icons-dark/applets/48/weather-clear-wind.svg
  icons-dark/applets/48/weather-clouds-wind-night.svg
  icons-dark/applets/48/weather-clouds-wind.svg
  icons-dark/applets/48/weather-few-clouds-wind-night.svg
  icons-dark/applets/48/weather-few-clouds-wind.svg
  icons-dark/applets/48/weather-many-clouds-wind.svg
  icons-dark/applets/48/weather-overcast-wind.svg
  icons/applets/48/weather-clear-wind-night.svg
  icons/applets/48/weather-clear-wind.svg
  icons/applets/48/weather-clouds-wind-night.svg
  icons/applets/48/weather-clouds-wind.svg
  icons/applets/48/weather-few-clouds-wind-night.svg
  icons/applets/48/weather-few-clouds-wind.svg
  icons/applets/48/weather-many-clouds-wind.svg
  icons/applets/48/weather-overcast-wind.svg

To: cblack, #vdg, ndavis, ngraham
Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24537: Icons for windy weather

[Carson Black]

cblack updated this revision to Diff 68079.
cblack added a comment.


  Run icons through SVG cleaner

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24537?vs=68009&id=68079

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

AFFECTED FILES
  icons-dark/applets/48/weather-clear-wind-night.svg
  icons-dark/applets/48/weather-clear-wind.svg
  icons-dark/applets/48/weather-clouds-wind-night.svg
  icons-dark/applets/48/weather-clouds-wind.svg
  icons-dark/applets/48/weather-few-clouds-wind-night.svg
  icons-dark/applets/48/weather-few-clouds-wind.svg
  icons-dark/applets/48/weather-many-clouds-wind.svg
  icons-dark/applets/48/weather-overcast-wind.svg
  icons/applets/48/weather-clear-wind-night.svg
  icons/applets/48/weather-clear-wind.svg
  icons/applets/48/weather-clouds-wind-night.svg
  icons/applets/48/weather-clouds-wind.svg
  icons/applets/48/weather-few-clouds-wind-night.svg
  icons/applets/48/weather-few-clouds-wind.svg
  icons/applets/48/weather-many-clouds-wind.svg
  icons/applets/48/weather-overcast-wind.svg

To: cblack, #vdg, ndavis, ngraham
Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24537: Icons for windy weather

[Carson Black]

cblack edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24537: Icons for windy weather

[TrickyRicky]

trickyricky26 added a comment.


  With the blue color, I like these icons. Please remember to update images in 
the test plan when you make changes such as this color change, they're very 
helpful for judging things e.g. on a phone.

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24707: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, drosca.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to BluezQt to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DBLUEZQT_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DBLUEZQT_NO_DEPRECATED
- -DBLUEZQT_DEPRECATED_WARNINGS_SINCE
- -DBLUEZQT_NO_DEPRECATED_WARNINGS
  
  or (once enabled when all KF modules are done)
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build BluezQt optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.57.0, CURRENT.

REPOSITORY
  R269 BluezQt

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24707

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/manager.cpp
  src/manager.h

To: kossebau, #frameworks, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer updated this revision to Diff 68072.
thomasfischer added a comment.


  I rewrote the patch to address the comments:
  
  1. Setting `ECM_SOURCE_UNDER_VERSION_CONTROL` has been refactored to set 
variable `ECM_SOURCE_VERSION_CONTROL_WHICH` as well to determine which of three 
known VCSes are used. `ECM_SOURCE_VERSION_CONTROL_WHICH` contains a string like 
"git" or "svn".
  2. The more expensive check where an external program ("git") has to be run 
got refactored into a macro (`ecm_source_version_control_stat`). Support for 
Subversion, Mercurial, and Bazaar got removed. Messages will be printed to show 
the status of the analysis. It is a macro, not a function, to have changes to 
variables like `ECM_SOURCE_VERSION_CONTROL_BRANCH` visible outside of the 
function.
  
  To clarify `ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT`: it counts the number of 
commits in direct line of succession from the repository's initialization to 
the current commit. It does not include commits in other branches. Basically 
the number of commits listed in a plain `git log`. The commit count gives a 
quick indication of the progress of a repository (or branch) without requiring 
to look up the repo's commit messages or hashes.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24641?vs=67922&id=68072

REVISION DETAIL
  https://phabricator.kde.org/D24641

AFFECTED FILES
  modules/ECMSourceVersionControl.cmake

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24598: Update elisa icon

[Nathaniel Graham]

ngraham added a comment.


  In D24598#548335 , @astippich 
wrote:
  
  > This is with the tape window moved up 1px
  >  F7608368: elisaBigNew2.png 
  >  When I look at images of real cassettes, they are not centered, hence why 
I only did this slight adjustment.
  >  If everyone is okay with this, I will update the revision with the 
optimized svgs.
  >  I don't think that filling this space is useful.
  
  
  That's just fine IMO!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  This is with the tape window moved up 1px
  F7608368: elisaBigNew2.png 
  When I look at images of real cassettes, they are not centered, hence why I 
only did this slight adjustment.
  If everyone is okay with this, I will update the revision with the optimized 
svgs.
  I don't think that filling this space is useful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[Méven Car]

meven updated this revision to Diff 68067.
meven added a comment.


  Update TODO

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24695?vs=68043&id=68067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24695

AFFECTED FILES
  src/kxmlguiclient.h

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[Méven Car]

meven added a comment.


  In D24695#548248 , @dfaure wrote:
  
  > In my experience 90 % of the users of this class don't care for the state 
feature, so I would rather move it to a separate class.
  >
  > Also this class is used everywhere, so the change would have massive 
repercussions, while most users (both subclasses and code using a kxmlguiclient 
pointer) don't care for the state thing.
  >
  > I suggest extracting the feature into a helper class separate from the 
kxmlguiclient hierarchy.
  
  
  Great suggestion, I agree.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis added a comment.


  Oh yes, that would be a good thing. Any of these will be fine: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24703

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[David Edmundson]

davidedmundson added a comment.


  Good rundown of the options.
  
  > remove SystemTray support from KdePlatformTheme
  
  It's not trivial. There's no way to access the relevant Qt classes. I should 
revisit the patch that allowed that.
  
  Our hopeful longterm plans for KF6 are to kill KStatusNotifierItem add the 
missing methods to QSystemTray, fix some other parts of their implementation 
and then drop it here.
  
  ---
  
  > do not delete menu in KSNI
  
  Makes the most sense in some form.
  It /could/ be done without additional API by abusing QObject parentship: 
https://phabricator.kde.org/P479
  
  Then this code being a special case would just set the parent back 
afterwards. Whether that's actually any better than any explicit boolean method 
is debatable though.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24703

AFFECTED FILES
  src/core/ksslerror_p.h
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24700: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, ilic.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KI18n to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DKI18N_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKI18N_NO_DEPRECATED
- -DKI18N_DEPRECATED_WARNINGS_SINCE
- -DKI18N_NO_DEPRECATED_WARNINGS
  
  or (once enabled when all KF modules are done)
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KI18n optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

REPOSITORY
  R249 KI18n

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24700

AFFECTED FILES
  CMakeLists.txt
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  src/CMakeLists.txt
  src/klocalizedstring.cpp
  src/klocalizedstring.h

To: kossebau, #frameworks, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[David Faure]

dfaure added a comment.


  In my experience 90 % of the users of this class don't care for the state 
feature, so I would rather move it to a separate class.
  
  Also this class is used everywhere, so the change would have massive 
repercussions, while most users (both subclasses and code using a kxmlguiclient 
pointer) don't care for the state thing.
  
  I suggest extracting the feature into a helper class separate from the 
kxmlguiclient hierarchy.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24652

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Kai Uwe Broulik]

broulik added a comment.


  > bool takeOwnership = true);
  
  If only Qt/we used modern C++ features to communicate object ownership :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24697: Expose isImmutable to introspection (e.g. QML)

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:3f68be12f87e: Expose isImmutable to introspection (e.g. 
QML) (authored by ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24697?vs=68046&id=68052

REVISION DETAIL
  https://phabricator.kde.org/D24697

AFFECTED FILES
  src/core/kcoreconfigskeleton.h

To: ervin, #plasma, #frameworks, mart, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24697: Expose isImmutable to introspection (e.g. QML)

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24697

To: ervin, #plasma, #frameworks, mart, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24697: Expose isImmutable to introspection (e.g. QML)

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, Frameworks, mart, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24697

AFFECTED FILES
  src/core/kcoreconfigskeleton.h

To: ervin, #plasma, #frameworks, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> zzag wrote in plasmawindowmanagement_interface.cpp:741
> Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in 
> KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.
> 
> Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in 
the commit message:
"No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by
someone with detailed knowledge about disabling implementation, if wanted."

I tried to add it, but too much API got deprecated yet still kept being used 
internally. So a version-levelled disabling of implementation is not yet 
possible, first needs more cleanup of the internal usages.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Björn Feber]

GB_2 added a comment.


  Can you clean the SVGs a bit?

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

[Kai Uwe Broulik]

broulik added a comment.


  I checked Qt source code and Qt indeed should handle this on its own, it also 
works fine hwere without the code.
  Worse, the explicit assignment from QML breaks any binding set on 
`currentIndex`.
  In the handler that's called when the delegate model creates a delegate it 
does the following
  
void QQuickComboBoxPrivate::createdItem(int index, QObject *object)
{
...
QQuickAbstractButton *button = qobject_cast(object);
if (button) {
button->setFocusPolicy(Qt::NoFocus);
connect(button, &QQuickAbstractButton::clicked, this, 
&QQuickComboBoxPrivate::itemClicked);
connect(button, &QQuickAbstractButton::hoveredChanged, this, 
&QQuickComboBoxPrivate::itemHovered);
}
  
  `ItemDelegate` is an `AbstractButton` and in `itemClicked` it sets the 
`currentIndex` and emits `activated`.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18299

To: apol, #frameworks, davidedmundson
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[Méven Car]

meven added a comment.


  This is just to make sure this TODO makes sense and is consensual.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, kossebau, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  To avoid string typing, replace usage of string with a proper enum defined in 
user classes

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24695

AFFECTED FILES
  src/kxmlguiclient.h

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

[Ahmad Samir]

ahmadsamir abandoned this revision.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: cullmann, ognarb, kde-frameworks-devel

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich added a dependent revision: D24691: Add support for WPA3.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Konrad Materka]

kmaterka added a comment.


  I think the best would be to add additional parameter to KSNI. Change from:
  
void KStatusNotifierItem::setContextMenu(QMenu *menu);
  
  to something like this:
  
void KStatusNotifierItem::setContextMenu(QMenu *menu, bool takeOwnership = 
true);
  
  Then, after next release of Frameworks, change implementation in 
plasma-integration.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  `kf5-network.directory` has been added to `plasma-workspace`.
  
  The trouble is still here: if we land this patch and released new frameworks, 
it won't work with older plasma workspace (like 5.17.0, 5.16.x).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich updated this revision to Diff 68029.
jgrulich added a comment.


  Compare against lowercase value

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68028&id=68029

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich added a reviewer: Frameworks.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 153 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/153/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 16 Oct 2019 08:39:36 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)56%
(34820/61637)40%
(17614/43576)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9656/10118)47%
(4502/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8798/14531)52%
(4569/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2021/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(520/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1795/4291)36%
(1311/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/140/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 16 Oct 2019 08:39:36 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Konrad Materka]

kmaterka added a reviewer: Frameworks.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Konrad Materka]

kmaterka retitled this revision from "Activate when both associatedWidget and 
menu are null" to "[KStatusNotifierItem] Allow left click when menu is null".

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:591cc2a16e3e: Treat 
"application/x-ms-dos-executable" as executable on all platforms 
(authored by Guo Yunhe ).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67761&id=68027

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag edited reviewers, added: KWin; removed: Plasma.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:741
>  
> -#ifndef KWAYLANDSERVER_NO_DEPRECATED
>  void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop)

Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in 
KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.

Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  The commit log talks about KCalendarCore instead of KIO :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  With D23523  and D24582 
, we can avoid some IO by not using 
SlaveBase::config()
  
  Will wait for KF 5.64 release before landing.

TEST PLAN
  Compiles

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

AFFECTED FILES
  CMakeLists.txt
  nfs/nfsv2.cpp
  nfs/nfsv3.cpp
  sftp/kio_sftp.cpp
  smb/kio_smb_dir.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/139/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 16 Oct 2019 07:04:32 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 152 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/152/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 16 Oct 2019 07:07:14 +
 Build duration:
32 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)56%
(34799/61625)40%
(17581/43532)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9639/10118)47%
(4468/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8796/14531)52%
(4565/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(520/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1795/4291)36%
(1311/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 68021.
kossebau added a comment.


  update to latest master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24684?vs=68018&id=68021

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24684

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/copyjob.h
  src/core/global.cpp
  src/core/global.h
  src/core/job_base.h
  src/core/jobuidelegateextension.h
  src/core/kcoredirlister.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/krecentdocument.h
  src/core/ksambashare.cpp
  src/core/ksambashare.h
  src/core/ksslcertificatemanager.h
  src/core/ktcpsocket.h
  src/core/scheduler.cpp
  src/core/scheduler.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/core/transferjob.cpp
  src/core/transferjob.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilepreviewgenerator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  src/filewidgets/knewfilemenu.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/CMakeLists.txt
  src/widgets/accessmanager.cpp
  src/widgets/accessmanager.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/kurifilter.cpp
  src/widgets/kurifilter.h
  src/widgets/kurlrequester.cpp
  src/widgets/kurlrequester.h
  src/widgets/kurlrequesterdialog.cpp
  src/widgets/kurlrequesterdialog.h
  src/widgets/paste.cpp
  src/widgets/paste.h
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h
  src/widgets/thumbcreator.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Followup after D24582 
  
  There are only 5 usage of SlaveBase::config() that are more intrusive to 
replace

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24685

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT here as well, that needs 
another round of work. Thus the removal of all the KIOWIDGETS_NO_DEPRECATED 
from the source files, no *_BUILD_DEPRECATED_SINCE there to properly replace 
them for now.
  
  So patch solely concentrating on visibility of deprecated API to consumers of 
KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KCalendarCore to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKIOCORE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKIOCORE_NO_DEPRECATED
- -DKIOCORE_DEPRECATED_WARNINGS_SINCE
- -DKIOCORE_NO_DEPRECATED_WARNINGS
- -DKIOKIOFILEWIDGETS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKIOKIOFILEWIDGETS_NO_DEPRECATED
- -DKIOKIOFILEWIDGETS_DEPRECATED_WARNINGS_SINCE
- -DKIOKIOFILEWIDGETS_NO_DEPRECATED_WARNINGS
- -DKIOWIDGETS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKIOWIDGETS_NO_DEPRECATED
- -DKIOWIDGETS_DEPRECATED_WARNINGS_SINCE
- -DKIOWIDGETS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS

REPOSITORY
  R241 KIO

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24684

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/copyjob.h
  src/core/global.cpp
  src/core/global.h
  src/core/job_base.h
  src/core/jobuidelegateextension.h
  src/core/kcoredirlister.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/krecentdocument.h
  src/core/ksambashare.cpp
  src/core/ksambashare.h
  src/core/ksslcertificatemanager.h
  src/core/ktcpsocket.h
  src/core/scheduler.cpp
  src/core/scheduler.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/core/transferjob.cpp
  src/core/transferjob.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilepreviewgenerator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  src/filewidgets/knewfilemenu.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/CMakeLists.txt
  src/widgets/accessmanager.cpp
  src/widgets/accessmanager.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/kurifilter.cpp
  src/widgets/kurifilter.h
  src/widgets/kurlrequester.cpp
  src/widgets/kurlrequester.h
  src/widgets/kurlrequesterdialog.cpp
  src/widgets/kurlrequesterdialog.h
  src/widgets/paste.cpp
  src/widgets/paste.h
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h
  src/widgets/thumbcreator.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0911763b8f19: Replace usage of SlaveBase::config() by 
SlaveBase::mapConfig() (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24582?vs=67943&id=68017

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/http/http.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns