D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:dc13d172fdc8: Use a more correct and appropriate visual 
metaphor for get hot new stuff icon (authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24871?vs=68567=68583

REVISION DETAIL
  https://phabricator.kde.org/D24871

AFFECTED FILES
  icons-dark/actions/16/get-hot-new-stuff.svg
  icons-dark/actions/22/get-hot-new-stuff.svg
  icons-dark/actions/24/get-hot-new-stuff.svg
  icons/actions/16/get-hot-new-stuff.svg
  icons/actions/22/get-hot-new-stuff.svg
  icons/actions/24/get-hot-new-stuff.svg

To: ngraham, #vdg, leinir, ndavis
Cc: kde-frameworks-devel, ndavis, LeGast00n, GB_2, michaelh, ngraham, bruns

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-appropriate-ghns-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24871

To: ngraham, #vdg, leinir, ndavis
Cc: kde-frameworks-devel, ndavis, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

[David Faure]

dfaure added a comment.


  `Depth: 1` is duplicated too.
  
  I tried adding a contentType.isEmpty() check, but it is actually empty. Needs 
more debugging

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24316

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

[David Faure]

dfaure added a comment.


  This commit completely breaks the davgroupware resource for me (to access 
kolab calendars via CALDAV).
  
  REPORT requests get a 400 Bad Request error from the server.
  
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
 Sending Header:
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"REPORT /calendars/dfa...@kdab.com/0a9636a30e83-8c02805b740e-0a0dee75/ HTTP/1.1"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Host: caldav.kdab.com"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Connection: keep-alive"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.34 (KHTML, like 
Gecko) akonadi_davgroupware_resource_11/5.12.2 Safari/534.34"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Pragma: no-cache"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Cache-control: no-cache"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Accept: text/html, text/*;q=0.9, image/jpeg;q=0.9, image/png;q=0.9, 
image/*;q=0.9, */*;q=0.8"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Accept-Encoding: gzip, deflate, x-gzip, x-deflate"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Accept-Charset: utf-8,*;q=0.5"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Accept-Language: en-US,en;q=0.9"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Content-Type: text/xml"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Depth: 1"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Authorization: Basic [snipped"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Depth: 1"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: 
"Content-Type: text/xml; charset=utf-8"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendBody: 
"\r\n\n \n  \n  \n \n \n  \n   \n  \n 
\n"
  2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http 
HTTPProtocol::readResponseHeader: 
  2019-10-22T12:35:17 kio_http(12004)/kf5.kio.kio_http 
HTTPProtocol::readResponseHeader:  Received Status Response:
  2019-10-22T12:35:17 kio_http(12004)/kf5.kio.kio_http 
HTTPProtocol::readResponseHeader: "HTTP/1.1 400 Bad Request"
  
  I think the problem is that the request has two Content-Type headers. The 
second one is added by the code we are now entering, line 2603, because of the 
modified if().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24316

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> ksslinfodialog.h:81
> + */
> +KIOWIDGETS_DEPRECATED void setSslInfo(const QList 
> ,
> +const QString , const QString ,

Does this need to use the new deprecated since markers?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24703

To: vkrause
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

[Volker Krause]

vkrause added a comment.


  This will compile, but it will only work correctly once TCPSlaveBase has been 
ported to QSslSocket too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24873

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, vkrause.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  ahmad/kio_http-ktcpsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24873

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now it's a duplicate (not even a symlink) of the `favorite` icon, which 
is
  semantically inaccurate. A more appropriate visual metaphor is "download", 
since that's
  what GHNS will do. So this patch symlinks the GHNS icon to `edit-download`. 
This makes
  it work for icons-only buttons as well, where the icon alone is sufficient to 
communicate
  what will happen.
  
  Thanks for @ndavis for suggesting this.
  
  BUG: 400500
  FIXED-IN: 5.64

TEST PLAN
  F7651335: global theme.png 
  F7651336: widget explorer.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-appropriate-ghns-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24871

AFFECTED FILES
  icons-dark/actions/16/get-hot-new-stuff.svg
  icons-dark/actions/22/get-hot-new-stuff.svg
  icons-dark/actions/24/get-hot-new-stuff.svg
  icons/actions/16/get-hot-new-stuff.svg
  icons/actions/22/get-hot-new-stuff.svg
  icons/actions/24/get-hot-new-stuff.svg

To: ngraham, #vdg, leinir
Cc: kde-frameworks-devel, ndavis, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/17/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 18:04:06 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarktest

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/15/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 18:04:08 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 39 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/39/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 18:03:56 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdelibs4configmigratortestFailed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kprocesslisttestFailed: projectroot.autotests.krandomtest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:42:19 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/37/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 22 Oct 2019 17:40:38 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.64.0.xmllogs/KF5WindowSystem/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7272/9597)56%
(3532/6351)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3079/3164)53%
(1293/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(827/1380)47%
(303/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3359/4695)60%
(1933/3197)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/18/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 17:26:54 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:39:20 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 74 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/74/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 17:39:21 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27192/32074)53%
(10952/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12501/12573)50%
(6591/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6344/7481)64%
(1828/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7893/9364)64%
(2356/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/38/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 17:21:28 +
 Build duration:
26 min and counting
   CONSOLE OUTPUT
  [...truncated 1210 lines...][2019-10-22T17:46:50.474Z] QWARN  : KDirWatch_UnitTest::shouldIgnoreQrcPaths() kf5.kcoreaddons.kdirwatch: Cannot watch QRC-like path ":/kio5/newfile-templates"[2019-10-22T17:46:50.474Z] PASS   : KDirWatch_UnitTest::shouldIgnoreQrcPaths()[2019-10-22T17:46:50.474Z] SKIP   : KDirWatch_UnitTest::benchCreateTree() Benchmarks are disabled in debug mode[2019-10-22T17:46:50.474Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.13\autotests\kdirwatch_unittest.cpp(814) : failure location[2019-10-22T17:46:50.474Z] SKIP   : KDirWatch_UnitTest::benchCreateWatcher() Benchmarks are disabled in debug mode[2019-10-22T17:46:50.474Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.13\autotests\kdirwatch_unittest.cpp(826) : failure location[2019-10-22T17:46:50.474Z] SKIP   : KDirWatch_UnitTest::benchNotifyWatcher() Benchmarks are disabled in debug mode[2019-10-22T17:46:50.474Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.13\autotests\kdirwatch_unittest.cpp(840) : failure location[2019-10-22T17:46:50.474Z] PASS   : KDirWatch_UnitTest::cleanupTestCase()[2019-10-22T17:46:50.474Z] Totals: 13 passed, 2 failed, 4 skipped, 0 blacklisted, 25451ms[2019-10-22T17:46:50.474Z] * Finished testing of KDirWatch_UnitTest *[2019-10-22T17:46:50.474Z] [2019-10-22T17:46:50.474Z] [2019-10-22T17:46:50.474Z] 85% tests passed, 4 tests failed out of 26[2019-10-22T17:46:50.474Z] [2019-10-22T17:46:50.474Z] Total Test time (real) =  73.10 sec[2019-10-22T17:46:50.474Z] [2019-10-22T17:46:50.474Z] The following tests FAILED:[2019-10-22T17:46:50.474Z] 	 12 - krandomtest (Failed)[2019-10-22T17:46:50.474Z] 	 19 - kdelibs4configmigratortest (Failed)[2019-10-22T17:46:50.474Z] 	 20 - kprocesslisttest (Failed)[2019-10-22T17:46:50.474Z] 	 26 - kdirwatch_qfswatch_unittest (Failed)[2019-10-22T17:46:50.474Z] Errors while running CTest[2019-10-22T17:46:50.474Z] ERROR: The process "kded5.exe" not found.[2019-10-22T17:46:50.474Z] ERROR: The process "klauncher.exe" not found.[2019-10-22T17:46:50.474Z] ERROR: The process "kdeinit5.exe" not found.[2019-10-22T17:46:50.474Z] ERROR: The process "test_crasher.exe" not found.[2019-10-22T17:46:50.474Z] ERROR: The process "dbus-daemon.exe" not found.[2019-10-22T17:47:51.990Z] ERROR: The process "kioslave.exe" not found.[2019-10-22T17:47:51.990Z] ERROR: The process "vctip.exe" not found.[Pipeline] junit[2019-10-22T17:47:52.316Z] Recording test results[2019-10-22T17:47:52.523Z] Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-22T17:47:52.955Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975[2019-10-22T17:47:52.955Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-22T17:47:52.955Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-22T17:47:52.955Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-22T17:47:52.955Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-10-22T17:47:52.955Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-10-22T17:47:52.955Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-10-22T17:47:52.955Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-10-22T17:47:52.955Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-10-22T17:47:52.955Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-10-22T17:47:52.955Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-10-22T17:47:52.955Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-22T17:47:52.955Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-22T17:47:52.955Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-22T17:47:52.955Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-22T17:47:52.955Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-22T17:47:52.955Z] 		at java.lang.Thread.run(Thread.java:748)[2019-10-22T17:47:52.955Z] java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins[2019-10-22T17:47:52.955Z] 	at hudson.ExtensionList.lookup(ExtensionList.java:433)[2019-10-22T17:47:52.955Z] 	at 

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.13/21/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 17:21:59 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:38:20 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 154 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/154/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:33:32 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:37:15 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/16/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 17:17:13 +
 Build duration:
17 min and counting
   CONSOLE OUTPUT
  [...truncated 498 lines...][2019-10-22T17:33:51.878Z] qt.qpa.windows: QWindowsTheme::refreshIconPixmapSizes (QSize(16, 16), QSize(32, 32), QSize(48, 48), QSize(256, 256))[2019-10-22T17:33:51.878Z] * Start testing of KBookmarkTest *[2019-10-22T17:33:51.878Z] Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-llp64 shared (dynamic) debug build; by MSVC 2017)[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::initTestCase()[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::testMimeDataOneBookmark()[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::testMimeDataBookmarkList()[2019-10-22T17:33:51.878Z] QDEBUG : KBookmarkTest::testFileCreatedExternally() kf5.kcoreaddons.kdirwatch: "KDirWatch-1" emitting created "C:/Users/Jenkins/AppData/Local/qttest/user-places.xbel"[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::testFileCreatedExternally()[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::testBookmarkManager()[2019-10-22T17:33:51.878Z] PASS   : KBookmarkTest::cleanupTestCase()[2019-10-22T17:33:51.878Z] Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 2691ms[2019-10-22T17:33:51.878Z] * Finished testing of KBookmarkTest *[2019-10-22T17:33:51.878Z] [2019-10-22T17:33:51.878Z] Start 2: kbookmarkmenutest[2019-10-22T17:33:51.878Z] 2/2 Test #2: kbookmarkmenutest    Passed3.26 sec[2019-10-22T17:33:51.878Z] [2019-10-22T17:33:51.878Z] 50% tests passed, 1 tests failed out of 2[2019-10-22T17:33:51.878Z] [2019-10-22T17:33:51.878Z] Total Test time (real) = 301.69 sec[2019-10-22T17:33:51.878Z] [2019-10-22T17:33:51.878Z] The following tests FAILED:[2019-10-22T17:33:51.878Z] 	  1 - kbookmarktest (Failed)[2019-10-22T17:33:51.878Z] Errors while running CTest[2019-10-22T17:33:51.878Z] ERROR: The process "kded5.exe" not found.[2019-10-22T17:33:51.878Z] ERROR: The process "klauncher.exe" not found.[2019-10-22T17:33:51.878Z] ERROR: The process "kdeinit5.exe" not found.[2019-10-22T17:33:51.878Z] ERROR: The process "test_crasher.exe" not found.[2019-10-22T17:33:51.878Z] ERROR: The process "dbus-daemon.exe" not found.[2019-10-22T17:34:53.386Z] ERROR: The process "kioslave.exe" not found.[2019-10-22T17:34:53.386Z] ERROR: The process "vctip.exe" not found.[Pipeline] junit[2019-10-22T17:34:53.907Z] Recording test results[2019-10-22T17:34:54.071Z] Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-22T17:34:54.757Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975[2019-10-22T17:34:54.757Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-22T17:34:54.757Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-22T17:34:54.757Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-22T17:34:54.757Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-10-22T17:34:54.757Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-10-22T17:34:54.757Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-10-22T17:34:54.757Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-10-22T17:34:54.757Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-10-22T17:34:54.757Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-10-22T17:34:54.757Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-10-22T17:34:54.757Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-22T17:34:54.757Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-22T17:34:54.757Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-22T17:34:54.757Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-22T17:34:54.757Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-22T17:34:54.757Z] 		at java.lang.Thread.run(Thread.java:748)[2019-10-22T17:34:54.757Z] java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins[2019-10-22T17:34:54.757Z] 	at hudson.ExtensionList.lookup(ExtensionList.java:433)[2019-10-22T17:34:54.757Z] 	at hudson.tasks.junit.TestNameTransformer.all(TestNameTransformer.java:40)[2019-10-22T17:34:54.757Z] 	at hudson.tasks.junit.TestNameTransformer.getTransformedName(TestNameTransformer.java:33)[2019-10-22T17:34:54.757Z] 	

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 53 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/53/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 22 Oct 2019 17:21:28 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6885/9076)43%
(10769/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2964)48%
(6171/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Friedrich W. H. Kossebau]

kossebau added a comment.


  As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also 
wrap the implementation of assignIconsToContextMenu, with #if 
KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_).
  
  Seems you are a candidate to answer the email 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/095831.html, 
please :)

INLINE COMMENTS

> kicontheme.h:291
>   */
> -static void assignIconsToContextMenu(ContextMenus type, QList 
> actions);
> +KICONTHEMES_DEPRECATED_VERSION(5, 64, "No longer necessary") static void 
> assignIconsToContextMenu(ContextMenus type, QList actions); // 
> TODO KF6 remove
> +#endif

IMHO moving the KICONTHEMES_DEPRECATED_VERSION onto an own line improves 
readability, especially with longer "what to do now" text arguments.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24764

To: vkrause, mlaurent
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 100 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/100/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 17:21:28 +
 Build duration:
4 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6885/9077)43%
(10769/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2964)48%
(6171/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:22:35 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/49/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:21:28 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/14/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 17:12:53 +
 Build duration:
6 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 610 lines...][2019-10-22T17:16:31.230Z] [2019-10-22T17:16:31.230Z] C:\CI\workspace\Frameworks\attica\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-10-22T17:16:31.734Z] **[2019-10-22T17:16:31.734Z] ** Visual Studio 2019 Developer Command Prompt v16.3.0[2019-10-22T17:16:31.734Z] ** Copyright (c) 2019 Microsoft Corporation[2019-10-22T17:16:31.734Z] **[2019-10-22T17:16:40.737Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-10-22T17:18:38.352Z] 'kdeinit5' is not recognized as an internal or external command,[2019-10-22T17:18:38.352Z] operable program or batch file.[2019-10-22T17:18:38.352Z]Site: DESKTOP-V7LQR8M[2019-10-22T17:18:38.352Z]Build name: Win32-jom[2019-10-22T17:18:38.352Z] Create new tag: 20191022-1718 - Experimental[2019-10-22T17:18:38.352Z] Test project C:/CI/workspace/Frameworks/attica/kf5-qt5 WindowsMSVCQt5.13/build[2019-10-22T17:18:38.352Z] Start 1: configtest[2019-10-22T17:18:39.484Z] 1/3 Test #1: configtest ...   Passed5.79 sec[2019-10-22T17:18:39.484Z] Start 2: persontest[2019-10-22T17:18:39.484Z] 2/3 Test #2: persontest ...   Passed0.18 sec[2019-10-22T17:18:39.484Z] Start 3: providertest[2019-10-22T17:18:44.488Z] 3/3 Test #3: providertest .   Passed5.14 sec[2019-10-22T17:18:44.488Z] [2019-10-22T17:18:44.488Z] 100% tests passed, 0 tests failed out of 3[2019-10-22T17:18:44.488Z] [2019-10-22T17:18:44.488Z] Total Test time (real) =  11.30 sec[2019-10-22T17:18:45.550Z] ERROR: The process "kded5.exe" not found.[2019-10-22T17:18:45.550Z] ERROR: The process "klauncher.exe" not found.[2019-10-22T17:18:45.550Z] ERROR: The process "kdeinit5.exe" not found.[2019-10-22T17:18:46.067Z] ERROR: The process "test_crasher.exe" not found.[2019-10-22T17:18:46.067Z] ERROR: The process "dbus-daemon.exe" not found.[2019-10-22T17:19:47.682Z] ERROR: The process "kioslave.exe" not found.[2019-10-22T17:19:47.682Z] ERROR: The process "vctip.exe" not found.[Pipeline] junit[2019-10-22T17:19:47.970Z] Recording test results[2019-10-22T17:19:48.938Z] Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-22T17:19:49.688Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975[2019-10-22T17:19:49.688Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-22T17:19:49.688Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-22T17:19:49.688Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-22T17:19:49.688Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-10-22T17:19:49.688Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-10-22T17:19:49.688Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-10-22T17:19:49.688Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-10-22T17:19:49.688Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-10-22T17:19:49.688Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-10-22T17:19:49.688Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-10-22T17:19:49.688Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-22T17:19:49.688Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-22T17:19:49.688Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-22T17:19:49.688Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-22T17:19:49.688Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-22T17:19:49.688Z] 		at java.lang.Thread.run(Thread.java:748)[2019-10-22T17:19:49.688Z] java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins[2019-10-22T17:19:49.688Z] 	at hudson.ExtensionList.lookup(ExtensionList.java:433)[2019-10-22T17:19:49.688Z] 	at hudson.tasks.junit.TestNameTransformer.all(TestNameTransformer.java:40)[2019-10-22T17:19:49.688Z] 	at hudson.tasks.junit.TestNameT

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:17:53 +
 Build duration:
1 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

D24841: Use modern way to set the C/CXX standard

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6e3c794e7c63: Use modern way to set the C/CXX standad 
(authored by vonreth).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24841?vs=68488=68560#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68488=68560

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/17/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 16:21:03 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.autotests.kiconloader_benchmark

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/153/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 16:16:07 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ccf27d634cbf: Deprecate 
KIconTheme::assignIconsToContextMenu (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24764?vs=68252=68555#toc

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24764?vs=68252=68555

REVISION DETAIL
  https://phabricator.kde.org/D24764

AFFECTED FILES
  src/CMakeLists.txt
  src/kicontheme.h

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:12b68224e084: Port the KSSLD D-Bus interface from 
KSslError to QSslError (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24676?vs=67999=68552#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24676?vs=67999=68552

REVISION DETAIL
  https://phabricator.kde.org/D24676

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h
  src/core/ksslcertificatemanager_p.h
  src/core/kssld_dbusmetatypes.h

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24703

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Luigi Toscano]

Jonathan Riddell ha scritto:
> There's a file called LICENSE which contains a copy of the LGPL 2.1
> 
> But all the files with an explicit licence seem to be GPL 2+3+KDEeV
> 
> Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove
> LICENSE and put a copy of the GPL 2 called COPYING which is our normal 
> practice.
> 

Also, if the goal is to make it part of Frameworks, it can't be GPL (but LGPL
or less restrictive licenses).

https://community.kde.org/Policies/Licensing_Policy

-- 
Luigi

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

[Méven Car]

meven added a comment.


  In D24858#552279 , @davidedmundson 
wrote:
  
  > The check comes from when the application requests a list of all available 
extensions, not when they actually request a specific one.
  >  The warning is a bit premature.
  >
  > kwallet most definitely shouldn't be getting the fake input extension!
  
  
  I guessed so because kate would have needed it as well...
  Thanks for the clarification @apol @davidedmundson another small thing to add 
to the Wayland TODO list ...

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D24858

To: meven, apol, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Re: Quick Charts in KDE Review

[Jonathan Riddell]

There's a file called LICENSE which contains a copy of the LGPL 2.1

But all the files with an explicit licence seem to be GPL 2+3+KDEeV

Please decide which licence you want to apply and if it's GPL 2+3+KDEeV
remove LICENSE and put a copy of the GPL 2 called COPYING which is our
normal practice.

Jonathan

On Mon, 21 Oct 2019 at 14:39, Arjen Hiemstra  wrote:

> Hi,
>
> Quick Charts has been moved to KDE review. The intent is to make it a
> Tier 1 framework.
>
> Quick Charts is a QML module that implements a set of high-performance,
> GPU accelerated
> charts. Currently the main user of it is a new KSysGuard UI I have been
> working on, but
> once it is part of Frameworks I also hope to convert several bits of
> Plasma to using it.
>
> - Arjen
>

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

[David Edmundson]

davidedmundson added a comment.


  The check comes from when the application requests a list of all available 
extensions, not when they actually request a specific one.
  The warning is a bit premature.
  
  kwallet most definitely shouldn't be getting the fake input extension!

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D24858

To: meven, apol, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24841: Use modern way to set the C/CXX standard

[Christophe Giboudeaux]

cgiboudeaux retitled this revision from "Use modern way to set the C/CXX 
standad" to "Use modern way to set the C/CXX standard".
cgiboudeaux edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

[Méven Car]

meven abandoned this revision.
meven added a comment.


  In D24858#552090 , @apol wrote:
  
  > These are not necessary for kwallet as far as I know. To fix this warning 
we'd have to look into where applications are requesting these and have these 
interfaces only requested when they're necessary.
  
  
  How can we prevent those warnings then ?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D24858

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24859: Add a .desktop file for kdeinit

[Méven Car]

meven abandoned this revision.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D24859

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.13/20/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 13:51:14 +
 Build duration:
21 min and counting
   CONSOLE OUTPUT
  [...truncated 849 lines...][2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  < 64  bytes:  165[2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  < 96  bytes:  514[2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  < 128  bytes:  56[2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  < 160  bytes:  0[2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  < 192  bytes:  0[2019-10-22T14:11:16.142Z] QDEBUG : QuickViewSharedEngineTest::engine() qt.qml.gc.statistics:  >= 224  bytes:  43[2019-10-22T14:11:16.142Z] PASS   : QuickViewSharedEngineTest::engine()[2019-10-22T14:11:16.142Z] PASS   : QuickViewSharedEngineTest::cleanupTestCase()[2019-10-22T14:11:16.142Z] Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted, 2272ms[2019-10-22T14:11:16.142Z] * Finished testing of QuickViewSharedEngineTest *[2019-10-22T14:11:16.142Z] qt.scenegraph.renderloop: windowDestroyed[2019-10-22T14:11:16.142Z] qt.scenegraph.renderloop: hide[2019-10-22T14:11:16.142Z] qt.scenegraph.renderloop: cleanup without an OpenGL context[2019-10-22T14:11:16.142Z] qt.qpa.gl: QWindowsEGLStaticContext::~QWindowsEGLStaticContext Releasing EGL display  0x21290f08ea0[2019-10-22T14:11:16.142Z] [2019-10-22T14:11:16.142Z] [2019-10-22T14:11:16.142Z] 50% tests passed, 1 tests failed out of 2[2019-10-22T14:11:16.142Z] [2019-10-22T14:11:16.142Z] Total Test time (real) =   9.33 sec[2019-10-22T14:11:16.142Z] [2019-10-22T14:11:16.142Z] The following tests FAILED:[2019-10-22T14:11:16.142Z] 	  2 - quickviewsharedengine (Failed)[2019-10-22T14:11:16.142Z] Errors while running CTest[2019-10-22T14:11:19.276Z] ERROR: The process "kded5.exe" not found.[2019-10-22T14:11:19.788Z] ERROR: The process "klauncher.exe" not found.[2019-10-22T14:11:19.788Z] ERROR: The process "kdeinit5.exe" not found.[2019-10-22T14:11:19.788Z] ERROR: The process "test_crasher.exe" not found.[2019-10-22T14:11:20.304Z] ERROR: The process "dbus-daemon.exe" not found.[2019-10-22T14:12:21.827Z] ERROR: The process "kioslave.exe" not found.[2019-10-22T14:12:21.827Z] ERROR: The process "vctip.exe" not found.[Pipeline] junit[2019-10-22T14:12:23.262Z] Recording test results[2019-10-22T14:12:24.214Z] Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-22T14:12:24.980Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975[2019-10-22T14:12:24.980Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-22T14:12:24.980Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-22T14:12:24.980Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-22T14:12:24.980Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-10-22T14:12:24.980Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-10-22T14:12:24.980Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-10-22T14:12:24.980Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-10-22T14:12:24.980Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-10-22T14:12:24.980Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-10-22T14:12:24.980Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-10-22T14:12:24.980Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-22T14:12:24.980Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-22T14:12:24.980Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-22T14:12:24.980Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-22T14:12:24.980Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-22T14:12:24.980Z] 		at java.lang.Thread.run(Thread.java:748)[2019-10-22T14:12:24.980Z] java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins[2019-10-22T14:12:24.980Z] 	at hudson.ExtensionList.lookup(ExtensionList.java:433)[2019-10-22T14:12:24.980Z] 	at hudson.tasks.junit.TestNameTransformer.all(TestNameTransformer.java:40)[2019-10-22T14:12:24.980Z] 	at 

D24821: Add ManagedConfigModule

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c8b95b07c53b: Add ManagedConfigModule (authored by ervin).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24821?vs=68530=68545

REVISION DETAIL
  https://phabricator.kde.org/D24821

AFFECTED FILES
  src/quickaddons/CMakeLists.txt
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol updated this revision to Diff 68546.
apol added a comment.


  Unrelated change

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23682?vs=68544=68546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

AFFECTED FILES
  src/plasma/CMakeLists.txt
  src/plasma/containment.cpp
  src/plasma/containmentactions.cpp
  src/plasma/containmentactions.h
  src/plasma/dataengine.cpp
  src/plasma/dataengine.h
  src/plasma/private/dataengine_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/scripting/dataenginescript.cpp
  src/plasma/scripting/dataenginescript.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: apol, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol updated this revision to Diff 68544.
apol added a comment.


  Adopt new deprecation macros

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23682?vs=65328=68544

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

AFFECTED FILES
  CMakeLists.txt
  src/plasma/CMakeLists.txt
  src/plasma/containment.cpp
  src/plasma/containmentactions.cpp
  src/plasma/containmentactions.h
  src/plasma/dataengine.cpp
  src/plasma/dataengine.h
  src/plasma/private/dataengine_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/scripting/dataenginescript.cpp
  src/plasma/scripting/dataenginescript.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: apol, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin updated this revision to Diff 68530.
ervin added a comment.


  Address David's comments

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24821?vs=68411=68530

REVISION DETAIL
  https://phabricator.kde.org/D24821

AFFECTED FILES
  src/quickaddons/CMakeLists.txt
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin marked an inline comment as done.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin marked 4 inline comments as done.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 11:24:56 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/73/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 11:24:59 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(238/268)89%
(238/268)82%
(26182/32028)51%
(10440/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)95%
(11881/12570)48%
(6243/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client95%
(72/76)95%
(72/76)81%
(6028/7457)59%
(1674/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7819/9345)64%
(2346/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 165 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/165/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 22 Oct 2019 10:53:52 +
 Build duration:
42 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)57%
(34831/61638)41%
(17630/43516)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9658/10118)47%
(4506/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8798/14530)52%
(4569/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4685/8303)43%
(2025/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(522/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1795/4291)36%
(1311/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D24859: Add a .desktop file for kdeinit

[Aleix Pol Gonzalez]

apol added a comment.


  Same as D24858 

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D24859

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

[Aleix Pol Gonzalez]

apol added a comment.


  These are not necessary for kwallet as far as I know. To fix this warning 
we'd have to look into where applications are requesting these and have these 
interfaces only requested when they're necessary.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D24858

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich closed this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  No, just rambling.
  
  Ship it.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/24/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 10:59:49 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.kmoretoolstest

D24859: Add a .desktop file for kdeinit

[Méven Car]

meven created this revision.
meven added reviewers: apol, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Prevents logs such as :
  
  kwin_core: Did not grant the interface "org_kde_plasma_window_management" to 
"/home/meven/kde/usr/bin/kdeinit5" . Please request it under 
X-KDE-Wayland-Interfaces
  kwin_core: Did not grant the interface "org_kde_kwin_keystate" to 
"/home/meven/kde/usr/bin/kdeinit5" . Please request it under 
X-KDE-Wayland-Interfaces
  kwin_core: Did not grant the interface "org_kde_kwin_fake_input" to 
"/home/meven/kde/usr/bin/kdeinit5" . Please request it under 
X-KDE-Wayland-Interfaces

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24859

AFFECTED FILES
  src/kdeinit/CMakeLists.txt
  src/kdeinit/org.kde.kdeinit5.desktop.cmake

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 164 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/164/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 21 Oct 2019 10:48:14 +
 Build duration:
1 day 0 hr and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)66%
(268/405)66%
(268/405)56%
(34575/61623)40%
(17466/43516)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)94%
(9485/10107)46%
(4443/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8765/14528)52%
(4556/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2021/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(522/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1749/4290)34%
(1232/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

Re: Quick Charts in KDE Review

[Arjen Hiemstra]

On 21-10-2019 16:45, Alexander Potashev wrote:

Hi Arjen,

1. I don't see any checks in the autotests. Would it be easy to
compare the displayed chart against a reference screenshot image, in
each of the tests?

The same screenshots could also help developers understand what kind
of charts kquickcharts is good for.


They are very simple QML based tests that currently only verify that the
main Chart types still get created correctly. It'd be nice to expand 
them,
though I am slightly hesitant to go with image based tests as they tend 
to

break easily. On the other hand, one of the main reasons for not having
more extensive tests is that I did not have an idea on how to do that, 
and

image based tests would solve part of that problem.



2. How to add a grid, ticks and labels to a line chart?



For the grid and labels, these are what I generally refer to as 
"decorations".
These are implemented as separate items that you use the normal QML 
layout
options with to layout. You can have a look at 
controls/LineChartControl.qml
to see how it is done for a Line chart. I still need to write some 
better

examples for this, but the control should give you a decent idea.

For ticks, assuming with those you mean some marker on the chart data 
points,
these are not currently implemented. I do have some ideas regarding 
these but

I did not need them yet.

- Arjen


пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra :


On 21-10-2019 15:22, Arjen Hiemstra wrote:
> Hi,
>
> Quick Charts has been moved to KDE review. The intent is to make it a
> Tier 1 framework.
>
> Quick Charts is a QML module that implements a set of
> high-performance, GPU accelerated
> charts. Currently the main user of it is a new KSysGuard UI I have
> been working on, but
> once it is part of Frameworks I also hope to convert several bits of
> Plasma to using it.

And of course, a link would be useful:

https://invent.kde.org/kde/kquickcharts

>
> - Arjen

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter updated this revision to Diff 68526.
sitter added a comment.


  remove warning

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24827?vs=68428=68526

BRANCH
  assert-for-git

REVISION DETAIL
  https://phabricator.kde.org/D24827

AFFECTED FILES
  CMakeLists.txt

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

[Méven Car]

meven created this revision.
meven added reviewers: apol, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  To Prevent logs such as :
  kwin_core: Did not grant the interface "org_kde_plasma_window_management" to 
"/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces
  kwin_core: Did not grant the interface "org_kde_kwin_keystate" to 
"/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces
  kwin_core: Did not grant the interface "org_kde_kwin_fake_input" to 
"/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24858

AFFECTED FILES
  src/runtime/kwalletd/kwalletd5.desktop

To: meven, apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> sitter wrote in CMakeLists.txt:49
> Well, at that point you can choose to:
> 
> - explicitly -DASSERT_SLAVE_STATES_DEFAULT=OFF which will not trigger the 
> warning as the option will not default to the auto detection if you set it 
> manually
> - just ignore the warning
> 
> If you don't want that I'd actually get rid of the warning altogether. 
> Determining what a given build type does isn't so reliably doable as users 
> may have custom build types that define whatever, so the warning is more of a 
> crutch than anything.

Please kill the warning then.
I want things to be simple for new developers. Having to find out what this 
"Assert slave states default" variable does shouldn't be part of the first day 
experience compiling KF5. And I certainly don't want to teach people to ignore 
warnings, either.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> dfaure wrote in CMakeLists.txt:49
> It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or 
> RelWithDebInfo (as I do for profiling).
> 
> Won't this give them the warning below then, even if they don't set the 
> KIO_ASSERT_SLAVE_STATES option)?
> 
> I would just set ASSERT_SLAVE_STATES_DEFAULT to OFF when the build type isn't 
> Debug.
> (i.e. checking for that as part of the condition on line 42)

Well, at that point you can choose to:

- explicitly -DASSERT_SLAVE_STATES_DEFAULT=OFF which will not trigger the 
warning as the option will not default to the auto detection if you set it 
manually
- just ignore the warning

If you don't want that I'd actually get rid of the warning altogether. 
Determining what a given build type does isn't so reliably doable as users may 
have custom build types that define whatever, so the warning is more of a 
crutch than anything.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added a comment.


  In D23766#533644 , @apol wrote:
  
  > The patch looks good to me, is there a reason why it wasn't accepted?
  
  
  I'm not sure from the comment whether David requested some changes to be made 
now or whether this is good for now and we can improve this in future.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

[Konrad Materka]

kmaterka added reviewers: Frameworks, broulik, nicolasfella.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24843

To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart