D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent edited the test plan for this revision. mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QXmlInputSource is deprecated in qt5.15 REPOSITORY R237 KConfig BRANCH port_QXmlStreamReader (branched from

D26441: New icon for KTimeTracker

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg, ndavis Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

cblack updated this revision to Diff 74293. cblack added a comment. Use a rich grey instead of a rich mahogany REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=74286=74293 BRANCH ktimetracker-icon (branched from master) REVISION DETAIL

D26888: work around to fully support the windows backend

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY really support the windows backend. REPOSITORY R289 KNotifications BRANCH windows (branched from master)

D26441: New icon for KTimeTracker

ndavis requested changes to this revision. ndavis added a subscriber: hellcp. ndavis added a comment. This revision now requires changes to proceed. I have to agree with what @hellcp said in the VDG chat earlier, the mahogany really does not fit. It draws attention to the wrong places and is

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 24 Jan 2020 01:07:07 + Build duration: 6 min 3 sec and counting JUnit Tests Name:

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. One more ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D26677: Port away from KLineEdit and KComboBox to Q equivalent

This revision was automatically updated to reflect the committed changes. Closed by commit R305:f9f0465b6352: Port away from KLineEdit and KComboBox to Q equivalent (authored by gassaf). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE

D26441: New icon for KTimeTracker

cblack updated this revision to Diff 74286. cblack added a comment. Adjust colour from blue to mahogany REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=72823=74286 BRANCH ktimetracker-icon (branched from master) REVISION DETAIL

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/74/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 23 Jan 2020 22:51:45 + Build duration: 2 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Jan 2020 22:51:45 + Build duration: 2 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 22:51:45 + Build duration: 1 min 40 sec and counting JUnit Tests Name:

D25798: Deprecated allowAsDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R309:f45bfd1c9fc0: Deprecated allowAsDefault (authored by nicolasfella). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=73672=74282 REVISION DETAIL

D26771: Add new signal for default action activation

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a2c88d21d9b7: Add new signal for default action activation (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73893=74281

D26623: KEMailSettings: group names in kconfig files should not be localized

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK. I'm pretty sure this used to be shown "as is" in kmail, VERY LONG ago. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D26623 To: meven,

D26878: Add a missing renamed event when a destination file already existed

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nitpicks: make oldDest const; extend jobtest. But this can also go in as is. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 To: meven,

D26848: Don't assume the manager and menu have the same lifetime

davidre updated this revision to Diff 74271. davidre added a comment. Use qApp as context REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26848?vs=74162=74271 BRANCH menumanager (branched from master) REVISION DETAIL

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Then it seems like the line is not tagged correctly. Maybe try `tagLines(note.position.line(), note.position.line())`? I think the column being the same is not what the function being called expects. REPOSITORY R39 KTextEditor BRANCH underMouse (branched from

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi added a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,

D26131: Braces around for, break early.

tcanabrava updated this revision to Diff 74258. tcanabrava added a comment. - use std::any_of REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26131?vs=71913=74258 BRANCH arcpatch-D26131 REVISION DETAIL https://phabricator.kde.org/D26131 AFFECTED

D26878: Add a missing renamed event when a destination file already existed

meven created this revision. meven added reviewers: Frameworks, ervin, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This was missing when a file was being copyied/moved, its destination

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY whitespace now returns a textStream so we don't need to stream() << whitespace() Use whitespace where we had

D26848: Don't assume the manager and menu have the same lifetime

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:191 > QActionGroup *group = new QActionGroup(menu); > -connect(group, ::triggered, this, [this](QAction * action) > { > -activateScheme(d->model->index(action->data().toInt())); > +connect(group,

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Run tests REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876

D26848: Don't assume the manager and menu have the same lifetime

broulik added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.cpp:191 > What is meant by "connecting to qApp"? Just doing the scheme switching here? > I wanted to avoid the duplication that's why I created the static helper > method. Using `qApp` as context object

D26848: Don't assume the manager and menu have the same lifetime

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:191 > QActionGroup *group = new QActionGroup(menu); > -connect(group, ::triggered, this, [this](QAction * action) > { > -activateScheme(d->model->index(action->data().toInt())); > +connect(group,

D26874: Use KStandardAction convenience method for switchApplicationLanguage

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on: D26873 REPOSITORY R263

D26873: KStandardAction: add method for SwitchApplicationLanguage action creation

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When SwitchApplicationLanguage was added to the enum StandardAction, a

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74241. apol added a comment. Address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74217=74241 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

apol marked 11 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is only used here, should only be exposed here. TEST PLAN Run unittests REPOSITORY R237 KConfig

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#599152 , @brauch wrote: > My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 14:12:28 + Build duration: 1 min 55 sec and counting JUnit Tests Name:

D26794: [WIP] Implement comment posting (and reenable voting)

leinir added a comment. Right, so because it is being brought up by people, i thought i should perhaps just do a touch of an explanation for the thought process that made me arrive at the current design for the NewCommentSheet component and its ability to chose whether or not you are

D26867: New class: KConfigTypeInformation

tcanabrava updated this revision to Diff 74231. tcanabrava added a comment. - Fix position of reference on parameter REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26867?vs=74224=74231 BRANCH rewrite_maps REVISION DETAIL

D26794: [WIP] Implement comment posting (and reenable voting)

leinir updated this revision to Diff 74230. leinir added a comment. - A better text for the "be the first" link (i'll try not dither too much) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26794?vs=74229=74230 BRANCH master REVISION DETAIL

D26794: [WIP] Implement comment posting (and reenable voting)

leinir updated this revision to Diff 74229. leinir edited the summary of this revision. leinir added a comment. - Clarify the "be the first" text a touch... REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26794?vs=74227=74229 BRANCH master REVISION

D26794: [WIP] Implement comment posting (and reenable voting)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

leinir updated this revision to Diff 74227. leinir added a comment. - Don't suggest making reviews if you're writing a reply comment - Don't pull up a comments model until we actually need it REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D26794: [WIP] Implement comment posting (and reenable voting)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

leinir updated this revision to Diff 74225. leinir added a comment. - Pull out the new comments sheet into a component - Use NewCommentSheet to let users create comments on entries without REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D26858: Provide an implementation for the tablet interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_tablet_interface.cpp:227 > +QCOMPARE(m_surfaces.count(), 3); > +for (SurfaceInterface* surface : m_surfaces) { > +

D26794: [WIP] Implement comment posting (and reenable voting)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26867: New class: KConfigTypeInformation

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This class handles transformations and queries for xml types to cpp types. Use KConfigTypeInformation to

D26848: Don't assume the manager and menu have the same lifetime

anthonyfieroni added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:191 > QActionGroup *group = new QActionGroup(menu); > -connect(group, ::triggered, this, [this](QAction * action) > { > -activateScheme(d->model->index(action->data().toInt())); > +

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 104 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/104/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 23 Jan 2020 12:23:47 + Build duration: 6 min 6 sec and counting BUILD ARTIFACTS

D26839: demote plugin load errors from warning to debug level + reword

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8353b9786c27: demote plugin load errors from warning to debug level + reword (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 151 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/151/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Jan 2020 12:23:47 + Build duration: 5 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/99/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 12:23:47 + Build duration: 2 min 26 sec and counting JUnit Tests Name:

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74217. apol added a comment. ehm.. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74214=74217 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

apol reopened this revision. apol added a comment. Phabricator chokes on git branches... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 11:21:13 + Build duration: 6 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 279 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/279/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 11:16:22 + Build duration: 7 min 50 sec and counting JUnit Tests Name:

D26858: Provide an implementation for the tablet interface

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:958cb1777b8d: Use K_DOXYGEN instead of deprecated DOXYGEN_SHOULD_SKIP_THIS (authored by kossebau). CHANGED PRIOR TO

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74213. apol added a comment. remove unrelated bits REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74212=74213 BRANCH apol/tablet-unstable-v2 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74212. apol added a comment. Addressed zzag's comments, fixed the patch overall. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74187=74212 BRANCH apol/tablet-unstable-v2 REVISION DETAIL

D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R264:c4a632ab65da: Define K_DOXYGEN as macro to check if kapidox/doxygen is run (authored by kossebau). CHANGED PRIOR TO

D26858: Provide an implementation for the tablet interface

apol marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/150/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Jan 2020 11:07:57 + Build duration: 4 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/103/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 23 Jan 2020 11:07:57 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/54/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 23 Jan 2020 11:06:52 + Build duration: 3 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Jan 2020 11:06:52 + Build duration: 3 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/98/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 11:07:57 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

D26794: [WIP] Implement comment posting (and reenable voting)

leinir updated this revision to Diff 74210. leinir added a comment. - Add editCredentials to the knscore provider interface - Implement edit credentials in the Attica provider - Add functionality to request a credentials editor from KNSCore::Engine - Add an invokable to the KNSQuick

D25015: Update breeze theme shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R242:35351ba3f299: Update breeze theme shadows (authored by niccolove, committed by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 149 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/149/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Jan 2020 10:18:31 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 102 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/102/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 23 Jan 2020 10:18:31 + Build duration: 4 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/97/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 23 Jan 2020 10:18:31 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

D26670: ki18n_wrap_ui: error when file doesn't exist

This revision was automatically updated to reflect the committed changes. Closed by commit R249:f56f3b211cf9: ki18n_wrap_ui: error when file doesnt exist (authored by davidre). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26670?vs=73793=74196 REVISION DETAIL

D26767: [KMessageWidget] Subtract the correct margin

broulik added inline comments. INLINE COMMENTS > kmessagewidget.cpp:214 >"border-radius: 4px;" >"border: 2px solid %2;" >"margin: %3px;" Maybe instead make the width an `int` variable and use it in

D26767: [KMessageWidget] Subtract the correct margin

This revision was automatically updated to reflect the committed changes. Closed by commit R236:2e2f06acac60: [KMessageWidget] Subtract the correct margin (authored by davidre). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26767?vs=73881=74195

D26858: Provide an implementation for the tablet interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_tablet_interface.cpp:2 > +/ > +Copyright 2014 Martin Gräßlin > + Haven't you written

D26801: Really fix the Windows backend for KNotifications

broulik added inline comments. INLINE COMMENTS > notifybysnore.cpp:89 > +KNotification *notification = m_notifications.value(id); > +if (notification == nullptr) { > qCDebug(LOG_KNOTIFICATIONS) << "Notification not found!"; `if (!notification) {` >

D26860: Readapt code to new kconfig code

mlaurent closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

mlaurent added a comment. Yep done :) REPOSITORY R237 KConfig BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26848: Don't assume the manager and menu have the same lifetime

broulik added a comment. lgtm REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

dfaure added a comment. Please make sure your commit log talks about \n and endl, not "Readapt code to new kconfig code". REPOSITORY R237 KConfig BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel,

D26860: Readapt code to new kconfig code

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns