D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella retitled this revision from "[scrollviewkcm] Respect header/footer visibility" to "[kcmcontrols] Respect header/footer visibility". REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, LeGast00

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [scrollviewkcm] Respect header/footer visibility

nicolasfella updated this revision to Diff 76136. nicolasfella added a comment. - Do same for GridViewKCM REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27562?vs=76135&id=76136 BRANCH rhv REVISION DETAIL https://phabricator.kde.org/D27562 AFFECT

D27562: [scrollviewkcm] Respect header/footer visibility

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Same as 1270e357a96f1e78281c0335b1bd05e5c9c3e3c6

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

dhaumann added a comment. Definitely a +1 for using a QIcon here. Still, I wonder whether we should postpone adding the MarkInterfaceV2 until the KF6 branch. Then we have it properly fixed in KF6. Or do you think we also need this in KF5 days to properly support e.g. hidpi ? REPOSIT

Re: Banning QNetworkAccessManager

On Thu, Feb 20, 2020 at 9:57 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Kra

D27557: Auto-generate 24px monochrome icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

ngraham added inline comments. INLINE COMMENTS > generate-24px-versions.sh:45 > +fi > +done comment to make this file visible for reviewers > CMakeLists.txt:26 > +endif() > + > gtk_update_icon_cache(${BREEZE_INSTALL_DIR}) comment to make the file visible for reviewers REPOSITORY R266 B

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde,

D27557: Auto-generate 24px monochrome icons

ngraham created this revision. ngraham added reviewers: VDG, ndavis, Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now we have 24px monochrome icons for compatibility with

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham added a revision: Unknown Object (Differential Revision). TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampalouk

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella added a comment. To apply the changes made in the web interface to your local commit you use `arc amend` I think. To upload new changes you do `arc diff --update D27528` > Once the diff is landed, it will be commited with the email address you set up in your KDE Identit

D27528: Adapt action numbering in Android to work like in KNotifications

jbbgameich added a comment. Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: jbbgamei

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauma

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau updated this revision to Diff 76127. kossebau added a comment. Switch to QIcon::paint, leaving all vodoo with devicePixelRatioF to QIcon logic Also results in better handling of pixmaps when they would be oversampled. Tested with QT_SCALE_FACTOR REPOSITORY R39 KTextEditor

D27552: Have kai the knotifications maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R289:224cc7382e63: Have kai the knotifications maintainer (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27552?vs=76121&id=76125 REVISION DET

D27552: Have kai the knotifications maintainer

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27552 To: apol, #frameworks, broulik, nicolasfella Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, mi

D27478: Add a --replace option to kded5

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R297:bb604f05b0bd: Add a --replace option to kded5 (authored by apol). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D27552: Have kai the knotifications maintainer

ngraham added a comment. +1 :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27552 To: apol, #frameworks, broulik Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

davidedmundson added a comment. This is a nice simple example of something with a version bump: https://phabricator.kde.org/D27535 for where to change registry. I was wrong about display, there is a number you need to change, but apparently it's on v9 already, so you don't need to do any

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. In D27464#614479 , @davidedmundson wrote: > Good start. The direction makes sense. > > display.cpp and registry.cpp need updating to the new version number. Otherwise we won't be able to use this new method. > > I

Re: Taking over KNotifications maintainership

https://phabricator.kde.org/D27552 On Mon, Feb 17, 2020 at 12:35 PM Aleix Pol wrote: > > > > El dl., 17 de febr. 2020, 12:19, Kai Uwe Broulik va > escriure: >> >> Hi all, >> >> I propose to make me the official maintainer of KNotifications given >> that's pretty much what I've been doing for qu

D27552: Have kai the knotifications maintainer

apol created this revision. apol added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY As discussed in the mailing list TEST PLAN :D REPOSITORY R289 KNotifications

D27550: Support Qt 5.14 on Android

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcatalog.cpp:121 > > +#ifdef Q_OS_ANDROID > +static QString androidUnpackCatalog(const QString &relpath) `#if defined(Q_OS_ANDROID) && QT_VERSION >= QT_VERSION_CHECK(5, 1

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

dfaure added a comment. kfileitemtest still passes? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

vkrause added a task: T12520: Qt 5.14. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27550 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY With Qt 5.14 asset files are no longer extracted into the filesystem, they are only available via assert: or qrc: URLs

D27350: Port away from Title and towards level 1 Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6b8f1142840f: Port away from Title and towards level 1 Heading (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27350?vs=755

D27350: Port away from Title and towards level 1 Heading

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port-away-from-title (branched from master) REVISION DETAIL https://phabricator.kde.org/D27350 To: ngraham, #plasma, davidedmundson Cc: kde-frameworks-

D25682: add initial wsdiscovery support

sitter added a comment. Yay. 1.9 is out. I've poked our CI maintainers about including kdsoap 1.9 and have high hopes at least suse is done by Monday. I am kinda leaning towards landing the diff on Monday regardless as I'd rather have this get more exposure sooner rather than later. REPOS

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615132 , @davidre wrote: > They stick around because as you said the settings differ from the defaults. Right, so "not a bug" (as in that's what's the patch is intended to do so far). > The pen for me

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615156 , @ngraham wrote: > Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would be nice to indicate how someone can test this. Which apps? System Settings? Where? How?

D27540: Status indicator for individual widgets in KCModule

ngraham added a comment. Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would be nice to indicate how someone can test this. Which apps? System Settings? Where? How? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D2

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

ngraham accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76106. meven added a comment. use QStringLitteral REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76088&id=76106 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES src/core/global

D27527: Add new `smiley-add` icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:4daac191fb33: Add new `smiley-add` icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27527?vs=76063&id=76105 REVISION DETAIL https

D27535: Add XdgOutputV1 version 2

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in xdgoutput_interface.cpp:319 > noob question: what would happen if you didn't have this check? If a client that only knew version1 connected and we sent this event, the client would raise a protocol error and quit. REPOSITORY

D27527: Add new `smiley-add` icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH smiley-add-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D27527 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, micha

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I've changed 417069 to CCBUG only, there's more to that issue than just the bogus fallback in this function. Diff LGTM, besides one minor comment about not keeping that QLatin1String.

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. In D27540#615129 , @ervin wrote: > In D27540#615105 , @davidre wrote: > > > In D27540#615092 , @ervin wrote: > > > > > In D275

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615105 , @davidre wrote: > In D27540#615092 , @ervin wrote: > > > In D27540#615061 , @davidre wrote: > > > > > How does

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

davidre added a reviewer: VDG. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. In D27540#615092 , @ervin wrote: > In D27540#615061 , @davidre wrote: > > > How does it look? Will this be opt in for other users of KConfigDialogManager? > > > I'd sa

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager) F8117874: grafik.png

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615091 , @davidre wrote: > The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615061 , @davidre wrote: > How does it look? Will this be opt in for other users of KConfigDialogManager? I'd say you should try it. ;-) I really need wider feedback on how it behaves in different contex

D27540: Status indicator for individual widgets in KCModule

ervin added inline comments. INLINE COMMENTS > meven wrote in kconfigdialogmanager_p.h:60 > I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets Not gonna rename those though, I'm merely moving code around (apart from indicatorWidget I could at least rename that one in

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/61/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 21 Feb 2020 11:55:10 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 21 Feb 2020 11:55:10 + Build duration: 5 min 38 sec and counting JUnit Tests Name: proje

D27538: Registry: don't destroy the callback on globalsync

This revision was automatically updated to reflect the committed changes. Closed by commit R127:4ceb35672dfa: Registry: don't destroy the callback on globalsync (authored by dvratil). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27538?vs=76084&id=76097 REV

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added reviewers: KNewStuff, Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27544 To: leinir, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The old downloadwidget's update system would explicitly require a user to pick which download item to use for updating i

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. How does it look? Will this be opt in for other users of KConfigDialogManager? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport Cc: davidre, kde-frameworks-devel, LeGast00n,

D21795: [KAuth] Add support for action details in Polkit1 backend.

sitter added a comment. LGTM. I do wonder if the new deprecation annotations should be used for the the deprecation though: https://api.kde.org/ecm/module/ECMGenerateExportHeader.html REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, d

D27540: Status indicator for individual widgets in KCModule

meven added inline comments. INLINE COMMENTS > kconfigdialogmanager_p.h:60 > +QHash buddyWidget; > +QHash indicatorWidget; > +QSet allExclusiveGroupBoxes; I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets > settingsstatusindicator_p.h:41 > +bool isDe

D27540: Status indicator for individual widgets in KCModule

ervin created this revision. ervin added reviewers: ngraham, davidedmundson, meven, crossi, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Extend KConfigDialogManager internals to insert a smal

D27538: Registry: don't destroy the callback on globalsync

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27538 To: dvratil, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, micha

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven added reviewers: dfaure, broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76088. meven added a comment. Clean code further REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76087&id=76088 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES src/core/global.

D27528: Adapt action numbering in Android to work like in KNotifications

cacahueto added a comment. I added a summary here. I also wanted to fix it directly in the commit. Besides, I didn't set the committer e-mail address correctly, so I'd like to fix that as well. How can I edit the commit with `arc`? Or can I just `git commit --amend` and push? REPOSITO

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76087. meven added a comment. Simplify REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76086&id=76087 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES src/core/global.cpp To: m

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417922 BUG: 417921 BUG: 417069 FIXED-IN: 5.68 REPOSITORY R241 KIO

D27528: Adapt action numbering in Android to work like in KNotifications

cacahueto edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

dvratil edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27538 To: dvratil, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

dvratil created this revision. dvratil added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY Instead just unref it, because the wl_display_dispatch_queue_pending will try to destr

D27535: Add XdgOutputV1 version 2

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27535 To: davidedmundson, #kwin, zzag Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns