D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kfontchooserdialog.cpp:97
> +{
> +KFontChooserDialog dlg(flags | KFontChooser::ShowDifferences, parent);
> +dlg.setObjectName(QStringLiteral("Font Selector"));

Is having dialog objects on the stack a good idea?

What if the application gets closed while the dialog is open, would that not 
crash?

At least at some point people thought it was not a good idea, see 
https://blogs.kde.org/node/3919

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78266.
ahmadsamir added a reviewer: dfaure.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28193?vs=78192=78266

BRANCH
  l-kfontchooser-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28193

AFFECTED FILES
  src/kfontchooser.cpp

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78265.
ahmadsamir added a reviewer: dfaure.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78190=78265

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> global.h:320
> + */
> +enum StatDetail {
> +/// No field returned, useful to check if a file exists

This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the 
KIO namespace, with no futher hint that these belong to this very enum, 
resulting in potential wrong usages (due to completion-based coding when being 
convertable to int) or in potential conflicts with other future additions.

Sadly no time to follow the review. Had this been discussed before? Ideally 
those flags would get more explicit names, like `BasicDetail` (hm, what is 
basic actually), `UserDetail`, etc.

Could not find naming recommendations for current Qt, but here some old one, 
scroll to the section "Naming Enum Types and Values": 
https://doc.qt.io/archives/qq/qq13-apis.html#theartofnaming

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27811: [KConfigGui] Check font weight when clearing styleName property

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:ec9522ae73ff: [KConfigGui] Check font weight when 
clearing styleName property (authored by ahmadsamir).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27811?vs=76875=78264

REVISION DETAIL
  https://phabricator.kde.org/D27811

AFFECTED FILES
  src/gui/kconfiggroupgui.cpp

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
ahmadsamir marked 2 inline comments as done.
Closed by commit R236:2e9cace39272: Copy KFontDialog from KDELibs4Support to 
KWidgetAddons, now KFontChooserDialog (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28122?vs=78251=78263

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontchooserdialog.png
  src/CMakeLists.txt
  src/kfontchooserdialog.cpp
  src/kfontchooserdialog.h
  tests/CMakeLists.txt
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[Nathaniel Graham]

ngraham added a reviewer: ndavis.
ngraham added a comment.


  Fantastic work! JFYI some of these icons have monochrome 32px versions that 
would need the same treatment for consistency's sake, or else the style changes 
with size: F8193984: Screenshot_20200322_214946.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a task: T12806: Move corner fold to the top-right for all 
document icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:25 +
 Build duration:
6 hr 58 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Faure]

dfaure added a comment.


  (technically, connecting to ::result is missing in the dolphin port, but 
unlike ProcessLauncherJob, CommandLauncherJob is very unlikely to fail. 
QProcess will only fail to start if we're out of resources for forking or if 
`sh` can't be executed... we don't detect bad shell commands, that happens 
after QProcess::start(). I wonder if it's worth connecting to the result signal 
of a CommandLauncherJob)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:26 +
 Build duration:
6 hr 55 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:27 +
 Build duration:
6 hr 56 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » kjs » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:26 +
 Build duration:
6 hr 54 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:24 +
 Build duration:
6 hr 53 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » knotifyconfig » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:24 +
 Build duration:
6 hr 52 min and counting

KDE CI: Frameworks » kdnssd » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdnssd/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:25 +
 Build duration:
6 hr 53 min and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:24 +
 Build duration:
6 hr 53 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kglobalaccel » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:22 +
 Build duration:
6 hr 53 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:22 +
 Build duration:
6 hr 52 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:21 +
 Build duration:
6 hr 52 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kidletime » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kidletime/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:22 +
 Build duration:
6 hr 52 min and counting

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:21 +
 Build duration:
6 hr 51 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:20 +
 Build duration:
6 hr 51 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kmediaplayer » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:19 +
 Build duration:
6 hr 50 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:20 +
 Build duration:
6 hr 50 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:16 +
 Build duration:
6 hr 50 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:19 +
 Build duration:
6 hr 50 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:55 +
 Build duration:
6 hr 50 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 487 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.RecursOn_ConnectDaily2.icsFailed: projectroot.autotests.RecursOn_ConnectDaily3.icsFailed: projectroot.autotests.RecursOn_ConnectDaily6.icsFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kinit » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:16 +
 Build duration:
6 hr 49 min and counting

KDE CI: Frameworks » kparts » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:15 +
 Build duration:
6 hr 48 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:15 +
 Build duration:
6 hr 48 min and counting

KDE CI: Frameworks » kcompletion » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:14 +
 Build duration:
6 hr 47 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:14 +
 Build duration:
6 hr 47 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.usr.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kholidays » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:14 +
 Build duration:
6 hr 46 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:14 +
 Build duration:
6 hr 46 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:13 +
 Build duration:
6 hr 45 min and counting

KDE CI: Frameworks » frameworkintegration » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:13 +
 Build duration:
6 hr 45 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kactivities » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kactivities/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:12 +
 Build duration:
6 hr 45 min and counting

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:12 +
 Build duration:
6 hr 44 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

KDE CI: Frameworks » kwallet » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:12 +
 Build duration:
6 hr 44 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdbusaddons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:11 +
 Build duration:
6 hr 43 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kcmutils » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:11 +
 Build duration:
6 hr 43 min and counting

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:09 +
 Build duration:
6 hr 42 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:10 +
 Build duration:
6 hr 42 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Frameworks » kplotting » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:10 +
 Build duration:
6 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:08 +
 Build duration:
6 hr 38 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:08 +
 Build duration:
6 hr 37 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:08 +
 Build duration:
6 hr 36 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kguiaddons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:08 +
 Build duration:
6 hr 36 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:05 +
 Build duration:
6 hr 35 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » syndication » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:06 +
 Build duration:
6 hr 35 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:04 +
 Build duration:
6 hr 35 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:04 +
 Build duration:
6 hr 34 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » khtml » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:03 +
 Build duration:
6 hr 34 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kdoctools » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:02 +
 Build duration:
6 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:02 +
 Build duration:
6 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)

KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:00 +
 Build duration:
6 hr 31 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kauth » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:00 +
 Build duration:
6 hr 30 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » threadweaver » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:59 +
 Build duration:
6 hr 30 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kdesignerplugin » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdesignerplugin/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:05:00 +
 Build duration:
6 hr 30 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:59 +
 Build duration:
6 hr 29 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kitemviews » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:59 +
 Build duration:
6 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kjobwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:59 +
 Build duration:
6 hr 27 min and counting

KDE CI: Frameworks » ki18n » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:59 +
 Build duration:
6 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kjsembed » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:58 +
 Build duration:
6 hr 27 min and counting

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:58 +
 Build duration:
6 hr 27 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:58 +
 Build duration:
6 hr 26 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:56 +
 Build duration:
6 hr 25 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:58 +
 Build duration:
6 hr 24 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)

D28200: Enable wrapping of error messages which use KMessageWidget

[Nathaniel Graham]

ngraham added a comment.


  In D28200#632622 , @davidedmundson 
wrote:
  
  > > I wonder if it makes sense to set this on the widget itself, as a 
sensible default.
  >
  > No.
  >
  > Not because it's a better or worse default, but because making a 
behavioural change in released public API would retroactively break any few 
places where we didn't want to word wrap.
  >
  > No code adds
  >
  > > setFoo(theDocumentedDefaultValue)
  
  
  Gotcha. Would that be something we can revisit for KF6?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:57 +
 Build duration:
6 hr 22 min and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » attica » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:57 +
 Build duration:
6 hr 21 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kemoticons » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:56 +
 Build duration:
6 hr 20 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kiconthemes » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:56 +
 Build duration:
6 hr 20 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » prison » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 19 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 19 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 18 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:54 +
 Build duration:
6 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D28200: Enable wrapping of error messages which use KMessageWidget

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > I wonder if it makes sense to set this on the widget itself, as a sensible 
default.
  
  No.
  
  Not because it's a better or worse default, but because making a behavioural 
change in released public API would retroactively break any few places where we 
didn't want to word wrap.
  
  No code adds
  
  > setFoo(theDocumentedDefaultValue)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » karchive » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:53 +
 Build duration:
6 hr 16 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kactivities-stats » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kactivities-stats/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:53 +
 Build duration:
6 hr 16 min and counting

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:53 +
 Build duration:
6 hr 16 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:52 +
 Build duration:
6 hr 15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:52 +
 Build duration:
6 hr 15 min and counting

KDE CI: Frameworks » kross » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kross/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:52 +
 Build duration:
6 hr 15 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kded » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:52 +
 Build duration:
6 hr 14 min and counting

D25660: Decouple KBookmarksMenu from KActionCollection

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Oops I forgot to review this again after your last changes.
  
  Looks fine to me now, but meanwhile it needs s/5.67/5.69/ everywhere (docu 
and deprecation macros).
  Feel free to land if you check that there's no 67 anywhere in the diff.

REPOSITORY
  R294 KBookmarks

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.14/1/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 22 Mar 2020 16:04:52 +
 Build duration:
6 hr 12 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D28200: Enable wrapping of error messages which use KMessageWidget

[Nathaniel Graham]

ngraham added reviewers: Plasma, Frameworks.
ngraham added a comment.


  Thanks for the patch! I wonder if it makes sense to set this on the widget 
itself, as a sensible default. You're probably going to want to word-wrap more 
often than you aren't.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:86832ca00e7b: KAbstractFileItemActionPlugin: Add missing 
quotes in code example (authored by alex).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27591?vs=76203=78255

REVISION DETAIL
  https://phabricator.kde.org/D27591

AFFECTED FILES
  src/widgets/kabstractfileitemactionplugin.h

To: alex, elvisangelaccio, #frameworks, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

[Ahmad Samir]

ahmadsamir added a comment.


  In D28184#632547 , @dfaure wrote:
  
  > In D28184#632459 , @ahmadsamir 
wrote:
  >
  > > It was failing locally for me too, both when I had /tmp as tmpfs and when 
I changed it to be a regular dir on /; /home is a separate partition on my 
system. So I didn't understand how the test passed on the CI.
  >
  >
  > Because on the CI (which is a LXC container), /home isn't a separate 
partition.
  >
  > So the tests for "moving between different partitions" are actually testing 
(again) moving on the same partition, on CI, because there is just one 
partition.
  >
  > > FTR, I build KIO on a regular mechanical/spinning HDD, but / and /home 
are on an SSD. Maybe that's why? the test wants two separate partitions on the 
same desk? that doesn't make sense though...
  >
  > Not sure what you mean by desk, but I hope the above explains the reason 
why the test was passing on CI and failing for most of us locally.
  
  
  Oops, I meant disk.
  
  That makes sense; most of us would have /home on a separate partition.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28184

To: dfaure, meven, apol
Cc: ahmadsamir, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Ahmad Samir]

ahmadsamir marked 3 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooserdialog.h:81
> Do @param need to be in order of the arguments? (I'm not sure)

They should be, it's more logical.

> dfaure wrote in kfontchooserdialog.h:89
> Good call. I can't think of any use case for this.
> 
> Maybe choosing an emoji font? But then how to know which of the installed 
> fonts qualify... Yeah let's wait until there's actually a use case, if ever.

emoji fonts... that would need a whole rewrite in a lot of places, starting at 
QFontDatabase, so we'd have isSmoothlyScalable and isEmojiScalable, and maybe 
isEmojiMonospace, just kidding.

(what's wrong with ":D" ":)" ";)" ":(" "\o/"? all fonts support them, and they 
look cool :D).

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78251.
ahmadsamir added a comment.


  @param should have the same order as the in the ctor declaration (patterns 
make life slightly easier)

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28122?vs=78249=78251

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontchooserdialog.png
  src/CMakeLists.txt
  src/kfontchooserdialog.cpp
  src/kfontchooserdialog.h
  tests/CMakeLists.txt
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28206: Port QList/QSet deprecated methods

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:37686fd70359: Port QList/QSet deprecated methods 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28206?vs=78239=78250

REVISION DETAIL
  https://phabricator.kde.org/D28206

AFFECTED FILES
  src/core/scheduler_p.h
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/urifilters/ikws/ikwsopts.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 291 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/291/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 22 Mar 2020 20:07:07 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/305)60%
(110/184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)80%
(199/250)60%
(100/166)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 184 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/184/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 22 Mar 2020 20:07:07 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/305)60%
(110/184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)80%
(199/250)60%
(100/166)