D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Méven Car]

meven added a comment.


  In D27951#641207 , @trmdi wrote:
  
  > In D27951#641173 , @meven wrote:
  >
  > > In D27951#639386 , @trmdi 
wrote:
  > >
  > > > In D27951#639350 , @meven 
wrote:
  > > >
  > > > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect 
ioslave, including the stat call made in `KIO::StatJob`.
  > > > >  It is in the kdeconnect code base, the issue you point to is there.
  > > >
  > > >
  > > > Thanks, got it. Then could we simply use KMountPoint instead of 
UDS_Device_ID ? KMountPoint seems more reliable.
  > >
  > >
  > > But KMountPoint induces more cost (it makes a syscall and a bunch of 
parsing).
  > >  So instead I would recommend fixing the issue in kdeconnect (and 
potentially other ioslave) as it will fix things here and elsewhere potentially 
too.
  > >
  > > Also `local = url.isLocalFile` should return false for kdeconnect in the 
first place.
  > >  So I belive you can avoid using KMountPoint at all and use only stat.
  >
  >
  > No, kde connect files have local urls.
  
  
  I thought their file scheme would be kdeconnect. They would be on a fuse 
mount, either way it is detectable.
  
  > Fixing every ioslave is too difficult. 
  >  So I should drop this idea.
  
  It does not rest on your shoulder only, fear not.
  I did not expect you to do all of this, but this could be a very shorltist as 
we don't that many writable filesystem-like ioslave that will need actual 
fixing.
  I meant this is not your concern for this patch.
  
  This is a nice feature some of our users will appreciate.
  
  So I would encourage you to reconsider abandoning this work.
  
  I might take over to finish it eventually.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  Working on solid : D28590 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28271: [KFontChooser] More code cleanup

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28271

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

[Nathaniel Graham]

ngraham added a comment.


  In D26113#642053 , @meven wrote:
  
  > I should go ahead with it in solid and loop back here once it is done.
  
  
  Yeah, that makes sense to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham added a comment.


  The outstanding security issues have been resolved (see T8075 
). We have requested a re-review from the 
SUSE security team, but have not received it yet. Given that the original 
schedule for this feature has already slipped by almost two years, I would like 
to propose that we land this patch and turn it on, and resolve any 
newly-discovered issues in follow-up work.
  
  Any objections?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: chinmoyr, #frameworks, dfaure
Cc: feverfew, mreeves, mati865, ngraham, elvisangelaccio

D28712: Redo api.kde.org to look more like Aether

[Olivier Churlaud]

ochurlaud added a comment.


  In D28712#645095 , @ognarb wrote:
  
  > Not tested yet but I like the style :) Though to be more consistent with 
the style used in other KDE websites, I would change the background color to 
#fff and use #f8f9fa for the sidebar.
  >
  > I also saw some alignment issues with the method args:
  >
  > F8227657: image.png 
  >
  > I will give a more in-depth review tomorrow.
  
  
  The issues already exist in the current design. I would do a second change 
request for fixing those issues (there are more if you browse a little in 
complex methods) and already push this cosmetic only patch.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28372: Remove rounded borders to plasmoidHeading

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma, ngraham
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28712: Redo api.kde.org to look more like Aether

[Olivier Churlaud]

ochurlaud accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Olivier Churlaud]

ochurlaud added a comment.


  Nice work. This is a ship it for me!

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Nathaniel Graham]

ngraham added a comment.


  Dang that looks way nicer.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove updated this revision to Diff 79740.
niccolove added a comment.


  Removed merged look, no longer needed, but kept rounded corners change

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78742&id=79740

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28372: Remove rounded borders to plasmoidHeading

[Niccolò Venerandi]

niccolove retitled this revision from "Added a merged look to the 
plasmoidheading and remove roundedborders" to "Remove rounded borders to 
plasmoidHeading".
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb added a comment.


  Not tested yet but I like the style :) Though to be more consistent with the 
style used in other KDE websites, I would change the background color to #fff 
and use #f8f9fa for the sidebar.
  
  I also saw some alignment issues with the method args:
  
  F8227657: image.png 
  
  I will give a more in-depth review tomorrow.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb added a reviewer: ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, ognarb.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  F8227629: image.png  F8227630: 
image.png  F8227631: image.png 

  
  F8227633: _home_cdblack_workdir_kirigamidocs_build_index.html(Pixel 2 XL) 
(1).png  F8227634: 
_home_cdblack_workdir_kirigamidocs_build_kwindowsystem_html_classKWindowSystem.html(Pixel
 2 XL).png 

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  How about committedBatch so that it's clear that they have been committed to 
the database?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir added a comment.


  hmm... first this is a copy-paste "error" on my part, I personally never use 
& when the RHS is a temporary (I don't see the point).
  
  Anyway; looking at statResult():
  const UDSEntry &StatJob::statResult() const
  {
  
return d_func()->m_statResult;
  
  }
  
  it is returning a const &, and the docs say:
  
  > Call this in the slot connected to result, and only after making sure no 
error happened.
  
  here we used job->exec(), it may finish and get deleted; KJob docs say:
  
  > KJob and its subclasses are meant to be used in a fire-and-forget way. Jobs 
will delete themselves when they finish using deleteLater() (although this 
behaviour can be changed), so a job instance will disappear after the next 
event loop run.
  
  The test never failed before for me; but it seems I can trigger a SIGSEGV by 
running the test many times in a row; it's my "educated guess", sort of 
confirmed by using job->setAutoDelete(false), that the job may finish and get 
deleted by the time we call entry.numberValue() on line 1534.
  
  So, to use job->statResult() to initialize a var &, that has to happen from a 
slot connected to result(); but if we call job->exec(), then later on we want 
to use the UDSEntry then we can't use var &, but rather take a copy.
  
  And maybe statResult() shouldn't return a reference (or a const reference for 
that matter, because if the caller uses 'entry = job->statResult()'
  then statResult() returning a const & doesn't make any difference if it's 
copied...).
  
  @dfaure, WDYT?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

kossebau added a comment.


  When it comes to Zoom, I would only expect it adapts to Global zoom settings 
again only once if I have reset my manual zooming to Default again.
  
  Though. seems Zoom is not covered by that config setting object... please not 
the "not" in "are not yet covered" in my first comment :)
  
  So, time to push now? Bit unsure how to take your last comments.

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28701: [WIP] Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added reviewers: Plasma, KNewStuff, Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added a comment.


  Okay thanks, can you update the test plan then? Also I think the diff 
currently does not actually fix 418466.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

T8349: Improve Places panel usability and presentation

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, 
manueljlin, iasensio, Orage, fprice, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
Codezela, feverfew, trickyricky26, meven, crozbo, spoorun, ndavis, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, rdieter, mikesomov, 
aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, 
manueljlin, iasensio, Orage, fprice, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
Codezela, feverfew, trickyricky26, meven, crozbo, spoorun, ndavis, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, rdieter, mikesomov, 
aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, 
manueljlin, iasensio, Orage, fprice, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
Codezela, feverfew, trickyricky26, meven, crozbo, spoorun, ndavis, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, rdieter, mikesomov, 
aaronhoneycutt, mbohlender

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D28701#644943 , @ngraham wrote:
  
  > Am I not testing properly?
  
  
  Correct, that's the bit where i've not added instructions as required for 
switching to using the kpackage support. Short version, comment out the 
uninstall and install commands, and add an Uncompress=kpackage line, in the 
lookandfeel.knsrc file :) (also considering perhaps doing some smart lookup 
type stuff, and switching things which call kpackagetool automatically to using 
this, but also am not entirely certain if there might not be some fallout from 
that... not sure, will need to look at that)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added a comment.


  Even with this patch, every attempt to uninstall a newly-installed global 
theme still fails with:
  
The uninstallation process failed to successfully run the command 
kpackagetool5 -t Plasma/LookAndFeel -r 
/tmp/01-com.github.vinceliuice.McMojave.tar.xz
  
  And every attempt to uninstall an already-installed global theme fails with:
  
The uninstallation process failed to successfully run the command 
kpackagetool5 -t Plasma/LookAndFeel -r /tmp/Sweet.tar.xz
  
  And every attempt to install an already-secretly-installed global theme fails 
with:
  
Error: Installation of /tmp/Sweet.tar.xz failed: 
/home/nate/.local/share/plasma/look-and-feel/Sweet already exists
  
  And clicking on the install/uninstall button still incorrectly changes the 
button to its other state despire the global theme not being correctly 
installed or uninstalled.
  
  Am I not testing properly?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28682: export done signal in filecontentindexer

[Stefan Brüns]

bruns added a comment.


  Regarding API, `done` is a little bit vague.
  
  Can you rename it to `finishedBatch` (or come up with a better name).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Stefan Brüns]

bruns added a comment.


  In D28682#644914 , @astippich 
wrote:
  
  > Then it's fine from my application point of view. I can add a corresponding 
start signal for convenience, though. Your call.
  
  
  Lets keep the API as small as possible ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  Then it's fine from my application point of view. I can add a corresponding 
start signal for convenience, though. Your call.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28499: [LauncherJobs] Emit description

[Nathaniel Graham]

ngraham added a comment.


  Seems sensible and sane to me. +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28673: [PackageUrlInterceptor] Make QRegularExpression static

[Stefan Brüns]

bruns added a comment.


  In D28673#644778 , @broulik wrote:
  
  > Yeah, can probably be a `startsWith`
  
  
  unlikely for `QUrl::toString()` ...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: broulik, #plasma
Cc: bruns, pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 09 Apr 2020 13:13:51 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D26016: [KeySequenceHelper] Work around Meta modifier behavior

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:4306fb8f4e19: [KeySequenceHelper] Work around Meta 
modifier behavior (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26016?vs=71596&id=79709

REVISION DETAIL
  https://phabricator.kde.org/D26016

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta 
modifier behavior (authored by broulik).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26017?vs=71597&id=79708

REVISION DETAIL
  https://phabricator.kde.org/D26017

AFFECTED FILES
  src/kkeysequencewidget.cpp

To: broulik, #frameworks, davidedmundson, ahartmetz
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 79704.
leinir added a comment.


  - Remove a stray newline

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=79703&id=79704

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/installation.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Adding support for KPackage directly to KNewStuff means that we are
  able to deal more gracefully with things like Plasma's Global Themes
  (and indeed any other kpackage based thing).
  
  This is done by adding another archive specialisation to the installer
  class, and by also adding a check to the cache to ensure that even
  when a kpackage is removed from the system outside of KNewStuff,
  it does not remain seemingly installed in the KNS lists.
  
  - Make sure the cache gets written
  - Add KPackage support to KNSCore::Installation
  
  BUG:418466

REPOSITORY
  R304 KNewStuff

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/installation.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28499: [LauncherJobs] Emit description

[Kai Uwe Broulik]

broulik updated this revision to Diff 79700.
broulik added a comment.


  - Drop ellipsis

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28499?vs=79105&id=79700

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven added a comment.


  The test is not stable (I reproduce locally)
  
  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/34/testReport/junit/projectroot/autotests/kiocore_jobtest/
  
==7022==ERROR: AddressSanitizer: heap-use-after-free on address 
0x61099be8 at pc 0x7f09559df9ed bp 0x7fff81ec0fe0 sp 0x7fff81ec0fd8
READ of size 8 at 0x61099be8 thread T0
#0 0x7f09559df9ec in 
QSharedDataPointer::operator->() const 
/usr/include/qt5/QtCore/qshareddata.h:82
#1 0x7f09559d499a in KIO::UDSEntry::numberValue(unsigned int, long 
long) const /home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.14/src/core/udsentry.cpp:368
#2 0x455940 in JobTest::statWithInode() 
/home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.14/autotests/jobtest.cpp:1534
  
  Replacing line 1517
  
const KIO::UDSEntry &entry = job->statResult();
  
  by
  
const KIO::UDSEntry entry = job->statResult();
  
  Fixes the issue, but I don't exactly see why.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:524bdc640dcc: [KNotificationJobUiDelegate] Append 
"Failed" for error messages (authored by broulik).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28531?vs=79190&id=79699

REVISION DETAIL
  https://phabricator.kde.org/D28531

AFFECTED FILES
  src/knotificationjobuidelegate.cpp

To: broulik, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28673: [PackageUrlInterceptor] Make QRegularExpression static

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Yeah, can probably be a `startsWith`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: broulik, #plasma
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28669: make CopyJob non-recursive

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:814
> Right. If this loop can really block the main thread for a substantial amount 
> of time, then it should have a condition like "after 100 symlinks, schedule 
> coming back here (e.g. QTimer singleshot) and `return;` for now".

So if `m_currentStatSrc` does not point to `m_srcList` end it should add timer 
event to queue returning back here in next queue iteration.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28669: make CopyJob non-recursive

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in copyjob.cpp:814
> > Which threads? There are no threads involved here.
> 
> Yes, i'm afraid of loop that can block the event queue, !isKilled will not 
> work in single thread environment.

Right. If this loop can really block the main thread for a substantial amount 
of time, then it should have a condition like "after 100 symlinks, schedule 
coming back here (e.g. QTimer singleshot) and `return;` for now".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28699: Add startCapture method

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  startCpature (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28699

To: davidre, #frameworks, davidedmundson, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28669: make CopyJob non-recursive

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:814
> Which threads? There are no threads involved here.
> 
> There is no need to handling killing here. It wasn't any different in the 
> orig code with the recursion.
> As soon as we find actual work to do, we'll go and launch a subjob, at which 
> point we go back to the event loop and can handle being killed.

> Which threads? There are no threads involved here.

Yes, i'm afraid of loop that can block the event queue, !isKilled will not work 
in single thread environment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28699: Add startCapture method

[David Redondo]

davidre created this revision.
davidre added reviewers: Frameworks, davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Starts capturing as if the user clicked on the main button. Useful if one
  wants to start capturing upon other user input than clicking on the item.

TEST PLAN
  Call the method

REPOSITORY
  R296 KDeclarative

BRANCH
  startCpature (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28699

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: davidre, #frameworks, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28669: make CopyJob non-recursive

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in copyjob.cpp:915
> When reaching here the `while (m_currentStatSrc != m_srcList.constEnd()) {` 
> means we have nothing left to stat, meaning stating phase is indeed finished.

Not if we just launched subjobs and we haven't gotten the signal that they are 
finished.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28669: make CopyJob non-recursive

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:915
> This makes no sense to me. We are finished when the previous phase is 
> actually finished.

When reaching here the `while (m_currentStatSrc != m_srcList.constEnd()) {` 
means we have nothing left to stat, meaning stating phase is indeed finished.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28669: make CopyJob non-recursive

[Méven Car]

meven added a comment.


  Currently the code does not handle the other call paths to `statNextSrc()` 
that would need to be adapted as well. We will need to call `statCurrentSrc()` 
after `statNextSrc()` basically there.
  In slotResultRenaming and slotResult.
  Currently, those code path would cause the finish the copy prematurely.
  
  The tests currently don't pass, they just hang.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:809
> Why did you remove this call?
> 
> Your patch has no context (please use `arc` to upload patches to 
> phabricator), but I can see here that this is in the CopyJobPrivate::skipSrc 
> method. Did you test skipping files? This isn't mentioned in your test plan.
> 
> Does the unittest jobtest still pass?

This is in `statNextSrc()`
This is the main point of recursion, so it this where this needs to change to 
break the recursion in coherence with the `continue`s added in 
`CopyJobPrivate::statCurrentSrc`

> copyjob.cpp:849
>  files.append(info);   // Files and any symlinks
>  statNextSrc(); // we could use a loop instead of a recursive 
> call :)
> +continue;

Remove comment

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/4/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 09 Apr 2020 09:30:26 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28697: Also relase the window in the destructor

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:6c5619ffebae: Also relase the window in the destructor 
(authored by davidre).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28697?vs=79688&id=79690

REVISION DETAIL
  https://phabricator.kde.org/D28697

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: davidre, broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28697: Also relase the window in the destructor

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  release (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28697

To: davidre, broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28697: Also relase the window in the destructor

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise the keyboard is never released when the item is destroyed while
  capturing is active

REPOSITORY
  R296 KDeclarative

BRANCH
  release (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28697

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: davidre, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns