D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

[Tobias Junghans]

junghans created this revision.
junghans added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
junghans requested review of this revision.

REVISION SUMMARY
  QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of `emit` should be 
replaced by `Q_EMIT`.

TEST PLAN
  Build with QT_NO_KEYWORDS define enabled and observe succesful build.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

AFFECTED FILES
  CMakeLists.txt
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  src/core/kcheckableproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kdescendantsproxymodel.cpp
  src/core/kextracolumnsproxymodel.cpp
  src/core/kselectionproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/lessthanwidget.cpp

To: junghans, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Felix Riiga]

riiga added a comment.


  The units added in 5.53 were pint (imperial) and gallon (US). The units in 
the bug report and added by me now are pint (US) and gallon (imperial).

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D27220: add pix icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  pix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27220

To: mbruchert, camiloh, #vdg, ndavis
Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80607.
xuetianweng added a comment.


  Fix the blank text issue by alway setLineWidth.
  
  For QTextLine, the layout information is not filled until certain function is 
called.
  If dynamic wrap is not enabled, the line width is -1 so at the point we do 
the calculation,
  we will have no size information of the text. Use INT_MAX to set the 
lineWidth as workaround.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=80606&id=80607

BRANCH
  arcpatch-D25339

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 20 Apr 2020 00:50:05 +
 Build duration:
42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80606.
xuetianweng added a comment.


  Clean up the code a little bit and adding comments. Also fix a small bug if 
m_fontHeight has 
  big difference with m_fontMetrics's height.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=80444&id=80606

BRANCH
  arcpatch-D25339

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 62 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/62/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 20 Apr 2020 00:38:15 +
 Build duration:
5 min 26 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34956/62173)40%
(17739/43936)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9815/10282)46%
(4582/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8499/14317)51%
(4462/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(425/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80605.
apol added a comment.


  oops

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80604&id=80605

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80604.
apol added a comment.


  Include server side, a test (that doesn't pass) and some renaming

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80411&id=80604

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Stefan Brüns]

bruns added a comment.


  In D28980#652102 , @mgallien wrote:
  
  > To be clear, I am fine with this change going in.
  >
  > I would still like to work on a proper solution to allow an application to 
monitor moved files or similar stuff without having to add file system watchers 
itself (duplicate from Baloo owns watchers).
  >
  > Do you have an idea ?
  
  
  Elisa would need to register something like a "persistent query". This is 
something also dolphin needs - there definitely already is some notification 
between dolphin/baloo, but that is not working properly.
  
  This could be something like "Audio files in ~/Music/", "Audio files in 
~/Audio books/", etc., and you get a signal whenever the query would return a 
different result.

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Stefan Brüns]

bruns added a comment.


  In D28980#652087 , @mgallien wrote:
  
  > The unusual method to get notified is about avoiding signaling moved files 
if nobody is watching. Baloo will only callback if applications have registered 
themselves.
  
  
  Registering for (expensive) notifications is fine, the 
org.kde.baloo.fileindexer interface is doing it as well the awkward part is
  a) using a method call instead of a signal
  b) registering an interface to be called, instead of just a service name

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks very much for the patch, but that bug report is very old and these 
units of measurement were already added in 5.53 as `GallonUS` and 
`PintImperial`. I'm sorry the the bug report wasn't correctly closed after 
those units were added (I have just done so). You did a great job here though. 
Would you care to work on a different unit conversion bug report? Here are a 
few: 
https://bugs.kde.org/buglist.cgi?component=general&list_id=1736763&product=frameworks-kunitconversion&resolution=---

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Friedrich W. H. Kossebau]

Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley:
> Hi all,
> 
> Another breakage in Qt?

Should be fixed now (restarted build now completed), with similar traps also 
removed for the future, thanks to David Faure for the work done and Ade for 
the root detecting investigations.

Seems Qt changed for Qt 5.14.1 -> 5.14.2 some wrappers around QSet-related API 
from
#if QT_VERSION < QT_VERSION_CHECK(6,0,0)
to
#if QT_DEPRECATED_SINCE(5, 14) && QT_VERSION < QT_VERSION_CHECK(6,0,0)
and by that stronger rules some projects no longer saw code they saw before, 
thus had started to fail.

Cheers
Friedrich

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28995: Add imperial gallon and US pint

[Felix Riiga]

riiga created this revision.
riiga added a reviewer: Frameworks.
riiga added a project: Frameworks.
riiga requested review of this revision.

REVISION SUMMARY
  Adds imperial gallon and US pint as requested in a bug report.
  
  BUG: 341072

TEST PLAN
  I haven't figured out how to test the changes, so any directions are welcome. 
I've tried LD_PRELOAD with the compiled library when launching KRunner to no 
avail.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

AFFECTED FILES
  src/fuel_efficiency.cpp
  src/unit.h
  src/volume.cpp

To: riiga, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  To be clear, I am fine with this change going in.
  
  I would still like to work on a proper solution to allow an application to 
monitor moved files or similar stuff without having to add file system watchers 
itself (duplicate from Baloo owns watchers).
  
  Do you have an idea ?

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Matthieu Gallien]

mgallien added a comment.


  The unusual method to get notified is about avoiding signaling moved files if 
nobody is watching. Baloo will only callback if applications have registered 
themselves.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Matthieu Gallien]

mgallien added a comment.


  Sorry for the lack of time to do a proper review.
  
  I will need to have a thorough look at what Elisa is currently doing and what 
is working (or not).
  
  Is there another working way to get information about files that have moved 
without having an application monitor them itself ?
  
  If I remember correctly, Baloo is not providing information about that even 
though it is monitoring it. Is this still the case ?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Ben Cooksley]

Hi all,

Another breakage in Qt?

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Sun, Apr 19, 2020 at 11:44 PM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
FreeBSDQt5.14 - Build # 8 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20FreeBSDQt5.14/8/
Project: Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14
Date of build: Sun, 19 Apr 2020 11:17:06 +
Build duration: 27 min and counting
* CONSOLE OUTPUT *
[...truncated 114019 lines...]
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/ResourceLinking.h:26:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:88:25: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT_MSG(!msg, str);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:61:46: note:
expanded from macro 'BOOST_ASSERT_MSG'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT_MSG(expr, msg)
assert((expr)&&(msg))
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.964Z] 6 warnings generated.
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/StatsPlugin.h:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:56:21: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT(!msg);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:60:36: note:
expanded from macro 'BOOST_ASSERT'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT(expr) assert(expr)
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/StatsPlugin.h:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:64:25: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT_MSG(!msg, str);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:61:46: note:
expanded from macro 'BOOST_ASSERT_MSG'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT_MSG(expr, msg)
assert((expr)&&(msg))
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.965Z] In file included from
/usr/home/jenkins/workspace/Administration/De

D27597: KRunner: Refactor deprecated toSet() method

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  This gets already handled/discussed in D28135 


REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D27597

To: alex, mlaurent, apol, #plasma
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Alexander Stippich]

astippich removed a reviewer: astippich.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

T11627: Improve KIO asynchronicity

[Méven Car]

meven added a comment.


  While copying from local to a nfs mount with the destination opened, you get 
a dolphin freeze because KCoreDirlister is run in main thread and because of
  
#0  statx (fd=-100, 
path=0x5564ae9e5148 "/media/NFS/Myfile", flags=0, mask=4095, 
buf=0x7ffc8ba20420) at ../sysdeps/unix/sysv/linux/statx.c:29
#1  0x7f3559719016 in ?? () from 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f35596b3984 in QFileInfo::isDir() const () from 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f355b1a5913 in ?? () from 
/usr/lib/x86_64-linux-gnu/libKF5KIOCore.so.5
#4  0x7f35597a3458 in QMetaObject::activate(QObject*, int, int, void**) 
()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f355a916fd6 in KDirWatch::dirty(QString const&) () from 
/usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so.5
#6  0x7f35597a3d5a in QObject::event(QEvent*) () from 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f355a268a66 in QApplicationPrivate::notify_helper(QObject*, 
QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#8  0x7f355a2720f0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#9  0x7f355977793a in QCoreApplication::notifyInternal2(QObject*, 
QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x7f355977a5b8 in 
QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#11 0x7f35597cff67 in ?? () from 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x7f35576c1fbd in g_main_context_dispatch () from 
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#13 0x7f35576c2240 in ?? () from 
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#14 0x7f35576c22e3 in g_main_context_iteration () from 
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x7f35597cf565 in 
QEventDispatcherGlib::processEvents(QFlags) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#16 0x7f35597764db in 
QEventLoop::exec(QFlags) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#17 0x7f355977e246 in QCoreApplication::exec() () from 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x7f355b9de8b5 in kdemain () from 
/usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
#19 0x7f355b7c70b3 in __libc_start_main (main=0x5564ad350060, argc=1, 
argv=0x7ffc8ba20f38, init=, 
fini=, rtld_fini=, 
stack_end=0x7ffc8ba20f28) at ../csu/libc-start.c:308
#20 0x5564ad35009e in _start ()
  
  The destination is marked dirty because of the new file being created.
  It triggers KDirWatch::dirty which in turn makes 
`KCoreDirListerCache::slotFileDirty` trigger a statx on the new file.
  Which blocks since the NFS drive is already in use.
  And this freezes Dolphin UI since KCoreDirlister is in dolphin main thread.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven
Cc: ahartmetz, broulik, ognarb, #dolphin, #frameworks, meven, dfaure, azyx, 
nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D25515: Only extract lyrics when the plain text flag is set

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25515

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25518: Extract front cover in the taglib extractor

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25518

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25679: Implement writing of front cover in taglibwriter

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25679

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich abandoned this revision.
astippich added a comment.


  Okay, since there seems to be no interest at all as even a short reply is not 
given, I am done here

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 19 Apr 2020 18:33:34 +
 Build duration:
6 min 29 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/7/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 19 Apr 2020 18:33:34 +
 Build duration:
5 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.70.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33029/49191)49%
(14823/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4797/5131)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1678/1892)74%
(1083/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1938/3176)48%
(1426/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(716/1038)56%
(226/403)src.search100%
  

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added a comment.


  In D25339#651701 , @cullmann wrote:
  
  > Hmm, after applying this patch, for me, no text is visible at all.
  >  By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of 
ktexteditor toplevel dir).
  >
  > F8246692: kwrite_no_text.png 
  
  
  Are you sure it is the latest patch? I know some old version in this patch 
might have this effect.
  What's your color & font in kwrite setup BTW?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28955: [FileContentIndexer] Fix state update and signal order

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:af260fbdd2e5: [FileContentIndexer] Fix state update and 
signal order (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28955?vs=80488&id=80574

REVISION DETAIL
  https://phabricator.kde.org/D28955

AFFECTED FILES
  src/file/filecontentindexer.cpp

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28954: [Monitor] Fix monitor state and signal ordering

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3157e9375cc4: [Monitor] Fix monitor state and signal 
ordering (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28954?vs=80487&id=80573

REVISION DETAIL
  https://phabricator.kde.org/D28954

AFFECTED FILES
  src/qml/experimental/monitor.cpp

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28953: [Extractor] Fix progress reporting

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:273b7a1d7a63: [Extractor] Fix progress reporting 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28953?vs=80486&id=80572

REVISION DETAIL
  https://phabricator.kde.org/D28953

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham, mlaurent, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added a comment.


  In D25339#651701 , @cullmann wrote:
  
  > Hmm, after applying this patch, for me, no text is visible at all.
  >  By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of 
ktexteditor toplevel dir).
  >
  > F8246692: kwrite_no_text.png 
  
  
  let me test with some different colorscheme..

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/11/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 19 Apr 2020 17:38:38 +
 Build duration:
1 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:3d30318e4d37: API dox: document Q_DECLARE_FLAGS-based 
flags (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28986?vs=80569&id=80571

REVISION DETAIL
  https://phabricator.kde.org/D28986

AFFECTED FILES
  src/lib/jobs/kjob.h
  src/lib/jobs/kjobuidelegate.h
  src/lib/text/ktexttohtml.h
  src/lib/util/kformat.h
  src/lib/util/kshell.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  documentFlags

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[David Faure]

dfaure added a comment.


  Sure.

REPOSITORY
  R244 KCoreAddons

BRANCH
  documentFlags

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If okay, I would walk over the other KF modules and apply the same pattern 
there as well, once this here is accepted.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 80569.
kossebau added a comment.


  drop the "OR" from "OR combination"

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28986?vs=80562&id=80569

BRANCH
  documentFlags

REVISION DETAIL
  https://phabricator.kde.org/D28986

AFFECTED FILES
  src/lib/jobs/kjob.h
  src/lib/jobs/kjobuidelegate.h
  src/lib/text/ktexttohtml.h
  src/lib/util/kformat.h
  src/lib/util/kshell.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kjob.h:99
> Inexperienced developers might be confused by the OR in there.
> In English it sounds like exclusive or, while the whole point of 
> Q_DECLARE_FLAGS is that multiple flags can be set at the same time.
> 
> Why not just say "Stores a combination of" ?

I had myself inspired by the wording of https://doc.qt.io/qt-5/qflags.html and 
similar of Qt docs for flags like 
https://doc.qt.io/qt-5/qwidget.html#RenderFlag-enum, which currently also talk 
about 
"The QFlags class provides a type-safe way of storing OR-combinations of enum 
values"
or
 "The RenderFlags type is a typedef for QFlags. It stores an OR 
combination of RenderFlag values."

But I tend to think you have a point, the OR here is not really needed and 
rather confusing, Will update.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kjob.h:99
> +/**
> + * Stores an OR combination of #Capability values.
> + */

Inexperienced developers might be confused by the OR in there.
In English it sounds like exclusive or, while the whole point of 
Q_DECLARE_FLAGS is that multiple flags can be set at the same time.

Why not just say "Stores a combination of" ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the
  underlying typedefs are no longer skipped by doxygen, but can be
  documented now, allowing links to be generated for these types e.g. when
  used as arguments.
  
  The "#" prefix to the enum name in the description text of all the
  Q_DECLARE_FLAGS docs seems needed to properly trigger doxygen autolinks.

REPOSITORY
  R244 KCoreAddons

BRANCH
  documentFlags

REVISION DETAIL
  https://phabricator.kde.org/D28986

AFFECTED FILES
  src/lib/jobs/kjob.h
  src/lib/jobs/kjobuidelegate.h
  src/lib/text/ktexttohtml.h
  src/lib/util/kformat.h
  src/lib/util/kshell.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D6794: assert the testpackage appstream data validates

[Harald Sitter]

sitter added a comment.


  @bcooksley I would think the CI image needs to ship some general purpose 
schemas. install 
https://software.opensuse.org/package/gsettings-desktop-schemas I guess.
  
  If it's still not working right with that installed I can take a look at 
what's missing. The warning does sound rather generic so I have high hopes for 
having any schemas resolving it.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D6794

To: sitter, sebas, apol
Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28956: [QML Monitor] Show remaining time as soon as possible

[Stefan Brüns]

bruns added a comment.


  In D28956#651795 , @apol wrote:
  
  > You're using QDeadlineTimer weird. Why don't you use 
QDeadlineTimer::remainingTime() and ::setDeadline?
  
  
  Because both functions do a syscall.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir added a reviewer: broulik.
ahmadsamir added a comment.


  I had trouble finding what urlPatterns would look like, and only found 
trash:/ and run:/, also couldn't find any documentation about 
X-Plasma-DropUrlPatterns.
  
  Porting regex, especially with the pesky QRegExp::Wildcard, seeing what the 
pattern should look like always helps (and then adding a comment in the code 
with examples, that helps future changes, some docs say that the best 
regex-handling-code is one that has comments with examples of what the regex is 
supposed to match).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28956: [QML Monitor] Show remaining time as soon as possible

[Aleix Pol Gonzalez]

apol added a comment.


  You're using QDeadlineTimer weird. Why don't you use 
QDeadlineTimer::remainingTime() and ::setDeadline?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28955: [FileContentIndexer] Fix state update and signal order

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28955

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28953: [Extractor] Fix progress reporting

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28953

To: bruns, #baloo, ngraham, mlaurent, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28954: [Monitor] Fix monitor state and signal ordering

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28954

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28769: Add Icelandic Krona

[Martin Tobias Holmedahl Sandsmark]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:1a7d46d3f753: Add Icelandic Krona to currencies (authored 
by sandsmark).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28769?vs=7&id=80541

REVISION DETAIL
  https://phabricator.kde.org/D28769

AFFECTED FILES
  src/currency.cpp
  src/unit.h

To: sandsmark, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, 
bruns

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, mgallien, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Revert "add missing license"
  This reverts commit 96fb5896c304b7292fc3cea87fb584b14b270448 
.
  
  This reverts commit ef0e268c657718d4a353638f91d3723624c358ac 
.
  
  The BalooWatcherApplication DBus interface was created to be used by
  Elisa, but the only use there is to create some debug output.
  As soon as Elisa registers itself, each rename causes a bunch
  of DB queries (in case a directory is renamed, it builds the list
  of all children) and a (potentially huge) DBus call.
  
  The DBus interface is totally awkward, as it calls a method in the
  watcher application (i.e. replicating the message on the sender side)
  instead of using DBus signals and letting the DBus daemon do its job.
  
  Keep the DBus interface as a stub, but remove the caused overhead.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28980

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/filewatchtest.cpp
  autotests/unit/file/metadatamovertest.cpp
  autotests/unit/file/metadatamovertest.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/CMakeLists.txt
  src/file/filewatch.cpp
  src/file/filewatch.h
  src/file/mainhub.cpp
  src/file/mainhub.h
  src/file/metadatamover.cpp
  src/file/metadatamover.h

To: bruns, #baloo, mgallien, astippich, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/11/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 19 Apr 2020 13:29:14 +
 Build duration:
2 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9126)43%
(10802/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6197/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 19 Apr 2020 13:29:14 +
 Build duration:
1 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D28979: Mark ancient KLibFactory typedef as deprecated

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:7d3e832c13ef: Mark ancient KLibFactory typedef as 
deprecated (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28979?vs=80538&id=80539

REVISION DETAIL
  https://phabricator.kde.org/D28979

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/plugin/kpluginfactory.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28979: Mark ancient KLibFactory typedef as deprecated

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  tagKLibFactorydeprecated

REVISION DETAIL
  https://phabricator.kde.org/D28979

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28979: Mark ancient KLibFactory typedef as deprecated

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  tagKLibFactorydeprecated

REVISION DETAIL
  https://phabricator.kde.org/D28979

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/plugin/kpluginfactory.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Christoph Cullmann]

cullmann added a comment.


  Hmm, after applying this patch, for me, no text is visible at all.
  By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of 
ktexteditor toplevel dir).
  
  F8246692: kwrite_no_text.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28973: Fix cache directory calculation when adding to trash

[David Faure]

dfaure added a comment.


  Thanks.  >0 is already something :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28973

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  AFAICS, from grep'ing for "DropUrlPatterns" in 
/usr/share/{kservices5,plasma/plasmoids/}
  "urlPatterns" is either run:/ or trash:/, hence startsWith() should suffice.

TEST PLAN
  make && ctest

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28978

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28973: Fix cache directory calculation when adding to trash

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ff831cb609ea: Fix cache directory calculation when adding 
to trash (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28973?vs=80534&id=80535

REVISION DETAIL
  https://phabricator.kde.org/D28973

AFFECTED FILES
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/trashimpl.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28973: Fix cache directory calculation when adding to trash

[Méven Car]

meven updated this revision to Diff 80534.
meven added a comment.


  Add test

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28973?vs=80520&id=80534

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28973

AFFECTED FILES
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/trashimpl.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28952: [KNewStuff] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6b5ec74ff4ca: [KNewStuff] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28952?vs=80483&id=80532

REVISION DETAIL
  https://phabricator.kde.org/D28952

AFFECTED FILES
  src/kmoretools/kmoretools_p.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28967: [KRichTextEditor] Add support for headings

[Igor Poboiko]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:2f86040cab5b: [KRichTextEditor] Add support for headings 
(authored by poboiko).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28967?vs=80524&id=80530

REVISION DETAIL
  https://phabricator.kde.org/D28967

AFFECTED FILES
  tests/krichtexteditor/krichtexteditorui.rc

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:b52622993b45: [KFontChooser] Make styleIdentifier() more 
precise by adding font styleName (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28974?vs=80521&id=80529

REVISION DETAIL
  https://phabricator.kde.org/D28974

AFFECTED FILES
  src/kfontchooser.cpp
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

[Ahmad Samir]

ahmadsamir added a comment.


  This particular one is the same bug, we've been fixing it for a couple of 
months now; in KConfig, in the Fonts KCM/KFontChooser*, we even had to bring 
KFontDialog back from the deprecation pile in KDELibs4Support (for this and for 
decimal font sizes which QFontDialog doesn't allow) all that because upstream 
most likely won't take a patch that clears a font styleName property when it's 
weight is Normal and the style name is Regular|Normal|Book|Roman... I don't 
claim to understand their reasons (I keep finding new reasons as I look at it 
more) but sometimes technical-correctness isn't that "correct".

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-tightenStyleId (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28974

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D28880#651415 , @dfaure wrote:
  
  > In D28880#651209 , @ahmadsamir 
wrote:
  >
  > > There are only two places in KDE code where readEntryList() is used, 
falkon and kwalletmanager; in both cases readEntryList() was used with "*" 
which means "read all entries", which is logical since in both cases the list 
is used to fill a "password manager" of some kind.
  >
  >
  > Does this mean that the most useful API would be entryList() which would 
return all entries.
  
  
  Yes. And then the "matching"/filtering part is done with a QSFPM-like model, 
which is what the two, and only, current users of readEntryList() do... I was 
hesitant thinking that there may be many entries and that filtering right here 
in kwallet might make more sense, but how many passwords will an average user 
have? 10-20 I would say. This is the same as say firefox (didn't look at the 
internals there), you get a list of all "saved logins" and filter from a line 
edit. That option is looking more promising (and less work :D).
  
  >> I am thinking of having 3 new methods (right now there is read{Entry, Map, 
Password}List, very intuitively replace "read" with "get") that take a third 
parameter:
  >>  enum KWallet::MatchType {KWallet::PlainText, KWallet::Regex}
  >> 
  >> this way in regex mode, the QString &key parameter is used to construct a 
QRegularExpression, abstracting the type of the regex class (nitpicking really, 
since given QRegExp has been around for what 10/15 years? QRegularExpression 
may live even longer with sturdy PCRE support o/...).
  > 
  > Well actually the regexp syntax changed (a bit) so better be explicit.
  
  If we go this route, we can be explicit in the docs, but always take a 
"QString &pattern" param (sort of like KTextEdit find/replace classes, it's 
always a QString pattern param and a KFind::RegularExpression options flag).
  
  > 
  > 
  >> New method names solve some hurdles (e.g. overloading a function that 
takes only one QString param, and it actually invoked by a dbus call).
  > 
  > Yes.
  > 
  >> In the meantime: https://marc.info/?t=14678878933&r=1&w=2 , can't say 
I understood all the issues there but it's definitely a grim read :)
  > 
  > Yes the idea of using QtKeychain as the application API came up again more 
recently, see T12219 
  >  This would make a lot of sense (abstracting the actual backend).
  >  Still, unless someone makes the bigger effort of "finishing 
KSecretService" it makes sense to fix the KWallet backend...
  
  Yeah...

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D28880

To: ahmadsamir, #frameworks, dfaure, blaze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28967: [KRichTextEditor] Add support for headings

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28967

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

[Igor Poboiko]

This revision was automatically updated to reflect the committed changes.
Closed by commit R310:7d3a1386bee2: [KRichTextEdit] Make sure headings 
don't mess with undo stack (authored by poboiko).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28968?vs=80508&id=80528

REVISION DETAIL
  https://phabricator.kde.org/D28968

AFFECTED FILES
  autotests/krichtextedittest.cpp
  src/widgets/krichtextedit.cpp

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Oh I see. Thanks, I didn't know that method.

REPOSITORY
  R310 KTextWidgets

BRANCH
  heading-undo-stack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28968

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

[Igor Poboiko]

poboiko added inline comments.

INLINE COMMENTS

> dfaure wrote in krichtextedit.cpp:572
> Where is the corresponding beginEditBlock()?

`joinPreviousEditBlock` in a way acts as `beginEditBlock` (see 
https://doc.qt.io/qt-5/qtextcursor.html#joinPreviousEditBlock).

The intent here was following: if user pressed `Return`, a new line (empty 
`QTextBlock`) is inserted somewhere inside `QTextEdit::keyPressEvent`. I want 
to also change the cursor style, and I want this action to be treated together 
with this `QTextBlock` insertion as a single action in undo stack. That's what 
`joinPreviousEditBlock / endEditBlock` combo does (semantically, this "previous 
edit block" is `QTextBlock` insertion inside `QTextEdit::keyPressEvent`)

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28968

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu updated this revision to Diff 80526.
marcingu added a comment.


  Review fixes

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28745?vs=80458&id=80526

REVISION DETAIL
  https://phabricator.kde.org/D28745

AFFECTED FILES
  thumbnail/thumbnail.cpp
  thumbnail/thumbnail.h

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  You're like a bugfixing machine, very impressive :-)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-tightenStyleId (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28974

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

[Igor Poboiko]

This revision was automatically updated to reflect the committed changes.
Closed by commit R310:0e14353610fa: [KRichTextEdit] Fix scroll jumping around 
when horizontal rule is added (authored by poboiko).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28966?vs=80505&id=80525

REVISION DETAIL
  https://phabricator.kde.org/D28966

AFFECTED FILES
  autotests/krichtextedittest.cpp
  autotests/krichtextedittest.h
  src/widgets/krichtextedit.cpp

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krichtextedit.cpp:572
>  setHeadingLevel(0);
> -}
> -
> -// If a line was merged with previous one, with different heading level,
> -// the style should also be adjusted accordingly (i.e. merged)
> -if ((event->key() == Qt::Key_Backspace) || (event->key() == 
> Qt::Key_Delete)) {
> -setHeadingLevel(textCursor().blockFormat().headingLevel());
> +textCursor().endEditBlock();
>  }

Where is the corresponding beginEditBlock()?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28968

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice work.

REPOSITORY
  R310 KTextWidgets

BRANCH
  dont-scroll-rule (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28966

To: poboiko, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28967: [KRichTextEditor] Add support for headings

[Igor Poboiko]

poboiko updated this revision to Diff 80524.
poboiko added a comment.


  Update version

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28967?vs=80507&id=80524

BRANCH
  heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28967

AFFECTED FILES
  tests/krichtexteditor/krichtexteditorui.rc

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28967: [KRichTextEditor] Add support for headings

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krichtexteditorui.rc:2
>  
>  
>  

increase version. => 14

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D28967

To: poboiko, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28952: [KNewStuff] Port QRegExp to QRegularExpression

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28952

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28973: Fix cache directory calculation when adding to trash

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Good catch. I wonder if the unittest could be extended so it would have 
caught this.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28973

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in kio_smb.h:96
> KF6 ?
> Or once we want to use it in KIO ?

Whenever we port a 3rd slave to it ;-)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28909

To: sitter, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  styleIdentifier() tries to get the correct font style based on weight,
  style, and stretch; this "styleID" could be the same for different font
  styles in the same family, and it worked in most cases because "Regular"-like
  styles usually are ordered first in the family styles list from QFontDatabase.
  However this breaks for font families that provide many font styles, e.g.
  Noto Sans, where "SemiCondensed" comes first in the list.
  
  Make it more precise by adding the font "styleName" property to the
  "styleID" we concatenate, this makes it more precise. Also handle empty
  styleName font prop. (we strip it on purpose, see 
KConfigGroupGui::writeEntryGui()
  for more details), try to pick the correct one so that we highlight
  it in the font style list view.

TEST PLAN
  kfontchooserdialogtest app, with the initial font set to "Noto Sans",
  before this change it'd select "SemiCondensed"; now it selects "Regular"
  as expected.
  
  BUG: 420287
  FIXED-IN: 5.70

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-tightenStyleId (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28974

AFFECTED FILES
  src/kfontchooser.cpp
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28973: Fix cache directory calculation when adding to trash

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  The directory size was not added to the directory cache size since D24773 


TEST PLAN
  Moved a folder to trash.
  Its size is visible in 
  ~/.local/share/Trash/directorysizes

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28973

AFFECTED FILES
  src/ioslaves/trash/trashimpl.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns