KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 151 - Still Unstable!

2021-03-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/151/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 02 Mar 2021 19:01:13 +
 Build duration:
7 min 25 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.80.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.80.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 64 test(s)Failed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(21/28)86%
(260/304)86%
(260/304)68%
(33873/50081)50%
(15338/30698)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(40/40)100%
(40/40)94%
(5305/5617)50%
(1961/3956)autotests.src.benchmarks0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/6)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5553/5596)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1704/1923)73%
(1078/1472)src.completion100%
(11/11)100%
(11/11)58%
(1841/3155)43%
(1043/2433)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/875)0%
(0/188)src.document100%
(4/4)100%
(4/4)61%
(1957/3208)48%
(1423/2955)src.export0%
(0/4)0%
(0/4)0%
(0/137)0%
(0/158)src.include.ktexteditor79%
(15/19)79%
(15/19)85%
(226/267)57%
(136/240)src.inputmode100%
(8/8)100%
(8/8)67%
(206/306)58%
(46/79)src.mode88%
(7/8)88%
(7/8)36%
(379/1067)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/282)src.render100%
(8/8)100%
(8/8)77%
(940/1214)67%
(612/914)src.script94%
(16/17)94%
(16/17)66%
(693/1057)51%
(207/409)src.sear

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 245 - Still Unstable!

2021-03-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/245/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 02 Mar 2021 18:55:13 +
 Build duration:
7 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.80.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.80.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 64 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(21/28)86%
(262/304)86%
(262/304)68%
(34282/50141)51%
(15581/30716)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(40/40)100%
(40/40)95%
(5361/5660)50%
(1972/3974)autotests.src.benchmarks0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/6)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5553/5596)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)90%
(1731/1923)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)58%
(1841/3155)43%
(1043/2433)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/875)0%
(0/188)src.document100%
(4/4)100%
(4/4)61%
(1964/3208)49%
(1439/2955)src.export0%
(0/4)0%
(0/4)0%
(0/137)0%
(0/158)src.include.ktexteditor79%
(15/19)79%
(15/19)91%
(242/267)65%
(157/240)src.inputmode100%
(8/8)100%
(8/8)67%
(206/306)58%
(46/79)src.mode88%
(7/8)88%
(7/8)36%
(379/1067)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/282)src.render100%
(8/8)100%
(8/8)76%
(918/1214)66%
(600/914)src.script94%
(16/17)94%
(16/17)69%
(729/1057)56%

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 150 - Still Unstable!

2021-03-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/150/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 02 Mar 2021 18:34:29 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.80.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.80.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 64 test(s)Failed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(21/28)86%
(260/304)86%
(260/304)67%
(33779/50073)50%
(15296/30698)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(40/40)100%
(40/40)94%
(5275/5614)49%
(1954/3956)autotests.src.benchmarks0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/6)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5553/5596)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1703/1923)73%
(1077/1472)src.completion100%
(11/11)100%
(11/11)58%
(1843/3155)43%
(1045/2433)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/875)0%
(0/188)src.document100%
(4/4)100%
(4/4)61%
(1953/3208)48%
(1415/2955)src.export0%
(0/4)0%
(0/4)0%
(0/137)0%
(0/158)src.include.ktexteditor79%
(15/19)79%
(15/19)85%
(226/267)57%
(136/240)src.inputmode100%
(8/8)100%
(8/8)67%
(206/306)58%
(46/79)src.mode88%
(7/8)88%
(7/8)36%
(379/1067)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/282)src.render100%
(8/8)100%
(8/8)76%
(918/1214)66%
(600/914)src.script94%
(16/17)94%
(16/17)64%
(671/1054)48%
(197/409)src.search100%

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 244 - Still Unstable!

2021-03-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/244/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 02 Mar 2021 18:34:29 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.80.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.80.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 64 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(21/28)86%
(262/304)86%
(262/304)68%
(34282/50141)51%
(15582/30716)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(40/40)100%
(40/40)95%
(5361/5660)50%
(1972/3974)autotests.src.benchmarks0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/6)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5553/5596)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)90%
(1731/1923)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)58%
(1841/3155)43%
(1043/2433)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/875)0%
(0/188)src.document100%
(4/4)100%
(4/4)61%
(1964/3208)49%
(1439/2955)src.export0%
(0/4)0%
(0/4)0%
(0/137)0%
(0/158)src.include.ktexteditor79%
(15/19)79%
(15/19)91%
(242/267)65%
(157/240)src.inputmode100%
(8/8)100%
(8/8)67%
(206/306)58%
(46/79)src.mode88%
(7/8)88%
(7/8)36%
(379/1067)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/282)src.render100%
(8/8)100%
(8/8)76%
(918/1214)66%
(600/914)src.script94%
(16/17)94%
(16/17)69%
(729/1057)56%

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka 
kdudka added a comment.


  I am fine with kio implementing things differently as long as the basic 
functionality keeps working.  I used to use Krusader to get images out of my 
camera and it simply stopped working for me with no obvious indication of what 
went wrong.  This code tries to implement some advanced error handling, yet it 
is written in a way that it passed a review with a fundamental programming 
mistake in the basic error handling.
  
  The fix proposed in https://phabricator.kde.org/D17816#677448 is incomplete, 
as I understand it.  If we break the loop with `valuelen == -1`, the value will 
be passed as `size_t` to the `size` argument of `fsetxattr()`, which may lead 
to reading `value.constData()` out of bounds.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns 
bruns added a comment.


  In D17816#677455 , @kdudka wrote:
  
  > @bruns I find your attitude unnecessarily hostile.  If you think that the 
code is perfect as it is, feel free to patch it case by case until it 
eventually works for everybody.  That is your choice.
  
  
  I never said its perfect. There is exactly one case which was missed (and 
only in this one location, for both listxattr and setxattr a return value of -1 
is handled correctly).
  
  > I do not think that KDE users will appreciate some **blindly** coded 
**fancy features** on top of that when the basic functionality gets **totally 
broken** as a result of these **experiments**.
  
  Such well chosen words ...
  
  Btw, there are plenty of more cases where kio deliberately deviates from the 
behavior of low level system tools.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka 
kdudka added a comment.


  @bruns I find your attitude unnecessarily hostile.  If you think that the 
code is perfect as it is, feel free to patch it case by case until it 
eventually works for everybody.  That is your choice.
  
  Anyway, strace of `cp --preserve=xattr` on the same device looks like this:
  
execve("/bin/cp", ["cp", "--preserve=xattr", "/mnt/mmc/file", "."], 
0x7ffdf8529c88 /* 81 vars */) = 0
access("/etc/ld.so.preload", R_OK)  = -1 ENOENT (No such file or 
directory)
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libacl.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libattr.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
stat(".", {st_mode=S_IFDIR|S_ISVTX|0777, st_size=1522, ...}) = 0
newfstatat(AT_FDCWD, "/mnt/mmc/file", {st_mode=S_IFREG|0755, st_size=0, 
...}, 0) = 0
newfstatat(AT_FDCWD, "./file", 0x7ffea3f59f50, 0) = -1 ENOENT (No such file 
or directory)
openat(AT_FDCWD, "/mnt/mmc/file", O_RDONLY) = 3
openat(AT_FDCWD, "./file", O_WRONLY|O_CREAT|O_EXCL, 0755) = 4
flistxattr(3, NULL, 0)  = 17
flistxattr(3, "security.selinux\0", 17) = 17
openat(AT_FDCWD, "/etc/xattr.conf", O_RDONLY) = 5
fgetxattr(3, "security.selinux", NULL, 0) = -1 EOPNOTSUPP (Operation not 
supported)
cp: getting attribute 'security.selinux' of 'security.selinux': Operation 
not supported
+++ exited with 1 +++

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns 
bruns added a comment.


  In D17816#677453 , @kdudka wrote:
  
  > I do not think we have to.  Please have a look at how attr_copy_fd() from 
 is implemented: 
http://git.savannah.nongnu.org/cgit/attr.git/tree/libattr/attr_copy_fd.c?id=a4187bec#n111
  This code is quite mature and it is used by cp(1) on GNU/Linux for instance.  
I do not think that KDE users will appreciate some blindly coded fancy features 
on top of that when the basic functionality gets totally broken as a result of 
these experiments.  Please keep the code simple and reliable.
  
  
  Its not blindly coded. Please keep your arrogant comments to yourself.
  
  And obviously, there is something strange going on on your system - 
flistxattr returns a list of keys, but fgetxattr then returns ENOTSUP?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka 
kdudka added a comment.


  I do not think we have to.  Please have a look at how attr_copy_fd() from 
 is implemented: 
http://git.savannah.nongnu.org/cgit/attr.git/tree/libattr/attr_copy_fd.c?id=a4187bec#n111
  This code is quite mature and it is used by cp(1) on GNU/Linux for instance.  
I do not think that KDE users will appreciate some blindly coded fancy features 
on top of that when the basic functionality gets totally broken as a result of 
these experiments.  Please keep the code simple and reliable.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns 
bruns added a comment.


  In D17816#677451 , @kdudka wrote:
  
  > The man page says that one has to check return value of the second call.  
It does not say that the function needs to be called in a loop indefinitely 
until it succeeds.
  
  
  And if the second call then returns ERANGE you have to start from the 
beginning.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka 
kdudka added a comment.


  The man page says that one has to check return value of the second call.  It 
does not say that the function needs to be called in a loop indefinitely until 
it succeeds.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns 
bruns added a comment.


  In D17816#677449 , @kdudka wrote:
  
  > Even after applying the proposed patch, the code still looks problematic to 
me.  I would prefer to have it explained first.  When fgetxattr(..., 0) returns 
-1/ERANGE, what is the point of calling fgetxattr(..., 0) again?  It is still 
going to busy-loop indefinitely in this case, doesn't it?  How many times do we 
actually need to call fgetxattr() on a single file descriptor?  Twice?  Then 
unbounded loop is not the best construction to begin with.
  
  
  Ever heard of a TOCTOU race?
  
  Quoting from man 2 getxattr:
  
  > If size is specified as zero, these calls return the current size of the 
named extended attribute (and leave value unchanged).  This can be used to 
determine the size of the buffer that should be supplied in a subsequent call.  
 (But,  bear  in  mind  that  there is a possibility that the attribute value 
may change between the two calls, so that it is still necessary to check the 
return status from the second call.)

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka 
kdudka added a comment.


  Even after applying the proposed patch, the code still looks problematic to 
me.  I would prefer to have it explained first.  When fgetxattr(..., 0) returns 
-1/ERANGE, what is the point of calling fgetxattr(..., 0) again?  It is still 
going to busy-loop indefinitely in this case, doesn't it?  How many times do we 
actually need to call fgetxattr() on a single file descriptor?  Twice?  Then 
unbounded loop is not the best construction to begin with.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Gleb Popov 
arrowd added a comment.


  In D17816#677446 , @kdudka wrote:
  
  > I was wondering why copying files in Krusader or Dolphin from a 
vfat-formatted memory card stopped working for me after update.  After copying 
the first file, the transfer stopped progressing and the process ended up 
consuming 100% CPU forever.  Later I discovered that the cause of the breakage 
was this patch: If fgetxattr() fails with ENOTSUP, the code loops indefinitely 
calling fgetxattr().
  >
  > The following hotfix made copying of files in Krusader work again for me:
  >  ...
  >
  > However, the code might need bigger changes to cover all the cases.  I do 
not fully understand the (IMO over-complicated) loops around flistxattr() and 
fgetxattr().  Note that the fact that one of them uses `while (true) { ... }` 
whereas the other one uses `do { ... } while (true)` does not improve code 
readability either.
  
  
  I think, the correct fix is something like
  
diff --git a/src/ioslaves/file/file_unix.cpp 
b/src/ioslaves/file/file_unix.cpp
index 74767123..4bc87c57 100644
--- a/src/ioslaves/file/file_unix.cpp
+++ b/src/ioslaves/file/file_unix.cpp
@@ -614,8 +614,8 @@ bool FileProtocol::copyXattrs(const int src_fd, const 
int dest_fd)
 valuelen = 0;
 continue;
 }
-// happens when attr value is an empty string
-if (valuelen == 0) {
+// valuelen=0 happens when attr value is an empty string
+if (valuelen == 0 || valuelen == -1) {
 break;
 }
 } while (true);
  
  Can you check if this works for you too?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

Re: KCGroups in KDEreview

2021-03-02 Thread Kevin Ottens 
Hello,

On Tuesday, 2 March 2021 12:06:51 CET David Edmundson wrote:
> > > (where 1000 is of course dynamic)
> > 
> > Ditto, what enum names could we give to those?
> 
> / -> All
> /system.slice -> System
> user.slice/user-1000.slice/user@1000.service -> User
> user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps
> user.slice/user-1000.slice/user@1000.service/session.slice -> UserSession
> user.slice/user-1000.slice/user@1000.service/background.slice ->
> UserBackground

Sounds good to me. Let's go for this.

Regards.
-- 
Kevin Ottens, http://ervin.ipsquad.net

enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en

signature.asc
Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

2021-03-02 Thread David Edmundson 
> > (where 1000 is of course dynamic)
>
> Ditto, what enum names could we give to those?

/ -> All
/system.slice -> System
user.slice/user-1000.slice/user@1000.service -> User
user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps
user.slice/user-1000.slice/user@1000.service/session.slice -> UserSession
user.slice/user-1000.slice/user@1000.service/background.slice -> UserBackground


> Yes, I know I roll with questions. :-)

> Cheers.
> --
> Kevin Ottens, http://ervin.ipsquad.net