"Approve"ing an MR

ted by bshah at https://gitlab.com/gitlab-org/gitlab/-/issues/231351 Have a good day :) -- Ahmad Samir

Re: Dropping the moderation by default flag

-devel ML, because I sent an email there and it was postponed due to moderation. Given that kde-core-devel and kde-frameworks-devel are similar, could you please set that same setting for kde-core-devel too? Thanks. :) -- Ahmad Samir

T8349: Improve Places panel usability and presentation

ahmadsamir added subscribers: sitter, ahmadsamir. ahmadsamir added a comment. ATM, the behaviour is that if you go to /foo/bar/baz/ and "bar" is present in the places panel, then while you're at baz or any of its sub-folders then "bar" is highlighted in the places panel, i.e the "closest" boo

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

as 5.13 is essentially unavailable" That's why team jumped to 5.14 directly, don't know the details however. [...] -- Ahmad Samir

D27224: add Kongress icon

ahmadsamir added a comment. Hello. FWIW, I would also close/abandon this diff :) (nice icon BTW). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert, dkardarakos, #vdg, ndavis Cc: ahmadsamir, ndavis, kde-frameworks-devel, LeGast00n, cblack, mich

clang-format section added to the coding style guide

so that it doesn't mangle your code) Have a good day. :) -- Ahmad Samir

Request for wide spread testing

day. -- Ahmad Samir

Saturday, 2021-04-11 KF6 meeting notes

is really no drawback on using a list of KCMs instead of a single KCM. What we forgot to do is pick the tasks for discussion for the next meeting, so if you have suggestions please post them somewhere (on this ML would work best). -- Ahmad Samir

Including instead of , does it upset POSIX?

ot be a concern when we use stuff specifically with the expectation that they will behave as documented from a POSIX or linux POV (such as signal safety in kcrash) [1] https://invent.kde.org/frameworks/kio/-/merge_requests/397 -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

On 14/04/2021 22:20, Albert Astals Cid wrote: El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure: Hello :) A week or so ago I created an MR to include instead of in KIO[1]. From /usr/include/c++/10/cerrno: /** @file cerrno * This is a Standard C

Re: Including instead of , does it upset POSIX?

ave an .c files. Thanks for re-checking. Cheers, Albert -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

ush the changes and if the CI doesn't barf on any of it, then my conclusion is it's OK so far. -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

On 21/04/2021 15:34, Ahmad Samir wrote: On 21/04/2021 15:20, Harald Sitter wrote: To conclude this our verdict is to always use the modern headers? I am re-checking the rest of the frameworks that failed the first time around; Albert already reported that it built for him locally with

KF6 weekly meeting reminder

hour trying to chisel away at the ever growing KF6 tasks board https://phabricator.kde.org/project/board/310/ Have a good day. -- Ahmad Samir

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

ahmadsamir added a comment. Anything other than the methods that were added for "portability at the expense of performance", should be OK, famous last words™. :) I've been bitten twice by the QStringView API in Qt5, it has too many surprises, basically because upstream decided to make "c

KF6 weekly meeting

(I would like to take this chance to thank Luigi, who somehow can keep track of all the tasks being discussed and posts the meeting notes on this ML every week o/). Have a good day. -- Ahmad Samir

KF6 weekly meeting

t to listen, see how stuff are discussed, maybe there is a task there that has your name on it, something that intrigues you and you'd like to work on ...etc. Have a good day. -- Ahmad Samir

KF6 weekly meeting

st want to listen/see how things are done in KDE. Have a good day. -- Ahmad Samir

Weekly meeting reminder

ricator.kde.org/project/board/310/, we're supposed to whittle it down if we want to finally, branch for KF6, no rush, but it should hopefully happen at some point, preferably during our lifetimes. :) All are welcome to join, even if you just want to listen/see how things are done in KDE. Have a

Pushing and creating a merge request from the command line

ne Have a good day. -- Ahmad Samir

Re: KF5 modules development branches now build in C++17 mode (but keep public headers compatible)

ences, it does make sense to disable compiler specific extensions. Cheers, Albert > -- Ahmad Samir

Weekly KF6 meeting poll

way to find a more suitable time for the weekly KF6 meeting (that we used to have on Saturdays 13:00 UTC), apparently the link might have gone too far under the radar in the KF6 meeting notes that were posted to this ML by Volker. So here it is, please vote: https://doodle.com/poll/94646r75keyxgqkx Have a good day. -- Ahmad Samir

Re: Weekly KF6 meeting poll

On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all the hair on his head"... sorry, I dig

Re: Weekly KF6 meeting poll

On 09/07/2021 19:08, Ahmad Samir wrote: On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all

Re: Porting notes / deprecation docs

asier to edit in my usual editor of choice). FWIW, there is supposed to be a KF6 meeting soon[1]. Not sure if we'll start this week or the next one though. [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2021-July/118028.html Thanks! Cheers, Frederik -- Ahmad Samir

Heads-up: kioslaves .so libs have been renamed

build-dir, as most of us do) or from your kdesrc-build installation; so you may want to clear up that situation. That leads to interesting issue, as kioslave5 binary could pick either kf5/kio/file.so or kf5/kio/kio_file.so and you get weird results. Have a good day. -- Ahmad Samir

KF API Documentation proposed, small, addition

/typewriter font face, typically e.g. @c true, @c false, @c setSomeValue(); for multiple words you'll have to use: multiple words * @copydoc to copy the docs of a different method, e.g. if one method overloads another -- Ahmad Samir

Please include this in 5.86

Fixes KMountPoint::findByPath(): https://invent.kde.org/frameworks/kio/-/commit/147193f5661173d24d75f6558e5607d3418f6c71 Thanks, Ahmad Samir

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77538. ahmadsamir added a comment. As pointed out by dfaure, we have to make sure the unit test passes even if KIO isn't installed (which might be the case on the KDE CI system). Since we aren't actually executing the ktelnetservice5 binary and only ch

D27947: Port away from deprecated QList::toSet()

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27947 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77554. ahmadsamir added a comment. QList::erase() invalidates the iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77477&id=77554 BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https

D27947: Port away from deprecated QList::toSet()

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kcoredirlister.cpp:1045 > Is this to force dir at the end? You mean at the front? I am not sure, but I matched the behaviour of the original code, it first appended "dir" then the QUrl list from canonicalUrls. It sort of makes s

D27965: [KPasswdServer] replace foreach with range/index-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:018f223692de: [KPasswdServer] replace foreach with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77554&id=7764

D27947: Port away from deprecated QList::toSet()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:30d964096430: Port away from deprecated QList::toSet() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27947?vs=77287&id=77649 REVISION DETAIL

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

ahmadsamir added a comment. I tested it; before applying the diff: $ /usr/lib64/libexec/kf5/kioexec --tempfiles does_not_exist /tmp/foo command= "does_not_exist" args= ("does_not_exist", "/tmp/foo") EXEC "does_not_exist /tmp/foo" EXEC done $ echo $? 0 $ /

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, s

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY QMimeDatabase re-adds/prepends the "main" glob pattern (the

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir updated this revision to Diff 77754. ahmadsamir added a comment. Tweak comment REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28079?vs=77753&id=77754 BRANCH l-mainglobpattern (branched from master) REVISION DETAIL https://phabrica

D28088: Fix warnings

ahmadsamir added inline comments. INLINE COMMENTS > containmentactions.cpp:138 > #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0) > +int o = > QObject::staticQtMetaObject.indexOfEnumerator("Orientations"); > +QMetaEnum orient = QObject::staticQtMetaObject.enumerator(o); const ? REP

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir added a comment. For background see: https://bugs.kde.org/show_bug.cgi?id=414742 I may be wrong, but personally I think QMimeDatabase is acting sensibly by not allowing to remove the "main" glob pattern of a mimetype. Also IIUC it seems other tools are sort of doing the sa

D27986: Allow providing an error message from the application

ahmadsamir added a comment. In D27986#628977 , @bcooksley wrote: > The following is notice that I intend to revert this change, along with the corresponding commits that make use of this functionality in Dr Konqi, as they cause a FTBFS on both

D28095: Bump required version of KF5 to 5.69.0

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY KCrash::setErrorMessage() was introduced in 5.69.0. REPOSITORY

D28095: Bump required version of KF5 to 5.69.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:ce461918868d: Bump required version of KF5 to 5.69.0 (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28095?vs=77812&id=77813 REVISION DETA

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Braces around if blocks. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kpasswdserver-clang-fo

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. Friendly ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop relative size bits, seems not that used - Use a KFontDialogP

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 77904. ahmadsamir added a task: T12760: Port/move KFontDialog from KDELibs4Support to KWidgetAddons. ahmadsamir added a comment. Link to KF6 task REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=77903&

D28124: Port away from deprecated QSet methods

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, cfeck. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest (some unit tests fail but are unrelated, as they fail on master too). REPOSITORY R236 KWidgetsAddo

D28124: Port away from deprecated QSet methods

This revision was automatically updated to reflect the committed changes. Closed by commit R236:8d993d727fce: Port away from deprecated QSet methods (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28124?vs=77911&id=77928 REVISI

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. In D27999#630193 , @dfaure wrote: > OK with me, but check with the fuse people. > > You test ssh, telnet etc but hasSchemeHandler is also true for at least http. While I was debugging this issue, I found th

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77964. ahmadsamir added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77538&id=77964 BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. In D27999#630329 , @dfaure wrote: > Only if an external browser is set, but yeah. Right, I missed the bit about the external browser; however with the recent change to fallback to mimeapps.list if external brow

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. In D27999#630756 , @feverfew wrote: > Quick testing with `fish` protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with `smb` it's an all good from the "KIOFuse people" ;) >

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

This revision was automatically updated to reflect the committed changes. Closed by commit R241:14b7f2c7ee72: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, sitter, apol. Herald added projects: Dolphin, Frameworks. Herald added a subscriber: kfm-devel. ahmadsamir requested review of this revision. TEST PLAN Showing man pages in konqueror still works REPOSITORY R320 KIO Extras

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. (Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)). REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.k

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631237 , @kossebau wrote: > Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. In D27999#631255 , @dfaure wrote: > This commit breaks krununittest in CI, can you take a look? > > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/471/testRepor

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. OK, I see why it's failing. KMimeTypeTrader::self()->preferredService() (from schemeService()) can't find ktelnetservice5.desktop in /usr/share/applications/ since KIO isn't installed on the CI system; so skip the test in that case? REPOSITORY R241 KIO REVISION

D28169: [DesktopExecParser] Let the service open protocols is claims to support

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, feverfew, ngraham. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This reverts commit 14b7f2c7ee72b

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. See D28169 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78124. ahmadsamir added a comment. - Rename to KFontChooserDialog to prevent conflict with the one from KDELibs4Support - Document "features" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=77904&id

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631254 , @kossebau wrote: > Please also add a note in the documentation when to use new-name-of-KFontDialog and when QFontDialog, i.e. in which use-cases new-name-of-KFontDialog is superior and not usi

D28169: [DesktopExecParser] Let the service open protocols is claims to support

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:350 > Doesn't this break the special case in the comment below? > VLC claims to support smb:// but if we have a password, we need to be able to > pass it, so we want to use KIOFuse? > > And then if you fix

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78152. ahmadsamir retitled this revision from "[DesktopExecParser] Let the service open protocols is claims to support" to "[krununittest] Skip the test if ktelnetservice5{,.desktop} isn't found". ahmadsamir edited the test plan for this revision. ahmadsam

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78153. ahmadsamir added a comment. Tweak docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78124&id=78153 BRANCH l-kfontdlg (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

ahmadsamir updated this revision to Diff 78154. ahmadsamir added a comment. clang-format only, less prone to errors, as the level of stupidity of the tool is locked at the compile time of the tool (unlike manual changes) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.k

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78155. ahmadsamir retitled this revision from "GIT_SILENT clang-format kpasswdserver.* plus some manual changes" to "GIT_SILENT clang-format kpasswdserver.*". ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir added a comment. In D28169#631809 , @dfaure wrote: > Ah, we had tried already to make it work uninstalled. > > The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just did

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78156. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28169?vs=78152&id=78156 BRANCH l-krun-ssh-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28169 AFFE

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78157. ahmadsamir added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78155&id=78157 BRANCH l-kpasswdserver-clang-format (branched from master) REVISION DETAIL https://phabrica

D28097: GIT_SILENT clang-format kpasswdserver.*

This revision was automatically updated to reflect the committed changes. Closed by commit R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.* (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78157&id=78158 REVISION DETAIL

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28169#631885 , @dfaure wrote: > OK, it's fixed now, after 3 commits :-) > You can drop this change, it's better that CI actually tests the code. [..] Yesterday, I did

D28186: GIT_SILENT break long lines for readability; add braces around if

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code still compiles. REPOSITORY R241 KIO BRANCH l-kpasswdserver-long-lines (branched from master) REVISION DETA

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir updated this revision to Diff 78171. ahmadsamir retitled this revision from "GIT_SILENT break long lines for readability; add braces around if" to "GIT_SILENT kpasswdserver, break long lines for readability; add braces around if". ahmadsamir added a comment. Verbatim REPOSITORY

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir added a comment. In D28186#631962 , @dfaure wrote: > Nice. > > clang-format can't be configured to add missing braces, Nope, I'd have had to use clang-format (which requires a "compilation server", I read some docs, searche

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d644f8f2eb5: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D28191: [KFontChooser] General code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Use new connect syntax - Prefix increment where appropriate - Replace foreach/iterator-based for

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in KFontChooser::Private m

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure, davidedmundson, apol Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

D28187: KIO DesktopExecParser: simplify code

ahmadsamir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28187 To: dfaure, ahmadsamir, feverfew, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28187: KIO DesktopExecParser: simplify code

ahmadsamir added a comment. Neat. The logic all seems to hold: We have no urls: - if it's a local file, useKioexec is false, and no fuse since "requests" will be empty - if it's not a local file, useKioexec is true, and we try fuse; if there's an error with fuse fallback to k

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

ahmadsamir added a comment. It was failing locally for me too, both when I had /tmp as tmpfs and when I changed it to be a regular dir on /; /home is a separate partition on my system. So I didn't understand how the test passed on the CI. FTR, I build KIO on a regular mechanical/spinning

D28206: Port QList/QSet deprecated methods

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-fromlist (branched from master) REVISION DETAIL https://phabric

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78241. ahmadsamir retitled this revision from "Move/port KFontDialog from KDELibs4Support to KWidgetAddons" to "Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog". ahmadsamir edited the summary of this revision. ahmadsamir edit

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir marked 6 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.h:89 > The usual way in Qt API is that the parent is the last argument, rather than > the first. > > But for this to be convenient, the fontlist argument would hav

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78249. ahmadsamir marked an inline comment as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Update the screenshot in the docs, Breeze style/colors REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://

D28206: Port QList/QSet deprecated methods

This revision was automatically updated to reflect the committed changes. Closed by commit R241:37686fd70359: Port QList/QSet deprecated methods (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28206?vs=78239&id=78250 REVISION DETAIL htt

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78251. ahmadsamir added a comment. @param should have the same order as the in the ctor declaration (patterns make life slightly easier) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78249&id=78251

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.h:81 > Do @param need to be in order of the arguments? (I'm not sure) They should be, it's more logical. > dfaure wrote in kfontchooserdialog.h:89 > Good call. I c

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

ahmadsamir added a comment. In D28184#632547 , @dfaure wrote: > In D28184#632459 , @ahmadsamir wrote: > > > It was failing locally for me too, both when I had /tmp as tmpfs and when I changed it to

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

This revision was automatically updated to reflect the committed changes. ahmadsamir marked 2 inline comments as done. Closed by commit R236:2e9cace39272: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHA

D27811: [KConfigGui] Check font weight when clearing styleName property

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ec9522ae73ff: [KConfigGui] Check font weight when clearing styleName property (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27811?vs=7687

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78265. ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78190&id=78265 BRANCH l-kfontchooser (branched from master) REVISION D

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78266. ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78192&id=78266 BRANCH l-kfontchooser-2 (branched from master) REVISION

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78295. ahmadsamir added a comment. Make connect() actually work for the QCheckBoxes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78265&id=78295 BRANCH l-kfontchooser (branched from master) REVIS

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78299. ahmadsamir added a comment. Also enable size spinbox when enabling the size list box REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78295&id=78299 BRANCH l-kfontchooser (branched from master

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

ahmadsamir added inline comments. INLINE COMMENTS > commandlauncherjobtest.cpp:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David Faure > + same. > commandlauncherjobtest.h:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in kfontchooserdialog.cpp:93 > Shouldn't this be not commented IIUC, if a function is declared static inside the class body (e.g. in the header file), the static keyword can't be repeated when it's defined outside the class body.

D28244: GIT_SILENT minor code formatting

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28244 AFF

  1   2   3   4   5   6   7   8   9   10   >