D26373: Port endl to \n

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol added inline comments. INLINE COMMENTS > kuitmarkup.cpp:412 > // Normalize key, trim and all lower-case. > -QString nkey = keys[i].trimmed().toLower(); > +const QString nkey = keys.at(i).trimmed().toLower(); > keys[i] = keyNames.contains(nkey) ? > keyNames[

D26359: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26359 To: ahmadsamir, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26358: KIO/SMB convert kio protocol declaration to json format

apol added inline comments. INLINE COMMENTS > kio_smb.cpp:42 > +Q_OBJECT > +Q_PLUGIN_METADATA(IID "org.kde.kio.slave.smb" FILE "smb.json") > +}; Shouldn't this go in the SMBSlave class? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frame

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D26302: Port endl to "\n" + flush at the end

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26299: endl is namespaced in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH compile_against_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26299 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26318 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26319: Port endl to \n (QFile flushs data when deleted)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26319 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

apol added inline comments. INLINE COMMENTS > CppGenerator.cpp:61 > writeCopyrightHeader(stream); > -stream << "#pragma once" << endl << endl; > -stream << "#include " << endl << endl; > -stream << "class QDBusObjectPath;" << endl << endl; > -stream << "na

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol added inline comments. INLINE COMMENTS > scalabletest.cpp:312 > QTextStream stream(&msg); > -stream << "Duplicated scalable icons:" << endl; > -for (auto icon : duplicatedScalableIcons.keys()) { > -stream << QString(" %1:").arg(icon) << e

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol added inline comments. INLINE COMMENTS > plugintest.cpp:60 > > -cout << "-- KPluginTrader Test --" << endl; > +cout << "-- KPluginTrader Test --" > +#if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) std::endl should just work with cout. REPOSITORY R309 KService REVISION DE

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pidgin_emoticons.cpp:221 > +out << QStringLiteral("Description=") + themeName() << "\n"; > +out << "Author=" << "\n"; > +out << "\n"; Put it in the same string

D26299: endl is namespaced in qt5.15

apol added inline comments. INLINE COMMENTS > prison-datamatrix.cpp:39 >QTextStream str(stdout); > - str << error << ": " << errormessage << endl; > + str << error << ": " << errormessage > + #if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) Wouldn't make more sense to port to std::endl

D26294: Allow to load widget based KCMs from kcms subdir

apol added a comment. It would be useful if you were a bit more explicit about how you tested it on the commit message. INLINE COMMENTS > kcmoduleloader.cpp:103 > if (!cm) { > +module = factory->create(parent, args2); > +if (module) {

D26055: Enable wheel events on Slider {}

This revision was automatically updated to reflect the committed changes. Closed by commit R242:66122410a11d: Enable wheel events on Slider {} (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71744&id=72405 REVISI

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

apol added a comment. Not saying that this patch is wrong, would have to look into it more closely. But for knsrc files you want to use KDE_INSTALL_KNSRCDIR anyway, which will fall into /usr. INLINE COMMENTS > KDEInstallDirs.cmake:376 > +list(FIND _gnu_install_special_vars "${va

D26227: Port to QRandomGenerator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26227 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in klistopenfilesjob_unix.cpp:69 > I didn't even know there was a splitRef... > > It'll have to be something like: > > QVector pidList = > out.splitRef

D26211: Port QRegExp to QRegularExpression

apol added a comment. Looks good otherwise INLINE COMMENTS > parsetrigrams.cpp:59 > +if (match.hasMatch()) { > +models[fname][line.left(3)] = match.captured(2).toInt(); > } capturedRef REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.k

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

apol added a comment. Looks good overall INLINE COMMENTS > klistopenfilesjob_unix.cpp:69 > const QString out(QString::fromLocal8Bit(lsofProcess.readAll())); > -QStringList pidList = out.split(QRegExp(QStringLiteral("\\s+")), > QString::SkipEmptyParts); > +QStringList

D26205: KWallet: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D26198: Deprecate KCModuleContainer

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH container REVISION DETAIL https://phabricator.kde.org/D26198 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26194: Port QRegExp to QRegularExpression

apol added a comment. LGTM otherwise INLINE COMMENTS > runnercontext.cpp:575 > for (const QString& entry : cfgList) { > -r.indexIn(entry); > -int count = r.cap(1).toInt(); > -QString id = r.cap(2); > +QRegularExpressionMatch match = re.match(entry); > +

D26133: Enable Auto Save

apol added inline comments. INLINE COMMENTS > test_signal.h.ref:137 > +/** Triggered whenever a setting changes */ > +void configurationChanged(); > + How about having `isSaveNeededChanged(bool)`? It could be in KCoreConfigSkeleton. > kconfig_compiler.cpp:2121 > } > -

D26148: Add truncation support to FileJob

apol added a comment. It would be interesting to explain why it's important or how it's to be used in the commit message. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, f

D26136: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, G

D26188: Port to QRandomGenerator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26188 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB

D26187: QMultiHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH insertmulti_is_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D26187 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26126: Simplify param method: Return Early, Use a Map and Assert.

apol added a comment. Why are you concerned about thread safety in the kconfig compiler? :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

apol added inline comments. INLINE COMMENTS > plasmashell_interface.h:178 > **/ > +//TODO KF6 rename to something generic > bool panelTakesFocus() const; How about we rename now and deprecate this one? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D261

D26106: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26136: Port QRegExp to QRegularExpression

apol added a comment. It didn't update here? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26156: [KDocTools] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in docbookl10nhelper.cpp:184 > I did it that way to indicate match is going to be re-assigned-to later on, > but it does look off a bit. :) The way of say

D26170: i18n: Add more semantic context strings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH i18n-more-msgctxt REVISION DETAIL https://phabricator.kde.org/D26170 To: aspotashev, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26158: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26158 To: ahmadsamir, #baloo, bruns, apol Cc: kde-frameworks-devel, #baloo, hurikhan7

D26156: [KDocTools] Port QRegExp to QRegularExpression

apol added a comment. LGTM otherwise INLINE COMMENTS > docbookl10nhelper.cpp:158 > **/ > -QRegExp rxEntity, rxEntity2, rxDocType, rxDocType2; > - > rxDocType.setPattern(QStringLiteral("^\\s* - > rxDocType2.setPattern(QStringLiteral("^\\s*$")); > - > rxEntity.setPattern(Q

D26145: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26145 To: ahmadsamir, mlaurent, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26137: Add KPluginMetaData::supportsMimeType

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26137 To: dfaure, arichardson, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

apol added a comment. I'm a bit confused as to why the regex needs to be different. Explain in the commit message? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D26133: Enable Auto Save

apol added a comment. It could make sense to add a test. Also for an application (system settings or kconfig dialogs) it's already possible to just trigger save when the kcm has changed (we already have signals for this). Why do you think it's needed? REPOSITORY R237 KConfig REVISION

D26122: Add utility text function KShell::tildeCollapse

apol added a comment. I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ng

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

apol added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:1122 > +// Types that `{}` are ok as return type for default value. > +if (QVector({ > +QLatin1String("stringlist"), If instead of creating a QVector you used an initializer list directly, you could use std::find

D26126: Simplify param method: Return Early, Use a Map and Assert.

apol added a comment. I'd make the types static const, or at least const. Also are you sure that here std::map is better than QHash? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D12172: Android: Also install plugins, otherwise they are just not available

apol abandoned this revision. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12172 To: apol, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, vkrause, LeGast00n, GB_2, benc

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71744. apol added a comment. Just never draw over 20 ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71742&id=71744 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 A

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71742. apol added a comment. don't show too many ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71741&id=71742 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFEC

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71741. apol added a comment. Include test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71685&id=71741 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFECTED FILES s

D26061: QHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH use_qmultihash_direcly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26061 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26057: Deprecate the top-level IconSize() function

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY So far PC3 version of the slider doesn't react to events, this change enables it. TE

D26044: Set breeze as default theme when reading from configuration file

apol added a comment. LGTM otherwise INLINE COMMENTS > kiconloader.cpp:564 > const QString newThemeName = sharedConfig->group("Icons") > - .readEntry("Theme", > QString()); > + .readEntry("Theme"

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. In D13541#578027 , @bcooksley wrote: > This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ fixed REPOSITORY R245 Solid REVISION DETAIL ht

D25972: Support PyQt5 compiled with SIP 5

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25972 To: arojas, bruns, dfaure, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham

D25922: Don't use a verified nullptr as a data source

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH dont-use-null-qcoreapp-instance (branched from master) REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol Cc: kde-framewo

D13541: Port solid from Qt5::Widgets to Qt5::Gui

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui (authored by graesslin, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13541?vs=36167&id=71569#toc REPOSITORY R245

D25972: Support PyQt5 compiled with SIP 5

apol added a comment. LGTM overall INLINE COMMENTS > FindPythonModuleGeneration.cmake:312 >NAMES QtCoremod.sip > + PATHS ${KDE_INSTALL_PYTHON3DIR}/PyQt5/bindings/QtCore >PATH_SUFFIXES share/sip/PyQt5/QtCore Should probably be HINTS. REPOSITORY R240 Extra CMake Modules REVISION D

D25434: [plasma-framework] port away from deprecated KF5 APIs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'd say we could make it so setupEngine knows itself that it's already been set up. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/

D25965: [plasmashell] Add signal for panelTakesFocus changing

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, provided that the rest make sense. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D25965 To: davidedmundson, apol Cc: apol, kde-framewor

D25953: Ignore parent scopes that are in the process of being removed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:208b94365ce0: Ignore parent scopes that are in the process of being removed (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25

D25953: Ignore parent scopes that are in the process of being removed

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY When we destroy a colorscope, all children will try to reparent. This patch makes it so they

D25918: Consistently define the tooltip delay

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c33fcaa8d747: Consistently define the tooltip delay (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25918?vs=71352&id=71443 R

D25918: Consistently define the tooltip delay

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Set the right value on the Kirigami.Units and use it from tooltip. REPOSITORY R242 Plasma Fr

D25858: Use QStyle for determining icon sizes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25824: Support archive installs with adoption commands

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH support-archive-installs-in-use-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D25824 To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham Cc:

D25827: kcodecs EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25827 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25829: kconfig EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25829 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25824: Support archive installs with adoption commands

apol added inline comments. INLINE COMMENTS > engine.cpp:744 > +const QDir dir(currentPath); > if (dir.path()==(rootPath+dir.dirName())) { > +qCDebug(KNEWSTUFFCORE) << "Found directory" << dir; Shouldn't we make sure rootPath ends with /? at least with an ASSERT if w

D25727: Expose enum to the metaobject compiler

apol added a comment. Had to revert the commit, it broke with GCC. https://commits.kde.org/kpeople/b495b1a260cd15463a03ee47614b783ae8c2203d REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj, davidedmundson

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol added a comment. Plasma master can depend on kf5 master. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25727: Expose enum to the metaobject compiler

This revision was automatically updated to reflect the committed changes. Closed by commit R307:508b1bab207e: Expose enum to the metaobject compiler (authored by apol). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70997&id=71093 REVISION DETAIL h

D25775: Check cursor_open return value

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25775 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, #baloo, hurikhan77, lots0log

D14218: Introduce a test to make sure we're not offering duplicated icons

apol abandoned this revision. apol added a comment. Doesn't seem relevant anymore REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n, GB_2,

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70997. apol added a comment. Alternative approach without Q_NAMESPACE_EXPORT, which is too new REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70895&id=70997 BRANCH arcpatch-D25727 REVISION DETAIL https://pha

D25755: Replace iterators with range-based for

apol added a comment. In D25755#572575 , @broulik wrote: > In D25755#572418 , @apol wrote: > > > Do we dislike iterators now? > > > We don't, and they still make sense for when you need the `key

D25757: EBN purpose constructor cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25757 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. I see this patch still works and applies. I'd say landing it would still make sense. If nobody disagrees I'll do so in a week. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhau

D22577: Remove unused pnm.desktop file

apol closed this revision. apol added a comment. This patch was already applied REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D22577 To: rempt, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

apol added a comment. Do we dislike iterators now? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25754: Refactor KHistoryComboBox::insertItems

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH refa REVISION DETAIL https://phabricator.kde.org/D25754 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25752: EBN extra-cmake-modules comments spelling cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-spelling-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25752 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB

D25753: EBN extra-cmake-modules transport cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, G

D25746: Adapt to change in KConfigCompiler

This revision was automatically updated to reflect the committed changes. Closed by commit R296:12b3c947a8a4: Adapt to change in KConfigCompiler (authored by apol). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25746?vs=70912&id=70921 REVISION DETAIL

D25746: Adapt to change in KConfigCompiler

apol added a comment. I'll land this for now because the alternative is to have this not working. Maybe it would make sense to include a KConfigSkeletonItem::propertyName property? Or even a KConfigSkeletonItem::notifySignal(KConfigSkeleton*)? Then here we could just consume the info

D25746: Adapt to change in KConfigCompiler

apol created this revision. apol added reviewers: Frameworks, tcanabrava, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Properties need to start with lower-case letters, otherwise QML won't u

D25734: MAke it compile without deprecated method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH make_it_compile_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D25734 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70895. apol added a comment. Export the namespace REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70872&id=70895 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25727 AFFECTED FILES src/declarat

D25727: Expose enum to the metaobject compiler

apol created this revision. apol added a reviewer: jbbgameich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Should Help the PersonActionsModel work on QML REPOSITORY R307 KPeople BRANCH master

D25620: Register ActionType enum with metaobject system

apol added a comment. Hi, thanks for your patience. Can you check if this works? https://phabricator.kde.org/D25727 Can you share a test case that uses it? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel

D25721: EBN kdeclarative transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25721 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

apol added a comment. +1 it doesn't seem to me that shift+delete is used elsewhere. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25719: EBN KActivites transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25719 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: mpyne, jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

apol added a comment. What do you mean by `Can easily be done otherwise.`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25704: [kfilewidget] Load icons by name

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH icco REVISION DETAIL https://phabricator.kde.org/D25704 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

apol added a comment. +1 Makes sense to me REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev

D25671: Fix git builds against Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706&id=70734 REVISION

<    1   2   3   4   5   6   7   8   9   10   >