Re: Review Request 121090: Move kio-mtp to kio-extras

2014-11-12 Thread Aleix Pol Gonzalez
On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Well, there's important kio's as well in kio-extras. Question is, is it useful outside the

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread Aleix Pol Gonzalez
). Albert Astals Cid wrote: But what's the point? now if i want to provide that feature i need to pull a bazillion of dependencies instead of just KEmoticons. KMessageBox don't show again is actually an integration feature, is this feature one? Aleix Pol Gonzalez wrote: I guess what Albert

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
it won't be slower because we were not really parallelizing much, given that we were avoiding to create different containments at the same time. One thing to look into after this is whether we can somehow batch-incubate the plasmoids within a same containment. - Aleix Pol Gonzalez On Nov. 13, 2014

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
On Nov. 13, 2014, 11:44 p.m., Albert Astals Cid wrote: +1 If you have to be blocking, use the proper blocking methods. Obviosuly it'd be better if no blocking call is used but since i know nothing about the code i'll just shut up now :D We've been going through the code with david

Re: Review Request 121143: add translationDomain for katepartui.rc

2014-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121143/#review70477 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Nov

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-16 Thread Aleix Pol Gonzalez
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/#review70632 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 18, 2014

Re: Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/#review70672 --- +1 looks good to me. - Aleix Pol Gonzalez On Nov. 19, 2014

Re: Review Request 121238: Add support for more multimedia keys

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121238/#review70886 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 25, 2014

Re: Review Request 121063: use correct ki18n_wrap_ui in ki18n based framework

2014-11-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121063/#review71065 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 2

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
after this? - Aleix Pol Gonzalez On Dec. 1, 2014, 4:56 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: Have you checked if the Background Services kded still works after this? Sorry, I meant KCM. - Aleix --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: Have you checked if the Background Services kded still works after this? Aleix Pol Gonzalez wrote: Sorry, I meant KCM. Alexander Richardson wrote: `grep -irn background /kf5-install/share/kservices5/kded` does not give

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Aleix Pol Gonzalez
proficient in this project to review the change. - Aleix Pol Gonzalez On Sept. 27, 2014, 11:59 a.m., Arjun AK wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388

Re: Review Request 121446: Ignore child mtp devices

2014-12-11 Thread Aleix Pol Gonzalez
to be. - Aleix Pol Gonzalez On Dec. 11, 2014, 1:05 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121446

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Aleix Pol Gonzalez
reasonably easy to create ecm tests nowadays and very useful afterwards. You'll see some examples in the repository. By the way, thanks for looking into this, really needed! - Aleix Pol Gonzalez On Dec. 11, 2014, 3:40 p.m., Ralf Habacker wrote

Re: Review Request 121495: Fix build if the X11 headers are not located in /usr/include

2014-12-14 Thread Aleix Pol Gonzalez
/#comment50207 Note there might be an include_directories(${XCB_...}) that can be removed now. +1 Makes sense! - Aleix Pol Gonzalez On Dec. 14, 2014, 3:43 a.m., Alexander Richardson wrote: --- This is an automatically

Re: Review Request 121581: Plotter in kdeclarative

2014-12-17 Thread Aleix Pol Gonzalez
an example application we can look at to test small things or just learn how to use it. Last, have you looked at the plotting component developed for ktouch? Is it comparable in any way? I'd love to duplicate there. https://projects.kde.org/projects/kde/kdeedu/kqtquickcharts/repository Thanks! - Aleix

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

2014-12-28 Thread Aleix Pol Gonzalez
On Dec. 28, 2014, 12:19 p.m., David Faure wrote: Ouch. This information *is* available, in the servicetype definition file. Why not try and read it from there? Alex Richardson wrote: Well, it only works once these files are installed. This is probably not be the case when

Re: Review Request 121618: Better name for kdoctools translation domain

2014-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121618/#review72642 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 28, 2014

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread Aleix Pol Gonzalez
QString(char* ) wasn't allowed in frameworks. - Aleix Pol Gonzalez On Dec. 29, 2014, 10:38 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-02 Thread Aleix Pol Gonzalez
On Jan. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote: We used to do this. It was removed because somebody (can't remember) considered it was misleading that the API would do things by itself. I would welcome this (as well as the --help) but I'd like to hear what others think

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-02 Thread Aleix Pol Gonzalez
remember) considered it was misleading that the API would do things by itself. I would welcome this (as well as the --help) but I'd like to hear what others think. - Aleix Pol Gonzalez On Jan. 2, 2015, 3:12 p.m., Albert Astals Cid wrote

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-02 Thread Aleix Pol Gonzalez
? Many applications are adding explicitly the addHelpOption, so with this they might get it twice? - Aleix Pol Gonzalez On Jan. 2, 2015, 3:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-04 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122359/#comment52173 maybe you want to add an option() call so it appears on ccmake as ON/OFF? modules/ecm_uninstall.cmake.in https://git.reviewboard.kde.org/r/122359/#comment52174 +1 - Aleix Pol Gonzalez On Feb. 3, 2015, 9:19 p.m., Alex Merry wrote

Review Request 122383: Remove internal copy of KXmlRpcClient

2015-02-02 Thread Aleix Pol Gonzalez
/COPYING.BSD cca2a5c Diff: https://git.reviewboard.kde.org/r/122383/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-06 Thread Aleix Pol Gonzalez
, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122482: Restore KCModule::setAuthAction

2015-02-08 Thread Aleix Pol Gonzalez
/#comment52293 else qWarning() invalid authorization ? Or something? - Aleix Pol Gonzalez On Feb. 8, 2015, 5:25 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 122495: CMake nitpicking on KDiagram

2015-02-08 Thread Aleix Pol Gonzalez
pulling Qt5::Gui. Diffs - src/KChart/CMakeLists.txt 06f3846 src/KGantt/CMakeLists.txt 25d198f CMakeLists.txt 76a7c50 Diff: https://git.reviewboard.kde.org/r/122495/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

2015-01-19 Thread Aleix Pol Gonzalez
On Jan. 19, 2015, 6:08 p.m., David Faure wrote: That's one option, and a good one for compat. The other option is to change the callers to pass a single dash instead, then Qt will process such options automatically - right? Aleix Pol Gonzalez wrote: Yes, but then we can't

Re: Review Request 122194: Initialise all member variables

2015-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/#review74512 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 21, 2015

Re: Review Request 122096: Fix build if epoxy headers are not installed to the default include dir

2015-01-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122096/#review74195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 17, 2015

Re: Review Request 121562: Fix build with Qt 5.5/dev branch in release mode

2015-01-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121562/#review74197 --- Ship it! - Aleix Pol Gonzalez On Jan. 17, 2015, 5:15 p.m

Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

2015-01-19 Thread Aleix Pol Gonzalez
98e646b Diff: https://git.reviewboard.kde.org/r/122149/diff/ Testing --- Ran it again, now it doesn't complain. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

2015-01-19 Thread Aleix Pol Gonzalez
--- On Jan. 19, 2015, 4:21 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122149

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74075 --- +1 Makes sense to me :) - Aleix Pol Gonzalez On Jan. 15

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Aleix Pol Gonzalez
-) or is it? - Aleix Pol Gonzalez On Jan. 22, 2015, 7:34 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Aleix Pol Gonzalez
On Jan. 23, 2015, 12:11 a.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible

Re: Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

2015-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122180/#review74480 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 21, 2015

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122514/diff/ Testing --- Builds, tests still pass. Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122526/#comment52364 You want to use HINTS instead of PATHS. Also wouldn't it make sense to have QtWayland exporting the scanner as a target? - Aleix Pol Gonzalez On Feb. 11, 2015, 2:39 p.m., Jonathan Riddell wrote

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-10 Thread Aleix Pol Gonzalez
, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/#review75897 --- +1 and +1 to the script. - Aleix Pol Gonzalez On Feb. 12

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76203 --- +1 Looks good to me. - Aleix Pol Gonzalez On Feb. 8, 2015

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75956 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 12, 2015

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- +1 What's the status of QtSpeech? - Aleix Pol Gonzalez

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2015

Re: Review Request 122642: an include is not correct

2015-02-19 Thread Aleix Pol Gonzalez
changed. - Aleix Pol Gonzalez On Feb. 19, 2015, 7:11 p.m., Guy Maurel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122642

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

2015-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73609 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 9, 2015, 3

Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
/ktoolbarhandler.cpp 83c77bd src/kxmlgui.xsd bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

2015-01-09 Thread Aleix Pol Gonzalez
parameter? It doesn't look like it needs to be re-used so it's fine like that as well. - Aleix Pol Gonzalez On Jan. 9, 2015, 4:33 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Aleix Pol Gonzalez
/#comment50989 Unrelated. And why? Other than that, +1. - Aleix Pol Gonzalez On Jan. 6, 2015, 11:55 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/#review73670 --- On Jan. 9, 2015, 4:27 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122495: CMake nitpicking on KDiagram

2015-02-09 Thread Aleix Pol Gonzalez
builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-02-08 Thread Aleix Pol Gonzalez
On Feb. 8, 2015, 9:45 p.m., David Faure wrote: Which magic tool did you come up with this time, to detect such things? :-) +1 :D I too want to know! - Aleix --- This is an automatically generated e-mail. To reply, visit:

Review Request 122562: Add method for converting from QVariant to base64

2015-02-13 Thread Aleix Pol Gonzalez
src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d Diff: https://git.reviewboard.kde.org/r/122562/diff/ Testing --- Adopted locally in my QuickShare plasmoid implementation Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-12 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122514/diff/ Testing --- Builds, tests still pass. Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Re: Review Request 122576: Introduce KMoreTools

2015-02-16 Thread Aleix Pol Gonzalez
/#comment52515 I don't think this class is enough reason to make KService depend on QtWidgets. tests/kmoretools/kmoretoolstest.cpp https://git.reviewboard.kde.org/r/122576/#comment52516 // ...? I like the feature though, I'm sure we'll be able to find it the correct spot. - Aleix Pol

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
! Did you forget to git add the file? - Aleix Pol Gonzalez On Jan. 4, 2015, 3:21 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121836/#review73098 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 4, 2015, 3

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/#review73105 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 5, 2015

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
- src/kioexec/CMakeLists.txt 1f08845 Diff: https://git.reviewboard.kde.org/r/121895/diff/ Testing --- Now it builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121907: Small code review

2015-01-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/#review73461 --- On Jan. 8, 2015, 2:08 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
a logging_conf if they prefer. Aleix Pol Gonzalez wrote: I'm unsure how to do that. Ideas? Martin Klapetek wrote: Maybe just replace it with QLoggingCategory::setFilterRules(*.debug=false) in main? That still gives QT_LOGGING_CONF and QT_LOGGING_RULES to overwrite it. That's

Review Request 121907: Small code review

2015-01-07 Thread Aleix Pol Gonzalez
/diff/ Testing --- Test still passes, if I don't remove teh ~/.qt-test as discussed in the kde-frameworks list. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
--- On Jan. 7, 2015, 5:57 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903

Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
though. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
/121895/diff/ Testing --- Now it builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122960: Let KXmlGui be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122960/#review77492 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122958: Let KTextWidgets be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122958/#review77491 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122957: Let KService be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122957/#review77490 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122848: Drop all find_dependancy calls from KDED cmake config

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122848/#review77487 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122956: Let KParts be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122956/#review77489 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122951: Let KEmoticons be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122951/#review77488 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Aleix Pol Gonzalez
On March 17, 2015, 4:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/#review77698 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 123032: Search for public dep in KPeople's cmake config

2015-03-18 Thread Aleix Pol Gonzalez
this is correct... - Aleix Pol Gonzalez On March 18, 2015, 6:34 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032

Re: Review Request 122844: Let KPty be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122844/#review77140 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122848: Make KDED's config search for KDBusAddons

2015-03-06 Thread Aleix Pol Gonzalez
it the application only? - Aleix Pol Gonzalez On March 6, 2015, 9:42 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122848

Re: Review Request 122847: Let KConfigWidgets be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122847/#review77138 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122848: Make KDED's config search for KDBusAddons

2015-03-06 Thread Aleix Pol Gonzalez
On March 7, 2015, 12:46 a.m., Aleix Pol Gonzalez wrote: What's the purpose of looking for KDED? Isn't it the application only? Hrvoje Senjan wrote: only 2 uses i know are within plasma-desktop and kde-baseapps, to get KDED_DBUS_INTERFACE variable... Ok then why look for anything

Re: Review Request 122845: Let KUnitConversion be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122845/#review77141 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122846: Let KCMUtils be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122846/#review77139 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122876: Delay notifications a bit on Plasma startup

2015-03-09 Thread Aleix Pol Gonzalez
? (We do that, right? show the notifications after going out of lock). Having a timer is kind of hacky... - Aleix Pol Gonzalez On March 9, 2015, 8:03 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 122832: Let KDocTools be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122832/#review77075 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122832: Let KDocTools be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
On March 6, 2015, 12:10 a.m., Luigi Toscano wrote: I'm not exactly a cmake expert, is it about the exported symbols of KDocTools? It's not needed, it's mainly so that when a project is compiled, you still know what include directories to use. - Aleix

Re: Review Request 122829: Let KCompletion be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122829/#review77072 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122833: Let KJobWidgets be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122833/#review77074 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-05 Thread Aleix Pol Gonzalez
/#comment52973 The find_package shouldn't change, why does it need KConfig now? Isn't it pulled by KConfigWidgets? +1. Removing an include has happened before in a couple of places already, both in Qt and KF5. I don't think it's a big problem. - Aleix Pol Gonzalez On March 5, 2015, 8:41 p.m

Re: Review Request 122830: Let KCrash be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122830/#review77073 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122843: Remove redundant build interface.

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/#review77120 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122843/#comment52991 Isn't this redundant, then? - Aleix Pol Gonzalez On March 6, 2015, 5:07 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Aleix Pol Gonzalez
On March 6, 2015, 5:17 p.m., Aleix Pol Gonzalez wrote: src/quickaddons/CMakeLists.txt, line 22 https://git.reviewboard.kde.org/r/122843/diff/1/?file=353379#file353379line22 Isn't this redundant, then? Michael Palimaka wrote: It builds fine with it removed. I don't know

Re: Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

2015-03-13 Thread Aleix Pol Gonzalez
marked as submitted. Review request for kdeconnect and KDE Frameworks. Changes --- Submitted with commit 15408e74d633df4e505bd85bfdff6ee6ef6624c6 by Aleix Pol to branch master. Repository: kcmutils Description --- KCMs make it possible to receive a list of arguments we're

Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

2015-03-10 Thread Aleix Pol Gonzalez
/kpluginselector.cpp 98ab59e src/kpluginselector_p.h d80cd2e Diff: https://git.reviewboard.kde.org/r/122900/diff/ Testing --- Tested over at kdeconnect, where we need this. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-12 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122913/#comment53119 Those should be QStringLiteral, as you are constructing a QString. - Aleix Pol Gonzalez On March 12, 2015, 4:37 a.m., Albert Vaca Cintora wrote: --- This is an automatically generated e-mail

<    7   8   9   10   11   12   13   14   15   16   >