> On Aug. 3, 2016, 3:32 a.m., Aleix Pol Gonzalez wrote:
> > I think that changing maintainership is fine, I'm not convinced that the
> > work done so far is enough to consider it up to speed.
>
> David Faure wrote:
> Can you give more details about what y
-packagestructure.json 4da86a8
src/plasma/packagestructure/plasmatheme-packagestructure.json c56a68d
src/plasma/packagestructure/plasmoid-packagestructure.json e9f4155
Diff: https://git.reviewboard.kde.org/r/128604/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 67d882037c8919dc62a0da23a02f965d1fa67db7 by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
This way we can use kpackagetool5 against them (see review 128590
Diff: https://git.reviewboard.kde.org/r/128603/diff/
Testing
---
All components in plasma-workspace and plasma-desktop are addons now, after
modifying locally the packagestructure metadata files.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128533/#review98075
---
ping?
- Aleix Pol Gonzalez
On July 28, 2016, 5:15 p.m
marked as submitted.
Review request for KDE Frameworks, Plasma, Matthias Klumpp, and Harald Sitter.
Changes
---
Submitted with commit 469f5a0a0bf7c9e99a8447af2bfa8789dbef145c by Aleix Pol to
branch master.
Repository: kpackage
Description
---
We want our components to be exposed
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128289/#review96990
---
+1 LGTM
- Aleix Pol Gonzalez
On June 26, 2016, 12:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128238/#review96988
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 18
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128308/#review96989
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 28
still works. See bug report.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128336/#review96992
---
I just checked and it fixes the issue on neon.
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128344/#review97026
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 2, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128345/#review97027
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 2, 2016
marked as submitted.
Review request for KDE Frameworks, Dan Leinir Turthra Jensen and Jeremy Whiting.
Changes
---
Submitted with commit fc2e7f5865df1c2bd83dced01ba046b76382ce5b by Aleix Pol to
branch master.
Bugs: 364896
https://bugs.kde.org/show_bug.cgi?id=364896
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:15c638307a91: Make it possible to adopt resources, mostly
for system-wide settings (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
apol added a comment.
Changes are in KNS now, can someone please review the patch?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4307
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, whiting, leinir,
apol added a comment.
Same was done with the transient hint, btw. Maybe it would make sense to add
a comment pointing to the documentation this refers to?
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4416
EMAIL PREFERENCES
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4416
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
apol created this revision.
apol added reviewers: Frameworks, Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Makes it possible to specify commands that will put the resource in use, such
as
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
2
REVISION DETAIL
https://phabricator.kde.org/D4389
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vonreth, smartins, alexmerry,
apol created this revision.
apol added reviewers: Plasma, Frameworks, mart, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise toBool doesn't work.
I didn't see it called anywhere as
apol created this revision.
apol added reviewers: Plasma, Frameworks, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Only generate appdata information for the packages end-users are supposed to
know
apol added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:93
> +
> +if (d->inSandbox) {
> +QDBusConnectionInterface *interface =
> QDBusConnection::sessionBus().interface();
Maybe instead of querying for dbus things we could figure out a what
QPlatformTheme is in use
discarded.
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
---
It shouldn't have an impact anymore.
Diffs
-
KF5PlasmaMacros.cmake 5827854
Diff: https://git.reviewboard.kde.org/r/129315/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
apol abandoned this revision.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, dfaure
Cc: shumski, anthonyfieroni, graesslin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6659517bce2d: Specify NoDisplay type (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4396?vs=10825=10852
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:102f68a42760: Don't generate appdata if it's marked as
NoDisplay (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4398?vs=10827=10853
REVISION
apol added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:56
>
> +bool inSandbox;
> +bool portalDBusServiceExists;
These could be a local variable, it's not being used outside for figuring out
the backend.
REPOSITORY
R289 KNotifications
REVISION DETAIL
apol added a comment.
Some coding style suggestions.
General +1.
INLINE COMMENTS
> knotificationmanager.cpp:85
> +const QString runtimeDir = qgetenv("XDG_RUNTIME_DIR");
> +if (!runtimeDir.isEmpty()) {
> +d->inSandbox = QFile::exists(runtimeDir +
>
apol added a comment.
In https://phabricator.kde.org/D4416#82951, @hein wrote:
> Gnome-only spec? Why aren't they contributing to fd.o?
That's most certainly not the best forum to discuss this.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d283d9f951fb: [KNS] Take into account the distribution
type (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4226?vs=10394=10449
REVISION
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> mart wrote in installation.h:137
> BIC
> even if the api of this file is beyond terrible, unfortunately it's exported,
> so no binary incompatible changes should occur
According to our BIC documentation:
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:3178240748c6: Don't block when running the post-install
command (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4227?vs=10396=10455#toc
REPOSITORY
R304 KNewStuff
CHANGES
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in installation.cpp:351
> I had to look multiple times to find what "f" is, can you make the name a bit
> more descriptive.
Good point. Will address this as I commit it.
REPOSITORY
R304
apol added a comment.
Please disregard the last message, I didn't mean to send that, I wrote it
some days ago.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol,
apol added inline comments.
INLINE COMMENTS
> dfaure wrote in kcrash.cpp:437
> You can't use QVector here. We're crashing, likely due to corrupted memory,
> the whole point of this code is to NOT do any memory allocation. You should
> revert to const char*[], or use something that always
matically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review102223
---
On Nov. 3, 2016, 2:06 a.m., Aleix Pol Gonzalez wrote:
>
> ---
> This i
apol updated this revision to Diff 10489.
apol added a comment.
Removed hover state as requested by David and Marco
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4214?vs=10379=10489
BRANCH
master
REVISION DETAIL
apol created this revision.
apol added reviewers: Frameworks, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Splits the logic into a separate binary, also cleans some unneeded code in
the KCM.
Introduces the
apol added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:565
> QPoint posi; // will be overwritten with the event's position
> -if (m_dropPoints.keys().contains(tjob)) {
> -posi = m_dropPoints[tjob];
> +if (m_dropPoints.contains(tjob)) {
> +
apol created this revision.
apol added reviewers: Frameworks, mart.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The process to install a kpackage package through knewstuff is:
- download to /tmp
- copy to /tmp with the desired filename
- call the install
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:95bb6fa8aabf: Don't fail when moving to the temp
directory when installing (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4320?vs=10644=10679
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129833/#review102322
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 14
?
- Aleix Pol Gonzalez
On Jan. 17, 2017, 11:47 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
apol created this revision.
apol added reviewers: Frameworks, leinir.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Otherwise we have an expression that doesn't do anything and possibly should
be removed altogether.
REPOSITORY
R304 KNewStuff
BRANCH
master
apol created this revision.
apol added reviewers: Frameworks, mart, leinir.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Which in fact is the install command for KPackages
BUG: 375287
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4213
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
apol added a reviewer: whiting.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D4227
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, mart, leinir, whiting
apol added a reviewer: whiting.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D4226
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, leinir, whiting
apol created this revision.
apol added reviewers: Frameworks, mart, whiting, leinir.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Using the same semantics as the InstallationCommand, makes it possible for the
client
apol added a comment.
In https://phabricator.kde.org/D4307#80774, @mart wrote:
> if this goes in, the stock knewstuff install dialog should use it as well
I'm not sure. In this specific case, if you're in the KNS Dialog means that
you already have the Wallpapers kcm open already,
it, turns out you are correct. :)
(also crappy API...)
- Aleix Pol Gonzalez
On Feb. 17, 2017, 12:23 a.m., Damjan Georgievski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboa
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4595
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure,
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
Otherwise the cmake cache has noisy values.
TEST PLAN
Recreated a project, it's not listed
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:54e87fe879ba: Make sure we display enabled ListItem on
hover (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4268
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, apol
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:3b0ee7dcf3fd: Fix appstream name/summary ends with '.'
warning (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4203?vs=10358=10464
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:2d6dc495fbe9: Don't ask if we're getting the file in /tmp
(authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4065?vs=9968=10350
REVISION DETAIL
apol updated the summary for this revision.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, dfaure
apol created this revision.
apol added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Puts in place a plugin system that exposes API to extract information to
send the handler. This allows us to de-couple from different modules that
need
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It's useful to be able to check the version and so.
TEST PLAN
Running `kglobalaccel5 --help` doesn't execute the service.
REPOSITORY
R268 KGlobalAccel
apol created this revision.
apol added reviewers: Frameworks, cgilles.
REVISION SUMMARY
libkexiv2/src/kexiv2_p.cpp:726:9: error: token is not a valid binary operator
in a preprocessor subexpression
TEST PLAN
Builds
REPOSITORY
R378 KExiv2 Library
BRANCH
master
REVISION DETAIL
apol added inline comments.
INLINE COMMENTS
> graesslin wrote in main.cpp:63
> Why did you scope the parser?
So that it frees the QCLP resources as we're not going to be using them
anymore. I agree it's not much, but also there's little reason to keep it alive
for the whole run of the
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:8e6f7b79c863: Introduce a QCommandLineParser for
kglobalaccel5 (authored by apol).
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4175?vs=10293=10304
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129833/#review102027
---
+1
- Aleix Pol Gonzalez
On Jan. 14, 2017, 7:54 p.m
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c07851470aa1: Remove unavailable ServiceTypes (authored
by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4169?vs=10277=10280
REVISION
apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4154
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk,
This revision was automatically updated to reflect the committed changes.
Closed by commit R378:bcf6308bd11a: Fix compilation with clang (authored by
apol).
REPOSITORY
R378 KExiv2 Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4179?vs=10297=10307
REVISION DETAIL
apol marked an inline comment as done.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
I just realized there was a weird workaround in plasma-nm where it gets
checked so it's
apol added a reviewer: Plasma.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4213
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #frameworks, #plasma
Cc: #frameworks
apol updated this revision to Diff 10377.
apol added a comment.
Dropped usage of QMap and QVector from the handler
Still using QPluginLoader and QDirIterator which probably are as bad as those.
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
apol updated this revision to Diff 10379.
apol marked an inline comment as done.
apol added a comment.
Address David's comment
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4214?vs=10372=10379
BRANCH
master
REVISION DETAIL
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ListItem.qml:97
> why are you now following containsMouse. That's a behavioural change
>
> How can background.pressed be true. I don't see where it exists?
> do you mean
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ListItem.qml:97
> > in fact it's what it was supposed to happen in the first place
>
> We have the highlight for the item under mouse.
> Why should the delegate change too?
If that's the case, then we should remove the
apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Drops the dot on these tags, possibly the right patch would be to fix the
apol added a comment.
In https://phabricator.kde.org/D4201#78631, @graesslin wrote:
> I don't understand why a plugin architecture allows to move it to tier1. Is
functionality split out? if yes, how does that help?
Ah, you are right, I forgot to mention it. I thought about this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128730/#review98550
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 22
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128840/#review98940
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128810/#review98817
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128917/#review99213
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 15
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129012/#review99517
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 25
> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote:
> > Again, I'll refer to how it's done in KCoreAddons. I don't think it's
> > really useful to need to define variables for every framework you are
> > compiling.
>
> Luigi Toscano wrote:
> Is this
> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote:
> > Again, I'll refer to how it's done in KCoreAddons. I don't think it's
> > really useful to need to define variables for every framework you are
> > compiling.
>
> Luigi Toscano wrote:
> Is this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129032/#review99552
---
+1 makes sense
- Aleix Pol Gonzalez
On Sept. 26, 2016, 11
be492b3
Diff: https://git.reviewboard.kde.org/r/129110/diff/
Testing
---
tests pass, even with the addition.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129104/#review99794
---
Ship it!
- Aleix Pol Gonzalez
On Oct. 5, 2016, 2:59 a.m
marked as submitted.
Review request for KDE Frameworks, Plasma and Matthias Klumpp.
Changes
---
Submitted with commit 435795224c2ac2f9b358d1b3588de80e356d40c5 by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Provide the icon name for now, maybe at some point
Description
---
Otherwise we get the item listed twice with a different icon.
Diffs
-
icons-dark/index.theme c319289
Diff: https://git.reviewboard.kde.org/r/129106/diff/
Testing
---
It's now shown properly both on the icons kcm and kde-gtk-config
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit bd970141ceb2390743072b75a751aba106585ac8 by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
I've been looking into what we're actually doing nowadays when we
-framework
Description
---
I forgot to do it in the previous RR.
Diffs
-
src/plasma/containment.cpp 1840f24
src/plasmaquick/appletquickitem.cpp 7da8673
src/plasmaquick/configview.cpp 8d9d518
Diff: https://git.reviewboard.kde.org/r/129100/diff/
Testing
---
Thanks,
Aleix Pol
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129057/#review99629
---
On Sept. 28, 2016, 3:41 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an auto
: https://git.reviewboard.kde.org/r/129102/diff/
Testing
---
Tests still pass, plasma still loads, even with RR #129103.
Thanks,
Aleix Pol Gonzalez
/129106/diff/
Testing
---
It's now shown properly both on the icons kcm and kde-gtk-config
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129102/#review99834
---
Ping?
- Aleix Pol Gonzalez
On Oct. 5, 2016, 4:18 a.m
that would improve at all.
Diffs
-
KF5PackageMacros.cmake 335fc81
Diff: https://git.reviewboard.kde.org/r/129103/diff/
Testing
---
Ran RR 129102 without any metdata.desktop files on my system. Nothing seemed to
break on the plasma world.
Thanks,
Aleix Pol Gonzalez
5eb529c
src/plasma/containment.h 0b7a3ef
src/plasma/containment.cpp 1840f24
Diff: https://git.reviewboard.kde.org/r/129102/diff/
Testing
---
Tests still pass, plasma still loads, even with RR #129103.
Thanks,
Aleix Pol Gonzalez
.
Thanks,
Aleix Pol Gonzalez
, plasma still loads, even with RR #129103.
Thanks,
Aleix Pol Gonzalez
1901 - 2000 of 4253 matches
Mail list logo
