D26749: WIP: Support NDK r20 and Qt 5.14

apol added inline comments. INLINE COMMENTS > Android.cmake:173 > +set(ANDROID_STL ${CMAKE_ANDROID_STL_TYPE}) > +include(${CMAKE_ANDROID_NDK}/build/cmake/android.toolchain.cmake REQUIRED) > + Why's this better? Or how is it different? REPOSITORY R240 Extra CMake Modules REVISION DETAIL htt

D26735: [Components 3]Make slider tickmarks optional

apol added a comment. But this means that for your keyboard it's either on or off, right? This is what it looks for me. The screen has hundreds of steps so it shows nothing, for the keyboard it has a middle step so it's shown below. I don't think it should be removed. F7893059: IMG_202

D26735: [Components 3]Make slider tickmarks optional

apol added a comment. You should only see them if you have very a few discrete number of steps. Can you show a screenshot of what you see that you don't like? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #plasma, #vdg Cc: apol,

D26740: Add KService::isSubseq as a public API for filtering queries.

apol added a comment. Other than that, makes sense. INLINE COMMENTS > kservice.h:576 > + */ > +static bool isSubseq(const QString& pattern, const QString& text, > Qt::CaseSensitivity cs = Qt::CaseSensitive); > + Can we give it a better name? How about something like `isContained`? o

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH use_multihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26736 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH port_to_QCborValue (branched from master) REVISION DETAIL https://phabricator.kde.org/D26737 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26713: Adapt to Qt 5.14 Android changes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26713 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26707 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpressoin-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26693 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel,

D26122: Add utility text function KShell::tildeCollapse

apol accepted this revision. apol added a comment. Looks good to me, just explain what it does on the commit message. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, k

D26633: Deprecate KWindowEffects::markAsDashboard()

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kwindoweffects.h:164 > * > * @param window The window for which to enable the blur effect > */ @deprecated since 5.67, support for dashboard windows was removed REPO

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, thanks David! Please address kossebau's comments before landing. REPOSITORY R237 KConfig BRANCH target (branched from master) REVISION DETAIL https://phabricator.kde.or

D26616: Adjust metainfo.yaml to new tier

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH tier REVISION DETAIL https://phabricator.kde.org/D26616 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22875: Offer toolTipDelay as a plasma unit

apol abandoned this revision. apol added a comment. This was eventually fixed in a different way REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22875 To: apol, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23586: Improve code that detects useful elements in an Svg file

apol updated this revision to Diff 73324. apol added a comment. address fregl's commetn REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23586?vs=65005&id=73324 BRANCH arcpatch-D23586 REVISION DETAIL https://phabricator.kde.org/D23586

D23586: Improve code that detects useful elements in an Svg file

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23586 To: apol, #plasma, #frameworks Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

This revision was automatically updated to reflect the committed changes. Closed by commit R242:591aceb3f926: Make use of KPluginMetaData where we can (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=73322&id=73323

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 73322. apol added a comment. Addressed kossebau's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68546&id=73322 BRANCH arcpatch-D23682 REVISION DETAIL https://phabricator.kde.org/

D23682: Make use of KPluginMetaData where we can

apol marked 8 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma, mart Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH no-have-x11 REVISION DETAIL https://phabricator.kde.org/D26597 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH unused-deps REVISION DETAIL https://phabricator.kde.org/D26596 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26594: Deprecate raiseWidget

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH raise REVISION DETAIL https://phabricator.kde.org/D26594 To: nicolasfella, #frameworks, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26588: Simplify usage of QMimeDatabase.

apol accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26588 To: dfaure, chinmoyr, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25490: Remove legacy plugin loading code

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH service REVISION DETAIL https://phabricator.kde.org/D25490 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

apol accepted this revision. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'll initialize with dumb values and refresh it when shown, which isn't

D26512: Drop unused headers

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26512 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26502 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26465 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26464 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

D26453: [Purpose] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26453 To: ahmadsamir, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D26194: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26194 To: ahmadsamir, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26416 REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fba

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:251 > +auto getFileItem = [=] () { > +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0) > +// Avoid calling QT_LSTAT and accessing recent documents I'm pretty sure we can/should depend on newer KF5. I'd say just

D26402: [android] Fix apk install target

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androidinstall REVISION DETAIL https://phabricator.kde.org/D26402 To: nicolasfella, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michael

D26394: ECMGeneratePriFile: Fix static configurations

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreas

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in kuitmarkup.cpp:412 > According to the QList docs, at() should be used for read-only access, it > could be faster than [] and it never causes a detach.

D26374: [Attica] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26374 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH use_qmultihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26372 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, L

D26373: Port endl to \n

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol added inline comments. INLINE COMMENTS > kuitmarkup.cpp:412 > // Normalize key, trim and all lower-case. > -QString nkey = keys[i].trimmed().toLower(); > +const QString nkey = keys.at(i).trimmed().toLower(); > keys[i] = keyNames.contains(nkey) ? > keyNames[

D26359: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26359 To: ahmadsamir, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26358: KIO/SMB convert kio protocol declaration to json format

apol added inline comments. INLINE COMMENTS > kio_smb.cpp:42 > +Q_OBJECT > +Q_PLUGIN_METADATA(IID "org.kde.kio.slave.smb" FILE "smb.json") > +}; Shouldn't this go in the SMBSlave class? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frame

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D26302: Port endl to "\n" + flush at the end

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26299: endl is namespaced in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH compile_against_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26299 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26318 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26319: Port endl to \n (QFile flushs data when deleted)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26319 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

apol added inline comments. INLINE COMMENTS > CppGenerator.cpp:61 > writeCopyrightHeader(stream); > -stream << "#pragma once" << endl << endl; > -stream << "#include " << endl << endl; > -stream << "class QDBusObjectPath;" << endl << endl; > -stream << "na

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol added inline comments. INLINE COMMENTS > scalabletest.cpp:312 > QTextStream stream(&msg); > -stream << "Duplicated scalable icons:" << endl; > -for (auto icon : duplicatedScalableIcons.keys()) { > -stream << QString(" %1:").arg(icon) << e

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol added inline comments. INLINE COMMENTS > plugintest.cpp:60 > > -cout << "-- KPluginTrader Test --" << endl; > +cout << "-- KPluginTrader Test --" > +#if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) std::endl should just work with cout. REPOSITORY R309 KService REVISION DE

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pidgin_emoticons.cpp:221 > +out << QStringLiteral("Description=") + themeName() << "\n"; > +out << "Author=" << "\n"; > +out << "\n"; Put it in the same string

D26299: endl is namespaced in qt5.15

apol added inline comments. INLINE COMMENTS > prison-datamatrix.cpp:39 >QTextStream str(stdout); > - str << error << ": " << errormessage << endl; > + str << error << ": " << errormessage > + #if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) Wouldn't make more sense to port to std::endl

D26294: Allow to load widget based KCMs from kcms subdir

apol added a comment. It would be useful if you were a bit more explicit about how you tested it on the commit message. INLINE COMMENTS > kcmoduleloader.cpp:103 > if (!cm) { > +module = factory->create(parent, args2); > +if (module) {

D26055: Enable wheel events on Slider {}

This revision was automatically updated to reflect the committed changes. Closed by commit R242:66122410a11d: Enable wheel events on Slider {} (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71744&id=72405 REVISI

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

apol added a comment. Not saying that this patch is wrong, would have to look into it more closely. But for knsrc files you want to use KDE_INSTALL_KNSRCDIR anyway, which will fall into /usr. INLINE COMMENTS > KDEInstallDirs.cmake:376 > +list(FIND _gnu_install_special_vars "${va

D26227: Port to QRandomGenerator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26227 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in klistopenfilesjob_unix.cpp:69 > I didn't even know there was a splitRef... > > It'll have to be something like: > > QVector pidList = > out.splitRef

D26211: Port QRegExp to QRegularExpression

apol added a comment. Looks good otherwise INLINE COMMENTS > parsetrigrams.cpp:59 > +if (match.hasMatch()) { > +models[fname][line.left(3)] = match.captured(2).toInt(); > } capturedRef REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.k

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

apol added a comment. Looks good overall INLINE COMMENTS > klistopenfilesjob_unix.cpp:69 > const QString out(QString::fromLocal8Bit(lsofProcess.readAll())); > -QStringList pidList = out.split(QRegExp(QStringLiteral("\\s+")), > QString::SkipEmptyParts); > +QStringList

D26205: KWallet: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D26198: Deprecate KCModuleContainer

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH container REVISION DETAIL https://phabricator.kde.org/D26198 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26194: Port QRegExp to QRegularExpression

apol added a comment. LGTM otherwise INLINE COMMENTS > runnercontext.cpp:575 > for (const QString& entry : cfgList) { > -r.indexIn(entry); > -int count = r.cap(1).toInt(); > -QString id = r.cap(2); > +QRegularExpressionMatch match = re.match(entry); > +

D26133: Enable Auto Save

apol added inline comments. INLINE COMMENTS > test_signal.h.ref:137 > +/** Triggered whenever a setting changes */ > +void configurationChanged(); > + How about having `isSaveNeededChanged(bool)`? It could be in KCoreConfigSkeleton. > kconfig_compiler.cpp:2121 > } > -

D26148: Add truncation support to FileJob

apol added a comment. It would be interesting to explain why it's important or how it's to be used in the commit message. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, f

D26136: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, G

D26188: Port to QRandomGenerator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26188 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB

D26187: QMultiHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH insertmulti_is_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D26187 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26126: Simplify param method: Return Early, Use a Map and Assert.

apol added a comment. Why are you concerned about thread safety in the kconfig compiler? :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

apol added inline comments. INLINE COMMENTS > plasmashell_interface.h:178 > **/ > +//TODO KF6 rename to something generic > bool panelTakesFocus() const; How about we rename now and deprecate this one? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D261

D26106: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26136: Port QRegExp to QRegularExpression

apol added a comment. It didn't update here? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26156: [KDocTools] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in docbookl10nhelper.cpp:184 > I did it that way to indicate match is going to be re-assigned-to later on, > but it does look off a bit. :) The way of say

D26170: i18n: Add more semantic context strings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH i18n-more-msgctxt REVISION DETAIL https://phabricator.kde.org/D26170 To: aspotashev, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26158: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26158 To: ahmadsamir, #baloo, bruns, apol Cc: kde-frameworks-devel, #baloo, hurikhan7

D26156: [KDocTools] Port QRegExp to QRegularExpression

apol added a comment. LGTM otherwise INLINE COMMENTS > docbookl10nhelper.cpp:158 > **/ > -QRegExp rxEntity, rxEntity2, rxDocType, rxDocType2; > - > rxDocType.setPattern(QStringLiteral("^\\s* - > rxDocType2.setPattern(QStringLiteral("^\\s*$")); > - > rxEntity.setPattern(Q

D26145: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26145 To: ahmadsamir, mlaurent, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26137: Add KPluginMetaData::supportsMimeType

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26137 To: dfaure, arichardson, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

apol added a comment. I'm a bit confused as to why the regex needs to be different. Explain in the commit message? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D26133: Enable Auto Save

apol added a comment. It could make sense to add a test. Also for an application (system settings or kconfig dialogs) it's already possible to just trigger save when the kcm has changed (we already have signals for this). Why do you think it's needed? REPOSITORY R237 KConfig REVISION

D26122: Add utility text function KShell::tildeCollapse

apol added a comment. I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ng

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

apol added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:1122 > +// Types that `{}` are ok as return type for default value. > +if (QVector({ > +QLatin1String("stringlist"), If instead of creating a QVector you used an initializer list directly, you could use std::find

D26126: Simplify param method: Return Early, Use a Map and Assert.

apol added a comment. I'd make the types static const, or at least const. Also are you sure that here std::map is better than QHash? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D12172: Android: Also install plugins, otherwise they are just not available

apol abandoned this revision. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12172 To: apol, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, vkrause, LeGast00n, GB_2, benc

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71744. apol added a comment. Just never draw over 20 ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71742&id=71744 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 A

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71742. apol added a comment. don't show too many ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71741&id=71742 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFEC

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71741. apol added a comment. Include test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71685&id=71741 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFECTED FILES s

D26061: QHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH use_qmultihash_direcly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26061 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26057: Deprecate the top-level IconSize() function

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY So far PC3 version of the slider doesn't react to events, this change enables it. TE

D26044: Set breeze as default theme when reading from configuration file

apol added a comment. LGTM otherwise INLINE COMMENTS > kiconloader.cpp:564 > const QString newThemeName = sharedConfig->group("Icons") > - .readEntry("Theme", > QString()); > + .readEntry("Theme"

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. In D13541#578027 , @bcooksley wrote: > This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ fixed REPOSITORY R245 Solid REVISION DETAIL ht

D25972: Support PyQt5 compiled with SIP 5

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25972 To: arojas, bruns, dfaure, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham

D25922: Don't use a verified nullptr as a data source

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH dont-use-null-qcoreapp-instance (branched from master) REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol Cc: kde-framewo

D13541: Port solid from Qt5::Widgets to Qt5::Gui

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui (authored by graesslin, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13541?vs=36167&id=71569#toc REPOSITORY R245

D25972: Support PyQt5 compiled with SIP 5

apol added a comment. LGTM overall INLINE COMMENTS > FindPythonModuleGeneration.cmake:312 >NAMES QtCoremod.sip > + PATHS ${KDE_INSTALL_PYTHON3DIR}/PyQt5/bindings/QtCore >PATH_SUFFIXES share/sip/PyQt5/QtCore Should probably be HINTS. REPOSITORY R240 Extra CMake Modules REVISION D

D25434: [plasma-framework] port away from deprecated KF5 APIs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'd say we could make it so setupEngine knows itself that it's already been set up. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/

<    1   2   3   4   5   6   7   8   9   10   >