D20443: Move to runtime the decision to use x11 or not

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of deciding at build time which backend to use, see which is used upon construction. This will make it possible to

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol updated this revision to Diff 55913. apol added a comment. Include keystates client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20191?vs=55247&id=55913 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20191 AFFECTED FILES sr

D20422: KZip: fix Heap-use-after-free in broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid, apol Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

apol added inline comments. INLINE COMMENTS > propertyinfo.cpp:650 > +for (const auto& entry : valueList) { > +displayList << (d->formatAsString)(entry); > +} `displayList << d->formatAsString(entry);` REPOSITORY R286 KFileMetaData REVI

D20042: Show the plasmoid context menu on long tap

apol added a comment. In D20042#446770 , @ngraham wrote: > That seems... quite sub-optimal to me. > > Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab t

D20042: Show the plasmoid context menu on long tap

apol abandoned this revision. apol added a comment. We discussed it and decided long tap is not the way to go, will have to find alternative ways to access the options on the context menu on a case-by-case basis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabric

D20376: [ktextwidget] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20376 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

apol added inline comments. INLINE COMMENTS > fuel_efficiency.cpp:36 > +const KLocalizedString &realString, const > KLocalizedString &integerString, > +const bool isReciprocal = false) > : UnitPrivate(categoryId, id, multiplier, I'm not sure I un

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

apol added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20261 To: kossebau, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

apol added a comment. Looks good, would it be possible to get a test case? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20260 To: aacid Cc: apol, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20230: Allow building without UDev on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit R245:124760e1a383: Allow building without UDev on Linux (authored by apol). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20230?vs=55353&id=55448 REVISION DETAIL https

D20244: [AppletInterface] Check for corona before accessing it

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20244 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20230: Allow building without UDev on Linux

apol added a comment. I don't really remember the reason why we can't use udev there, it was more of a "it can be there but it will be useless", then there was a very long discussion with "what if I..." and people saying that udev needed redesigning. It was few years ago. At the moment if

D20230: Allow building without UDev on Linux

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Flatpak has been patching this for a while, there doesn't seem to be a way to use it ther

D20219: Propose Stefan Bruns as KFileMetaData maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:79db0d55b933: Propose Stefan Bruns as KFileMetaData maintainer (authored by apol). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20219?vs=55323&id=55342 REV

D20225: use more appropriate plasma-specific icon for plasma category

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D20225 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20219: Propose Stefan Bruns as KFileMetaData maintainer

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY He has been doing most of the work lately and seems very active, I'd say he is

D20031: Declare PropertyInfo as QMetaType

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20031 To: bruns, #baloo, #frameworks, ngraham, astippich, apol Cc: apol, kde-frameworks-dev

D20032: Convert string formatting tests to be data driven

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Whatever. @bruns Have you considered becoming the module maintainer? :) REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #balo

D20216: Export path of kwalletd binary for kwallet_pam

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D20216 To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol retitled this revision from "Depends on D20191" to "Expose locked keystates on KModifierKeyInfo when on wayland". apol edited the summary of this revision. apol added a dependency: D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work. REPOSITORY R273 KGu

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20193: Expose locked keystates on KModifierKeyInfo when on wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20193: Depends on D20191

apol updated this revision to Diff 55250. apol added a comment. description REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20193?vs=55249&id=55250 BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES src/CMak

D20193: Depends on D20191

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R273 KGuiAddons BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES src/CMakeLists.tx

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20192: Implement the keystate protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Tested with both the lock screen and the keyboard indicator plasmoid REPOSITORY R127 KWayland BRANCH

D20095: Reduce the importance of some debug information so actual warnings can be seen.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f132316c561: Reduce the importance of some debug information so actual warnings can be seen. (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabr

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

apol added a comment. In D20181#441918 , @JJRcop wrote: > In D20181#441887 , @aacid wrote: > > > Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this ag

D20095: Reduce the importance of some debug information so actual warnings can be seen.

apol updated this revision to Diff 55223. apol added a comment. remove warning fix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20095?vs=54992&id=55223 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20095 AFFECTED FIL

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20164 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20162 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20163 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20149: Fix compilation

apol added inline comments. INLINE COMMENTS > ora.cpp:21 > static constexpr char s_magic[] = "image/openraster"; > -static constexpr int s_magic_size = strlen(s_magic); > +static constexpr int s_magic_size = sizeof(s_magic) - 1; // -1 to remove the > last \0 > Won't sizeof give the sizeof(ch

D20145: Fix RGBHandler::canRead

apol accepted this revision. apol added a comment. Makes sense, maybe it would make sense to include a test case? if such a thing exists... REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela, apol Cc: apol, svuorela, kde

D20143: ora:kra: qstrcmp -> qstrncmp

apol added a comment. +1 otherwise INLINE COMMENTS > kra.cpp:21 > > +static constexpr char s_magic[] = "application/x-krita"; > +static constexpr int s_magic_size = strlen(s_magic); how about calling it s_mimetype? REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde

D20127: Fix finding the host tools targets file in the Android docker environment

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20127 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20032: Convert string formatting tests to be data driven

apol added a subscriber: mgallien. apol added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:71 > Still not convinced? Not really, but if @mgallien, who is the maintainer, is fine with it, I'm fine too. After all it's still better than what we used to have. REPOSITORY

D20105: ecm_add_wayland_client_protocol: Improve error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6b27bbf0b954: ecm_add_wayland_client_protocol: Improve error messages (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20105?vs=55012&

D20105: ecm_add_wayland_client_protocol: Improve error messages

apol updated this revision to Diff 55012. apol added a comment. for generating server files too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20105?vs=55011&id=55012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20105 AFFECT

D20105: ecm_add_wayland_client_protocol: Improve error messages

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of passing the data from stdin, pass the path, th

D20092: New class KOSRelease - a parser for os-release files

apol added a subscriber: mpyne. apol added a comment. @mpyne is KCoreAddons maintainer, maybe he has some comments on the new class. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: mpyne, kde-frameworks-devel, michaelh,

D20092: New class KOSRelease - a parser for os-release files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

apol added a comment. LGTM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. ¯\_(ツ)_/¯ REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20087 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20095: Reduce the importance of some debug information so actual warnings can be seen.

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kd

D20085: Expose a method to show the context menu of an applet from QML

apol updated this revision to Diff 54991. apol added a comment. boop REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20085?vs=54967&id=54991 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 AFFECTED FILES src/scrip

D20092: New class KOSRelease - a parser for os-release files

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kosrelease.h:34 > + * > + * os-release is a free software standard for describing an operating system. > + * This class parses and models os-release files. it's a

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

apol added inline comments. INLINE COMMENTS > qtquicksettings.cpp:47 > +if (s.graphicsResetNotifications() || > +QLibraryInfo::version() >= QVersionNumber(5, 13, 0)) { > format.setOption(QSurfaceFormat::ResetNotification); Shouldn't this check be in graphicsResetNotification

D20085: Expose a method to show the context menu of an applet from QML

apol added a dependent revision: D20093: Show a context menu on pressAndHold. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20085: Expose a method to show the context menu of an applet from QML

apol created this revision. apol added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Decouples the code that shows it and exposes it to the different containments and applets

D20077: Accept any HTTP status between 100 and 199 as benign

apol added a comment. LGTM REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D20077 To: leinir, #knewstuff, #frameworks Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20077: Accept HTTP status 103 as benign

apol added a comment. And why are 101 and 102 bad? Should we just accept between 100 and 200? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D20077 To: leinir, #knewstuff, #frameworks Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

apol added a comment. etc. INLINE COMMENTS > datamodel.cpp:309 > > -foreach (const QString &key, m_dataSource->data()->keys()) { > +const auto lst = m_dataSource->data()->keys(); > +for (const QString &key : lst) { same? Also this should clearly be using iterators, no? > toolt

D20042: Show the plasmoid context menu on long tap

apol updated this revision to Diff 54901. apol added a comment. Convert to the containment coordinate system, otherwise we show the context menu of the applet at 0,0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20042?vs=54777&id=54901

D20070: [PlasmaComponents3 ComboBox] Fix textColor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20070 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D20065 To: broulik, #frameworks, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH highlight-filename-after-click-when-saving (branched from master) REVISION DETAIL https://phabricator.kde.org/D19849 To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure, apol Cc: kd

D19913: [plasma-desktop] make it compiles without foreach

apol added a comment. It's bad enough that we need to give things names because Qt keeps detaching on foreach, I'd be giving at least more semantic names to these temporary variables. INLINE COMMENTS > coronatest.cpp:149 > > -foreach (auto cont, m_corona->containments()) { > +cons

D20059: Take clang-cl into account.

apol added a comment. LGTM, looks like clang-cl will be missing a few arguments though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20060: [KDynamicJobTracker] Use generated DBus interface

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20060 To: broulik, #frameworks, davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20059: Take clang-cl into account.

apol added a reviewer: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20047: Add X-GNOME-UsesNotifications as recognized key

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D20047 To: broulik, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20042: Show the plasmoid context menu on long tap

apol updated this revision to Diff 54777. apol added a comment. polish REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20042?vs=54776&id=54777 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20042 AFFECTED FILES src/scr

D20042: Show the plasmoid context menu on long tap

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Also expose a method to show the context menu so plasmoids that implement a MouseAr

D20032: Convert string formatting tests to be data driven

apol added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:71 > This saves adding the `QVariant(...)` around each value, and avoids the > repeated formatting of the row name/data index. The property enum is used > twice in each addRow. And instead it makes you create a w

D7732: Force KAuth helpers to have UTF-8 support

apol added a comment. LGTM +1 I've dealt with such issues when working on samba-mounter, there we ended up encoding everything as base64 and using QString::fromUtf8 like maniacs. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson, apol Cc: kde-f

D20032: Convert string formatting tests to be data driven

apol added a comment. +1 to _data splitting, makes a lot of sense. INLINE COMMENTS > propertyinfotest.cpp:71 > > -PropertyInfo bitRate(Property::BitRate); > -QCOMPARE(bitRate.formatAsDisplayString(QVariant(128000)), > QStringLiteral("128 kbit/s")); > -QCOMPARE(bitRate.formatAsD

D20005: Report human-readable error if Qt5Widgets is required but is not found

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D20005 To: aspotashev, #frameworks, apol Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19972: [krunners] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19972 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19967: [kpeople] make it compile without foreach

apol added inline comments. INLINE COMMENTS > matchessolver.cpp:63 > +QList::const_iterator it = > destinationResolver.keys(urlB).constBegin(); > +const QList::const_iterator end = > destinationResolver.keys(urlB).constEnd(); > +for (; it != end; ++it) { You

D19965: kactivities: remove unused variable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH remove_unused_variable REVISION DETAIL https://phabricator.kde.org/D19965 To: carneirogustavo, #kactivities, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19935: [KCMUTILS] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19935 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19934: [kded] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19934 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19945: Update link to fsearch project

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH update-fsearch-link REVISION DETAIL https://phabricator.kde.org/D19945 To: meven, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19917: Additions for ProviderManager documentation

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. We'll see I guess. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19917 To: leinir, #frameworks, #knewstuff, apol Cc: apol, kde-frameworks-devel, #knewstuff, michaelh,

D19917: Additions for ProviderManager documentation

apol added inline comments. INLINE COMMENTS > providermanager.h:50 > * > - * Once you have loaded a Provider, use its functions to access the service. > + * See addProviderFileToDefaultProviders(const QUrl &url) for an example of > + * what the provider file sohuld look like. You can add provid

D19900: Set category on Attica entries

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19900 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19896: [kdnssd] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19896 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19891: Use https for the pastebin backend and publicly accessible documentation

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19891 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

apol added a comment. How about having 3 icons? autorotate, locked portrait and locked landscape? This way we don't need to have a weird red strike-through. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-framew

D19870: [kactivities] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19870 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19869: [kglobalaccel] Make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19869 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19877: [kdeclarative] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19877 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19850: Make AppStream generation opt-in

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY After discussing the feature over it became apparent that developers will need to be pro-activ

D19783: [kitemview] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R276 KItemViews BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19783 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, b

D19806: Allow selecting only supported audio files

apol added a comment. How do we know that's the only ones supported? REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D19806 To: broulik, #frameworks, dfaure Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:254 > +// return any useful information for our purposes here. > +url.setScheme(QString()); > +KFileItem fileItem(url); This looks very much like a workaround. How about adding an argument to the KFileItem to skip th

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

apol added a comment. Does this solve the fluffy bunny issue? Otherwise it could be that the theme needs adapting to tell plasma to repeat the pattern instead of stretching it. INLINE COMMENTS > framesvgitem.cpp:148 > if (m_border == FrameSvg::TopBorder || m_border == > Frame

D19783: [kitemview] compile without foreach

apol added inline comments. INLINE COMMENTS > kwidgetitemdelegatepool.cpp:136 > +const auto lst = d->widgetInIndex.keys(); > +for (QWidget *widget : lst) { > const QAbstractProxyModel *proxyModel = qobject_cast QAbstractProxyModel *>(d->delegate->d->model); This one clearly shou

D19734: Fix compilation with Android API level >= 26

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19734 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19732: [KWidgetAddons] Fix build with Qt 5.13

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19732 To: matthieugras, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19338: New location for KNSRC files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19719: [kpackages] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH fix_compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19719 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19718: [kiconthemes] compiles without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19718 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19697: Fixes the build failure when using ECM Android toolchain

apol added a comment. Maybe it would make more sense to remove them instead? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19679: Support image/vnd.zbrush.pcx mime type

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19679 To: broulik, #frameworks, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorale

D19674: [Icon Item] Also clear image icon when using Plasma Svg

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19674 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19672: [knewstuff] make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19672 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

<    5   6   7   8   9   10   11   12   13   14   >