Re: Review Request 115083: Python3 support

: https://git.reviewboard.kde.org/r/115083/diff/ Testing --- tested w/ python 3.3 and 2.7 Thanks, Alex Turbov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

D5338: Add syntax highlighting file for Doxyfile

turbov added a comment. my 2 cents: I've used the syntax made by Ernst quite a long time and pretty happy w/ it :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: turbov, emaurer,

D7245: Improve reStructuredText highlighting

turbov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 1. make `code-block` directive looks like a "directive" and not like a "code" 2. highlight directive options for `code-block` (and `code`)

D7245: Improve reStructuredText highlighting

turbov updated this revision to Diff 17992. turbov added a comment. Fix attribute name CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7245?vs=17991=17992 REVISION DETAIL https://phabricator.kde.org/D7245 AFFECTED FILES data/syntax/rest.xml To: turbov, #kate,

D7245: Improve reStructuredText highlighting

turbov updated this revision to Diff 17993. turbov added a comment. Make code block `::` works as again as expected CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7245?vs=17992=17993 REVISION DETAIL https://phabricator.kde.org/D7245 AFFECTED FILES data/syntax/rest.xml To:

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#133152, @dhaumann wrote: > I see seveal issues that imo should be addressed: > > 1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?) no, I don't run tests yet (it

D7175: Redesign CMake syntax

turbov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake syntax has been redesigned to pursue the following goals: - the former generator has used an output of `cmake --help` (and

D7245: Improve reStructuredText highlighting

turbov updated this revision to Diff 18321. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7245?vs=17993=18321 REVISION DETAIL https://phabricator.kde.org/D7245 AFFECTED FILES data/syntax/rest.xml To: turbov, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann,

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#138554, @dhaumann wrote: > What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right? correct. it

D7175: Redesign CMake syntax

turbov updated this revision to Diff 18322. turbov added a comment. Remove spaces around `` CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=17801=18322 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D7245: Improve reStructuredText highlighting

turbov added a comment. In https://phabricator.kde.org/D7245#146719, @dhaumann wrote: > @turbov ping pong... I wanted to make some improvements... And it would be nice to have some hint about how to add the mentioned tests... REVISION DETAIL

D7175: Redesign CMake syntax

turbov updated this revision to Diff 21207. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=18322=21207 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake.yaml data/generators/generate-cmake-syntax.py data/syntax/cmake.xml To:

D7175: Redesign CMake syntax

turbov updated this revision to Diff 21208. turbov added a comment. Include updates for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21207=21208 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D8780: Try `llvm-config` to find `libclang`

turbov created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY The current way to search for `libclang` doesn't work for me (Gentoo with clang 4 and 5 installed). Instead of

D7175: Redesign CMake syntax

turbov added a comment. ping REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann, #frameworks

D7175: Redesign CMake syntax

turbov updated this revision to Diff 23100. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=6=23100 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh data/generators/cmake.xml.tpl data/generators/cmake.yaml

D7175: Redesign CMake syntax

turbov updated this revision to Diff 6. turbov edited the summary of this revision. turbov added a comment. Updated for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21208=6 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES

D8780: Try `llvm-config` to find `libclang`

turbov added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:212 > NAMES clang clang-3.8 clang-3.9 > > and remove the lines 234-239 What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? I've just checked Ubuntu 14.04 (Clang 3.3 to

D8780: Try `llvm-config` to find `libclang`

turbov added a comment. @cgiboudeaux, Yep, this review is the first in series about to clean up the code of `FindPythongModuleGeneration` and make it generic (not only for Ubuntu) and flexible. It is why I want to clean up it from "hard-coded" values like `3.8`/`3.9` and "brute

D7175: Redesign CMake syntax

turbov added a comment. @cullmann , @dhaumann if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways... REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann,

D7175: Redesign CMake syntax

turbov updated this revision to Diff 26933. turbov added a comment. Updates for CMake 3.11 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=23100=26933 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#202300, @vkrause wrote: > I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies. It doesn' needed to run anything @

D7245: Improve reStructuredText highlighting

turbov added a comment. @cullmann, Up to you... When I'll fix it for the cases I've found (trying to write the `hightlighting.rst` test file) I come back w/ a new PR :) REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann,

D7245: Improve reStructuredText highlighting

turbov marked an inline comment as done. turbov added a comment. I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %) Most of the time I quite satisfied w/ it... and sorry for the tests :(

D7245: Improve reStructuredText highlighting

turbov added a comment. You can just close this MR, I'll be back sometime later w/ highlighting example and tests... REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, #frameworks, michaelh,

D14824: Relicense modelines.xml to MIT license

turbov accepted this revision. turbov added a comment. I agree w/ relicense REPOSITORY R216 Syntax Highlighting BRANCH relicense-modelines-mit (branched from master) REVISION DETAIL https://phabricator.kde.org/D14824 To: dhaumann, vkrause, cullmann, martinwalch, turbov Cc:

D15780: YAML: add literal & folded block styles

turbov accepted this revision. turbov added a comment. This revision is now accepted and ready to land. Good job! @dhaumann, my +1 REPOSITORY R216 Syntax Highlighting BRANCH fix-literal-style-yaml REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, cullmann,

D22095: Fix CMake add_custom_command() paren highlighting

turbov added a comment. I would say all commands w/ `COMMAND` named parameter need that. Also, `add_custrom_target` and `execute_process`... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting, cullmann Cc:

D22340: Bring some missed features

turbov created this revision. turbov added reviewers: Kate, Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REVISION SUMMARY - handle `CMAKE_ARGVn` properly - add

D22340: cmake: bring some missed features

turbov retitled this revision from "Bring some missed features" to "cmake: bring some missed features". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting Cc: ngraham, kwrite-devel, kde-frameworks-devel,

D22698: Support passing target to ki18n_wrap_ui macro

turbov added a comment. @daandemeyer Cool stuff! :)) one more proposal is to turn it into a function to avoid pollution of the outer scope w/ inner used (**and still unset**) variables %) Using `set(${RESULT_VAR} "blah-blah" PARENT_SCOPE)` could help to do that %) REVISION DETAIL

D22698: Support passing target to ki18n_wrap_ui macro

turbov added inline comments. INLINE COMMENTS > KF5I18nMacros.cmake.in:76 > + endif() > endforeach (_current_FILE) > endmacro (KI18N_WRAP_UI) Its _Modern CMake_ :) no need to use that crap anymore %) (I'm talking about matched `end*()` things %) REVISION DETAIL

D25686: Updates from CMake 3.16 final release

turbov added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25686 To: turbov, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D25686: Updates from CMake 3.16 final release

turbov created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25686 AFFECTED FILES

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D27580: Updates for CMake 3.17

turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

turbov added a comment. In D25811#587606 , @cullmann wrote: > Hi, can you add stuff to the tests or shall we merge this as is? Sorry, I don't have time for this nowadays %( REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D27929: CMake syntax fixes

turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REVISION SUMMARY - add some more variables introduced in CMake