D17358: implement cover extraction for asf files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2a41e4b45262: implement cover extraction for asf files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17358?vs=46868=46985 REVISION

D17357: extend list of supported mimetypes for embedded image extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9f67b436f851: extend list of supported mimetypes for embedded image extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16671: Refactor embedded image extractor for greater extensibility

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7929a896b5e1: Refactor embedded image extractor for greater extensibility (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16671?vs=46880=46982#toc REPOSITORY R286

D17357: extend list of supported mimetypes for embedded image extractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH image_extend REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15829: make units and prefixes of formatValue translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0b58dc656d1a: make units and prefixes of formatValue translatable (authored by astippich). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43038=46981

D16671: Refactor embedded image extractor for greater extensibility

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:134 > Does Taglib signal an error when it fails to parse the file? Or is calling > pictureList() always safe? Docs don't say, so I fed a musepack file into this

D16671: Refactor embedded image extractor for greater extensibility

astippich updated this revision to Diff 46880. astippich added a comment. - new lines, handle dataPosition == -1 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=46860=46880 BRANCH refactor_embedded_image REVISION DETAIL

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17324 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17358: implement cover extraction for asf files

astippich updated this revision to Diff 46868. astippich added a comment. - fix REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17358?vs=46863=46868 BRANCH wma_cover REVISION DETAIL https://phabricator.kde.org/D17358 AFFECTED FILES

D17357: extend list of supported mimetypes for embedded image extractor

astippich added a dependent revision: D17358: implement cover extraction for asf files. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17358: implement cover extraction for asf files

astippich added a dependency: D17357: extend list of supported mimetypes for embedded image extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17358 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16671: Refactor embedded image extractor for greater extensibility

astippich added a dependent revision: D17357: extend list of supported mimetypes for embedded image extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D17357: extend list of supported mimetypes for embedded image extractor

astippich added a dependency: D16671: Refactor embedded image extractor for greater extensibility. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D17301: add documentation to result class

astippich added a comment. Thanks for your patience :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46864. astippich added a comment. - remove docstring for reimplemented functions REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46750=46864 BRANCH result_documentation REVISION DETAIL

D17358: implement cover extraction for asf files

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement support for last missing mimetype compared to

D17357: extend list of supported mimetypes for embedded image extractor

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY use existing functions to add support for new mimetypes

D16671: Refactor embedded image extractor for greater extensibility

astippich updated this revision to Diff 46860. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=44982=46860 BRANCH refactor_embedded_image REVISION DETAIL https://phabricator.kde.org/D16671 AFFECTED

D17245: Add string formatting function to property info

astippich marked 3 inline comments as done. astippich added a comment. I'm wondering, anything else to do if I add a new dependency to KFileMetaData? INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:63 > I think this should be "44.1 kHz". Insert the correct expected value and make > it

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46859. astippich added a comment. - small fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46688=46859 BRANCH display_value REVISION DETAIL https://phabricator.kde.org/D17245 AFFECTED FILES

D17300: add result to baloo namespace

astippich abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16931: Extract more tags from exif metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0b35de4243aa: Extract more tags from exif metadata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16931?vs=45608=46757 REVISION

D17301: add documentation to result class

astippich marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46750. astippich added a comment. - more adjustments REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46706=46750 BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 AFFECTED

D17315: Avoid potential nullptr access for Document use reference instead

astippich added a comment. In D17315#370404 , @bruns wrote: > In D17315#370298 , @astippich wrote: > > > This one doesn't apply, looks like D17824 is a dependency? > > > D17312

D17298: remove unused docId from result

This revision was automatically updated to reflect the committed changes. Closed by commit R293:647823d36592: remove unused docId from result (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17298?vs=46680=46743 REVISION DETAIL

D16671: Refactor embedded image extractor for greater extensibility

astippich added a comment. anyone? I would like to extend the support to the same file types as supported by the taglibextractor REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo,

D17315: Avoid potential nullptr access for Document use reference instead

astippich added a comment. This one doesn't apply, looks like D17824 is a dependency? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17300: add result to baloo namespace

astippich updated this revision to Diff 46733. astippich added a comment. - rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17300?vs=46683=46733 BRANCH result_namespace REVISION DETAIL https://phabricator.kde.org/D17300 AFFECTED FILES

D17313: Use Compact json formatting for storing document metadata

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17313 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17312: Remove unused map() getter from Result

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17312 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17298: remove unused docId from result

astippich removed a dependency: D16826: Treat uints the same as ints. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16826: Treat uints the same as ints

astippich removed a dependent revision: D17298: remove unused docId from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17299: move implementation of document get to cpp file

astippich abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17298: remove unused docId from result

astippich retitled this revision from "remove unused doc_id from result" to "remove unused docId from result". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel,

D17302: add simple test for string merging

astippich updated this revision to Diff 46710. astippich marked 2 inline comments as done. astippich added a comment. - small fixes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=46686=46710 BRANCH test_result REVISION DETAIL

D17302: add simple test for string merging

astippich added inline comments. INLINE COMMENTS > bruns wrote in resulttest.cpp:40 > No need to reset the default constructed `Baloo::Document` with a default > constructed one. Actually it is. The TermGenerators are otherwise only initialized with nullptr, and consequently will crash. That

D16826: Treat uints the same as ints

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f6f9ecb2a17e: Treat uints the same as ints (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=46679=46709 REVISION DETAIL

D17301: add documentation to result class

astippich marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46706. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46687=46706 BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 AFFECTED

D17299: move implementation of document get to cpp file

astippich added a comment. Really just a cosmetic change for consistency, if you don't want it in, I'm fine with dropping it REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17282 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

astippich added a comment. In D17282#369617 , @ngraham wrote: > Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file? I'm wondering the same. REPOSITORY R293 Baloo REVISION DETAIL

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46688. astippich added a comment. - update strings for image orientation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46509=46688 BRANCH display_value REVISION DETAIL

D17301: add documentation to result class

astippich marked 4 inline comments as done. astippich added a comment. Thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46687. astippich added a comment. - use param REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46684=46687 BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 AFFECTED FILES

D17302: add simple test for string merging

astippich added a comment. Didn't found what I wanted to find, but since the code is there we can add it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17302: add simple test for string merging

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY adds a simple test for the result class that tests how multiple

D17301: add documentation to result class

astippich added a comment. I had the impression that I have to read a lot of code just to know which variable does what, so I wrote some simple documentation. Please check if I got anything wrong. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich,

D17301: add documentation to result class

astippich added a dependency: D17300: add result to baloo namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

astippich added a dependent revision: D17300: add result to baloo namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17300: add result to baloo namespace

astippich added a dependent revision: D17301: add documentation to result class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17300: add result to baloo namespace

astippich added a dependency: D17299: move implementation of document get to cpp file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16826: Treat uints the same as ints

astippich added a dependent revision: D17298: remove unused doc_id from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17298: remove unused doc_id from result

astippich added a dependency: D16826: Treat uints the same as ints. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

astippich added a dependency: D17298: remove unused doc_id from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17298: remove unused doc_id from result

astippich added a dependent revision: D17299: move implementation of document get to cpp file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17301: add documentation to result class

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R293 Baloo BRANCH result_documentation REVISION DETAIL

D17300: add result to baloo namespace

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY it is the only file not using the Baloo namespace REPOSITORY

D17299: move implementation of document get to cpp file

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY for consistency REPOSITORY R293 Baloo BRANCH result_doc

D17298: remove unused doc_id from result

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The doc id in result class is never set and never read, so remove

D16826: Treat uints the same as ints

astippich retitled this revision from "Treat uints and doubles the same as integers" to "Treat uints the same as ints". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham,

D16826: Treat uints and doubles the same as integers

astippich updated this revision to Diff 46679. astippich added a comment. - only add uints for now REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=46625=46679 BRANCH uint_double REVISION DETAIL https://phabricator.kde.org/D16826 AFFECTED FILES

D16826: Treat uints and doubles the same as integers

astippich added a comment. Okay, so there is more work to do for floats. What about then reducing this patch to uints for now, and doubles are added when everything else is in place? I have something in the pipeline for the Result class, which I added for figuring out how string lists are

D16826: Treat uints and doubles the same as integers

astippich added a comment. @bruns do you consider this useful or shall I abandon? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16826: Treat uints and doubles the same as integers

astippich updated this revision to Diff 46625. astippich added a comment. - rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=45314=46625 BRANCH uint_double REVISION DETAIL https://phabricator.kde.org/D16826 AFFECTED FILES

D16931: Extract more tags from exif metadata

astippich added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16931: Extract more tags from exif metadata

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ca8c11351fe7: fix extraction of GPS altitude for exif data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16617?vs=44723=46624

D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:83 > IMHO thats not better at all - what does "top, left" refer to? And whats the > difference to "left, top"? > > Every orientation save "normal" and "rotated 180" is ambiguous without > further description.

D15960: Don't check if file is directory based on mime-type

astippich accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D17160: Remove extra spaces from Debug output, insert delimiters between fields

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17160 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16617: fix extraction of GPS altitude for exif data

astippich added a comment. Thanks INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:217 > This is bogus, why am I not allowed to take photos at sea level? Or in > Greenwhich, at the Equator? > > Invalid data should **not** be signaled by 0.0 Yep, I will change that in another diff

D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:83 > Of course I can look this up. But this information is not available when the > user looks at the string. > > Probably we should ask what is the target audience here? The average user > only wants the

D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:81 > Thats somewhat ambigous - flipped along the vertical axis, or top/bottom > flipped? Actually I don't know, I just copied the code from Dolphin into here. Seems to be a common term though according to

D16617: fix extraction of GPS altitude for exif data

astippich added a comment. gentle ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46509. astippich added a comment. - make KCoreAddons a required framework REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46508=46509 BRANCH display_value REVISION DETAIL

D17245: Add string formatting function to property info

astippich created this revision. astippich added reviewers: broulik, bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Adds the ability to format the metadata value

D15829: make units and prefixes of formatValue translatable

astippich added a comment. If no-one objects or has any comments regarding coding, I'm going to land this revision in one week REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc:

D16671: Refactor embedded image extractor for greater extensibility

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16931: Extract more tags from exif metadata

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Extract more metadata from exif that can be easily mapped to the

D16931: Extract more tags from exif metadata

astippich added a dependency: D16617: fix extraction of GPS altitude for exif data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

astippich added a dependent revision: D16931: Extract more tags from exif metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D12114: Revive 'Description' property for DublinCore metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:103f86746b8a: Revive Description property for DublinCore metadata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16196: add a description property to KFileMetaData

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:32c1e88ed922: add a description property to KFileMetaData (authored by astippich). REPOSITORY R286 KFileMetaData

D16196: add a description property to KFileMetaData

astippich added a comment. I'm gonna merge this tonight to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D11365: also test for value types in taglibextractortest and fix errors

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: kde-frameworks-devel, bruns, michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, abrahams

D16617: fix extraction of GPS altitude for exif data

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:285 > According to: > https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html > and > http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf > > the absolute altitude value is a rational, like

D16716: skip writing test if mime type is not supported by the extractor

astippich added a comment. I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution. I think a skip is still the right thing to do here, since we cannot determine if the tags are correctly written.

D16671: Refactor embedded image extractor for greater extensibility

astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:204 > I know you have only moved this code here ... > > `TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this > is safe here. But maybe we should return `QByteArray()` instead? The

D16564: cleanup the test for embedded image extraction

This revision was automatically updated to reflect the committed changes. Closed by commit R286:218f4c51c4db: cleanup the test for embedded image extraction (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16564?vs=44587=45235

D12114: Revive 'Description' property for DublinCore metadata

astippich added a comment. I've reverted the test data for docx format for now, since there are apparently more issues. Funnily, LibreOffice and MS Word label the description property with "Comment". REPOSITORY R286 KFileMetaData BRANCH description_dc REVISION DETAIL

D12114: Revive 'Description' property for DublinCore metadata

astippich updated this revision to Diff 45234. astippich added a comment. - revert docx test data for now REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12114?vs=44834=45234 BRANCH description_dc REVISION DETAIL

D12114: Revive 'Description' property for DublinCore metadata

astippich added inline comments. INLINE COMMENTS > bruns wrote in office2007extractortest.cpp:52 > Strictly speaking, this should be part of another commit. > Feel free to split it off and git push without review. Just to let you know, I'm currently having issues creating a new test file.

D16196: add a description property to KFileMetaData

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not crash if no suitable extractor is found. Skip the

D16671: Refactor embedded image extractor for greater extensibility

astippich updated this revision to Diff 44982. astippich added a comment. - more cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=44868=44982 BRANCH refactor_embedded_image REVISION DETAIL https://phabricator.kde.org/D16671

D16672: Add support for speex files to taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ac63b25577f3: Add support for speex files to taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16672?vs=44869=44937

<    1   2   3   4   5   6   7   8   9   10   >