Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

On Aug. 28, 2014, 9:02 p.m., Albert Astals Cid wrote: Errr, what do you mean it doesn't do anything? It's used http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cpp?v=kf5-qt5 To use a QIcon there? Alexander Volkov wrote: -QString programIconName = QCoreApplication::instance()-property(applicationIconName).toString(); +QString programIconName = QGuiApplication

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cpp?v=kf5-qt5 To use a QIcon there? Alexander Volkov wrote: -QString programIconName = QCoreApplication::instance()-property(applicationIconName).toString(); +QString programIconName = QGuiApplication

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 243626c27f3f27db3ec6c94f5de1e6751b56fa18 by Alexander Volkov to branch master. Bugs: 286260 https://bugs.kde.org/show_bug.cgi?id=286260 Repository: kwidgetsaddons

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 Diff: https://git.reviewboard.kde.org/r/129809/diff/ Testing --- Thanks, Alexander Volkov

Re: Review Request 129857: Remove unused jp2.desktop

: https://git.reviewboard.kde.org/r/129857/diff/ Testing --- Thanks, Alexander Volkov

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129809/#review101970 ------- On Jan. 13, 2017, 12:45 p.m., Alexander Volkov wrote: > > --- > This is an

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129809/#review101970 ------- On Jan. 12, 2017, 8:57 p.m., Alexander Volkov wrote: > > --- > This is an

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 Diff: https://git.reviewboard.kde.org/r/129809/diff/ Testing --- Thanks, Alexander Volkov

Review Request 129809: KFontRequester: Find the nearest match for a missing font

6cca672b0284265daacd428d8bca9cec08da8910 Diff: https://git.reviewboard.kde.org/r/129809/diff/ Testing --- Thanks, Alexander Volkov

D9348: Handle positions of LMB clicks on legacy systray icons

volkov added a comment. It can be tested on the latest kmix. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D9348 To: volkov, #frameworks, mck182 Cc: ngraham, alexeymin, #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D9348 AFFECTED FILES src/kstatusnotifieritem.cpp To: volkov

D9348: Handle positions of LMB clicks on legacy systray icons

volkov added a reviewer: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D9348 To: volkov, #frameworks Cc: #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

volkov added a reviewer: mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D9348 To: volkov, #frameworks, mck182 Cc: ngraham, alexeymin, #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

This revision was automatically updated to reflect the committed changes. Closed by commit R289:b5e43439386e: Handle positions of LMB clicks on legacy systray icons (authored by volkov). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D8590: KPageListView: Update width on font change

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In particular its font can be changed by Breeze style that modifies bold fonts to regular when it polishes list views. REPOSITORY R236

D8590: KPageListView: Update width on font change

volkov added a reviewer: wojnilowicz. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8590 To: volkov, cfeck, wojnilowicz Cc: #frameworks

D7787: Set KPageListView width properly

volkov added a comment. Could you try to test it without + 5 and with the following change applied? https://phabricator.kde.org/D8590 ? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7787 To: wojnilowicz, #frameworks Cc: volkov, cfeck, tbaumgart, #kmymoney

D8590: KPageListView: Update width on font change

volkov added a reviewer: cfeck. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8590 To: volkov, cfeck Cc: #frameworks

D8590: KPageListView: Update width on font change

This revision was automatically updated to reflect the committed changes. Closed by commit R236:525cf0666bc1: KPageListView: Update width on font change (authored by volkov). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8590?vs=21690=22016 REVISION

D8689: Fix the result of KDesktopFile::sortOrder()

volkov added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8689 To: volkov, #frameworks Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KDesktopFile::sortOrder() returns the value of SortOrder key as a string whithout parsing it as a list. But according to Desktop Entry

D8689: Fix the result of KDesktopFile::sortOrder()

volkov added a comment. Well, at first I was planning to use this method in my project, but since it's not used in KDE and besides the SortOrder key is deprecated, I guess that KDesktopFile::sortOrder() should be marked as deprecated. The question is whether to fix it first?

D9224: Deprecate KDesktopFile::sortOrder()

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a69d8e562b6e: Deprecate KDesktopFile::sortOrder() (authored by volkov). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23553=23554 REVISION DETAIL

D9224: Deprecate KDesktopFile::sortOrder()

volkov updated this revision to Diff 23553. volkov added a comment. add 'since 5.42' REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23552=23553 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224 AFFECTED FILES

D9224: Deprecate KDesktopFile::sortOrder()

volkov updated this revision to Diff 23552. volkov added a comment. make the test buildable with KDE_NO_DEPRECATED REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23551=23552 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224

D9224: Deprecate KDesktopFile::sortOrder()

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The SortOrder key is deprecated by the Desktop Entry Specification: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html

D9224: Deprecate KDesktopFile::sortOrder()

volkov added reviewers: dfaure, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9224 To: volkov, dfaure, #frameworks Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder() (authored by volkov). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8689?vs=22018=23548 REVISION DETAIL

D9794: Provide access to data returned by helper even on error replies

volkov added a comment. The error text is nonlocalized because a helper doesn't know a locale of a user process. With this change the helper may return data that can be composed into a translated message in the user process. REPOSITORY R283 KAuth REVISION DETAIL

D9794: Provide access to data returned by helper even on error replies

volkov added a comment. ping REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D9794 To: volkov, #frameworks Cc: #frameworks, michaelh, ngraham, bruns

D9794: Provide access to data returned by helper even on error replies

volkov added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D9794 To: volkov, #frameworks Cc: #frameworks

D9794: Provide access to data returned by helper even on error replies

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. volkov requested review of this revision. REVISION SUMMARY Helper may provide an additional information about an error in it. REPOSITORY R283 KAuth BRANCH

D14732: Actually allow to set the refresh rate for device statistics

volkov closed this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D14732 To: volkov, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Set the DBus property of the NetworkManager, not the internal property that doesn't

D14732: Actually allow to set the refresh rate for device statistics

volkov added reviewers: Frameworks, jgrulich. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D14732 To: volkov, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Entries in this file have the following format: [size] [mtime] [percent-encoded-directory-name] , and

D15317: trash: Fix directorysizes cache parsing

volkov added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

volkov closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

volkov added a comment. It should fix the bugs: https://bugs.kde.org/show_bug.cgi?id=331707 https://bugs.kde.org/show_bug.cgi?id=386460 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D12016: [ktexteditor] much faster positionFromCursor

volkov added a comment. Herald added subscribers: kde-frameworks-devel, kwrite-devel. I get the following warning from valgrind because of this change: ==3621== Conditional jump or move depends on uninitialised value(s) ==3621==at 0x4FF3605:

D15420: Intialize m_lastPosition

volkov accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15420 To: jtamate, #ktexteditor, cullmann, volkov Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D11786: Fix returning of data in the helper example

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:de225f87ae11: Fix returning of data in the helper example (authored by volkov). REPOSITORY R283 KAuth CHANGES

D11786: Fix returning of data in the helper example

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. volkov requested review of this revision. REVISION SUMMARY ActionReply::data() returns a value, not a reference, so its modifications will be lost. Use

D11786: Fix returning of data in the helper example

volkov added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D11786 To: volkov, #frameworks Cc: #frameworks, michaelh, ngraham

D15510: Introduce HKDF

volkov updated this revision to Diff 43125. volkov added a comment. more reinterpret_casts REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=43123=43125 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES

D15510: Introduce HKDF

volkov updated this revision to Diff 43123. volkov added a comment. fixed REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=41656=43123 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES

D15510: Introduce HKDF

volkov added inline comments. INLINE COMMENTS > dfaure wrote in qca-botan.cpp:250 > override? it still supports build with Qt 4 and without C++ 11 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15510: Introduce HKDF

volkov added a comment. BTW, should I create a review request to reformat code with astyle-kdelibs? REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15510: Introduce HKDF

volkov closed this revision. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs

volkov added a reviewer: Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D16226 To: volkov, #frameworks

D15510: Introduce HKDF

volkov added a comment. D16248 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: bcooksley, dfaure

D16251: qca-gcrypt: Add support for HKDF

volkov added reviewers: iromanov, Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D16251 To: volkov, dfaure, iromanov, #frameworks

D16250: Use lambdas instead of std::bind()

volkov added a comment. @davidedmundson Lambdas are more readable. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16250 AFFECTED FILES

D16250: Use lambdas instead of std::bind()

volkov added a reviewer: KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

volkov added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16612 To: volkov, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Auto-connections is bad practice cause object renames break code and it can't be detected at compile time. REPOSITORY

D15510: Introduce HKDF

volkov added a reviewer: Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks

D14661: Force reevaluation of Predicates if interfaces are removed

volkov added a comment. This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: volkov, apol,

D14661: Force reevaluation of Predicates if interfaces are removed

volkov added a comment. Looks like the bug is caused by removing the line "updateBackend(udi);" REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh,

D16250: Use lambdas instead of std::bind()

volkov added a comment. https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html > std::bind can be hard to read and can result in larger object files and binaries due to type information that will not be produced by equivalent lambdas. REPOSITORY R127 KWayland

D16250: Use lambdas instead of std::bind()

volkov closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin, davidedmundson Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D14661: Force reevaluation of Predicates if interfaces are removed

volkov added a comment. I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true. Adding "updateBackend(udi);" before "emit

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22809 To: volkov, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:1368 > Dunno, probably oversight or forgotten to rebase.. Looks like a rebase: https://phabricator.kde.org/D6313?vs=31197=34779=ignore-most#toc REPOSITORY R302 KIconThemes REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > kiconloader.cpp:1368 > > -if (group >= 0 && group < KIconLoader::LastGroup) { > +if (group >= 0) { > img = d->mpEffect.apply(img, group, state); Why this line reverts D12002 ? REPOSITORY

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov added a reviewer: broulik. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22809 To: volkov, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY This restores commit 49f8718446322b1722822f99f6b9f3b975ea723e

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL, which requires screen's geometry in device

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov added a reviewer: Frameworks. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22737 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov added inline comments. INLINE COMMENTS > apol wrote in kwindowsystem.cpp:75 > I don't think that it makes sense to multiply topLeft by dpr, since dpr is > local to the screen you're treating. > > How have you tested this? Only on a single screen. Thanks for notice. REPOSITORY R278

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov updated this revision to Diff 62536. volkov added a comment. fixed REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22737?vs=62531=62536 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22737 AFFECTED FILES

D24245: Add support for passing Unix file descriptors

volkov added inline comments. INLINE COMMENTS > aacid wrote in kauthunixfiledescriptor.h:33 > Does this class really need to be exported and its header installed? > > Seems like this is implementation detail? Who would use this header? It's needed to mark file descriptors in QVariantMap. Usage

D24245: Add support for passing Unix file descriptors

volkov added a comment. It will require adding the following methods: Action::setFileDescriptors() Action::addFileDescriptor() Action::fileDescriptors() ActionReply::setFileDescriptors() ActionReply::addFileDescriptor() ActionReply::fileDescriptors() and

D24245: Add support for passing Unix file descriptors

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Introduce UnixFileDescriptor class, which holds a copy of a file descriptor. Actually it's a wrapper around

D5394: KAuth integration in document saving - vol. 2

volkov added a comment. D24245 - support for passing Unix file descriptors in KAuth. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny, #ktexteditor, fvogt Cc: kde-frameworks-devel, volkov,

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

volkov added a comment. Herald added a subscriber: kde-frameworks-devel. Passing file descriptors with KAuth: D24245 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks, dfaure Cc:

D24245: Add support for passing Unix file descriptors

volkov added a dependent revision: D24259: WIP: Save file directly if possible when root privileges are required. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel, LeGast00n,

D24259: WIP: Save file directly if possible when root privileges are required

volkov added a dependency: D24245: Add support for passing Unix file descriptors. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24259 To: volkov Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D24259: WIP: Save file directly if possible when root privileges are required

volkov created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. volkov requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24259 AFFECTED FILES

D24245: Add support for passing Unix file descriptors

volkov updated this revision to Diff 66946. volkov added a comment. fix breaking API and ABI of KAuth::ActionReply REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24245?vs=66905=66946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24245

D24245: Add support for passing Unix file descriptors

volkov added a comment. DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel,

D24245: Add support for passing Unix file descriptors

volkov edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

volkov added a comment. yes, thanks REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

volkov added inline comments. INLINE COMMENTS > aacid wrote in HelperProxy.cpp:25 > i don't think we should have dbus stuff in HelperProxy, dbus stuff should be > in DBusHelperProxy, no? yes, thanks REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov,

D24245: Add support for passing Unix file descriptors

volkov updated this revision to Diff 66968. volkov added a comment. moved dbus stuff to DBusHelperProxy REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24245?vs=66946=66968 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24245 AFFECTED FILES

D5394: KAuth integration in document saving - vol. 2

volkov added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the

D24245: Add support for passing Unix file descriptors

volkov added a comment. Without UnixFileDescriptor you could try to write int fd = ... Action action(...); action.addArgument(QStringLiteral("fd"), fd); but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int. REPOSITORY R283

D24245: Add support for passing Unix file descriptors

volkov added a comment. Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData(). REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid,

D25397: Install .pri file for KAuthCore

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY And fix dependencies in .pri file for KAuth. This commit amends 65db21c6fc5369ad498b959b08ab8de19b73c5c4

D18610: Introduce KF5AuthCore

volkov added a comment. What about qmake? I came across the following error: g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so /usr/lib/x86_64-linux-gnu/libKF5Auth.so /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so /usr/lib/x86_64-linux-gnu/libQt5Core.so

D18610: Introduce KF5AuthCore

volkov added a comment. Fix for .pri: D25397 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18610 To: aacid, apol Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

volkov added a reviewer: aacid. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

volkov added a comment. Qt Core > cat qt_lib_widgets.pri | grep depends QT.widgets.depends = core gui REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26648: Improved quality of JPEG thumbnails

volkov added a comment. `imageReader.setQuality(0);` was added in https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when I ported `JpegCreator` to `QImageReader`. But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to

D26294: Allow to load widget based KCMs from kcms subdir

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REPOSITORY R295 KCMUtils BRANCH xxx REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES src/kcmoduleloader.cpp To:

D26294: Allow to load widget based KCMs from kcms subdir

volkov added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

volkov updated this revision to Diff 72393. volkov added a comment. change branch REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26294?vs=72392=72393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES

D26294: Allow to load widget based KCMs from kcms subdir

volkov added a dependent revision: D26244: Install all kcm plugins into kcms subdir. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >