Re: Qt 5.6/QtWebkit (got it, now to build it)

2016-03-20 Thread Antonio Rojas
René J. V. Bertin wrote: > I presume there must be at least one member on this list who managed to > build QtWebKit 5.6.0 (and remembers how)? See https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qt5-webkit Besides generating headers with syncqt.pl, you need

Re: QIcon::fromTheme() does not load scalable icons

2016-07-12 Thread Antonio Rojas
Olivier Churlaud wrote: > > Can you point me to the right place where to open the bug? > Already fixed in http://commits.kde.org/kiconthemes/0abf1b7a148cf6b27caea01a329631e0f1daa983 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-12 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97303 --- Works here, thanks - Antonio Rojas On Jul. 12, 2016, 12

Re: Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
by the KF5 konsole. Diffs (updated) - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas

Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas

Re: Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit c784a879eaba0babc6274bc32e761772add3d4f8 by Antonio Rojas to branch master. Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails

Review Request 129280: Fix editing autostart items

2016-10-28 Thread Antonio Rojas
://git.reviewboard.kde.org/r/129280/diff/ Testing --- Autostart items can be edited and saved again from the systemsettings autostart KCM. Thanks, Antonio Rojas

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread Antonio Rojas
: https://git.reviewboard.kde.org/r/129280/diff/ Testing --- Autostart items can be edited and saved again from the systemsettings autostart KCM. Thanks, Antonio Rojas

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread Antonio Rojas
case for /usr/local/share/applications - Antonio --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100390 -------

Re: Review Request 129280: Fix editing autostart items

2016-10-31 Thread Antonio Rojas
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit af0105c22ec80e411bf226e77f40987464e478d3 by Antonio Rojas to branch master. Bugs: 371194 https://bugs.kde.org/show_bug.cgi?id=371194 Repository: kio Description

D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6

2017-09-03 Thread Antonio Rojas
arojas created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Explicitely set LIBRARY_OUTPUT_DIRECTORY for the python module TEST PLAN kcoreaddons python bindings are

D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6

2017-09-03 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:8b4033f16c2a: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6 (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6665: Make kssl compile against OpenSSL 1.1.0

2017-08-31 Thread Antonio Rojas
arojas added a comment. In https://phabricator.kde.org/D6665#141883, @aacid wrote: > So archlinux is using https://git.archlinux.org/svntogit/packages.git/tree/trunk/kdelibs4support-openssl-1.1.patch?h=packages/kdelibs4support > > @arojas why did you guys not try to contribute that?

D9099: Update comment for new Qt API

2017-12-02 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY recursiveFiltering has been renamed to recursiveFilteringEnabled in 5.10-rc2

D9099: Update comment for new Qt API

2017-12-02 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R275:8b5b30d90253: Update comment for new Qt 5.10 API (authored by arojas). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9099?vs=23252=23253 REVISION DETAIL

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-25 Thread Antonio Rojas
arojas added a comment. Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though. REPOSITORY

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-28 Thread Antonio Rojas
arojas added a comment. In D15091#316243 , @rdieter wrote: > I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. Oh, if upstream recommends it then I guess it should cause no

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas updated this revision to Diff 40479. arojas added a comment. Use a regex to account for the case where -n an its arg are not space-separated REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40477=40479 REVISION DETAIL

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas added inline comments. INLINE COMMENTS > bruns wrote in run-sip.py:11 > Is there a gurantee `-n` and its arg are space separated? > > otherwise: > > import re > m = re.search('-n\s*(\S+)', PYQT_CONFIGURATION["sip_flags"]) > if m: > sipArgs = ['-n', m.group(1)] + sipArgs I

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-26 Thread Antonio Rojas
arojas added a comment. In D14912#315763 , @bruns wrote: > Thats on Arch? Yes REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel,

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PyQt>=5.11 is compiled with the 'PyQt5.sip'

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-26 Thread Antonio Rojas
arojas added a comment. With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-28 Thread Antonio Rojas
arojas planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sip flags used by PyQt

2018-08-28 Thread Antonio Rojas
arojas updated this revision to Diff 40570. arojas retitled this revision from "Compile python bindings with the same sipname used by PyQt" to "Compile python bindings with the same sip flags used by PyQt". arojas edited the summary of this revision. REPOSITORY R240 Extra CMake Modules

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-18 Thread Antonio Rojas
arojas added a comment. This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas,

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-27 Thread Antonio Rojas
arojas added a comment. In D15091#316150 , @rdieter wrote: > Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? Not sure if we really want to do this. For instance, bindings would get tagged with the Qt version that PyQt

D14915: Bindings: Check if bindings can be generated for a specific python version

2018-08-26 Thread Antonio Rojas
arojas added a comment. sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks Cc: arojas,

D14124: Fix qtplugins in KStandardDirs

2018-07-15 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by arojas). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14124?vs=37785=37794 REVISION DETAIL

D14124: Fix qtplugins in KStandardDirs

2018-07-15 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PLUGIN_INSTALL_DIR already contains the /plugins/

D13990: Honor BUILD_TESTING

2018-07-19 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R308:a3847124d53f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13990?vs=37370=38061 REVISION DETAIL

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-14 Thread Antonio Rojas
arojas added a comment. This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48 REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808

D14915: Bindings: Check if bindings can be generated for a specific python version

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14914: Bindings: Use python version matching the found clang python module

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14914 To: bruns, #frameworks, arojas Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13948: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R236:00175c834fb8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13948?vs=37314=37341 REVISION DETAIL

D13983: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13989: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13990: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only builds tests if BUILD_TESTING is on TEST PLAN

D13991: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dvratil. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13992: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13993: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: alexmerry, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST

D13986: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R301:e7f4466de3b5: Honor BUILD_TESTING (authored by arojas). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13986?vs=37366=37374 REVISION DETAIL

D13992: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R495:f03e2db94959: Honor BUILD_TESTING (authored by arojas). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13992?vs=37372=37375 REVISION DETAIL

D13991: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R312:6239b73d5fa8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R312 KXmlRpcClient CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13991?vs=37371=37376 REVISION DETAIL

D13989: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R307:1599ed797389: Honor BUILD_TESTING (authored by arojas). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13989?vs=37369=37377 REVISION DETAIL

D13987: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R252:5ec96d346322: Honor BUILD_TESTING (authored by arojas). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13987?vs=37367=37379 REVISION DETAIL

D13947: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R237:00646c782459: Honor BUILD_TESTING (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13947?vs=37313=37380 REVISION DETAIL

D13985: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b3cc8b84714d: Honor BUILD_TESTING (authored by arojas). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13985?vs=37364=37381 REVISION DETAIL

D13980: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R6:569b588a5ede: Honor BUILD_TESTING (authored by arojas). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13980?vs=37354=37389 REVISION DETAIL

D13977: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R279:d9404a942334: Honor BUILD_TESTING (authored by arojas). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13977?vs=37351=37391 REVISION DETAIL

D13993: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R316:a4cb54ea637a: Honor BUILD_TESTING (authored by arojas). REPOSITORY R316 KMediaPlayer CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13993?vs=37373=37392 REVISION DETAIL

D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R244:bb56c91ede0f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13941?vs=37307=37393 REVISION DETAIL

D13943: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R243:6c2b95f4c3be: Honor BUILD_TESTING (authored by arojas). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13943?vs=37309=37394 REVISION DETAIL

D13946: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R270:b6c89b7e7b08: Honor BUILD_TESTING (authored by arojas). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13946?vs=37312=37395 REVISION DETAIL

D13949: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R284:b15446a2288d: Honor BUILD_TESTING (authored by arojas). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13949?vs=37315=37397 REVISION DETAIL

D13945: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R283:b08104d00a44: Honor BUILD_TESTING (authored by arojas). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13945?vs=37311=37398 REVISION DETAIL

D13950: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R273:50c20f8c7d46: Honor BUILD_TESTING (authored by arojas). REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13950?vs=37316=37399 REVISION DETAIL

D13951: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R265:6657decb1d4b: Honor BUILD_TESTING (authored by arojas). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13951?vs=37317=37400 REVISION DETAIL

D13952: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R278:432169e7acc8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13952?vs=37319=37401 REVISION DETAIL

D13953: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R285:d1094af0e34c: Honor BUILD_TESTING (authored by arojas). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13953?vs=37320=37402 REVISION DETAIL

D13954: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R271:4349c759a4e4: Honor BUILD_TESTING (authored by arojas). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13954?vs=37321=37403 REVISION DETAIL

D13955: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R268:55377a85a70f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13955?vs=37322=37405 REVISION DETAIL

D13956: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R276:0bfc8d73ab03: Honor BUILD_TESTING (authored by arojas). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13956?vs=37323=37406 REVISION DETAIL

D13960: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R294:54ed625ac551: Honor BUILD_TESTING (authored by arojas). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13960?vs=37327=37407 REVISION DETAIL

D13962: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R245:94b5c7e0dd40: Honor BUILD_TESTING (authored by arojas). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13962?vs=37330=37408 REVISION DETAIL

D13959: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R263:3a058181c8ef: Honor BUILD_TESTING (authored by arojas). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13959?vs=37326=37410 REVISION DETAIL

D13964: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R289:4bf77fb4eb99: Honor BUILD_TESTING (authored by arojas). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13964?vs=37332=37411 REVISION DETAIL

D13963: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R288:08d6672f5928: Honor BUILD_TESTING (authored by arojas). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13963?vs=37331=37409 REVISION DETAIL

D13975: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R291:d962a0d04275: Honor BUILD_TESTING (authored by arojas). REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13975?vs=37349=37413 REVISION DETAIL

D13976: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R292:6e1110f1df1e: Honor BUILD_TESTING (authored by arojas). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13976?vs=37350=37415 REVISION DETAIL

D13983: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R314:2d4d34b5ef32: Honor BUILD_TESTING (authored by arojas). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13983?vs=37361=37416 REVISION DETAIL

D13965: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R311:fd8f94d86359: Honor BUILD_TESTING (authored by arojas). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13965?vs=37333=37417 REVISION DETAIL

D13973: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13973 To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13985: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13977: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: mirko, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests and benchmarks if BUILD_TESTING

D13982: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13974: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13975: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13987: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: afiestas, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST

D13957: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R302:f059164f8aba: Honor BUILD_TESTING (authored by arojas). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13957?vs=37324=37513 REVISION DETAIL

D13973: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R296:fdd04af53dae: Honor BUILD_TESTING (authored by arojas). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13973?vs=37347=37515 REVISION DETAIL

D13982: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R242:061588dcd6cc: Honor BUILD_TESTING (authored by arojas). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13982?vs=37359=37514 REVISION DETAIL

D13944: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R238:6303431a9405: Honor BUILD_TESTING (authored by arojas). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13944?vs=37310=37512 REVISION DETAIL

D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13943: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13944: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: ltoscano. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if

D13945: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests ib BUILD_TESTING is on TEST PLAN

D13946: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13947: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: mdawson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST

D13948: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13949: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13950: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13951: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13952: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13952: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas updated this revision to Diff 37319. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13952?vs=37318=37319 REVISION DETAIL https://phabricator.kde.org/D13952 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh,

D13953: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13954: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13955: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13956: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: davidedmundson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on

  1   2   >