D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment. Ping? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg Cc: filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis,

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment. Thanks. I will apply when when I have time! REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg, ngraham Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros,

D17924: Better plasma-media-center icon

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Forgot to change plasma-media-center in D17919 , this

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY The current icons with an abstract desktop wallpaper in the background have a very hard

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17923 To: GB_2, #vdg, #breeze Cc: #breeze, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18379: Add tools icon

2019-01-19 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R266 Breeze Icons BRANCH tools-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg, GB_2 Cc: GB_2, rooty,

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2 Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham,

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Björn Feber
GB_2 added a comment. It should fall back to `preferences-desktop-plasma-theme`, because it fits better than `preferences-desktop-theme` and it is also what we use now. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis,

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Frameworks, VDG. GB_2 added projects: Frameworks, VDG. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 399163 This changes the default sort ordering of the download dialog to

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef,

D17355: Align Plasma QML button content in center if it has an icon

2018-12-14 Thread Björn Feber
GB_2 planned changes to this revision. GB_2 added a comment. In D17355#376973 , @mart wrote: > in general, buttons with icons may be stacked vertically, which for me makes a general -1 But it's not consistent with Qt Widgets and looks

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Aligns the Plasma QML Button content in the center if it

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46907. GB_2 added a comment. Improved code. How `qmlscene tests/components/button.qml` looks like: F6457867: Plasma QML Button Content Align qmlscene (1).png For some reason "elide" doesn't work... REPOSITORY

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pitel,

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 added a comment. It works properly, no matter how big the button is or if have an icon or not. In my opinion we should leave it how it is now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg,

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46918. GB_2 added a comment. I can't figure out how to make "elide" work without using `Layout.fillWidth`. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355?vs=46907=46918 REVISION DETAIL

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 added a comment. Hmm... then I give up. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen,

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46920. GB_2 added a comment. Improve menu button. F6458257: Plasma QML Button Content Align qmlscene (3).png REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47081. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47078=47081 REVISION DETAIL https://phabricator.kde.org/D17419

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: Breeze. GB_2 added projects: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 401646 F6462086: private-mode Breeze Icon.png

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 added a comment. In D17419#372992 , @filipf wrote: > Very Chrome/-ium like :) > > F6462196: image.png > > Maybe expanding the bottom line just a tad more would make it more obvious it's a

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47093. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47081=47093 REVISION DETAIL https://phabricator.kde.org/D17419

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Is this better? F6463614: private-mode Breeze Icon (2).png F6463613: private-mode.svg REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2,

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46677. GB_2 added a comment. Improve code (pass `this` as parent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46637=46677 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FILES

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna,

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-03 Thread Björn Feber
GB_2 added a comment. Ok. Email: febe...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26,

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17281#370253 , @ngraham wrote: > @GB_2, can you provide an email address so we can land this for you? Thanks! How can I provide an email address in the Phabriactor webinterface? I already provided an email in

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh,

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47145. GB_2 retitled this revision from "Add private-mode icon" to "Add view-private icon". GB_2 added a comment. Change name to the more common "view-private" and add a symlink for the symbolic icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? It's for compatibility, because other icons in Breeze and also other icon themes do it.

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. How is that even possible? There is no 48 px size icon and the one you showed was and older version of the icon... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf,

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Oh, thanks for reminding me about Cuttlefish... I forgot about it, but now I don't need a QML for testing icons anymore :P REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis,

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo,

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47147. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons (wider hat brim). It's perfect now :-) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47145=47147 REVISION DETAIL

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Wait, but I thought if the hat brim is wider, the margins are not big enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel,

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 updated this revision to Diff 46862. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355?vs=46856=46862 REVISION DETAIL https://phabricator.kde.org/D17355 AFFECTED FILES src/declarativeimports/plasmastyle/ButtonStyle.qml To:

D17924: Better plasma-media-center icon

2019-01-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b66a65bac264: Better plasma-media-center icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48596=48657 REVISION DETAIL

D17924: Better plasma-media-center icon

2019-01-03 Thread Björn Feber
GB_2 updated this revision to Diff 48596. GB_2 added a comment. Remove dark radial gradient REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48555=48596 BRANCH better-plasma-media-center-icon (branched from master) REVISION DETAIL

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4679f600075: [kio] Add ellipsis to search label in Cookies section (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R276:649157422e4e: [kitemviews] Change the search in Desktop Behavior/Activities to more in line… (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R276 KItemViews CHANGES

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R295:24ba84914a84: [kcmutils] Add ellipsis to search labels in KPluginSelector (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improves the screen background gradient in the multimedia related icons to make them look

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber
GB_2 updated this revision to Diff 48538. GB_2 added a comment. Update other multimedia related icons too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17919?vs=48537=48538 BRANCH better-multimedia-category-icon (branched from master) REVISION

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Björn Feber
GB_2 added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH better-kolf-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17969 To: trickyricky26, #vdg, #kde_games, ndavis Cc: GB_2, ndavis, yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-01 Thread Björn Feber
GB_2 updated this revision to Diff 46637. GB_2 edited the test plan for this revision. GB_2 added a comment. Improved code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46615=46637 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-01 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna,

D20147: Improve executable dialog buttons' icons

2019-03-31 Thread Björn Feber
GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-execute-dialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20147 To: ngraham, #vdg, GB_2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19923: Improve the KCM error message

2019-03-21 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R295:e51e8e1e34fd: Improve the KCM error message (authored by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19923?vs=54437=54479 REVISION DETAIL

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 added a comment. In D20226#442882 , @ngraham wrote: > Also, could we create a 22x22 version too? How can you efficiently do that without having to realign everything to the new grid manually? REPOSITORY R266 Breeze Icons

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 updated this revision to Diff 55347. GB_2 added a comment. Move bell's pendulum REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55339=55347 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION

D17355: Align Plasma QML button content in center if it has an icon

2019-04-03 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh,

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
GB_2 updated this revision to Diff 55420. GB_2 added a comment. Remake icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55347=55420 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 added a comment. In D20226#442841 , @ngraham wrote: > +1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (`preferences-desktop-notification-bell`) is triggering my OCD. :) Do

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406121 Needed for the upcoming do not disturb mode and overhauled notifcations.

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:47af5254b039: Add notifications and notifications-disabled icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55420=55451

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

2019-04-01 Thread Björn Feber
GB_2 added a comment. In D20166#441715 , @ndavis wrote: > Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more

D20367: Add alternatives icon

2019-04-07 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20367: Add alternatives icon

2019-04-07 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add a more appropriate icon for "Alternative Widgets". TEST PLAN Search for "alternatives" in

D20367: Add alternatives icon

2019-04-08 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

2019-04-08 Thread Björn Feber
GB_2 updated this revision to Diff 55755. GB_2 added a comment. Improve icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20367?vs=55713=55755 BRANCH add-alternatives-icon (branched from master) REVISION DETAIL

D20342: Update KDE logo to be closer to original

2019-04-08 Thread Björn Feber
GB_2 added a reviewer: KDE Promo. GB_2 added a subscriber: KDE Promo. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20342 To: GB_2, #vdg, #kde_promo Cc: #kde_promo, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-14 Thread Björn Feber
GB_2 updated this revision to Diff 53883. GB_2 added a comment. Don't turn real files into symlinks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53882=53883 REVISION DETAIL https://phabricator.kde.org/D19733 AFFECTED FILES

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-14 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-14 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons". REPOSITORY R266 Breeze Icons REVISION DETAIL

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-14 Thread Björn Feber
GB_2 updated this revision to Diff 53882. GB_2 added a comment. Update preferences-desktop-theme-applications icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53813=53882 BRANCH add-preferences-desktop-theme-windows-icon (branched from

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-17 Thread Björn Feber
GB_2 added a comment. In D19733#432498 , @bcooksley wrote: > This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable) > > See

D19791: Make KFontRequester consistent

2019-03-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Make the KFontRequester widget consistent with the new font selection style in the Fonts

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-14 Thread Björn Feber
GB_2 added a comment. In D19733#431139 , @ndavis wrote: > I think `preferences-desktop-theme-applications` is fine, but `preferences-desktop-theme-windowdecorations` looks odd with that border. F6691545: Screenshot_20190314_135511.png

D19733: Add preferences-desktop-theme-applications icon

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-windows icon" to "Add preferences-desktop-theme-applications icon". GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds an application style icon, adds a symlink and renames the old one to

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons". REPOSITORY R266 Breeze Icons REVISION DETAIL

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 updated this revision to Diff 53813. GB_2 added a comment. Rename files and make icons more accurate REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53811=53813 BRANCH add-preferences-desktop-theme-windows-icon (branched from master)

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-applications icon" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon". GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D19923: Improve the KCM error message

2019-03-20 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve the KCM error message. TEST PLAN Open a broken KCM. To get one, remove for

D19791: Make KFontRequester consistent

2019-03-15 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R236:0c04c4c8c450: Make KFontRequester consistent (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19791?vs=53968=53969#toc REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-15 Thread Björn Feber
GB_2 added a comment. In D19733#431693 , @ngraham wrote: > So now this happens: > > F6693594: Weird.gif > > Does the category Icon in System Settings itself need to be updated too? Did you

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-15 Thread Björn Feber
GB_2 updated this revision to Diff 53936. GB_2 added a comment. Use old style for preferences-desktop-theme-windowdecorations REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53883=53936 BRANCH arcpatch-D19733 REVISION DETAIL

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-07 Thread Björn Feber
GB_2 added a comment. In D18702#407259 , @ngraham wrote: > Can you improve the font selection icon in a separate patch please? Is it bad that the branch name is wrong then though? REPOSITORY R266 Breeze Icons REVISION DETAIL

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-07 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. Great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2 Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber
GB_2 added a dependent revision: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber
GB_2 removed a dependent revision: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-08 Thread Björn Feber
GB_2 updated this revision to Diff 51167. GB_2 added a comment. Revert font selection icon change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18702?vs=50782=51167 BRANCH remove-monochrome-font-preferences-icon-and-improve-font-selection-icon

D18702: Remove monochrome font preferences icon

2019-02-08 Thread Björn Feber
GB_2 retitled this revision from "Remove monochrome font preferences icon and improve font selection icon" to "Remove monochrome font preferences icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel,

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber
GB_2 added a dependency: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18855: Improve font selection icon

2019-02-08 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improves the font selection icon by making the three dots black/white instead of orange.

D18702: Remove monochrome font preferences icon

2019-02-08 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5c94b245d1a: Remove monochrome font preferences icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18702?vs=51167=51200 REVISION DETAIL

D18855: Improve font selection icon

2019-02-08 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:11e51771626b: Improve font selection icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18855?vs=51195=51196 REVISION DETAIL

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R236:d5cdd29f9630: Use correct KStandardGuiItem no icon (authored by GB_2). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19081?vs=51860=51871 REVISION DETAIL

D19094: Use KCM name in KCM header

2019-02-17 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Change it for KCMs not opened through the system settings too, similar to D19006

D19094: Use KCM name in KCM header

2019-02-17 Thread Björn Feber
GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D19094 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19094: Use KCM name in KCM header

2019-02-18 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R295:a4041266241f: Use KCM name in KCM header (authored by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19094?vs=51906=51977 REVISION DETAIL

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D19081 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the "no" icon to the correct one that is used in other places too. Before:

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-05 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham,

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-07 Thread Björn Feber
GB_2 added a comment. @rooty just copy a different 16px font icon like `format-font-size-more` and remove the other things than the A and align it in the horizontal center. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis Cc: GB_2,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-01 Thread Björn Feber
GB_2 added a comment. Good idea, but I think it's a bit too dark. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-01 Thread Björn Feber
GB_2 added a comment. In D18649#403326 , @ngraham wrote: > Here's 0.65 opacity instead: F6581631: 0.65 opacity.png Ok, the previous was better because you could see the red trash icon better.

  1   2   3   4   >