D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55891. GB_2 added a comment. Use old style, better recognizable at small sizes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55889&id=55891 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55902. GB_2 added a comment. Add 22px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55891&id=55902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/

D20417: Add invokable public API for emitting contextualActionsAboutToShow

2019-04-10 Thread Björn Feber
GB_2 added a comment. Yeah, thanks a lot! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc: GB_2, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55933. GB_2 added a comment. Redesign icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55902&id=55933 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/act

D20417: Add invokable public API for emitting contextualActionsAboutToShow

2019-04-10 Thread Björn Feber
GB_2 added a dependent revision: D17410: Add alternatives button to applet configuration in panel edit mode. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc: GB_2, broulik, kde-frameworks-

D20426: Improve "widget-alternatives" icon

2019-04-12 Thread Björn Feber
GB_2 added a dependent revision: D17410: Add alternatives button to applet configuration in panel edit mode. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-13 Thread Björn Feber
GB_2 updated this revision to Diff 56111. GB_2 added a comment. Re-clean SVGs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55933&id=56111 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/act

D20426: Improve "widget-alternatives" icon

2019-04-13 Thread Björn Feber
GB_2 added a comment. In D20426#449101 , @ndavis wrote: > Can you flip the direction of the 16px version? I know the icon you're copying the design of is also like this, but I think it needs to be fixed. Ok, will do that here. The other s

D20426: Improve "widget-alternatives" icon

2019-04-13 Thread Björn Feber
GB_2 updated this revision to Diff 56127. GB_2 added a comment. Flip 16px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=56111&id=56127 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark

D20426: Improve "widget-alternatives" icon

2019-04-13 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-13 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d1ccdfcac565: Improve "widget-alternatives" icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=56127&id=56135 REVISION DETAIL

D20536: Use consistent default Kickoff user icon

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add the 22px default user icon that is used everywhere else. F6771466: Consistent Default

D20536: Use consistent default Kickoff user icon

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56196. GB_2 added a comment. Use symlinks instead of copying the icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56195&id=56196 BRANCH use-consistent-default-kickoff-user-icon (branched from master)

D20536: Use consistent default Kickoff user icon

2019-04-14 Thread Björn Feber
GB_2 added a comment. In D20536#450246 , @ngraham wrote: > This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd. Ok, then we could rename that 128px icon to something different. REPOSITO

D20536: Use consistent default Kickoff user icon

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56263. GB_2 added a comment. Change name of blue user icon, will need to make a patch for `user-manager` too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56196&id=56263 BRANCH use-consistent-default-kic

D20536: Use consistent default Kickoff user icon

2019-04-14 Thread Björn Feber
GB_2 added a dependency: D20564: Change default user avatar. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20536 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

2019-04-15 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20283 To: ngraham, #plasma, mart Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

2019-04-20 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add an alternative to `list-remove`, which needs to be next to `list-add` for context and `edit-d

D20700: Add "edit-remove" icon

2019-04-20 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

2019-04-20 Thread Björn Feber
GB_2 added a comment. Oops, forgot that `paint-none` already exists, which looks like this. I will just make a symlink then. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

2019-04-21 Thread Björn Feber
GB_2 updated this revision to Diff 56651. GB_2 added a comment. Use symlinks: `edit-remove` -> `paint-none` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56634&id=56651 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL

D20700: Add "edit-remove" icon symlink

2019-04-21 Thread Björn Feber
GB_2 retitled this revision from "Add "edit-remove" icon" to "Add "edit-remove" icon symlink". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

2019-04-21 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

2019-04-21 Thread Björn Feber
GB_2 added a comment. In D20700#453562 , @ndavis wrote: > Why does `list-remove` need an alternative? > alternative to list-remove, which needs to be next to list-add for context `list-remove` is just a minus icon, which has no

D20700: Add "edit-remove" icon symlink

2019-04-21 Thread Björn Feber
GB_2 added a comment. In D20700#453658 , @ndavis wrote: > We have a problem where we don't use consistent iconography for "remove". Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red X and sometimes it's a red trash

D20536: Use consistent default Kickoff user icon

2019-04-21 Thread Björn Feber
GB_2 updated this revision to Diff 56677. GB_2 added a comment. Fix diff REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56263&id=56677 BRANCH arcpatch-D20536_1 REVISION DETAIL https://phabricator.kde.org/D20536 AFFECTED FILES icons-da

D20536: Use consistent default Kickoff user icon

2019-04-21 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1c6e30d312c7: Use consistent default Kickoff user icon (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20536?vs=56677&id=56678#toc REPOSITORY R266 Breeze Icons CHANGES SI

D20700: Add "edit-remove" icon symlink

2019-04-22 Thread Björn Feber
GB_2 updated this revision to Diff 56707. GB_2 added a comment. Add 22px version of `paint-none` and add symlink for it REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56651&id=56707 BRANCH add-edit-remove-icon (branched from master) REVISI

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-22 Thread Björn Feber
GB_2 retitled this revision from "Add "edit-remove" icon symlink" to "Add "edit-remove" icon symlink and add 22px version of "paint-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-22 Thread Björn Feber
GB_2 updated this revision to Diff 56747. GB_2 added a comment. Fix icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56707&id=56747 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20700

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-23 Thread Björn Feber
GB_2 updated this revision to Diff 56834. GB_2 added a comment. (Hopefully) fix icons and add 22px version of `edit-none` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56747&id=56834 BRANCH add-edit-remove-icon (branched from master) REVI

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
GB_2 retitled this revision from "Add "edit-remove" icon symlink and add 22px version of "paint-none"" to "Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, n

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
GB_2 updated this revision to Diff 56835. GB_2 added a comment. Fix one 16px path point REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56834&id=56835 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7c6559bdb86f: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit… (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

2019-04-24 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Icon themes that don't have the icon will now fall back to `edit-delete`. TEST PLAN Search for

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

2019-04-24 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:2cbbfe2351a6: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other… (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20791?vs=56905&id=56907#toc REPO

D19812: Add a web page to view and compare icons of different sizes

2019-04-25 Thread Björn Feber
GB_2 added a comment. I personally think this could be quite useful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20827: Reword some text, a couple clean ups, add a separator

2019-04-25 Thread Björn Feber
GB_2 added reviewers: Frameworks, VDG. GB_2 added a project: VDG. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squea

D20827: Reword some text, a couple clean ups, add a separator

2019-04-25 Thread Björn Feber
GB_2 accepted this revision. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg, GB_2 Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPet

D20934: Rename file dialog "Filter" label text to "Type"

2019-05-01 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Frameworks, Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 79903 The term "Filter" is a bit strange for choosing a file type, "F

D20934: Rename file dialog "Filter" label text to "Type"

2019-05-01 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20934 To: GB_2, #frameworks, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, #vdg, #plasma, kde-frameworks-devel, #frameworks, michaelh, ngraham, bruns

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 commandeered this revision. GB_2 added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, er

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 updated this revision to Diff 59081. GB_2 added a comment. Change reveal password button logic REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=26701&id=59081 BRANCH change-reveal-password-button-logic (branched from master

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 added a comment. Changed `onClicked` to `onPressedChanged` REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisan

D10362: Change reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 retitled this revision from "Swap reveal password button logic" to "Change reveal password button logic". REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma

D10362: Change reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature li

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-01 Thread Björn Feber
GB_2 updated this revision to Diff 46637. GB_2 edited the test plan for this revision. GB_2 added a comment. Improved code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46615&id=46637 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FI

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-01 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46677. GB_2 added a comment. Improve code (pass `this` as parent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46637&id=46677 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FILES src/widgets/kbui

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17281#370253 , @ngraham wrote: > @GB_2, can you provide an email address so we can land this for you? Thanks! How can I provide an email address in the Phabriactor webinterface? I already provided an email in my

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-03 Thread Björn Feber
GB_2 added a comment. Ok. Email: febe...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michae

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Aligns the Plasma QML Button content in the center if it

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 updated this revision to Diff 46862. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355?vs=46856&id=46862 REVISION DETAIL https://phabricator.kde.org/D17355 AFFECTED FILES src/declarativeimports/plasmastyle/ButtonStyle.qml To: G

D17355: Align Plasma QML button content in center if it has an icon

2018-12-04 Thread Björn Feber
GB_2 added a comment. It works properly, no matter how big the button is or if have an icon or not. In my opinion we should leave it how it is now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, k

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46907. GB_2 added a comment. Improved code. How `qmlscene tests/components/button.qml` looks like: F6457867: Plasma QML Button Content Align qmlscene (1).png For some reason "elide" doesn't work... REPOSITORY R2

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, michael

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46918. GB_2 added a comment. I can't figure out how to make "elide" work without using `Layout.fillWidth`. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355?vs=46907&id=46918 REVISION DETAIL https:

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 added a comment. Hmm... then I give up. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pite

D17355: Align Plasma QML button content in center if it has an icon

2018-12-05 Thread Björn Feber
GB_2 updated this revision to Diff 46920. GB_2 added a comment. Improve menu button. F6458257: Plasma QML Button Content Align qmlscene (3).png REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: Breeze. GB_2 added projects: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 401646 F6462086: private-mode Breeze Icon.png

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47081. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47078&id=47081 REVISION DETAIL https://phabricator.kde.org/D17419 AFFEC

D17419: Add private-mode icon

2018-12-07 Thread Björn Feber
GB_2 added a comment. In D17419#372992 , @filipf wrote: > Very Chrome/-ium like :) > > F6462196: image.png > > Maybe expanding the bottom line just a tad more would make it more obvious it's a privat

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Is this better? F6463614: private-mode Breeze Icon (2).png F6463613: private-mode.svg REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47093. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47081&id=47093 REVISION DETAIL https://phabricator.kde.org/D17419 AFFEC

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47106. GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47093&id=47106 REVISION DETAI

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. How is that even possible? There is no 48 px size icon and the one you showed was and older version of the icon... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham,

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Oh, thanks for reminding me about Cuttlefish... I forgot about it, but now I don't need a QML for testing icons anymore :P REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf,

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, f

D17419: Add private-mode icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47143. GB_2 edited the summary of this revision. GB_2 added a comment. Only provide correct 16px icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47106&id=47143 REVISION DETAIL https://phabricator.kde

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47145. GB_2 retitled this revision from "Add private-mode icon" to "Add view-private icon". GB_2 added a comment. Change name to the more common "view-private" and add a symlink for the symbolic icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDAT

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, croz

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. Wait, but I thought if the hat brim is wider, the margins are not big enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. I think I'll leave it how it is. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky2

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 updated this revision to Diff 47147. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons (wider hat brim). It's perfect now :-) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47145&id=47147 REVISION DETAIL h

D17419: Add view-private icon

2018-12-08 Thread Björn Feber
GB_2 added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? It's for compatibility, because other icons in Breeze and also other icon themes do it. REP

D17355: Align Plasma QML button content in center if it has an icon

2018-12-14 Thread Björn Feber
GB_2 planned changes to this revision. GB_2 added a comment. In D17355#376973 , @mart wrote: > in general, buttons with icons may be stacked vertically, which for me makes a general -1 But it's not consistent with Qt Widgets and looks kin

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Frameworks, VDG. GB_2 added projects: Frameworks, VDG. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 399163 This changes the default sort ordering of the download dialog to "Mo

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef, ngra

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment. Ping? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg Cc: filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, firef,

D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment. Thanks. I will apply when when I have time! REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg, ngraham Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improves the screen background gradient in the multimedia related icons to make them look

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber
GB_2 updated this revision to Diff 48538. GB_2 added a comment. Update other multimedia related icons too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17919?vs=48537&id=48538 BRANCH better-multimedia-category-icon (branched from master) REVISION

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY The current icons with an abstract desktop wallpaper in the background have a very hard to

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17923 To: GB_2, #vdg, #breeze Cc: #breeze, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17924: Better plasma-media-center icon

2019-01-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Forgot to change plasma-media-center in D17919 , this

D17924: Better plasma-media-center icon

2019-01-03 Thread Björn Feber
GB_2 updated this revision to Diff 48596. GB_2 added a comment. Remove dark radial gradient REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48555&id=48596 BRANCH better-plasma-media-center-icon (branched from master) REVISION DETAIL https

D17924: Better plasma-media-center icon

2019-01-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b66a65bac264: Better plasma-media-center icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48596&id=48657 REVISION DETAIL htt

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Björn Feber
GB_2 added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH better-kolf-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17969 To: trickyricky26, #vdg, #kde_games, ndavis Cc: GB_2, ndavis, yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4679f600075: [kio] Add ellipsis to search label in Cookies section (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabr

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R276:649157422e4e: [kitemviews] Change the search in Desktop Behavior/Activities to more in line… (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R276 KItemViews CHANGES S

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R295:24ba84914a84: [kcmutils] Add ellipsis to search labels in KPluginSelector (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE ht

D18379: Add tools icon

2019-01-19 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R266 Breeze Icons BRANCH tools-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg, GB_2 Cc: GB_2, rooty, kde-framework

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2 Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, br

<    1   2   3   4   >