D4363: Don't set gnu style parameter with Clang and MSVC

cullmann added a comment. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Is this still relevant? If yes, from the diff, looks ok for me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4363

D24355: TypeScript: update grammar and fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems fine. Does typescript-react.xml lack a version update? REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D24355

D24357: KateModeMenuList: force the vertical position above the button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with that. REPOSITORY R39 KTextEditor BRANCH menu-vertical-position REVISION DETAIL https://phabricator.kde.org/D24357 To: nibags, #ktexteditor, cullmann, dhaumann Cc:

D24492: [FilteredDirIterator] Reduce stack pressure

cullmann added a comment. Yes, I think you want the concept of a loop with continue. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24442: ensure winId() not called on non-native widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R252:93c19fbfa125: ensure winId() not called on non-native widgets (authored by cullmann). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. It would be great to have that in 5.63, or I am too late? REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. If nobody objects will push that later, without any window on secondary screen is garbage after palette change. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik,

D24442: ensure winId() not called on non-native widgets

cullmann added a reviewer: dfaure. cullmann added a comment. If possible I would like to have this in 5.63, as otherwise any color scheme change will make all Qt applications on the non-primary screen unusable with scaling. REPOSITORY R252 Framework Integration REVISION DETAIL

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. Can I merge this? The effect is quiet "evil" here ;=) REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a reviewer: Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. For KRun for me the calls there look properly guarded. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. You mean if there are such calls? Can do. Btw., Gwenview doesn't render for me any pictures on the second screen either, but I found there no suspicious code :/ REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To:

D24442: ensure winId() not called on non-native widgets

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY if we do that, window will be corrupted BUG: 412675 TEST PLAN Use Kate, change color theme on a second screen

D24403: Small performance improvements suggested by clang-tidy

cullmann accepted this revision. cullmann added a comment. I think this is ok to merge, I don't see the issue with the QRegExp. (I understand that it stores it result in mutable data in the object, but that patch didn't alter this, just avoids the copying of the regex before this happens,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen Cc:

D24378: WordDetect rule: detect delimiters at the inner edge of the string

cullmann added a comment. Seems reasonable, do we need some doc updates? Or some more verbose description in the XSD? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen

D24311: Remove useless variable

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yeah, looks useless. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D24311 To: aacid, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n,

D24306: Highlight GeoJSON files as if they were plain JSON

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea. REPOSITORY R216 Syntax Highlighting BRANCH basic-geojson-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D24306 To: gszymaszek, cullmann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

This revision was automatically updated to reflect the committed changes. Closed by commit R216:72683653db72: Add syntax highlighting for SubRip Text (SRT) Subtitles (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D24210: KadeModeMenuList: fix memory leaks and others

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f1d9f086da6f: KadeModeMenuList: fix memory leaks and others (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D24210: KadeModeMenuList: fix memory leaks and others

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Like that better, thanks! REPOSITORY R39 KTextEditor BRANCH fix-mode-menu REVISION DETAIL https://phabricator.kde.org/D24210 To: nibags, #ktexteditor, dhaumann, cullmann Cc:

D24287: cleanup dbus related objects early enough to avoid hang on program exit

This revision was automatically updated to reflect the committed changes. Closed by commit R288:301b33daff31: cleanup dbus related objects early enough to avoid hang on program exit (authored by cullmann). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D24287: cleanup dbus related objects early enough to avoid hang on program exit

cullmann added a comment. This should be a replacement for D2545 . REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D24287 To: cullmann, dfaure, kfunk Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24287: cleanup dbus related objects early enough to avoid hang on program exit

cullmann created this revision. cullmann added reviewers: dfaure, kfunk. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY workaround for issue seen on Windows that at the moment requires Qt patch

D24210: KadeModeMenuList: fix memory leaks and others

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24210 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D24210: KadeModeMenuList: fix memory leaks and others

cullmann added a comment. I would prefer just some QString m_searchName, strings are shared anyways, no need to try to save there a few bytes but then introduce more heap allocated things. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24210 To: nibags,

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. Ok, ah, no longer applies cleanly, must redo some things it seems. Will create a new patch for submission. REVISION DETAIL https://phabricator.kde.org/D2545 To: kfunk, vonreth, dfaure Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. David, could we apply this patch, even with the workaround in the Qt patch in craft to have a better experience for people not patching their Qt? REVISION DETAIL https://phabricator.kde.org/D2545 To: kfunk, vonreth, dfaure Cc: cullmann, thiago, albertvaka,

D24226: bitbake: handle embedded shell and python

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable + has test => accept ;=) REPOSITORY R216 Syntax Highlighting BRANCH syntax-bitbake (branched from master) REVISION DETAIL https://phabricator.kde.org/D24226

D24210: KadeModeMenuList: fix memory leaks and others

cullmann added a comment. I must confess the m_searchName deletion condition seems for me too be overly complex. Given QString copying is cheap, can't we just always set that and store it inline as value? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24210

D24179: Fix skipOffset with dynamic RegExpr

cullmann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH d399388 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24179 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D24180: Jam: fix identifier in a SubRule

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH jam_check_ident (branched from master) REVISION DETAIL https://phabricator.kde.org/D24180 To: jpoelen, cullmann Cc: cullmann,

D24179: Fix skipOffset with dynamic RegExpr

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks I think it would be nice to have a comment added to the 612 ​ 613 /** 613 ​/** 614* no match 614 ​

D24176: Add syntax definition for Perl6

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. This is incredible! I have no idea about Perl 6, but this looks cool given the example you added. Only nitpick: increase the perl.xml version, then push. Thanks a lot for

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH use-qicon-implicitly-shared REVISION DETAIL https://phabricator.kde.org/D24166 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems useful, maches the int configPages()/configPage(int number, QWidget *parent) api REPOSITORY R39 KTextEditor BRANCH expose-show-plugin-config-page REVISION DETAIL

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. Given we always needs to patch Qt for this, shall we not use this workaround in our code instead? I think the other "it always hangs" stuff in Qt bug https://bugreports.qt.io/browse/QTBUG-49870 got fixed. Would this patch here making patching Qt not needed for

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care, I was always to lazy too tackle that :/ REPOSITORY R39 KTextEditor BRANCH port_child REVISION DETAIL https://phabricator.kde.org/D23960 To: dfaure,

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good, thanks for Windows patches. REPOSITORY R39 KTextEditor BRANCH modemenu-search REVISION DETAIL https://phabricator.kde.org/D23935 To: nibags, #ktexteditor, cullmann,

D23832: Backup on save: Support time and date string replacements

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:2594 > Shall we wrap all this with > > if (!(backupSuffix.isEmpty() && backupPrefix.isEmpty())) {...} Why not, saves useless evals. REPOSITORY R39 KTextEditor BRANCH bug REVISION DETAIL

D23832: Backup on save: Support time and date string replacements

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks fine. REPOSITORY R39 KTextEditor BRANCH bug REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: ngraham, kwrite-devel, kde-frameworks-devel,

D23861: Port away from Qt's foreach: loop directly over pimpl member

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks more consistent. REPOSITORY R263 KXmlGui BRANCH portloopdirectlyoverdmembers REVISION DETAIL https://phabricator.kde.org/D23861 To: kossebau, dfaure, cullmann Cc:

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH morecountoversplit REVISION DETAIL https://phabricator.kde.org/D23674 To: kossebau, #kate, cullmann Cc: cullmann, apol, kwrite-devel,

D23824: Initial start of variables dialog

cullmann added a comment. Upsa, file missing :P REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23824 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23824: Initial start of variables dialog

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. :P ok REPOSITORY R39 KTextEditor BRANCH add-variables-dialog REVISION DETAIL https://phabricator.kde.org/D23824 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

cullmann added a comment. Hmm, is lastLineLenght correct? Must one not decrement by one? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23674 To: kossebau, #kate Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D23696: completion: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, push after tagging. Thanks for taking care again! REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_completion REVISION DETAIL

D23697: buffer: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks OK. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_buffer REVISION DETAIL https://phabricator.kde.org/D23697 To: kossebau, #kate,

D23698: document: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_document REVISION DETAIL https://phabricator.kde.org/D23698 To: kossebau, #kate,

D23721: Fix race condition in TextBuffer

cullmann added a comment. Hmm, the use of atomic + a local var might avoid that the compiler optimizes away the local var and just uses m_lastUsedBlock again directly, but I am not sure if we should go that way. If one has concurrent accesses to the buffer from different threads, all is

D23699: mode: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. That looks sane for me. If there are threads this will all break into parts, there is no need to care for that (the shared containers are then not the real issue). REPOSITORY R39

D23691: C & ISO C++: add digraphs (folding & preprocessor)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:364ed572e2ec: C ISO C++: add digraphs (folding preprocessor) (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23691: C & ISO C++: add digraphs (folding & preprocessor)

cullmann added a comment. Btw., BIG thanks for taking care of all this highlighting issues! REPOSITORY R216 Syntax Highlighting BRANCH cpp-digraphs REVISION DETAIL https://phabricator.kde.org/D23691 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D23688: Allow to customize attributes for KSyntaxHighligting themes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:1c0b0069b960: Allow to customize attributes for KSyntaxHighligting themes (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23691: C & ISO C++: add digraphs (folding & preprocessor)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think di-graphs are good enough, tri-graphs are ancient cruft. REPOSITORY R216 Syntax Highlighting BRANCH cpp-digraphs REVISION DETAIL https://phabricator.kde.org/D23691 To:

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. :=) I have no idea, I hope future Qt versions are there more consistent with STL, which I prefer. Please push this as is, at least we are away from Q_FOREACH. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. I would have thought you could use the it.value/key stuff with the range based for, too, but I must confess I mostly use stl containers with for, perhaps mistaken. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. thought not sure why a range based for doesn't work on the m_codesToSpecialKeys stuff with qAsConst. But I assume that has some reason and it is just testing code anyways. REPOSITORY R39 KTextEditor BRANCH

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests REVISION DETAIL https://phabricator.kde.org/D23695 To: kossebau, #kate, cullmann

D23688: Allow to customize attributes for KSyntaxHighligting themes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, thanks for the fix! REPOSITORY R39 KTextEditor BRANCH fix-attributes REVISION DETAIL https://phabricator.kde.org/D23688 To: nibags, #ktexteditor, dhaumann, cullmann Cc:

D23661: Port away from Qt's foreach all loops over method-local containers

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok for me, thanks for taking care. REPOSITORY R39 KTextEditor BRANCH plainporttorangeloop REVISION DETAIL https://phabricator.kde.org/D23661 To: kossebau, #kate, cullmann

D23626: Use QChar overload for single char strings where possible

cullmann added a comment. :=) If you have time to spare and some fun for tedious work: D19367 Finalizing a chunk wise regex search as drafted in https://cgit.kde.org/ktexteditor.git/commit/?id=dbebf059575f83608c94ac3a6d374667b5a6 is highly

D19367: SearchBar: Don't block GUI when enter incremental pattern

cullmann added a comment. I thought a bit about the problem with multi-line regex. I think we can solve this in a consistent way by allowing to incremental do matches that span more than one line. See the first example code in this commit:

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:00721e80b5b4: Fix for all themes: allow turn off attributes in XML highlighting files (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23515: Format class: add functions to know if XML files set style attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b7555d6a475a: Format class: add functions to know if XML files set style attributes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23645: Do not generate string list at runtime

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is nicer, yes! REPOSITORY R39 KTextEditor BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645 To: kossebau, #kate, cullmann Cc:

D23644: Use more QString::splitRef

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. looks ok REPOSITORY R39 KTextEditor BRANCH moresplitref REVISION DETAIL https://phabricator.kde.org/D23644 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok INLINE COMMENTS > kossebau wrote in kateviewhelpers.cpp:1191 > Refactoring to one static object will be separate commit. I would have no issue with this to be in this commit ;=)

D23637: Use more QString::midRef where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. looks ok REPOSITORY R39 KTextEditor BRANCH usemidref REVISION DETAIL https://phabricator.kde.org/D23637 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23634: Use more QString::leftRef where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok REPOSITORY R39 KTextEditor BRANCH moreleftref REVISION DETAIL https://phabricator.kde.org/D23634 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23641: Use s.mid(n) instead of s.right(s.size() - n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems ok, too. REPOSITORY R39 KTextEditor BRANCH midnotrightlengthminus REVISION DETAIL https://phabricator.kde.org/D23641 To: kossebau, #kate, cullmann Cc: cullmann,

D23630: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH repeatedtoconstructor REVISION DETAIL https://phabricator.kde.org/D23630 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23633: Use s.chop(n) instead of s = s.left(s.length() - n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok REPOSITORY R39 KTextEditor BRANCH chopnotleft REVISION DETAIL https://phabricator.kde.org/D23633 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23632: Use s.truncate(n) instead of s = s.left(n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH truncatenotleft REVISION DETAIL https://phabricator.kde.org/D23632 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23629: Use QLatin1String over QStringLiteral in string concatenation

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok ;=) REPOSITORY R39 KTextEditor BRANCH usemoreqlatin1string REVISION DETAIL https://phabricator.kde.org/D23629 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is fine, as soon as the other patch is in, feel free to commit! REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516

D23642: Use QStringLiteral instead of runtime conversion to QString

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks fine. REPOSITORY R39 KTextEditor BRANCH noruntimetoqstringconversion REVISION DETAIL https://phabricator.kde.org/D23642 To: kossebau, #kate, cullmann Cc: cullmann,

D23645: Do not generate string list at runtime

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? REPOSITORY R39 KTextEditor REVISION DETAIL

D23626: Use QChar overload for single char strings where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, too. Thanks! REPOSITORY R39 KTextEditor BRANCH useqcharoverload REVISION DETAIL https://phabricator.kde.org/D23626 To: kossebau, #kate, cullmann Cc: cullmann,

D23515: Format class: add functions to know if XML files set style attributes

cullmann added a comment. Dominik, ok with this now, too? Or did I miss some name issues in the API? (tried to read all lines for spelling mistakes :=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting,

D23625: Use QString::count(QChar) over QString::split().length() - 1

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks. REPOSITORY R39 KTextEditor BRANCH usecount REVISION DETAIL https://phabricator.kde.org/D23625 To: kossebau, #kate, cullmann Cc: cullmann,

D23515: Format class: add functions to know if XML files set style attributes

cullmann accepted this revision. cullmann added a comment. Think this is fine now, thanks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel,

D23515: Format class: add functions to know if XML files set style attributes

cullmann added a comment. As we have already members like hasX would it make sense to have hasItalicOverride() to be more consistent? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting,

D23515: Format class: add functions to know if XML files set style attributes

cullmann added a comment. Shall we go with the definitionHasX style or change it? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel,

D23500: Support for native Matlab strings

This revision was automatically updated to reflect the committed changes. Closed by commit R216:20e4bb60aa40: Support for native Matlab strings (authored by bbuch, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23500: Support for native Matlab strings

cullmann added a comment. I see, there is already some highlight.m test, I will just add your test case to that stuff. REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D23500 REVISION DETAIL https://phabricator.kde.org/D23500 To: bbuch, cullmann Cc: dhaumann, kwrite-devel,

D23500: Support for native Matlab strings

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, this seems ok for me, will add the needed test references myself (make test complaints about missing ones). REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D23500

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

cullmann abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: cullmann, bbuch Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

cullmann commandeered this revision. cullmann edited reviewers, added: bbuch; removed: cullmann. cullmann added a comment. Ok, then we can abandon this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: cullmann, bbuch Cc: kwrite-devel,

D23515: Format class: add functions to know if XML files set style attributes

cullmann added a comment. No idea if definitionhasBold or the other variants are better. For the "PS: Another solution is to port all xml files to not use hard coded colors. That's a lot of work, though.": I think to hardcode e.g. bold/italic/... is actually not that bad in some cases.

D23513: Gettext: Add "Translated String" style and spellChecking attribute

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice! Please inc version and push. REPOSITORY R216 Syntax Highlighting BRANCH po_spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D23513 To:

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks ok modulo missing version update, for more input please take a look at the reply in D23500 Support for native Matlab strings

D23484: gcc naming conflict

This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ff7f78ebcb7: gcc naming conflict (authored by mickaelbo, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23484?vs=64727=64757

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0bf552243404: Mimic QInputControl::isAcceptableInput() when filtering typed characters (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Actually, I can take care of the changes after applying this, is already a good start, thanks! REPOSITORY R39 KTextEditor BRANCH ahmad/soft-hyphen (branched from master) REVISION

D23500: Support for native Matlab strings

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I think it is very nice that you pickup the matlab file! Three things I would like to have changed: 1. please move the example from the comment in the XML to

D23484: gcc naming conflict

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok, thanks REVISION DETAIL https://phabricator.kde.org/D23484 To: mickaelbo, #framework_syntax_highlighting, cullmann Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel,

D23484: gcc naming conflict

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I would prefer that we just rename the vars. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23484 To: mickaelbo,

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

cullmann added a comment. Please only add the isAcceptableInputText with the event. We only need to check that for the keyboard input in KateViewInternal::keyPressEvent(QKeyEvent *e). And there we don't need to do this for the \t tab insertion, makes no sense, we want to add there a \t

D23457: Port regex search to QRegularExpression

cullmann added a comment. In D23457#519217 , @ahmadsamir wrote: > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? > >

<    1   2   3   4   5   6   7   8   9   10   >