Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

usly for that session, > rather than the geometry used by whatever KDevelop session was run last. On > OS X that would be done with something like `[NSWindow > setFrameautosaveName:[window representedFile]]`, where `[NSWindow > representedFile]` corresponds to `QWindow::filePath`

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

usly for that session, > rather than the geometry used by whatever KDevelop session was run last. On > OS X that would be done with something like `[NSWindow > setFrameautosaveName:[window representedFile]]`, where `[NSWindow > representedFile]` corresponds to `QWindow::filePath`

QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

On Sunday 03 January 2016 11:11:48 René J.V. Bertin wrote: > On Sunday January 03 2016 10:22:27 David Faure wrote: > > >> You saw I said "wait for QProcess to be improved", right? I don't expect a > >> patch for QProcess to be incorporated before 5.7.x ...

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

usly for that session, > rather than the geometry used by whatever KDevelop session was run last. On > OS X that would be done with something like `[NSWindow > setFrameautosaveName:[window representedFile]]`, where `[NSWindow > representedFile]` corresponds to `QWindow::filePath`

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

s running isn't enough, the process has to be registered somewhere else, and > as long as that's not the case (= the app is starting up) it won't listen to > the "activate" instruction. OK. Yes I was thinking at the process layer. In the graphical layer you can of course check that your event is being processed by the event loop of another app, if that event expects a reply. I suppose one could cook that up with X11 too - but I'm not aware of a need for that. It's rather surprising that the events are not queued until the app processes them. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126648: Allow to disable KArchive for internal usage

tps://git.reviewboard.kde.org/r/126648/#comment61977> I would suggest to add a qWarning() under this line, to warn at runtime in case this is ever called in a non-karchive build. - David Faure On Jan. 6, 2016, 12:58 a.m., Luigi Toscano

Re: Review Request 126651: Fix wrong documentation for KIconTheme::iconPath

, KIconLoader. - David Faure On Jan. 6, 2016, 8:28 a.m., Holger Kaelberer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

ttps://git.reviewboard.kde.org/r/126659/#comment62039> yes, this is a QDate behaviour change in Qt5. - David Faure On Jan. 7, 2016, 10 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

> On Jan. 7, 2016, 11:15 a.m., David Faure wrote: > > src/ioslaves/ftp/ftp.cpp, line 1775 > > <https://git.reviewboard.kde.org/r/126659/diff/1/?file=428702#file428702line1775> > > > > The porting bug is here. In kdelibs4 tmptr was initialized to the

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

> On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: >

Re: Review Request 126674: Add a thumbnailer for kra/ora images

(or just run astyle-kdelibs from kde-dev-scripts) - David Faure On Jan. 8, 2016, 8:38 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 126403: Get rid of QApplication dependency

to exactly that, when #including QGuiApplication. The commit log also needs to be updated, assuming it's still equal to the description that is visible in ReviewBoard. - David Faure On Jan. 6, 2016, 5:34 p.m., Thomas Lübking wrote: > > ---

Re: Review Request 126681: Duplicate the file descriptor while opening

> On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: > https://mail.kde.org/pipermail/release-team/2016-January/009263.html > > Kai Uwe Broulik wrote: > ok, I was just wondering becau

Re: Review Request 126681: Duplicate the file descriptor while opening

; ok, I was just wondering because it wasn't mentioned in the changelog :) > > David Faure wrote: > A changelog is only a summary of the changes that impact the users of the > framework, not the full git log. > > When a release contains a change, and then a &

Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

bac98e78c7bf9f3f3112a55a9 Diff: https://git.reviewboard.kde.org/r/126692/diff/ Testing --- `qdbus org.kde.kpasswdserver /modules/kpasswdserver` works even if kiod isn't running yet. Thanks, David Faure ___ Kde-frameworks-devel mailing lis

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

/diff/ Testing --- `qdbus org.kde.kpasswdserver /modules/kpasswdserver` works even if kiod isn't running yet. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Review Request 126694: KHTML java applet viewer: repair broken DBus call to kpasswdserver

trigger this code. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

anager_p.h 0b9a85d6f05b93dbe8e80962401dff5ca73617f8 Diff: https://git.reviewboard.kde.org/r/126695/diff/ Testing --- It compiles. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126696: kssld: install DBus service file for org.kde.kssld5

x27;t running yet. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 158f62a6710a8ec02eeb9c4e94ee1badd591ae47 by David Faure to branch master. Repository: kio Description --- QList calls both, so both are needed, but indeed operator= means the members can'

Jenkins scripts broken?

2 + > Build duration: 1 min 11 sec > > CHANGE SET > Revision 9bbb9f948fd0729e86e67793adf9d72598e0cc02 by David Faure: (Make kded > register under aliases specified by the kded modules.) > change: edit src/kded.cpp > > > JUNIT RESULTS > > Name: (root

Re: QSP patch/activator

On Sunday 10 January 2016 17:04:14 René J.V. Bertin wrote: > On Saturday December 12 2015 19:32:34 David Faure wrote: > > I didn't mean switching at runtime. I mean using KF5 in Qt apps. > > I'm pretty sure we had this discussion already but here we go again: > > If

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

s.txt 2944e02ca27becb602e651921977f677206bf5c2 src/kpasswdserver/org.kde.kpasswdserver.service.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126692/diff/ Testing --- `qdbus org.kde.kpasswdserver /modules/kpasswdserver` works even if kiod isn't running yet. Thanks, D

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

) <https://git.reviewboard.kde.org/r/125048/#comment62072> Why was this set to false (and autoload to true) when the kcookiejar.desktop file had X-KDE-Kded-autoload=false X-KDE-Kded-load-on-demand=true ? I assume it wasn't intentional, but a copy/paste error? -

Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

stake) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126403: Get rid of QApplication dependency

y and weird, it's the end of an if() block. - David Faure On Jan. 10, 2016, 9:58 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: QSP patch/activator

igration is a big concern? > To be very honest, other than Apple's App Store rules I really don't see why > cross-platform applications couldn't use their usual locations. Recent OS X > versions hide ~/Library in the Finder (where all OS X versions already did > that with

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 7dd6cb612f59f7d494034c756bfc823550a0eba2 by David Faure to branch master. Repository: kio Description --- This way the calling code can just ask for that service name rather than having to

Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8624f1128fc434485ba6302c0be4b75e4f0de649 by David Faure to branch master. Repository: kio Description --- The only caller is ksslcertificatemanager but this is more consistent with what was

Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8c81f8b052da5366515e5736c7b22c771501510a by David Faure to branch master. Repository: kio Description --- This will make it possible to move it away from kded one day. Change-Id

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

ever have a dangling pointer to the menu. - David Faure On Jan. 12, 2016, 1:14 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visi

KIOGui ?

e question is: this would only depend on KIOCore and QImage. Shall I put it in KIOWidgets or shall I create a new KIOGui library, for QML apps to avoid the QWidget dependency ? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Fr

Re: KIOGui ?

t least for new classes, better put them into the right lib from the start, then be stuck with the difficulty of moving later". -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

> On Jan. 12, 2016, 9:49 p.m., David Faure wrote: > > Can I see the backtrace, with a description of how this gets triggered? I'm > > not sure the issue is fully understood (as shown by the use of "might" in > > the description...). > > > >

Re: KIOGui ?

On Thursday 14 January 2016 02:53:09 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 13. Januar 2016, 00:33:36 schrieb David Faure: > > I'm about to write a class to handle favicons in a KIO library, rather than > > using DBus communication to a (currently kded, could be kiod o

Re: Deadlock in kded whith Qt 5.6

the BlockingQueuedConnection call from messageFilter to the main thread occasionnally leads to deadlocks, we need your "postpone incoming messages" idea. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

coltojson/main.cpp (line 159) <https://git.reviewboard.kde.org/r/125869/#comment62408> const QString & - David Faure On Jan. 3, 2016, 6:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatic

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All pla

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/#review91304 --- Ship it! Ship It! - David Faure On Jan. 14, 2016, 11

Re: Review Request 126745: Fix karchive autotests on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126745/#review91305 --- Ship it! Ship It! - David Faure On Jan. 18, 2016, 4:58

Re: Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

unittest still pass? 2) if yes, then it should be extended to test for this case - David Faure On Jan. 18, 2016, 9:59 a.m., Volker Krause wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Reporting bugs to frameworks

What did I miss? > > frameworks-kdaemon What a weird name! We don't say kdaemon anywhere else, at all. I really wonder how it came to be called this way. Can someone rename it to frameworks-kded, the only name that would actually make sense, for a framework called kded? -- Davi

Re: Review Request 126769: Fix all Clazy warnings in KDED.

g/r/126769/#comment62424> That's new in Qt 5.5, we need this code to compile with Qt >= 5.3 (until 5.6 is out). Please revert, or wrap this in #if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0) - David Faure On Jan. 16, 2016, 2:27 p.m., Andr

[karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure. Committed on 19/01/2016 at 08:14. Pushed by dfaure into branch 'master'. Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET). Any volunteer for doing this over all frameworks? CCMAIL: kde-frameworks-devel@kde.

Re: Deadlock in kded whith Qt 5.6

On Tuesday 19 January 2016 22:54:35 Thiago Macieira wrote: > On Monday 18 January 2016 09:23:51 David Faure wrote: > > Thiago: indeed the BlockingQueuedConnection call from messageFilter to the > > main thread occasionnally leads to deadlocks, we need your > > "postpo

Re: Deadlock in kded whith Qt 5.6

On Tuesday 19 January 2016 23:59:31 Thiago Macieira wrote: > On Wednesday 20 January 2016 08:55:17 David Faure wrote: > > Doesn't seem to support service autostart + module autoload together. > > > but if I kill kded5 again and do this right away: > > $ qdbus

Re: Deadlock in kded whith Qt 5.6

On Wednesday 20 January 2016 08:41:31 Thiago Macieira wrote: > On Wednesday 20 January 2016 09:08:38 David Faure wrote: > > > Can you run with QDBUS_DEBUG=1 and tell me the messages it prints? > > > [cut] > > I didn't see any "invoking message spies" of

Re: Deadlock in kded whith Qt 5.6

Even the proxyscout module with its usage of system bus in the module ctor gets autostarted+autoloaded just fine. Thanks Thiago. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing li

Re: kconfig question

icular one, but imagine having to select your spellcheck dictionaries in all apps or . In general, I don't like AppConfigLocation, we've been bitten by "appdata" too much in kde4 times, same issue: some code starts as app code, it uses such an app-specific location type, the

Re: Making polkit-qt-1 a tier1 framework

for all: bug fixes > will get to users in a timely manner. > > Opinions? Sounds good. A few questions come to mind: - Will you be the official maintainer? (Otherwise who will?) - Is this an opportunity for a better name? I keep wondering why this lib targets Qt 1 :-) -- David Faure, f

Re: QSP patch/activator

If you route calls via a wrapper, then it can do the extra lookups itself, it doesn't need to add paths to QSP. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

On Tuesday 19 January 2016 10:11:06 Aleix Pol wrote: > On Tue, Jan 19, 2016 at 9:15 AM, David Faure wrote: > > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure. > > Committed on 19/01/2016 at 08:14. > > Pushed by dfaure into branch 'master'. >

Re: Review Request 126774: Fix many warnings presented by clazy

pass for you, and I would be happy if you emailed me the details about the 3 failures (stderr when running the individual tests) so we debug this together. - David Faure On Jan. 20, 2016, 2 a.m., Russell Greene wrote: > > --- &

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

tps://git.reviewboard.kde.org/r/126831/#comment62519> I think we should, yes, or even in the caller of setDirectory, if it's calling it with a non-directory URL. From the name it's pretty clear that we don't expect that to be called with a file. - David Faure On Jan. 20, 2016, 9

Re: about rpath "automagic" (CMAKE_INSTALL_RPATH)

On Saturday 23 January 2016 10:25:07 René J.V. Bertin wrote: > Hello, [...] Hi. This is a topic for kde-buildsys...@kde.org. I suggest reading the last two posts by Boud, they are also about RPATH on OSX. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Framework

Review Request 126857: kio_http: fix porting bugs which broke caching.

Now kio_http says lots of good things like "readBody: reading data from cache..." Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126858: Change DBus name of kio_http_cache_cleaner so it doesn't exit if the kde4 one is running.

p_cache_cleaner" [...] HTTPProtocol::sendCacheCleanerCommand: Could not connect to cache cleaner, not updating stats of this cache file. kio_http_cache_cleaner: Already running! After: Hmm, now it does run, but still "Could not connect". Must be another b

Re: Review Request 126857: kio_http: fix porting bugs which broke caching.

r below in kio_http's output HTTPProtocol::cacheFileOpenWrite: Could not open file for writing: "" due to error 5 (First fix was to fix the debug output not to show an empty filename on error) Now kio_http says lots of good things like "readBody: rea

Review Request 126864: kio_http_cache_cleaner: don't exit on startup if cache dir doesn't exist yet

the cache. Corner case due to different paths in unit-tests, but can't hurt to mkpath. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126863: kio_http_cache_cleaner: fix warning when scoreboard doesn't exist yet

d6ff0a Diff: https://git.reviewboard.kde.org/r/126863/diff/ Testing --- watching kio_http debug output when triggered by a simple KIO::get unittest Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/

Review Request 126865: kio_http: fix waiting until the cache cleaner listens to the socket.

kio_http output. Before: HTTPProtocol::sendCacheCleanerCommand: Could not connect to cache cleaner, not updating stats of this cache file. After: HTTPProtocol::sendCacheCleanerCommand: Successfully connected to cache cleaner. Thanks, David Faure ___

Re: Review Request 126868: Update docs for KCrash::Initialize.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/#review91513 --- Ship it! Ship It! - David Faure On Jan. 24, 2016, 11

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

) <https://git.reviewboard.kde.org/r/126876/#comment62556> Yes, this definitely looks like it should be fixed in Qt instead (and this code can be kept with a #ifdef QT_VERSION if you want). The method is called setDirectory, I expect it to get a directory. - David Faure On J

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > <https://git.reviewboard.kde.org/r/126876/diff/1/?file=439596#file439596line195> > > > > Yes, this definitely looks like it should be fixed

Re: Review Request 126880: Fix QFileDialog::openUrl() for remote files

org/r/126880/ > --- > > (Updated Jan. 24, 2016, 11:24 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 345253 > https://bugs.kde.org/show_bug.cgi?id=345253 > > > Repository: frameworkintegration > > > Description > --

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

", this is rather about Qt calling this method, not "returning". src/platformtheme/kdeplatformfiledialoghelper.cpp (line 201) <https://git.reviewboard.kde.org/r/126876/#comment62594> No need for KFileItem just for that, use entry.isDir(). - David Faure

Re: Review Request 126864: kio_http_cache_cleaner: don't exit on startup if cache dir doesn't exist yet

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9331d94ee183b39fd985d27cdaa547c75fb65931 by David Faure to branch master. Repository: kio Description --- + add warning if listen fails, just in case Change-Id

Re: Review Request 126857: kio_http: fix porting bugs which broke caching.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ead19e986357bcecb334706732bf7aba339d0880 by David Faure to branch master. Repository: kio Description --- CacheLocation was used instead of GenericCacheLocation, so the appname was inserted

Re: Review Request 126858: Change DBus name of kio_http_cache_cleaner so it doesn't exit if the kde4 one is running.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9c6ce5b155ff286c5a735783b95bfc017d35e13b by David Faure to branch master. Repository: kio Description --- This DBus service name is only used for "unique app" behaviour. It'

Re: Review Request 126863: kio_http_cache_cleaner: fix warning when scoreboard doesn't exist yet

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 959c2df23e79bfff513b5afaa3954cb9a31cd6aa by David Faure to branch master. Repository: kio Description --- QIODevice::read (QFile, "/home/dfaure/.cache/kio_http/scoreboard"): device

Re: Review Request 126865: kio_http: fix waiting until the cache cleaner listens to the socket.

nected to cache cleaner. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126887: Fix crash if KWindowSystem::mapViewport is called without a QCoreApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126887/#review91639 --- Ship it! Ship It! - David Faure On Jan. 26, 2016, 8:30

Re: KCoreAddons qml plugins

together", "no kdebindings-depends-on-everything"). And yet we don't do it. Because KIO users don't want to be forced to install python. Similarly, many users of kcoreaddons don't want a dependency on QML. I honestly don't see the problem with having this in KDecl

API review: FavIconManager vs FavIconHostRequestJob

g the apps to the new favicon class. Well, that was much thinking aloud. Any comments? Anyone thinks the backend should be a kiod module instead, to avoid concurrent downloads of the same icon and notify all processes when the favicon is available? -- David Faure, fa...@kde.org, http://www.d

Re: kconfig question

On Wednesday 27 January 2016 10:32:50 Boudewijn Rempt wrote: > On Sat, 23 Jan 2016, David Faure wrote: > > > > > Not sure this answers Boud's question, since he *is* seeing "Local" on > > Windows. > > He said: "I noticed that krita on windows

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

FAICS this is done using KGlobalAccel API anyway, not kxmlgui API. So that's perfect IMHO, neither users or apps will end up with broken functionality. - David Faure On Jan. 28, 2016, 1:29 p.m., Andre Heinecke wrote: > > --- &g

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like use

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like use

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like use

Re: Finding kdesu binary

ec was to avoid a clash with the KDE4 kdesu, I see no reason against installing a kdesu5 script in PREFIX/bin which contains: #!/bin/sh exec /full/path/to/libexec/kdesu (using configure_file to expand the path during cmake time) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126903: Fix buddy widgets working with KFontRequester

set the focus policy of the widget and its focusproxy differently. In simple cases like this it doesn't make sense indeed, I don't know about more complex cases. Sounds scary to change in Qt in any case, IMHO. - David Faure On Jan. 27, 2016, 1:42 p.m., David Edmun

Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/#review91815 --- Ship it! Ship It! - David Faure On Jan. 20, 2016, 2

Re: API review: FavIconManager vs FavIconHostRequestJob

the KIO::iconNameForUrl() API, so they will benefit from this, but they don't need any porting. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QSP patch/activator

s not like Mac OSX has freedesktop icon themes natively installed... i.e. it seems to me that this unbreaks QIcon::fromTheme() on OSX, which was until now searching ... nowhere. Right? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 _

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/#review91818 --- Ship it! Ship It! - David Faure On Jan. 31, 2016, 10

Re: API review: FavIconManager vs FavIconHostRequestJob

On Sunday 31 January 2016 11:29:31 laurent Montel wrote: > Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > &

Re: KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

his feature too (with 6 items in the contextmenu), it is actually implemented in the kbookmarks framework (so not using kdelibs4support), see the class KonqBookmarkContextMenu. Looks like all you need is m_parentMenu->setContextMenuPolicy(Qt::CustomContextMenu); connect(m_parentMenu,

Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/#review91841 --- Ship it! Ship It! - David Faure On Jan. 29, 2016, 11

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/#review91842 --- Ship it! Ship It! - David Faure On Jan. 29, 2016, 11

Re: Review Request 126955: Fix crash in activities context menu

tes a class, that should decide how it should get deleted, rather than the class itself deciding that (same reason why for widgets, WA_DeleteOnClose should be set after new, not in the ctor). - David Faure On Feb. 1, 2016, 9:16 p.m., David Edmundson

Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

/diff/ Testing --- Wrote a unittest, as complete as possible. Didn't port any apps yet. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb src/gui/CMakeLists.txt PRE-CREATION src/gui/faviconrequestjob.h PRE-CREATION src/gui/faviconrequestjob.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126963/diff/ Testing --- Wrote a unittest, as complete as possible. Didn't port any apps yet.

Re: Review Request 126955: Fix crash in activities context menu

> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose sh

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

On Thursday 28 January 2016 11:23:16 Aleix Pol wrote: > On Sat, Jan 23, 2016 at 12:05 PM, David Faure wrote: > > On Tuesday 19 January 2016 10:11:06 Aleix Pol wrote: > >> On Tue, Jan 19, 2016 at 9:15 AM, David Faure wrote: > >> > Git commit 3b13ef97925725b2a273a4d3e

Re: Review Request 126982: Fix NTLMv2 stage 3 response creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126982/#review92045 --- Ship it! Ship It! - David Faure On Feb. 3, 2016, 9:35

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

marked as submitted. Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune Vuorela. Changes --- Submitted with commit 1510bea556fdc973af3872636d067b9978b83f53 by David Faure to branch master. Repository: kio Description --- Replaces the favicons kded module from

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

// current code #endif - David Faure On Feb. 4, 2016, 3:50 p.m., Krzysztof Nowicki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 126991: Try multiple authentication methods in case of failures

another host? Shouldn't these lists ("blacklisted auth methods" etc.) be cleared? - David Faure On Feb. 4, 2016, 4:01 p.m., Krzysztof Nowicki wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

take a look, but if he doesn't, feel free to push. Especially since the release is tomorrow, and I guess you'd like this in ;) - David Faure On Feb. 5, 2016, 11:17 a.m., Krzysztof Nowicki wrote: > > --- > This is an a

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

> On Feb. 5, 2016, 12:36 p.m., David Faure wrote: > > Looks good to me. Ideally I'd like Dawit to take a look, but if he doesn't, > > feel free to push. > > Especially since the release is tomorrow, and I guess you'd like this in ;) > > Krzysztof No

<    1   2   3   4   5   6   7   8   9   10   >