Re: Review Request 129302: Fix include dir in pri file

marked as submitted. Review request for KDE Frameworks and Jan Grulich. Changes --- Submitted with commit 4e295bcf03d3964d5675894053190a71a5288baa by David Rosca to branch master. Repository: networkmanager-qt Description --- Currently the pri file has Qt.NetworkManagerQt.includes

Review Request 129303: Fix include dir in pri file

--- Correct include paths when used from qmake. Thanks, David Rosca

Review Request 129302: Fix include dir in pri file

--- Correct include paths when used from qmake. Thanks, David Rosca

Re: Review Request 129302: Fix include dir in pri file

://git.reviewboard.kde.org/r/129302/diff/ Testing (updated) --- Correct include paths when used from qmake. It still cannot be used from qmake without additional changes because `generictypes.h` includes `nm-version.h` from libnm which is not in include paths. Thanks, David Rosca

Re: Review Request 129303: Fix include dir in pri file

marked as submitted. Review request for KDE Frameworks and Jan Grulich. Changes --- Submitted with commit 79725bf9892520538a6bde836ced583a65ea6767 by David Rosca to branch master. Repository: modemmanager-qt Description --- Currently the pri file has Qt.ModemManagerQt.includes

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `App

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

`, not the other way). This never worked (emitting `contextualActionsAboutToShow` from plasmoid), but only this change exposed it. I have no idea how to fix it, other than adding new method to `AppletInterface` to emit this signal or hacky both-way connection. - David Rosca On Oct. 3, 2016, 10:45 a.m

Re: Review Request 129743: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129743/#review101719 --- Ship it! Ship It! - David Rosca On Jan. 2, 2017, 10

D5066: Provide device type for Low Energy devices

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D5066 To: elvisangelaccio, drosca Cc: #frameworks

D5324: Revert "[calendar] Use ui language for getting the month name"

drosca abandoned this revision. drosca added a comment. > However, if your UI language is all Spanish and you want to use the US date formatting, the month name labels would suddenly be in English while they should remain Spanish (and this is what the code you're removing does). Well,

D5324: Revert "[calendar] Use ui language for getting the month name"

drosca created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Qt.locale().standaloneMonthName() is used from QML side in MonthView, so using the same code on C++ part again makes

D5345: Calendar: Use correct language for month and day names

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a01e4fb69efe: Calendar: Use correct language for month and day names (authored by drosca). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5345: Calendar: Use correct language for month and day names

drosca added inline comments. INLINE COMMENTS > mck182 wrote in DaysCalendar.qml:315 > Now I'm not entirely sure but can the `uiLanguages[0]` > possibly return null? It's used exactly the same on the C++ side (without the bounds check), so I assume it's safe as that code is now over 2 years

D5550: Fix property changes being missed immediately after an obejct is added

drosca created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Fix race condition when property changes may be missed if the property is changed immediately after the object is created. The issue was that the connection to PropertyChanged signal was

D5345: Calendar: Use correct language for month and day names

drosca created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Apply fix for bug 353715 also on QML side. TEST PLAN I have English ui language + Czech time format. Months and days

Re: KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!

Hi, I just fixed it yesterday and now it fails again. What did change this time, please? Thanks, David On Mon, Aug 14, 2017 at 3:54 PM, wrote: > *BUILD UNSTABLE* > Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5- > qt5%20XenialQt5.7/20/ > Project: Frameworks

D5550: Fix property changes being missed immediately after an obejct is added

This revision was automatically updated to reflect the committed changes. Closed by commit R269:c02c4806c9bf: Fix property changes being missed immediately after an obejct is added (authored by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE

D8806: Do not leak rfkill file descriptors.

drosca added a comment. Alright, thanks for the explanation. I need your full name and e-mail to commit it (I can't get it with `arch patch` probably because you didn't upload this review with `arc diff`). REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D8806

D8806: Do not leak rfkill file descriptors.

This revision was automatically updated to reflect the committed changes. Closed by commit R269:ae044d6dfec9: Do not leak rfkill file descriptors. (authored by ofreyermuth, committed by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE

D8806: Do not leak rfkill file descriptors.

drosca added a comment. In https://phabricator.kde.org/D8806#167509, @bshah wrote: > I do wonder if this is security fix? And should probably be handled like that? Why? It's not like any other process can't open /dev/rfkill as we ship udev rule to enable r+w access to

D8806: Do not leak rfkill file descriptors.

drosca added a comment. Just for the record, how does Konsole inherit this fd when BluezQt is only used in plasmashell + kded and KDE apps are afaik not forked from these processes? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D8806 To: ofreyermuth,

D8806: Do not leak rfkill file descriptors.

drosca added a comment. Though on the other hand, why isn't KLauncher (KRun) used for running apps everywhere? This way they are forked from `kdeinit5` and this issue is non-existant. Quick test: - Launch from taskmanager -> forked from plasmashell - Launch from quicklaunch

D13268: Add signal for devices's address changing

drosca added a comment. Do you have a dev account? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D13268 To: andreysemenov, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

drosca added a comment. In D13268#273516 , @andreysemenov wrote: > In D13268#273515 , @drosca wrote: > > > Do you have a dev account? > > > I think i don't. Ok, your name and e-mail

D13268: Add signal for devices's address changing

This revision was automatically updated to reflect the committed changes. Closed by commit R269:41b41939c028: Add signal for devicess address changing (authored by andreysemenov, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13268?vs=35331=35511#toc REPOSITORY

D13268: Add signal for devices's address changing

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D13268 To: andreysemenov, mlaurent, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10167: Initialize m_usableAdapter with nullptr

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D10167 To: aacid, dhaumann, drosca Cc: dhaumann, drosca, #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Since it is a shared pointer then it doesn't need explicit initialization and this line can just be removed. REPOSITORY R269 BluezQt REVISION DETAIL

D16084: Add Media and MediaEndpoint API header generation

This revision was automatically updated to reflect the committed changes. Closed by commit R269:a65823a9aa43: Add Media and MediaEndpoint API header generation (authored by mweichselbaumer, committed by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE

D16084: Add Media and MediaEndpoint API header generation

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D16084 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Remove NoInputNoOutputAgent and it's good to go. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham,

D15745: Implement Media and MediaEndpoint API

drosca added a comment. Alright, last thing: Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway. REVISION DETAIL

D15745: Implement Media and MediaEndpoint API

drosca added a comment. In D15745#336662 , @mweichselbaumer wrote: > In D15745#336644 , @drosca wrote: > > > Remove NoInputNoOutputAgent and it's good to go. > > > Agree. Is it ok to move it

D15745: Implement Media and MediaEndpoint API

drosca added a comment. In D15745#336615 , @mweichselbaumer wrote: > In D15745#336593 , @drosca wrote: > > > Alright, last thing: > > > > Why NoInputNoOutputAgent? That should be implemented by

D15745: Implement Media and MediaEndpoint API

drosca added a comment. Thanks. I'll need your full name + e-mail if you don't have dev account to push it. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

This revision was automatically updated to reflect the committed changes. Closed by commit R269:5f12404807cc: Implement Media and MediaEndpoint API (authored by mweichselbaumer, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15745?vs=42877=42878#toc REPOSITORY

D15745: Implement Media and MediaEndpoint API

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > manager_p.cpp:46 > , m_bluezProfileManager(nullptr) > +, m_media(nullptr) > , m_initialized(false) No need because it is smart pointer. >

D15745: Implement Media and MediaEndpoint API

drosca added inline comments. INLINE COMMENTS > mweichselbaumer wrote in media_p.h:37 > MediaPrivate will later act as parent for child objects (inheriting QObject). Then just parent them to Media instead of private class. REVISION DETAIL https://phabricator.kde.org/D15745 To:

D15745: Implement Media and MediaEndpoint API

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks good apart from the coding style. Also it would be great to have at least basic autotest. INLINE COMMENTS > media.h:95 > + > +friend class MediaPrivate; > +}; Not

D15745: Implement Media and MediaEndpoint API

drosca added inline comments. INLINE COMMENTS > broulik wrote in media_p.h:35 > I think this needs `Q_DECL_HIDDEN` Why? This class is not exported by default, afaik it is only needed if MediaPrivate was declared inside Media class (eg. Media::MediaPrivate), which it is not. REPOSITORY R269

D18315: Device: Check object path in interfaces removed slot

drosca created this revision. drosca added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. drosca requested review of this revision. REVISION SUMMARY Only remove Input and MediaPlayer objects when path matches. BUG: 403289 TEST

D17419: Add view-private icon

drosca added a comment. In D17419#374064 , @ngraham wrote: > Ah yeah, I guess that makes sense. > > #falkon folks, is this acceptable? Yes, looks great! REPOSITORY R266 Breeze Icons

D19805: Manager: Don't require Media1 interface for initialization

drosca created this revision. drosca added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. drosca requested review of this revision. REVISION SUMMARY BUG: 405478 FIXED-IN: 5.57 REPOSITORY R269 BluezQt BRANCH bug405478

D19805: Manager: Don't require Media1 interface for initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R269:5da57e174696: Manager: Dont require Media1 interface for initialization (authored by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19805?vs=54013=54187

D18315: Device: Check object path in interfaces removed slot

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R269:9197a45652be: Device: Check object path in interfaces removed slot (authored by drosca). REPOSITORY R269 BluezQt

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks really good! INLINE COMMENTS > gattapplication.cpp:38 > + > +GattApplication::GattApplication(QObject *parent) : > +ObjectManager(parent), Coding style:

D21511: Make falkon icon a real SVG

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH falkon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts, drosca Cc: ngraham, kde-frameworks-devel, michaelh,

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. After this, it should be good to go. INLINE COMMENTS > drosca wrote in gattapplication.h:47 > Maybe it would be best to add constructor that uses default object path. Also >

D21584: Add LE Advertising and GATT APIs

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > gattapplication.h:85 > + */ > +virtual QDBusObjectPath objectPath() const; > + This should be protected > gattapplication.h:96 > + */ > +

D21584: Add LE Advertising and GATT APIs

drosca added a comment. In D21584#475914 , @ngraham wrote: > What is the net effect of this patch? What does it improve? It adds initial support for Bluetooth Low Energy, it's not used anywhere in Plasma. REPOSITORY R269 BluezQt

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. It seems you uploaded only diff with latest changes, you need to upload the entire diff against master. INLINE COMMENTS > gattapplication.h:47 > */ > -explicit

D22107: Add MediaTransport API

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > mweichselbaumer wrote in tpendingcall.h:45 > Actually, my intention was to provide a type-safe way to obtain return values > from PendingCall and to express

D19960: bluez-qt: remove warnings

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH remove_compile_warnings REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca Cc: pino, kde-frameworks-devel,

D19960: bluez-qt: remove warnings

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Actually ... INLINE COMMENTS > a2dp-codecs.c:59 > AAC_OBJECT_TYPE_MPEG4_AAC_SCA, */ > -AAC_INIT_FREQUENCY( > +AAC_INIT_FREQUENCY(( > /*AAC_SAMPLING_FREQ_8000 |

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23988 To: dfaure, drosca Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22107: Add MediaTransport API

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > a2dp-codecs.h:33 > #define A2DP_CODEC_MPEG240x02 > -#define A2DP_CODEC_ATRAC 0x03 > +#define A2DP_CODEC_ATRAC 0x04 >

D22346: Should we install bluezqt_dbustypes.h?

drosca added a comment. Sorry, that slipped in the review. Fixed now: https://cgit.kde.org/bluez-qt.git/commit/?id=185e2c70331f08c61cc6903336eaf25a5193e352 REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22346 To: joselema, drosca, mweichselbaumer Cc:

D25859: Add Battery1 interface

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > batterytest.cpp:40 > + > +//qRegisterMetaType("ReconnectMode"); > +} If it's not needed, then just remove it. REPOSITORY R269 BluezQt REVISION DETAIL

D27112: Fix errors in the QRegularExpression porting commit

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77674 --- Bump - David Rosca On March 15, 2015, 4:56 p.m., David

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

daf3902 src/org.kde.JobView.xml f64d232 src/org.kde.JobViewV2.xml 245a5f0 Diff: https://git.reviewboard.kde.org/r/122970/diff/ Testing --- plasma-workspace stable now builds fine changing V2 - V3 in CMakeFiles.txt in master branch enable the new setError method. Thanks, David Rosca

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit abafc8a6e72e4bb8d84cac2863d8513ed50aff00 by David Rosca to branch master. Repository: kjobwidgets Description --- Reuse org.kde.JobView.xml file that is no longer used

Re: Review Request 122926: Add setError method to JobViewV2 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77503 --- On March 13, 2015, 7:26 p.m., David Rosca wrote: --- This is an automatically

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

f64d232 src/org.kde.JobViewV2.xml 245a5f0 Diff: https://git.reviewboard.kde.org/r/122970/diff/ Testing --- plasma-workspace stable now builds fine changing V2 - V3 in CMakeFiles.txt in master branch enable the new setError method. Thanks, David Rosca

Re: New framework: BluezQt

I'm forwarding the reply here too: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not a right thing. The

New framework: BluezQt

Hi all, BluezQt is a wrapper library for Bluez 5 DBus API. It will be used in Bluedevil as a replacement for libbluedevil. It is currently in playground (playground/libs/bluez-qt). It should be a Tier 1 framework (only depends on Qt libs). The code should follow all framework policies and the

Re: [kde-frameworks-devel] Review request: QBluez

On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell j...@jriddell.org wrote: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which

Re: Review Request 122926: Add setError method to JobViewV2 interface

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 812d0b440e7f08e3acdd1c9bb95779bd871b75b3 by David Rosca to branch master. Repository: kjobwidgets Description --- Currently, there is no way to retrieve value of KJob::error(). This patch

Review Request 122926: Add setError method to JobViewV2 interface

(changes in kuiserver, dataengine and notifications plasmoid). Diffs - src/kuiserverjobtracker.cpp 191359b src/org.kde.JobViewV2.xml cacb5e8 Diff: https://git.reviewboard.kde.org/r/122926/diff/ Testing --- Works fine with patched plasma-workspace Thanks, David Rosca

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

://git.reviewboard.kde.org/r/123335/#review78835 --- On April 11, 2015, 6:34 p.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 123335: Fix native file dialogs from widgets QFileDialog

/standarddialogs works fine QFileDialog *d = new QFileDialog(parent); d-open(); works fine test app: https://paste.kde.org/psddcng5n I'm running Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca ___ Kde

Re: Review Request 123677: Bring back use of KEncodingFileDialog

marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit d9eeed19cefe87e7b2d7345c12177bf89d90ff3c by David Rosca to branch master. Bugs: 343255 https://bugs.kde.org/show_bug.cgi?id=343255 Repository: ktexteditor Description

Review Request 123677: Bring back use of KEncodingFileDialog

. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123677: Bring back use of KEncodingFileDialog

/diff/ Testing --- Save file dialogs are working fine and saving to different encoding works too. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123677: Bring back use of KEncodingFileDialog

On May 7, 2015, 8:48 p.m., David Rosca wrote: Sorry, didn't know of the bug. Should I discard this rr? Christoph Feck wrote: Why? What you propose here was discussed as one possible option. Yes, but from the bug discussion it seems reverting those commits is not something

Re: Review Request 123677: Bring back use of KEncodingFileDialog

? - David Rosca On May 7, 2015, 8:45 p.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated

Review Request 123720: Fix autotests

the test pass. Diffs - autotests/kdirselectdialog_unittest.cpp bbbc958 autotests/kfiledialog_unittest.cpp 30392bf Diff: https://git.reviewboard.kde.org/r/123720/diff/ Testing --- All tests now pass Thanks, David Rosca ___ Kde

Re: Review Request 123714: Only accept existing directories in FileMode::Directory mode

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 55fba9000550c4a043961631d435069226aaea27 by David Rosca to branch master. Repository: frameworkintegration Description --- This also implements other modes for fileMode command line option

Re: Review Request 123713: KFileWidget: Don't accept files in directory only mode

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 74e7f27a41b76635dd5172f9dfd57deb882c794d by David Rosca to branch master. Repository: kio Description --- Don't accept files entered in location line edit when in directory only (KFile

Re: Review Request 123720: Fix autotests

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6732e8f47ec7898cf73b7831e3045c1a5a822a76 by David Rosca to branch master. Repository: frameworkintegration Description --- The kfiledialog_unittest was broken by me (sorry

Review Request 123713: KFileWidget: Don't accept files in directory only mode

--- Don't accept files entered in location line edit when in directory only (KFile::Directory) mode. Diffs - src/filewidgets/kfilewidget.cpp 58dd92e Diff: https://git.reviewboard.kde.org/r/123713/diff/ Testing --- Files are no longer accepted in directory only mode Thanks, David

Review Request 123714: Only accept existing directories in FileMode::Directory mode

-existant directories are no longer accepted. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

New framework: BluezQt

Hi all, I'd like to submit bluez-qt [1] for a review and then release it as part of frameworks 5.11. It is used in Bluedevil since the first release with Plasma 5.3. I have worked on API changes (it is source incompatible from the 5.3 version) and also added a new tests (including QML tests). I

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review80415 --- On April 17, 2015, 8 a.m., David Rosca wrote

Review Request 123778: Fix crash when DBus call ends with error

the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

marked as submitted. Review request for KDE Frameworks, David Faure and Lukáš Tinkl. Changes --- Submitted with commit 26406a9aa01d6f4f01a3f084b51451de8385c8fc by David Rosca to branch master. Repository: frameworkintegration Description --- 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

://git.reviewboard.kde.org/r/123341/#comment53926 You probably forgot to replace this save() with return true. - David Rosca On April 12, 2015, 7:52 a.m., Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: bluez qt bic sic - soversion regression

Fixed now, sorry about that. David On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter sit...@kde.org wrote: alohas this commit http://quickgit.kde.org/?p=bluez-qt.gita=commith=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 removed the soversion6 which is needed as the present API is incompatible

Re: New framework: BluezQt

It's been over 14 days now, so if there are no objections, I will ask sysadmins to move it to frameworks. Also, are there any other steps I should do besides moving the repository? Thanks, David On Tue, May 12, 2015 at 11:44 PM, David Rosca now...@gmail.com wrote: Hi all, I'd like to submit

Re: Review Request 123778: Fix crash when DBus call ends with error

callback is not called (maybe it would be good to somehow indicate the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca

Re: Review Request 123778: Fix crash when DBus call ends with error

, continuation callback is not called (maybe it would be good to somehow indicate the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca

<    1   2