D26564: Clean kbuildsycoca4 support

hein added a comment. Let's wait until branching, there's still some KDE 4 apps people use. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26564 To: meven, ervin, #frameworks, hein Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23036: Fix incorrect initial tabs position for vertical tab bars

hein accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23036 To: lisin, #plasma, ngraham, hein Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22960: Add handle icons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:29dffaf4cd72: Add handle icons (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22960?vs=63155&id=63327 REVISION DETAIL https://phabricator.kde

D22958: Add initial Android support to ecm_add_app_icon

hein abandoned this revision. hein added a comment. Marco explained privately he doesn't want this so I'll move it to my codebase for now until the alternative better thing appears. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #framewo

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. In D22958#507299 , @nicolasfella wrote: > Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well? Mostly because I don't know what assumptions Kirigami makes. Its own macro is hardcoded to only wor

D22960: Add handle icons

hein created this revision. hein added reviewers: Frameworks, apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 AFFECTED F

D22958: Add initial Android support to ecm_add_app_icon

hein added inline comments. INLINE COMMENTS > apol wrote in ECMAddAppIcon.cmake:154 > this if could go up to where we're checking the icon name in an elseif up at > line 146. We'd need to do a `get_filename_component` there and end up either pulling the `ext` thing out twice (unless CMake does

D22955: Add icon used by Kirigami.AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c17c048ec2f7: Add icon used by Kirigami.AboutPage (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22955?vs=63146&id=63152 REVISION DETAIL htt

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. This is the culmination of a patch series that makes About dialogs in Kirigami work reasonably across platforms: F7168840: about.jpg REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 T

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. The code is mostly copy-and-pasted together from ECMAddAppIcon.cmake and ECMInstallIcons.cmake. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #frameworks, mart, leinir, apol Cc: kde-frameworks-devel, kde-buildsyste

D22958: Add initial Android support to ecm_add_app_icon

hein created this revision. hein added reviewers: Frameworks, mart, leinir, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hein requested review of this revision. REVISION SUMMARY Kirigami has a `kirigami_package_breeze_ico

D22955: Add icon used by Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22955 AFFECTED FILES

D22868: Revamp Kirigami.AboutPage

hein added a comment. I'll remove that part of the patch later tonight and talk Marco into fixing it differently. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella, ngraham,

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a99c14d1eac9: Consistently use Units.toolTipDelay instead of hardcoded values (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22867?vs=62879&id=

D22868: Revamp Kirigami.AboutPage

hein updated this revision to Diff 62883. hein added a comment. Don't hit Kirigami.Label (deprecated) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22868?vs=62880&id=62883 BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 AFFECTED

D22868: Revamp Kirigami.AboutPage

hein added a reviewer: leinir. REPOSITORY R169 Kirigami BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

hein added a comment. Discover: F7130049: Screenshot_20190801_100601.png Material style: F7130053: Screenshot_20190801_100645.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde

D22868: Revamp Kirigami.AboutPage

hein added a comment. Before: F7130036: Screenshot_20190801_15.png After: F7130037: Screenshot_20190801_100033.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868

D22868: Revamp Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, VDG, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Use a FormLayout to work nicely in both portrait and landscape orientations - Don

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 AFFECTED FILES src/controls/private/GlobalDrawerActionI

D21169: Add app icon for the Kirogi Drone control app

hein added a comment. I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that. Appli

D21169: Add app icon for the Kirogi Drone control app

hein added a comment. @trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D20428: separe mobile text selection to avoid recursive imports

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Works here now, thx! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20428 To: mart, #plasma, hein Cc: hein, kde-frameworks-devel,

D18986: [breeze-icons] Add video camera icons

hein accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

hein added a comment. Would it be possible to also add the lineart versions as -symbolic? In my new app I rely on Kirigami's icon recoloring feature and it only works with monochrome icons, so I rely on -symbolic to request them. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVI

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH gamepad-icon-16-22-px (branched from master) REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, brun

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein added a comment. LGTM, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein added a comment. Could this maybe be input-games-symbolic (too)? Because I want a monochrome version always (my app recolors icons using the Kirigami feature, and that only works with monochrome icons). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030

D18901: Add device icons for drones

hein added a comment. Thank you! Just what I needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein, ngraham, rooty Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D17691: Add rows info to the plasma virtual desktop protocol

hein added a task: T4457: [kwayland] Virtual Desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18187 To: chinmoyr, ngraham, hein Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

hein added a comment. > The desktop cube shows everything flat, desktop grid is configurable (and hardcoded). The desktop grid effect uses the rows setting from the KCM for me. I don't think it's easy for users to understand that the KCM is configuring KWin only, instead of all of P

D17691: Add rows info to the plasma virtual desktop protocol

hein added a comment. As per this , progress on this is currently blocking wrapping up Wayland virtual desktops support for 5.15. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: hein, kde-

D16643: Correct the accept flag of the event object on DragMove

hein added a comment. @mart ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D15970: Properly look for fallback themes

hein accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D15970 To: apol, #plasma, davidedmundson, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15074: [server] Do not try to create data offers without source

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH offerWithSourceOnly REVISION DETAIL https://phabricator.kde.org/D15074 To: romangg, #kwin, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

hein added a task: T4457: [kwayland] Virtual Desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

hein added a comment. I have a problem: When I restart plasmashell, I don't get any desktops again. I think the code may not be re-sending the data when the client goes away and comes a second time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #

D14042: Support special URLs for finding files of a certain type

hein added a comment. Does it make sense to name the queries after XDG_USER_DIRS, so e.g. pictures instead of images? https://www.freedesktop.org/wiki/Software/xdg-user-dirs/ REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns, d

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

hein accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14043 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13866: Fix ResultModel item moving

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. It works for me. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D13866 To: davidedmundson, ivan, hein Cc: hein, kde-frameworks-devel, m

D12820: Add KWayland virtual desktop protocol

hein added a dependent revision: D13745: Implement support for virtual desktops on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraha

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e108d7e90e36: Teach ContainmentInterface::processMimeData how to handle Task Manager drops (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabrica

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

hein created this revision. hein added reviewers: davidedmundson, Zren, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. hein requested review of this revision. REVISION SUMMARY To explicitly confine Task Manager drops to

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

hein updated this revision to Diff 35463. hein added a comment. Fix last minute build error. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13275?vs=35371&id=35463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13275 AF

D13223: Set kcm context property on the correct context

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D13223 To: davidedmundson, #plasma, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13137: Updated handles and overflow-menu-*

hein accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This looks good, but I think there might be additional copies of these values in (a) the color KCM code and (b) the kdeglobals code in kdelibs4support, did you have a chance to look into those?

D12508: Make KMessageWidget match Kirigami inlineMessage's style

hein accepted this revision. hein added a comment. Looks good to me, thanks for working on this. REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart,

D12512: ScrollViewKCM

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH mart/ScrollViewKCM REVISION DETAIL https://phabricator.kde.org/D12512 To: mart, #plasma, hein Cc: hein, #frameworks, michaelh, bruns

D12512: ScrollViewKCM

hein added a comment. It looks good otherwise and I really want to accept this so I can progress on the Language KCM, but this magic value thing gives me a headache. It's going to break with other QStyles with a different value. We need some sort of fix for that ... REPOSITORY R296 KDecla

D12512: ScrollViewKCM

hein added a comment. Does the magic pixel size number for the padding get scaled correctly on hidpi? And where does System Settings have the magic pixel number from - is it hardcoded there as well or is it a QStyle thing that could change with the style engine? Could System Settin

D12215: Add a "Reload" menu item to KDirOperator's context menu

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks, hein Cc: maximilianocuria, dhaumann, rkflx, michaelh, bruns

D12097: Make room for footer and header.

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c6c41b4a97cc: Make room for footer and header. (authored by hein). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12097?vs=31836&id=32594 REVISION DETAIL ht

D12034: Use the more appropriate "two sliders" icon for "configure"

hein added a comment. In D12034#244019 , @hein wrote: > In principle I totally agree with this, but I'm not sure about the `input-keyboard` icon it extends to. Do you know where it's used currently? It's sometimes even used as window icon

D12034: Use the more appropriate "two sliders" icon for "configure"

hein added a comment. In principle I totally agree with this, but I'm not sure about the `input-keyboard` icon it extends to. Do you know where it's used currently? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: he

D12097: Make room for footer and header.

hein added a dependent revision: D12102: Port Language KCM to Qt Quick. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12097 To: hein, #kirigami, mart Cc: plasma-devel, #frameworks, michaelh, ngraham, bruns, apol, davidedmundson, mart, hein

D12097: Make room for footer and header.

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added projects: Kirigami, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. hein requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAI

D11960: Support nvidia reset notifications in QtQuickViews

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D11960 To: davidedmundson, #plasma, hein Cc: #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

hein added a comment. I also prefer the "Before" images. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, davidedmundson, plasma-

D11552: [WIP] Handle CJK characters

hein added a comment. For the record though - a better way to do this is to use QTextBoundaryFinder which will operate e.g. on grapheme cluster boundaries. This still isn't super great for Chinese though. If you want to really-properly do it you'll end up depending on ICU and using its Break

D11552: [WIP] Handle CJK characters

hein added a comment. If you're going to loop over a QString and break it down into QChars anyway, why don't you just use QChar::script? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashap

D10670: Reduce plasmashell frozen time

hein added a comment. I think it's because mwolff did "Requesting changes" and he didn't accept. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff, davidedmundson Cc: hein, mwolff, plasma-devel, davided

D10670: Reduce plasmashell frozen time

hein added a comment. > This revision was not accepted when it landed; it landed in state Needs Review. Weird, David accepted it though? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff, davidedm

D11510: [KPropertiesDialog] Support Checksum tab for any local path

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11510 To: broulik, #frameworks, dfaure, elvisangelaccio, hein Cc: michaelh, ngraham

D11278: [KateCompletionWidget] Create configuration interface on demand

hein added a comment. A backtrace for the crash @martinkostolny mentioned can be found here: https://bugs.kde.org/show_bug.cgi?id=391955 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11278 To: broulik, #ktexteditor, dhaumann, kfunk, cullmann Cc: hein, martinkos

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9625a3be6b1: [KProtocolInfoFactory] Don't clear cache if it had just been built (authored by hein). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11107?vs=28916&id=29

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik, dfaure Cc: michaelh

D11153: Use correct item URL for Create New context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:032709c17f00: Use correct item URL for Create New context menu (authored by prukgaber, committed by hein). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11153?vs=29006

D11153: Use correct item URL for Create New context menu

hein added reviewers: Frameworks, dfaure. hein added a comment. Looks good to me. I'll let David have a look too and then it can go in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein updated this revision to Diff 28916. hein added a comment. Slightly cleaner approach. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11107?vs=28885&id=28916 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11107 AFFECTED FILES src/core/k

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein commandeered this revision. hein edited reviewers, added: broulik; removed: hein. hein added a comment. Commandeering as agreed upon with Kai, new rev in a moment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik Cc: michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein added a comment. Good idea, but every time one of those state tracking bools get copied my mind screams "BAD PATTERN". It's not the fault of your patch but I don't like how this cache handling is written - it'd be cleaner if fillCache had a return value for "I actually did work" and if

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10870 To: broulik, #plasma, hein Cc: #frameworks, michaelh

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10863 To: broulik, #frameworks, #plasma, hein, aleksejshilin Cc: michaelh

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein added a comment. @ivan So you wrote a method that can return null, but the call sites aren't actually prepared to handle that gracefully? :) But I was waiting for your review for that context. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricat

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks, hein Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, a

D10684: [Drop Job] Create proper trash file on linking

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10684 To: broulik, #frameworks, #plasma, hein Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e3a80661c9cd: Stuff the "Couldn't find executable" message box into a queued lambda (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10405?vs=27048&id=27285#toc REPOSITORY

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. (Side note: I like the idea of a KRun job - something like that could even be added without needing a KIO 6.) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein updated this revision to Diff 27048. hein added a comment. - Fall back to qWarning if !qGuiApp - Use QTimer::singleShot to work on older Qt REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=27046&id=27048 BRANCH master REVISION DETAIL https:/

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. There's a problem with my patch :(. QMetaObject::invokeMethod(context, functor) is new in Qt 5.10. I don't think we can depend on that yet, right? Ah, but QTimer::singleShot added an overload w/ context in 5.4 .. REPOSITORY R241 KIO REVISION DETAIL https://phab

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein retitled this revision from "Don't proceed in runCommandInternal if the executable doesn't exit" to "Stuff the "Couldn't find executable" message box into a queued lambda". hein edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein updated this revision to Diff 27046. hein added a comment. New approach. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=26821&id=27046 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 AFFECTED FILES src/widgets/krun.cpp T

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. It's totally conceivable for e.g. a KPart or a Plasma plugin to open a QWidget-based window where the KMessageBox is appropriate, and if there's only a global interface instance and Plasma overrides it to hide all message boxes it's going to break KIO users in plugins.

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. There's a Job::setUiDelegateExtension though in addition to KIO::setDefaultJobUiDelegateExtension. A global would wreak havoc with stuff like plugins, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. Thanks for the solution for sure, but - it requires writing a million lines of boilerplate, extensively refactoring KRun and adding reams of new overloads to its API (there would need to be some way to pass an instance of that interface to all these - not internal - sta

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10420 To: apol, #plasma, hein Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. /o\ I don't like life anymore REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. @dfaure I don't see how the virtual thing is going to work - there's numerous static affected codepaths so there's no 'this' to pass down to call the non-static error handler on. I could add a new "silent" RunFlag and pass that around to quiet the message box altog

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. Yeah, I had a feeling there were other design considerations here, but they're not documented/commented in the code so the only way to find out was to show you a patch :) You want this virtual method where? In KRun? And then Plasma should subclass KRun? REPOSITORY

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

hein added a comment. Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.) Otherwise makes sense (and finally fixes some Wayland uglyness I've been annoyed by ...). REPOSITORY R242 Plasma Framework (Library) REVIS

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein updated this revision to Diff 26821. hein added a comment. Remove unrelated changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=26820&id=26821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 AFFECTED FILES src/widgets

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. Argh, sorry for the noisy diff, I didn't do commit -a but arc did I guess ... I'll clean this up, one sec. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart Cc: #frameworks, michaelh, ngraham

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein created this revision. hein added reviewers: dfaure, davidedmundson, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. hein requested review of this revision. REVISION SUMMARY Without this patch, runCommandInternal tries running

D9207: Don't load KDE platform module in kglobalaccel5

hein abandoned this revision. hein added a comment. As mentioned, I'm OK with abandoning it. I think the change is hygienic, but it's also a micro-optimization. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graess

D9207: Don't load KDE platform module in kglobalaccel5

hein added a comment. Well, the maintainer spoke out against it, so not much I can do. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,

D10251: [RFC] Use mipmap filtering in window thumbnails

hein added a comment. It's definitely nicer, but could we go for the full thing and make it crisper too? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, ngrah

  1   2   3   >