D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio updated this revision to Diff 22433. elvisangelaccio added a comment. - Use local variables REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22432=22433 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 AFFECTED FILES

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio updated this revision to Diff 22432. elvisangelaccio added a comment. - Fix also mkpathjobtest and fileundomanagertest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22430=22432 BRANCH master REVISION DETAIL

D8837: Fix testtrash with qtbase 5.10 beta 4

elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? I have two other failing tests in kio, which I'm fixing now. I guess this change will probably break

D8837: Fix testtrash with qtbase 5.10 beta 4

elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, thiago. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Same fix as in https://phabricator.kde.org/D8836, this time for testtrash. TEST

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY The latest Qt 5.10 beta includes [1] which breaks KIO all over the place, since `url.setPath("//foo")` will now result in an invalid

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio marked 2 inline comments as done. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio updated this revision to Diff 22241. elvisangelaccio added a comment. - Implement a global 'edit mode' that enables both kind of drags (whole toolbar + actions within the toolbar). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D8698: Fix KProtocoInfoTest if krusader is installed

elvisangelaccio retitled this revision from "Fix KProtolInfoTest if krusader is installed" to "Fix KProtocoInfoTest if krusader is installed". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8698 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166846, @colomar wrote: > Why don't we do this the way Firefox does it: Have a menu entry that puts the whole UI in config mode. > That works far better then trying to make each individual config feature

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166734, @apol wrote: > Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable? No, "unlocking" means you can drag the whole toolbar, e.g. from the top to the

D8774: Show Configure Toolbars dialog as modal

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY The "Configure Toolbars" dialog was made non-modal a long time ago [1] in order to allow drag-and-drop of toolbar actions while the

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a dependent revision: D8774: Show Configure Toolbars dialog as modal. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. Screenshot: F5488679: Screenshot_20171112_115923.png REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, VDG, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Drag-and-drop of toolbar actions is a nice feature that currently is basically hidden to end users. The only way to enable it

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. As I mentioned, using //only// a combobox doesn't work, because the main functionality (= check integrity of downloaded files) is now harder to use. REPOSITORY

D8696: Don't autoremove empty temp file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a2f1e9fa43d2: Dont autoremove empty temp file (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8696?vs=22034=22093 REVISION DETAIL

D8697: Don't check whether an empty filename exists

elvisangelaccio added a comment. In https://phabricator.kde.org/D8697#165670, @apol wrote: > Here's an alternative: https://codereview.qt-project.org/210716 That would be much cleaner indeed, I'll hold this patch for now. REPOSITORY R241 KIO BRANCH fix-empty-exists REVISION

D8696: Don't autoremove empty temp file

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a system call with an

D8698: Fix KProtolInfoTest if krusader is installed

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Krusader has a `krarc` ioslave that handles zip files. If krusader is installed,

D8697: Don't check whether an empty filename exists

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a system call with an

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio added a comment. @kossebau Ping? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8336 To: elvisangelaccio, kossebau, dfaure Cc: apol, #frameworks

D8434: Created 'shared' section

elvisangelaccio added a comment. In https://phabricator.kde.org/D8434#162727, @mwolff wrote: > lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#161276, @ngraham wrote: > My vote is for a single combobox with a reasonably common default choice like sha256, but that that remember the last-used choice if you change it. My sense is that most people who actually

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#161255, @ngraham wrote: > The concept of an "advanced" hashing algorithm doesn't really make sense IMHO. This whole thing is an "advanced" feature. > > How about a combobox containing a list of all available

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Thanks, now I can build it. Please add screenshots so that the https://phabricator.kde.org/tag/vdg/ team can have a look. I don't think we can show so much

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added inline comments. INLINE COMMENTS > CMakeLists.txt:6 > > +set(CMAKE_CXX_STANDARD 17) > + We can't use this in frameworks (and the patch doesn't build for me), see https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 REPOSITORY

D7828: createKMessageBox tries to focus a default button when available

elvisangelaccio added a comment. Does this mean that apps should always pass a parent? (if that's the case, we should mention it in the KMessageBox documentation) REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: elvisangelaccio, rkflx,

D8296: Use Alt+, as the standard shortcut for "Configure "

elvisangelaccio added inline comments. INLINE COMMENTS > kstandardshortcut.cpp:159 > { KeyBindings, "KeyBindings", QT_TRANSLATE_NOOP3("KStandardShortcut", > "Key Bindings", "@action"), 0, 0, QList(), false }, > -{ Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut", >

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio added inline comments. INLINE COMMENTS > apol wrote in kjobtrackerinterface.h:73 > Then it should be protected? Probably yes, should we add a TODO comment for KF6? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8336 To: elvisangelaccio, kossebau,

D8352: Use KIO::PreviewJob::defaultPlugins()

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D8352 REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks, broulik, elvisangelaccio, markg

D8352: Use KIO::PreviewJob::defaultPlugins()

elvisangelaccio added a comment. The alternative is to wrap the change with #if KIO_VERSION >= QT_VERSION_CHECK(5, 27, 0) without bumping the minumum version in cmake. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks,

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

elvisangelaccio added inline comments. INLINE COMMENTS > madcatx wrote in kio_smb_browse.cpp:521 > Yes. The idea is this: When the slave loads, it checks what libsmbclient lib > is available and sets the `m_enableEEXISTWorkaround` if a broken version is > detected. Then iff the return code

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

elvisangelaccio added inline comments. INLINE COMMENTS > madcatx wrote in kio_smb_browse.cpp:521 > Well, this method actually applies the workaround. The > `m_enableEEXISTWorkaround` is set to true when the an affected libsmbclient > library is detected. Don't we set

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

elvisangelaccio added inline comments. INLINE COMMENTS > kio_smb.cpp:67 > SMBSlave::SMBSlave(const QByteArray& pool, const QByteArray& app) > -: SlaveBase( "smb", pool, app ), m_openFd(-1) > +: SlaveBase( "smb", pool, app ), m_openFd(-1), > +

D8352: Use KIO::PreviewJob::defaultPlugins()

elvisangelaccio requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks, broulik, elvisangelaccio, markg

D8352: Use KIO::PreviewJob::defaultPlugins()

elvisangelaccio reopened this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. We cannot use new API without bumping the minimum KF5 version (currently 5.3, we need 5.40...) REPOSITORY R320 KIO Extras REVISION DETAIL

D7520: Fix icon of KStandardAction::MoveToTrash

This revision was automatically updated to reflect the committed changes. Closed by commit R265:b8641527bb67: Fix icon of KStandardAction::MoveToTrash (authored by elvisangelaccio). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7520?vs=20631=20966

D8347: KIO::PreviewJob::defaultPlugins() function

elvisangelaccio added inline comments. INLINE COMMENTS > previewjob.cpp:740-741 > +{ > +QStringList blacklist = QStringList() > +<< QStringLiteral("textthumbnail"); > + Shouldn't the blacklist be user-configurable? > previewjob.cpp:745 > +foreach (const

D8334: Fix display name of Generator property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:16751d8e232d: Fix display name of Generator property (authored by elvisangelaccio). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8334?vs=20865=20871

D8336: Improve apidox of KJobTrackerInterface

elvisangelaccio created this revision. elvisangelaccio added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As discussed in https://phabricator.kde.org/D3977, document when unregisterJob()

D8334: Fix display name of Generator property

elvisangelaccio created this revision. elvisangelaccio added a reviewer: mgallien. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use a shorter sentence (since space is limited) with Title Capitalization (since we

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

elvisangelaccio added a comment. In https://phabricator.kde.org/D3977#155762, @kossebau wrote: > On a quick look the automatic unregistering based on the finished signal seems to make sense for any KJob subclass. Perhaps the change in this commit conflicts with some older code in Ark to

D7130: KMoreTools: Update and fix desktopfiles

elvisangelaccio added a comment. @ngraham This patch is for knewstuff :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

elvisangelaccio added a comment. @kossebau After this change we get the Tried to unregister a kio job that hasn't been registered. warning with a `KCompositeJob` in Ark (batchextract.cpp). The job is now automatically unregistered and the `unregisterJob(this)` call in the

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

elvisangelaccio added a comment. I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so it's not a big deal if we also show the mtime there. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications,

D7520: Fix icon of KStandardAction::MoveToTrash

elvisangelaccio updated this revision to Diff 20631. elvisangelaccio added a comment. - Switched from `user-trash` to `trash-empty` (discussed with @andreaska in person). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7520?vs=18688=20631 BRANCH

D7130: KMoreTools: Update and fix desktopfiles

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. I had tested the patch and it was fixing the bug. I'm fine with this as long as @gregormi volunteers to maintain this code updated (and eventually to switch to a better design, if possible).

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

elvisangelaccio added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D8064 To: awilcox, dfaure Cc: #frameworks

D8000: Properly create KPixmapSequence

This revision was automatically updated to reflect the committed changes. Closed by commit R304:d967bd9e9345: Properly create KPixmapSequence (authored by elvisangelaccio). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8000?vs=19959=20118 REVISION DETAIL

D8000: Properly create KPixmapSequence

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Since KF5 we need to pass it the full path of the icon. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

elvisangelaccio added a comment. In https://phabricator.kde.org/D7944#148134, @ngraham wrote: > You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location.

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

elvisangelaccio added a comment. The linked bug looks wrong. I'm not sure I agree with this change. We save a click if we want to go from `/home/foo` to e.g. `/usr`, but we add an additional click if we just want to append something to `/home/foo`. I do this all the time (to go in the

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

elvisangelaccio added a comment. Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin,

D7929: [WIP] Add new Column View option to KDirOperator

elvisangelaccio added a comment. I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: elvisangelaccio, lbeltrame, #frameworks

D7855: Fix tags KIO-slave protocol description

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7855 To: nicolasfella, #frameworks, elvisangelaccio Cc: #frameworks

D7837: Show kioslave names in the debug output

This revision was automatically updated to reflect the committed changes. Closed by commit R241:589ee216b091: Show kioslave names in the debug output (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7837?vs=19558=19572 REVISION

D7837: Show kioslave names in the debug output

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This makes clear which kioslaves need fixing. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D7520: Fix icon of KStandardAction::MoveToTrash

elvisangelaccio added a subscriber: andreaska. elvisangelaccio added a comment. @andreaska Is it possible to add a new breeze icon for the move-to-trash action? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7520 To: elvisangelaccio, #frameworks Cc:

D7758: Deprecate KStandardShortcut::SaveOptions

This revision was automatically updated to reflect the committed changes. Closed by commit R237:34c2460d09dd: Deprecate KStandardShortcut::SaveOptions (authored by elvisangelaccio). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7758?vs=19357=19386 REVISION

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

This revision was automatically updated to reflect the committed changes. Closed by commit R265:806a5243bd71: Deprecate KStandardAction::PasteText and KPasteTextAction (authored by elvisangelaccio). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

elvisangelaccio updated this revision to Diff 19358. elvisangelaccio edited the summary of this revision. elvisangelaccio added a comment. - Bump @since REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7294?vs=18351=19358 BRANCH deprecate-pastetext

D7758: Deprecate KStandardShortcut::SaveOptions

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY For consistency with https://phabricator.kde.org/D7293. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D7758 AFFECTED FILES

D7729: Drop KAction references from kxmlgui apidox

This revision was automatically updated to reflect the committed changes. Closed by commit R263:302aee4debe1: Drop KAction references from kxmlgui apidox (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7729?vs=19294=19314

D7729: Drop KAction references from kxmlgui apidox

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7729 AFFECTED FILES src/kgesture_p.h src/kkeysequencewidget.h src/kmainwindowiface_p.h

D7605: Add apidox to KStandardShorcut::StandardShortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R237:5e75d6552ca1: Add apidox to KStandardShorcut::StandardShortcut (authored by elvisangelaccio). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7605?vs=18926=19120

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Note that this only works if there are no custom places yet (probably not a big deal). INLINE COMMENTS > kfileplacesmodel.cpp:110 >

D6197: Add kauth helper to file ioslave

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added inline comments. INLINE COMMENTS > file.actions:3 > +Name=Execute action as root. > +Description=Root privileges are required to complete the action. > +Policy=auth_admin We could use more descriptive sentences

D7620: Fix KHelpMenu position on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R263:f984e30b637f: Fix KHelpMenu position on Wayland (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7620?vs=18979=19032 REVISION DETAIL

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

elvisangelaccio added a comment. Ping REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7294 To: elvisangelaccio, #frameworks

D7620: Fix KHelpMenu position on Wayland

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This fixes the transient parent of KHelpMenu, which is required to properly position the popup on Wayland. TEST PLAN open Help menu from dolphin Control button. REPOSITORY R263

D7620: Fix KHelpMenu position on Wayland

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7620 To: elvisangelaccio, #frameworks

D7605: Add apidox to KStandardShorcut::StandardShortcut

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D7605 AFFECTED FILES src/gui/kstandardshortcut.h To: elvisangelaccio, #frameworks

Minutes GSoC meeting

Present: me, chinmoy, shortstheory Minutes in the attachment. Cheers, Elvis2017-08-26 08:59:26 eangMeeting! 2017-08-26 09:00:12 IrcsomeBot Sup 2017-08-26 09:00:28 chinmoy[m] here 2017-08-26 09:00:39 eanglet's start :) 2017-08-26 09:01:57 chinmoy[m]

D7479: klauncher: fix appId matching for flatpak apps

This revision was automatically updated to reflect the committed changes. Closed by commit R303:1ebdf8ea6ac1: klauncher: fix appId matching for flatpak apps (authored by elvisangelaccio). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18758=18856

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio updated this revision to Diff 18758. elvisangelaccio added a comment. Use `leftRef()` REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18700=18758 BRANCH kdbus-appId REVISION DETAIL https://phabricator.kde.org/D7479 AFFECTED

D7520: Fix icon of KStandardAction::MoveToTrash

elvisangelaccio added a comment. In https://phabricator.kde.org/D7520#139761, @broulik wrote: > I do have two somewhat different looking icons in the context menu. dolphin git master? Make sure you have https://phabricator.kde.org/D6778, which is what caused the regression >

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

elvisangelaccio added inline comments. INLINE COMMENTS > kurifilter.cpp:682-684 > // NOTE: Plugin priority is determined by the InitialPreference entry in > // the .desktop files, so the trader result is already sorted and should > // not be manually sorted. This comment looks

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio marked 2 inline comments as done. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio updated this revision to Diff 18700. elvisangelaccio added a comment. - Fixed David's issues. REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18600=18700 BRANCH kdbus-appId REVISION DETAIL https://phabricator.kde.org/D7479

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

This revision was automatically updated to reflect the committed changes. Closed by commit R303:db633494ef71: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs (authored by elvisangelaccio). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7480?vs=18586=18690 REVISION DETAIL

D7520: Fix icon of KStandardAction::MoveToTrash

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It should be different from the DeleteFile icon, otherwise it's not possible to distinguish them. TEST PLAN Open context menu of Dolphin (master) and press Shift. REPOSITORY R265

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio edited the summary of this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio updated this revision to Diff 18600. elvisangelaccio added a comment. - Add reference to https://phabricator.kde.org/D5775 REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18585=18600 BRANCH kdbus-appId REVISION DETAIL

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio added a comment. In https://phabricator.kde.org/D7479#138860, @elvisangelaccio wrote: > I just realized that ".kdbus" is appended by KDBusAddons, not by flatpak. Maybe we could also fix it there... Nope, it's intentional (see https://phabricator.kde.org/D5775). So

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio added a comment. I just realized that ".kdbus" is appended by KDBusAddons, not by flatpak. Maybe we could also fix it there... REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

elvisangelaccio edited the summary of this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7480 To: elvisangelaccio, dfaure Cc: #frameworks

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We are already using qCDebug(), so there is no reason to have this ifdefs all over the place. REPOSITORY R303 KInit BRANCH

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With flatpak applications we can have the following scenario: appId= "org.kde.ark.kdbus-_1_769" newAppId= "org.kde.ark.kdbus"

D7391: Replace KStandardAction::PasteText with KStandardAction::Paste

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b53e6d04cf09: Replace KStandardAction::PasteText with KStandardAction::Paste (authored by elvisangelaccio). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

Minutes GSoC meeting

Present: me, chinmoy, shortstheory Minutes in the attachment. Cheers, Elvis2017-08-20 09:01:22 eangMeeting! 2017-08-20 09:01:27 chinmoy[m] yes 2017-08-20 09:02:11 eanglet's start then 2017-08-20 09:03:44 chinmoy[m] Didn't do much this week due to college :(

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

elvisangelaccio edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7294 To: elvisangelaccio, #frameworks

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

elvisangelaccio edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7294 To: elvisangelaccio, #frameworks

D7391: Replace KStandardAction::PasteText with KStandardAction::Paste

elvisangelaccio created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY The PasteText standard action creates a KPasteTextAction rather than a simple QAction. KPasteTextAction is a very old

D7294: Deprecate KStandardAction::PasteText and KPasteTextAction

elvisangelaccio retitled this revision from "Deprecate KStandardAction::PasteText" to "Deprecate KStandardAction::PasteText and KPasteTextAction". elvisangelaccio edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7294 To:

D7294: Deprecate KStandardAction::PasteText

elvisangelaccio updated this revision to Diff 18351. elvisangelaccio added a comment. - Also deprecate KPasteTextAction REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7294?vs=18095=18351 BRANCH deprecate-pastetext REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >