D20659: Detach container in Component::cleanUp before interating

fvogt updated this revision to Diff 56517. fvogt added a comment. Use auto (which might actually make it build) REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56515&id=56517 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2065

D20659: Detach container in Component::cleanUp before interating

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Might fix crashes similiar to bug 406426 TEST PLAN Not tested, will ask someone to do that with valgrind REPOSITORY R2

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt accepted this revision. fvogt added a comment. Code still looks good to me - I can't comment on the cmake parts though. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthony

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. Looking good to me, @bruns: any addiitonal comments? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Looks good to me otherwise. INLINE COMMENTS > file.cpp:1033 > +/* And linux version using statx syscall */ > +if (buff.stx_btime.tv_nsec > 0) { > +entry.

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

fvogt added a comment. I'm very much in favor of this, but don't know anything about the cmake magic involved, so can't really say much about that. INLINE COMMENTS > CMakeLists.txt:15 > +set_package_properties(svgcleaner PROPERTIES > +TYPE REQUIRED > +) You could make this o

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. In D20096#440923 , @meven wrote: > In D20096#440921 , @fvogt wrote: > > > In D20096#440919 , @meven wrote: > > > > > So unless I

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. In D20096#440919 , @meven wrote: > In D20096#440868 , @fvogt wrote: > > > In D20096#440842 , @meven wrote: > > > > > In D20096#44

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. In D20096#440842 , @meven wrote: > In D20096#440830 , @pino wrote: > > > Note that, even if the system supports statx() (so with glibc >= 2.28), you must support systems withou

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434405 , @rooty wrote: > This wasn't supposed to land in Plasma 5.15 as well as master? Plasma Framework is (in this case unfortunately) a Framework, so no stable branches. REPOSITORY R242 Plasma Framew

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434371 , @rikmills wrote: > I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. I agree - as this touches binary files, appl

D19821: Fix breeze dialog background with Qt 5.12.2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54176&id=5

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434345 , @acooligan wrote: > Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ? Yes. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phab

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: filipf, heikobecker,

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt updated this revision to Diff 54176. fvogt added a comment. One more file. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54143&id=54176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 AFFECTED FILES

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. There's a special case in `./src/desktoptheme/breeze/icons/audio.svgz` and `.../battery.svgz`: It has color scheme definitions both in a `

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt updated this revision to Diff 54143. fvogt added a comment. Keep the style element, but assign id and type. Fix tooltip.svgz as well. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54076&id=54143 BRANCH master REVISION

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY style elements without type="text/css" were ignored before, but now they act as if type w

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D18845: authority: add support for passing details to polkit

fvogt added a comment. LGTM to me as well - I'm not familiar with this code at all though. REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: mati865, kde-frameworks-devel

D19394: Show a warning if a plugin requires a newer version

This revision was automatically updated to reflect the committed changes. Closed by commit R242:02ec1b77c23e: Show a warning if a plugin requires a newer version (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19394?vs=52

D19394: Show a warning if a plugin requires a newer version

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently it just fails silently. TEST PLAN Loaded a plasmoid with an incompatible plugin

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

fvogt added a comment. Can you add context to this diff by either using arc or git diff with more context? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19027 To: Lekensteyn, ngraham, dfaure, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

fvogt added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

fvogt closed this revision. fvogt added a comment. Landed (phab didn't notice): https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, he

D16643: Correct the accept flag of the event object on DragMove

fvogt accepted this revision. fvogt added a comment. @trmdi: Do you have push access? If not, which name should be used for the commit? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: fvogt, aacid

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. @trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed and everyone's happy :-) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: fvogt, aacid, bruns, dkorth, n

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. > The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) prior to the first return statement would cove

D18662: Add and rename some YaST icon symlinks because of Qt bugs

fvogt added a comment. In D18662#403612 , @ndavis wrote: > @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. I tried to understand what this change does both by trying to reproduce the issue and reading Qt code. Here the symptom was more drags not getting accepted at all than flipping back and forth, but this patch fixes that as well. What might cause confusion is that

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

This revision was automatically updated to reflect the committed changes. Closed by commit R287:51d710adda14: Fix various OOB reads and writes in kimg_tga and kimg_xcf (authored by fvogt). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18574?vs=50416&id=

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

fvogt updated this revision to Diff 50416. fvogt added a comment. Also bail out early if image data known broken. (Unrelated to the overflow fixes, but nice to have) REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18574?vs=50414&id=50416 BRANCH se

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

fvogt created this revision. fvogt added a reviewer: aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. TEST PLAN No crash anymore. REPOSITORY R287 KImageFormats BRANCH sec REVISION DETAIL https://phabrica

D17122: Add option to use wl_display_add_socket_auto

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d671fcd0c09d: Add option to use wl_display_add_socket_auto (authored by fvogt). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=50238&id=50241 REVISION DE

D17122: Add option to use wl_display_add_socket_auto

fvogt updated this revision to Diff 50238. fvogt added a comment. Replace XDG_RUNTIME_DIR, test still passes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=49806&id=50238 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122 AFFE

D17122: Add option to use wl_display_add_socket_auto

fvogt marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

fvogt added inline comments. INLINE COMMENTS > romangg wrote in test_display.cpp:223 > This fails when one tries to run the test inside another Wayland session, > which already uses the wayland-0 socket name. > > What you could do here is loop until you find the first non-existing > `wayland-x

D10716: handle wrong password when using sudo which asks for another password

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R299 KDESu BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

fvogt updated this revision to Diff 49806. fvogt marked 2 inline comments as done. fvogt added a comment. Add some style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=49802&id=49806 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D17122: Add option to use wl_display_add_socket_auto

fvogt added a comment. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

fvogt retitled this revision from "RFC: Use wl_display_add_socket_auto by default" to "Add option to use wl_display_add_socket_auto". fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt updated this revision to Diff 49802. fvogt added a comment. Use a new bool instead. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=46075&id=49802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122 AFFECTED FILES autote

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395762 , @romangg wrote: > In D17122#395745 , @fvogt wrote: > > > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior. That would need changes in KWin though so Plasma 5.16 only :-( REPOSITORY

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395704 , @romangg wrote: > In D17122#395696 , @fvogt wrote: > > > In D17122#395537 , @romangg wrote: > > > > > I don't

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395537 , @romangg wrote: > I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket. I

D10716: handle wrong password when using sudo which asks for another password

fvogt added inline comments. INLINE COMMENTS > fvogt wrote in suprocess.h:75 > Just use 0 instead - the enum isn't meant for that apparently. This is still there, so not done yet. The enum SuErrors is (apparently) not meant to be used by callers of exec as they have different accessibility. RE

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

fvogt added inline comments. INLINE COMMENTS > jriddell wrote in suprocess.h:75 > yes > autotests/kdesutest.cpp:40:45: error: ‘KDESu::SuProcess::SuErrors ok’ is > private within this context Just use 0 instead - the enum isn't meant for that apparently. REPOSITORY R299 KDESu REVISION DETAIL

D17528: Refactor SlaveInterface::calcSpeed

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slaveinterface.cpp:102 > +// Note for future reference: A list is maintained for sizes and times. > +// Minimum list size is 1 and maximum list size is 8

D10716: handle wrong password when using sudo which asks for another password

fvogt added a comment. In D10716#391331 , @jriddell wrote: > > Is it necessary to write the mock su/sudo in python? That introduces a big and mostly unnecessary dependency on python. > > Nope but that's what was easiest for me and I'm out of

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D10716#390699 , @jriddell wrote: > - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir What you want is

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > suprocess.cpp:124 > +if (d->testMode) { > +args += QByteArray(CMAKE_RUNTIME_OUTPUT_DIRECTORY) + "/kdesu_stub"; > +} else { This means the path t

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > su:28 > +self.state = State.GOOD > +call(["/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu_stub"]) > +exit(0) That w

D17623: Add YaST icons

fvogt added a comment. In D17623#380551 , @ndavis wrote: > In D17623#380549 , @fvogt wrote: > > > In D17623#380511 , @ndavis wrote: > > > > > @fvogt @he

D17623: Add YaST icons

fvogt added a comment. In D17623#380511 , @ndavis wrote: > @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me figure

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt created this revision. fvogt added reviewers: KWin, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY If there is no socketName specified explicitly, it will use wl_display_add_socket_aut

D16471: Listen for added DBus interfaces instead of registered services

This revision was automatically updated to reflect the committed changes. Closed by commit R282:fa472e6a5e26: Listen for added DBus interfaces instead of registered services (authored by fvogt). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16471?vs=

D16471: Listen for added DBus interfaces instead of registered services

fvogt retitled this revision from "[RFC] Listen for added DBus interfaces instead of registered services" to "Listen for added DBus interfaces instead of registered services". fvogt edited the summary of this revision. REPOSITORY R282 NetworkManagerQt BRANCH ifadded REVISION DETAIL https

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

fvogt added a comment. In D16692#355067 , @albertvaka wrote: > In D16692#354990 , @fvogt wrote: > > > I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit mess

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

fvogt added a comment. I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message. Is this workaround/fix only needed on neon or is the message wrong? REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduiste

D16471: [RFC] Listen for added DBus interfaces instead of registered services

fvogt added a comment. In D16471#354635 , @jgrulich wrote: > Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated success

D16434: Fix keyboard layout change notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R268:4d28bd4183d2: Fix keyboard layout change notifications (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44765&id=44766 REVISION DE

D16434: Fix keyboard layout change notifications

fvogt updated this revision to Diff 44765. fvogt marked 2 inline comments as done. fvogt added a comment. This file needs to be reformatted anyway. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44715&id=44765 BRANCH master REVISION DETAIL

D16434: Fix keyboard layout change notifications

fvogt updated this revision to Diff 44715. fvogt added a comment. Use if-else ladder instead of switch-case and fix a typo. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44714&id=44715 BRANCH master REVISION DETAIL https://phabricator.k

D16434: Fix keyboard layout change notifications

fvogt marked 2 inline comments as done. fvogt added inline comments. INLINE COMMENTS > romangg wrote in kglobalaccel_x11.cpp:96 > Before there was a check to `QX11Info::isPlatformX11()`. Probably we don't > need the check, but did you test on Wayland? The plugin is only loaded if the Qt platfor

D16434: Fix keyboard layout change notifications

fvogt updated this revision to Diff 44714. fvogt marked an inline comment as done. fvogt added a comment. Add Q_ASSERT and xcb_key_symbols_free. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44247&id=44714 BRANCH master REVISION DETAIL

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

This revision was automatically updated to reflect the committed changes. Closed by commit R302:3501660aa3d7: Add a QIconEnginePlugin to allow QIcon deserialization (authored by fvogt). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16305?vs=43893&id=44698

D16471: [RFC] Listen for added DBus interfaces instead of registered services

fvogt updated this revision to Diff 44334. fvogt added a comment. Fix bad merge REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16471?vs=44332&id=44334 BRANCH ifadded REVISION DETAIL https://phabricator.kde.org/D16471 AFFECTED FILES src/man

D16471: [RFC] Listen for added DBus interfaces instead of registered services

fvogt created this revision. fvogt added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY When the service is registered, the interfaces might not be available yet. So wait for those instead. BUG: 400359 Th

D16434: Fix keyboard layout change notifications

fvogt updated this revision to Diff 44247. fvogt added a comment. Don't use a union. Still works. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44241&id=44247 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16434 AFFECTED FI

D16434: Fix keyboard layout change notifications

fvogt marked 4 inline comments as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16434 To: fvogt, #frameworks, #plasma Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D16434: Fix keyboard layout change notifications

fvogt added a comment. Note that the way it's done is ~~copied from~~ inspired by QXcbConnection. I don't like it either though, so I'll try getting rid of the union. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16434 To: fvogt, #frameworks, #plasma Cc:

D16434: Fix keyboard layout change notifications

fvogt created this revision. fvogt added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This rework fixes several issues: - Qt wasn't informed about XCB_MAPPING_NOTIFY anymore - With XKB enabled in Qt, X won't s

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This is necessary to allow QIcons with a KIconEngine as engine to deserialize properly. BUG: 399989 TEST PLAN Ran the PoC in th

D8532: [WIP] Restrict file extractor with Seccomp

fvogt added a comment. AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs. The best design would be (IMO, not sure how well the current architecture fits) to have a fully sandboxed executable which can only communicate with baloo over

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d2d52da38016: Avoid QByteArray::remove in AccessManagerReply::readData (authored by fvogt). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41476&id=42138 REVI

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. @svuorela accessmanagertest already tests whether the AMR works in general. Do you mean a test which ensures there is no performance regression? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisan

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41476. fvogt added a comment. Remove code. Any more nits to pick? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41468&id=41476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED FI

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. In D15426#324636 , @bruns wrote: > In D15426#324486 , @fvogt wrote: > > > In D15426#324284 , @bruns wrote: > > > > > For the triv

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41468. fvogt added a comment. The empty "if" is kept for readability. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41456&id=41468 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED FIL

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41456. fvogt added a comment. Avoid reallocation in slotData if removing m_offset frees enough space. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41455&id=41456 BRANCH master REVISION DETAIL https://phabrica

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. In D15426#324284 , @bruns wrote: > For the trivial case, do the clear in `readData()`. > > For the non-trivial case: > > 1. in `readData()`, no memmoves were ever done. Currently, if you have e.g. 50 kB in m_data, y

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41455. fvogt added a comment. Save m_offset bytes in slotData as well. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41427&id=41455 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED FI

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added inline comments. INLINE COMMENTS > bruns wrote in accessmanagerreply_p.cpp:156 > Wouldn't it be better to trim the buffer in slotData, at least in the > non-trivial case? For the non-trivial case it shouldn't make a difference really. For the trivial one it does, as otherwise it wo

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41427. fvogt added a comment. - Actually make it work - Free memory if m_offset is half of the array size - Bail out if maxSize < 0 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41406&id=41427 BRANCH master

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. Depending on how AccessManagerReply is used, it might be necessary to do `m_data.remove(0, m_offset); m_offset = 0;` if `m_offset` grows too large to not leak memory. Can a KIO expert answer this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt created this revision. fvogt added reviewers: Frameworks, elvisangelaccio. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY It copies the remaining data to the beginning of the buffer, which can be really expensive. BUG: 375765 TEST PLAN

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. This will likely not work with ACLs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15242 To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame Cc: kde-frame

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bfbef9f61a17: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1 (authored by fvogt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15113?vs=40535&id=40820 REV

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

fvogt added a comment. With a few modification the patch is correct and necessary though. statfs (not statvfs!) has in the documentation: `Fields that are undefined for a particular filesystem are set to 0.`. Currently KIO just returns garbage in that case. The KMountPoint calls abo

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

fvogt created this revision. fvogt added a reviewer: Frameworks. fvogt requested review of this revision. REVISION SUMMARY Missing previously. TEST PLAN git add and commit worked. REPOSITORY R320 KIO Extras BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D15113

D14723: Add option to disable KWallet entirely in the new wallet dialog

fvogt added inline comments. INLINE COMMENTS > aacid wrote in knewwalletdialog.h:67 > do we really need to rename this? It's not just a rename - it's doing the opposite now as there are three instead of two actions. If you follow which slot this ends up, it's responsible for switching between

D14723: Add option to disable KWallet entirely in the new wallet dialog

fvogt updated this revision to Diff 40079. fvogt added a comment. Quit kwalletd if option was selected. The .sync is necessary because the change is made in a KSharedConfig but read by the simple KConfig in reconfigure. I guess it should use KSharedConfig everywhere and just call "repa

<    1   2   3   4   >