D25999: Add optional subtitle to grid delegate

filipf added a comment. In D25999#577780 , @ngraham wrote: > It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? Yeah if we could it wouldn't be bad to add a

D25999: Add optional subtitle to grid delegate

filipf added a comment. ^ No, it seems to be GridDelegate actually. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

filipf added a comment. Testing it. Usability wise the strength is perfectly fine; the shadows still do their job. Visually it's a definitive improvement for me. Only thing I'm not sure of is the weaker strength in the corners, but I'm going to keep testing to see if it's just a

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button). The

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. filipf added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

filipf added a comment. My impression is that the rounding is currently just faked by the shadow. So when the shadow gets lighter, it becomes more obvious that the object itself isn't really rounded. F7787609: image.png REPOSITORY R242 Plasma

D24593: Modified breeze shadows

filipf added a comment. > b) radial gradients instead of linear on the four sides to make the center darker than the angles. Other than this, they look great to me. I think they should be uniformly dispersed. One of the things with shadows is that the user shouldn't really notice

D25015: Update breeze theme shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R242:35351ba3f299: Update breeze theme shadows (authored by niccolove, committed by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. I really like this all in all, and the light version looks ready to go. The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be somewhat darker and then the Plasma theme would also be darker. What's more important

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Arcpatched and compiled and I was getting an overly transparent Breeze Dark: F8094138: image.png It was only when I turned Contrast Effect off and then on again that I was seeing what's in the test plan. We should

D27299: Vertically center tooltip icon/image

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27299 To: ngraham, #vdg, #plasma, filipf Cc:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Right, I also noticed the color-aware theme now has somewhat more pronounced discrepancy between the panel and the popups when dark color schemes are used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We're the only theme with the appropriate heading svgs that make the headers and footers look as they should. All

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29352 To: filipf, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Adding a patch to 5.70

Dear Frameworks maintainers, Would it be possible to add this (https://phabricator.kde.org/D29352) patch to the 5.70 release? The change concerns not breaking third-party Plasma themes, and as Nate explained "If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: Adding a patch to 5.70

Thank you, David! On Sun, May 3, 2020 at 7:08 PM David Faure wrote: > On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote: > > Dear Frameworks maintainers, > > > > Would it be possible to add this (https://phabricator.kde.org/D29352) > patch > > to the 5.

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

filipf added a comment. LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29802: Require out-of-source builds

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella, filipf Cc: ltoscano, davidre,

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a comment. The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for `focus-background` and `pressed`. REPOSITORY R242 Plasma

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: davidedmundson, mart, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc:

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We have two interfering button background items right now: - surfaceNormal when it has activeFocus and is using

<    1   2