Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

://git.reviewboard.kde.org/r/119111/#comment42863 This also removes the first po_file argument resulting in no installed translations at all if a single po file per language directory is shipped. After removing the 1 I've successfully built and installed systemsettings-4.98.0 - Heiko Becker On July 4

Review Request 119230: Import FindOpenGLES from kwin.

://git.reviewboard.kde.org/r/119230/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119230: Import FindOpenGLES from kwin.

/119227/. Diffs - find-modules/FindOpenGLES.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119230/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc

the link took me to KSharedConfig's page. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc

://git.reviewboard.kde.org/r/121272/diff/ Testing --- Generated the api docs and tested the link took me to KSharedConfig's page. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122606: Fix startup of kssld5 dbus service

that the patch solves the described problem for me. - Heiko Becker On Feb. 17, 2015, 2:34 nachm., Bartosz Sławianowski wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606

Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81439 --- Ping? - Heiko Becker On Mai 8, 2015, 7:15 nachm., Heiko

Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 5a63345aa9f9a3e27bcc25f53328687e519c1fdc by Heiko Becker to branch master. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run

Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

no clue about Mac OS, I do wonder in what respect GUI-less tests are special on Mac OS. - Heiko Becker On Juni 13, 2015, 7:56 nachm., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124636: Remove DDS and JPEG-2000 plugin

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit e5fce91de6ef72f15c7d31b16b2494f534c7157c by Heiko Becker to branch master. Repository: kimageformats Description --- They were already disabled when building with Qt = 5.3

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- Successfully installed it with -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

=/usr/share Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 59509139a33829a5b76424d2a8c1cb2f3b885580 by Heiko Becker to branch master. Repository: kwallet Description --- Two reasons to do this: - DBUS_INTERFACES_INSTALL_DIR is marked deprecated - It's

Re: Review Request 125387: qca-ossl: Fix build without support for SHA-0

marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Changes --- Submitted with commit 0dbed8eb38afd1561907a52283091c37e7b85156 by Heiko Becker to branch master. Repository: qca Description --- LibreSSL >= 2.3.0 removed support for SHA-0, so there's no EVP_

Re: Review Request 125386: qca-ossl: Fix build without SSLv3

marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Changes --- Submitted with commit 20a587d77636186edb044cd2b71d6d90fe98d232 by Heiko Becker to branch master. Repository: qca Description --- This fixes building with LibreSSL >= 2.3.0 which has removed supp

Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

ion should possibly get removed). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

f039db19e1df89f62a33dc323cf0b8344d9b33fd icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0 Diff: https://git.reviewboard.kde.org/r/126056/diff/ Testing --- Icons get installed into the desired location. Thanks, Heiko Becker ___ Kde-frameworks-devel

Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons

beaf06c4e181fee0 Diff: https://git.reviewboard.kde.org/r/126056/diff/ Testing --- Icons get installed into the desired location. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

get installed into the desired location. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

it: https://git.reviewboard.kde.org/r/125852/#review87947 --- On Okt. 28, 2015, 9:48 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

way to fix the issue, or if the option should be made to work without boost (or the option should possibly get removed). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124321: Fix building with the fake backend

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5c026991572eb44eccf0e50c33199e80984c733e by Heiko Becker to branch master. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given

Re: Review Request 124321: Fix building with the fake backend

4e237afe40199df2b154cf10868e27993fa0fa27 KF5AuthConfig.cmake.in b7aa445aedef308a47de326475db91e483a078e1 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing

Review Request 124321: Fix building with the fake backend

/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124321: Fix building with the fake backend

/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124321: Fix building with the fake backend

b7aa445aedef308a47de326475db91e483a078e1 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 125387: qca-ossl: Fix build without support for SHA-0

ilt, ran the tests and installed (with LibreSSL-2.3.0 and OpenSSL-1.0.2d). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125386: qca-ossl: Fix build without SSLv3

tps://git.reviewboard.kde.org/r/125386/diff/ Testing --- Successfully built, ran the tests and installed. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

marked as submitted. Review request for KDE Frameworks and Uri Herrera. Changes --- Submitted with commit 5a501dd330b6a61cf6eb909946e5295115fe7693 by Heiko Becker to branch master. Repository: breeze-icons Description --- It was previously hard-coded to prefix/share which

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

iewboard.kde.org/r/126056/diff/ Testing --- Icons get installed into the desired location. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

marked as submitted. Review request for KDE Frameworks and andreas kainz. Changes --- Submitted with commit a341a4a9fc8290cb9d453ec12f3bca79b09f92bd by Heiko Becker to branch master. Repository: oxygen-icons5 Description --- It was previously hard-coded to prefix/share which

Review Request 128139: Silence CMake policy CMP0063 warning

. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128139: Silence CMake policy CMP0063 warning

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit a4de98aa4f77c393116be91ec2fbc8945895f4ff by Heiko Becker to branch master. Repository: kimageformats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's

Review Request 128250: Silence CMake policy CMP0063 warning also for tests

/ Testing --- Warnings disappeared, still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128252: Silence CMake policy CMP0063 warning

, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128251: Silence CMake policy CMP0063 warning

, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127015: Move to tier2

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit baf894ba199623510ec9c894f947f001b863c5ce by Heiko Becker to branch master. Repository: kimageformats Description --- 6934d5441778a09d157836a590236e3dc8d5a492 added an optional

Review Request 127015: Move to tier2

10d0df9d41bd759174d99f387673a5fa6df66321 Diff: https://git.reviewboard.kde.org/r/127015/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127334: Fix build with -DBUILD_TEST=TRUE

. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE

marked as submitted. Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin. Changes --- Submitted with commit 1b4b6b721d4f853f0ef93808ccf6648f3a7b3b9f by Heiko Becker to branch master. Repository: polkit-qt-1 Description --- Otherwise it fails with "test/test.c

Re: Review Request 127597: Fix generation of path to xcb plugin

... be better suited to solve the relative/absolute PLUGINDIR issue? - Heiko Becker On April 7, 2016, 7:55 vorm., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 127597: Fix generation of path to xcb plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94420 --- Ship it! Ship It! - Heiko Becker On April 8, 2016, 6

Re: Review Request 128251: Silence CMake policy CMP0063 warning

marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 93fd546cb9f6455bc47bdc11df12dbab67284c0f by Heiko Becker to branch master. Repository: kactivities Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's

Re: Review Request 128252: Silence CMake policy CMP0063 warning

marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 62ce194fe00ce0a7c04027db78a91a6dab72a11c by Heiko Becker to branch master. Repository: kactivities-stats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended

Re: Review Request 128250: Silence CMake policy CMP0063 warning also for tests

marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 1c1b2130235f0019d31f490bb95549a91d3ef342 by Heiko Becker to branch master. Repository: kpeople Description --- Despite NO_POLICY_SCOPE being added to the inclusion

Review Request 128357: Fix warning from uic

.kde.org/r/128357/diff/ Testing --- Warning disappears, builds fine. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128357: Fix warning from uic

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 7099aab54289b2a8be742b110e58759f9bad9a0c by Heiko Becker to branch master. Repository: knewstuff Description --- Gets rid of the following warning: "src/downloadwidg

Re: Review Request 128739: Fix build with Qt < 5.6

> On Aug. 23, 2016, 1:27 nachm., Heiko Becker wrote: > > ?[12:11] ?? commit it if someone can test with the appropriate > > Qt versions > > ... > > ?[12:13] ?? hmm, I have the right Qt versions. I can download the > > pat- > > ... > > ?[12:31] ?? he

Review Request 128985: Drop obsolete version checks

f6de1c1f22c723ab7556a9fb880dd70c745b3454 src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 Diff: https://git.reviewboard.kde.org/r/128985/diff/ Testing --- Thanks, Heiko Becker

Review Request 128982: Drop obsolete version check

Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 Diff: https://git.reviewboard.kde.org/r/128982/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 128980: Use QTEST_GUILESS_MAIN

marked as submitted. Review request for KDE Frameworks and Volker Krause. Changes --- Submitted with commit 0fea247d1afdeccb2fbba9ce4375f108953701f4 by Heiko Becker to branch master. Repository: syntax-highlighting Description --- Allowing the tests to pass without a running X

Review Request 128984: Drop obsolete version check

--- Frameworks already require Qt 5.5.0. Diffs - src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 Diff: https://git.reviewboard.kde.org/r/128984/diff/ Testing --- Thanks, Heiko Becker

Review Request 128981: Drop obsolete version check

Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 Diff: https://git.reviewboard.kde.org/r/128981/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 128982: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit f9ed1d9c9f090457223c88df8729161bc811f0a2 by Heiko Becker to branch master. Repository: karchive Description --- Frameworks already require Qt 5.5.0. Diffs - autotests

Re: Review Request 128981: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Rosca. Changes --- Submitted with commit 40dc1493ab859223a093a9b9f6f5c84795376066 by Heiko Becker to branch master. Repository: bluez-qt Description --- Frameworks already require Qt 5.5.0. Diffs - src

Review Request 128983: Drop obsolete version check

: kcoreaddons Description --- Frameworks already require Qt 5.5.0. Diffs - src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 Diff: https://git.reviewboard.kde.org/r/128983/diff/ Testing --- Thanks, Heiko Becker

Review Request 128980: Use QTEST_GUILESS_MAIN

autotests/testhighlighter.cpp e903e97 autotests/theme_test.cpp f602e11 autotests/wildcardmatcher_test.cpp 3cf61bc Diff: https://git.reviewboard.kde.org/r/128980/diff/ Testing --- Tests build and run fine. Thanks, Heiko Becker

Review Request 128993: Drop obsolete version checks

, Heiko Becker

Review Request 128995: Drop obsolete version check

Description --- Frameworks already require Qt 5.5.0. Diffs - src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 Diff: https://git.reviewboard.kde.org/r/128995/diff/ Testing --- Thanks, Heiko Becker

Review Request 128992: Drop obsolete version check

/kquickcontrolsaddons/plotter.cpp ffcb4ee4b43f5d99f419ef0e1680064f57cb1002 Diff: https://git.reviewboard.kde.org/r/128992/diff/ Testing --- Thanks, Heiko Becker

Review Request 128994: Drop obsolete version check

: kglobalaccel Description --- Frameworks already require Qt 5.5.0. Diffs - src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c Diff: https://git.reviewboard.kde.org/r/128994/diff/ Testing --- Thanks, Heiko Becker

Review Request 128986: Drop obsolete version checks

/128986/diff/ Testing --- Thanks, Heiko Becker

Review Request 128988: Drop obsolete version check

Description --- Frameworks already require Qt 5.5.0. Diffs - src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128988/diff/ Testing --- Thanks, Heiko Becker

Review Request 128987: Drop obsolete version checks

://git.reviewboard.kde.org/r/128987/diff/ Testing --- Thanks, Heiko Becker

Review Request 128991: Drop obsolete version check

: kactivities Description --- Frameworks already require Qt 5.5.0. Diffs - src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 Diff: https://git.reviewboard.kde.org/r/128991/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 128988: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128988: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128984: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8c58398b4cafe22ce1cf28fdaf9fb62948425d36 by Heiko Becker to branch master. Repository: kidletime Description --- Frameworks already require Qt 5.5.0. Diffs - src/logging.cpp

Re: Review Request 128994: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Changes --- Submitted with commit f2f0b2722e2cf53d982c5ebb52425e84278140e1 by Heiko Becker to branch master. Repository: kglobalaccel Description --- Frameworks already require Qt 5.5.0. Diffs

Re: Review Request 128985: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ed9e2553a92844567f76e7ce468a5d3128e9fb51 by Heiko Becker to branch master. Repository: kitemmodels Description --- Frameworks already require Qt 5.5.0. Diffs - autotests

Re: Review Request 128989: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 5fdcdff6e387b5f6285a6eb5ad0c7f7a99b8bd1a by Heiko Becker to branch master. Repository: kimageformats Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128991: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 40077d52b554d5903aa53fffaba46912aa55918a by Heiko Becker to branch master. Repository: kactivities Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128990: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 36142ace3236517180a3ccbcb3e692beebe53498 by Heiko Becker to branch master. Repository: kjobwidgets Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp

Re: Review Request 128987: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 61c63d6b8e08c60f3336604f45a647691c32cf91 by Heiko Becker to branch master. Repository: kauth Description --- Frameworks already require Qt 5.5.0. Diffs - src/backends/dbus

Re: Review Request 128983: Drop obsolete version check

/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 128986: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit c55f73557ca7ab09caaa593d951297cc551c6d72 by Heiko Becker to branch master. Repository: sonnet Description --- Frameworks already require Qt 5.5.0

Re: Review Request 128993: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 1536ab6c8996d5f21d7a59089bf99de675faee18 by Heiko Becker to branch master. Repository: kdesignerplugin Description --- Frameworks already require Qt 5.5.0. Diffs

Re: Review Request 128988: Drop obsolete version check

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/#review99438 --- On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote: > > --- > This is an

Review Request 128739: Fix build with Qt < 5.6

- src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 Diff: https://git.reviewboard.kde.org/r/128739/diff/ Testing --- Haven't an old Qt around, tested building with 5.7. though. Thanks, Heiko Becker

Re: Review Request 128739: Fix build with Qt < 5.6

marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit b241c854c42931280ee5366439af40144f1268af by Heiko Becker to branch master. Repository: sonnet Description --- Also correct the other #ifdef because like

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

marked as submitted. Review request for KDE Frameworks, David Edmundson and Michael Pyne. Changes --- Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker to branch master. Repository: kcoreaddons Description --- 70c745d6147e465ce1e34b6037eb7dedb8e77f27

Review Request 129351: Only search for a avatar if loginName isn't empty

Testing --- kusertest doesn't fail anymore. Thanks, Heiko Becker

Re: Review Request 128992: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit c75362b095fb249e8bc60743c7a3ac2ec6e9ee16 by Heiko Becker to branch master. Repository: kdeclarative Description --- Frameworks already require Qt 5.5.0. Diffs - src

Review Request 129559: Also search for hunspell-1.5

. Repository: sonnet Description --- Also search for hunspell-1.5 Diffs - cmake/FindHUNSPELL.cmake f028abe Diff: https://git.reviewboard.kde.org/r/129559/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 129559: Also search for hunspell-1.5

marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 5fc1e9679e0607d7d918b27ee13092a234abefe6 by Heiko Becker to branch master. Repository: sonnet Description --- Also search for hunspell-1.5 Diffs

Re: Review Request 128992: Drop obsolete version check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128992/#review101113 --- Ping? - Heiko Becker On Sept. 21, 2016, 7:36 nachm

Re: Review Request 129559: Also search for hunspell-1.5

the tests. Thanks, Heiko Becker

Re: Review Request 129417: Add metainfo.yaml

marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 1b72429bdd256711b1f430367408abe9ddee8186 by Heiko Becker to branch master. Repository: prison Description --- Striking one requirement for becoming a framework from the list

Re: Review Request 129418: Adjust directory structure to Frameworks policies

marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 96d2e4e7dfe3d13b85ee37df0961d33566e8659a by Heiko Becker to branch master. Repository: prison Description --- According to the requirements listed on https://community.kde.org

Review Request 129417: Add metainfo.yaml

Description --- Striking one requirement for becoming a framework from the list. Diffs - metainfo.yaml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129417/diff/ Testing --- Thanks, Heiko Becker

Review Request 129418: Adjust directory structure to Frameworks policies

a722367 tools/CMakeLists.txt tools/prison-datamatrix.cpp 6491b76 Diff: https://git.reviewboard.kde.org/r/129418/diff/ Testing --- cmake .. && make Thanks, Heiko Becker

[Differential] [Closed] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

This revision was automatically updated to reflect the committed changes. Closed by commit R263:78ff1ebd4a18: kbugreport: Remove reference to deprecated KCmdLineArgs (authored by heikobecker). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4052?vs=9936=9945

Re: Shipping prison with next frameworks version

Hi, sorry for writing this mail shortly before the tagging of the next Frameworks release, but I got sidetracked by other things. On 09/30/16 09:42, David Faure wrote: > On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote: >> Other than asking sysadmin to move prison from kdesupport

[Differential] [Request, 4 lines] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D4052 AFFECTED FILES src/kbugreport.h EMAIL PREFERENCES

D5291: FindPyModGen: Also search for an unversioned clang++

This revision was automatically updated to reflect the committed changes. Closed by commit R240:47a4c068a4ec: FindPyModGen: Also search for an unversioned clang++ (authored by heikobecker). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5274: extractorcollectiontest: Use QTEST_GUILESS_MAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6d7468be4cc6: autotests: Use QTEST_GUILESS_MAIN (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5274?vs=13044=13099#toc REPOSITORY R286 KFileMetaData CHANGES

  1   2   >