D6116: Add new stateChanged() signal to active connection

2017-06-16 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D6116#116560, @davidedmundson wrote: > > can you find a new signal name and emit both for compatibility? What would you suggest? I can think of stateChangedWithReason() or stateChangedWithKnownReason() or

D6115: Update introspections (NM 1.8.0)

2017-06-06 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:ffb40b433368: Update introspections (NM 1.8.0) (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6115?vs=15209=15211#toc REPOSITORY R282 NetworkManagerQt CHANGES SINCE

D6116: Add new stateChanged() signal to active connection

2017-06-06 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY There is a new additional StateChanged() signal coming from NetworkManager with additional reason property so with that we can now check

D6116: Add new stateChanged() signal to active connection

2017-06-06 Thread Jan Grulich
jgrulich added a reviewer: lvsouza. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6116 To: jgrulich, lvsouza Cc: #frameworks

D6115: Update introspections (NM 1.8.0)

2017-06-06 Thread Jan Grulich
jgrulich abandoned this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6115 To: jgrulich Cc: #frameworks

D6115: Update introspections (NM 1.8.0)

2017-06-06 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add new stateChanged() signal to active connection There is a new additional StateChanged() signal coming from NetworkManager with

D5970: Fix KSNIs being unable to register service under flatpak

2017-05-26 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D5970 To: davidedmundson, #frameworks, jgrulich Cc: jgrulich

D5970: Fix KSNIs being unable to register service under flatpak

2017-05-26 Thread Jan Grulich
jgrulich added a comment. +1 I tested this change with flatpak and it works as it should. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5970 To: davidedmundson, #frameworks Cc: jgrulich

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D5911#110687, @davidedmundson wrote: > I explained badly, let me try again with code. > https://paste.kde.org/pvzge2wq8 > > It will work in flatpak, and the SNI test we have in p-w still works fine. That indeed seems

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

2017-05-18 Thread Jan Grulich
jgrulich abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5911 To: jgrulich, apol Cc: davidedmundson, #frameworks

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D5911#110683, @davidedmundson wrote: > This is a big solution for a problem that I don't think exists. There are actually two problems: 1. You need to guarantee that the SNI dbus service name will be unique, you cannot

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a reviewer: apol. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5911 To: jgrulich, apol Cc: #frameworks

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

2017-05-18 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In my previous change I made sure that the dbus service name for SNI is predictable so we can allow it in advance, but it introduced

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D5775#110551, @apol wrote: > In https://phabricator.kde.org/D5775#110530, @jgrulich wrote: > > > In https://phabricator.kde.org/D5775#110529, @jgrulich wrote: > > > > > +1 > > > > > > good idea, it should solve all the

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D5775#110529, @jgrulich wrote: > +1 > > good idea, it should solve all the problems, we should use similar approach in KNotifications for SNI support. Actually this won't work for KNotifications and SNI, still problem

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-18 Thread Jan Grulich
jgrulich added a comment. +1 good idea, it should solve all the problems, we should use similar approach in KNotifications for SNI support. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich Cc: dfaure, davidedmundson,

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-16 Thread Jan Grulich
jgrulich added a comment. I think this still doesn't solve the general problem we have with sandboxed applications as you cannot still allow this dbus service in app manifest. You can use "org.kde.AppName.*" , but then the dbus name would need to be in form of "org.kde.AppName.appPid" or

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-11 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D5775#108825, @apol wrote: > In https://phabricator.kde.org/D5775#108649, @jgrulich wrote: > > > In https://phabricator.kde.org/D5775#108558, @aacid wrote: > > > > > I don't think this is a fix. > > > > > > I can't

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-10 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R289:0d2f45ed3033: Use application name instead of pid when creating SNI dbus service (authored by jgrulich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-10 Thread Jan Grulich
jgrulich added a comment. Using applicationName-pid you cannot guarantee the pid will be always 1 or 2, you can have e.g a special launcher for an app doing some stuff and then you end up with much higher pid. REPOSITORY R289 KNotifications BRANCH application-dbus (branched from

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-10 Thread Jan Grulich
jgrulich updated this revision to Diff 14361. jgrulich added a comment. Remove my useless debug REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5783?vs=14360=14361 BRANCH application-dbus (branched from master) REVISION DETAIL

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-10 Thread Jan Grulich
jgrulich updated this revision to Diff 14360. jgrulich added a comment. Use applicationName() instead of applicationPid() only for sandboxed applications This still doesn't make the service name unique, but at least there won't be collision between instances running outside the

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-09 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is required when using SNI in sandbox (e.g. in flatpak) where the pid starts from 1, usually it is 2 (the first one is bwrap) and

D5783: Use application name instead of pid when creating SNI dbus service

2017-05-09 Thread Jan Grulich
jgrulich added a reviewer: apol. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5783 To: jgrulich, apol Cc: #frameworks

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-08 Thread Jan Grulich
jgrulich added a comment. Looks good, it really doesn't make sense to use pid when running app in flatpak, because you cannot guarantee what pid it will get and without that you cannot allow dbus access in app's flatpak manifest. REPOSITORY R271 KDBusAddons REVISION DETAIL

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
On pondělí 3. dubna 2017 15:04:54 CEST Hartmut Goebel wrote: > Am 03.04.2017 um 14:16 schrieb Jan Grulich: > > Pushed two fixes into master branch, hopefully they fix all issues with > > the > > failing unit test. > > Applying both patches make the tests pass. Thanks

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Pushed two fixes into master branch, hopefully they fix all issues with the failing unit test. Jan On pondělí 3. dubna 2017 13:28:06 CEST David Faure wrote: > On lundi 3 avril 2017 12:57:11 CEST Jan Grulich wrote: > > Hi, > > > > could you please try attached patch? For m

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Hi, could you please try attached patch? For me it was working even without the patch, but I think I spotted a potential problem and this hopefully will fix it. Regards, Jan On sobota 1. dubna 2017 21:54:04 CEST David Faure wrote: > On mardi 28 mars 2017 08:10:15 CEST Jan Grulich wr

Re: Test failures with networkmanager-qt

2017-03-28 Thread Jan Grulich
Hi, I didn't say you shouldn't investigate the cause. Could you please run the test with "-v2 -vs" parameters? Jan On úterý 28. března 2017 11:43:06 CEST Hartmut Goebel wrote: > Am 28.03.2017 um 08:10 schrieb Jan Grulich: > > I can't think of any reason why the test fai

Re: Test failures with networkmanager-qt

2017-03-28 Thread Jan Grulich
Hi, I can't think of any reason why the test fails for you. Looking to the git log the only relevant change is fixed uninitialized state variable in ActiveConnection, which may affect ActiveConnection::stateChanged() signal. Regards, Jan On pondělí 27. března 2017 18:02:05 CEST Hartmut

Re: Review Request 123534: Add public dependency on ModemManager

2017-02-25 Thread Jan Grulich
KF5ModemManagerQtConfig.cmake.in d60610a autotests/CMakeLists.txt 03e1939 cmake/FindModemManager.cmake d522e93 src/CMakeLists.txt 29a7a63 src/fakemodem/CMakeLists.txt b6d4a90 Diff: https://git.reviewboard.kde.org/r/123534/diff/ Testing --- Thanks, Jan Grulich

[Differential] [Accepted] D4646: Manager: Fix emitting deviceAdded twice when NM restarts

2017-02-17 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good. Thanks. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D4646 EMAIL PREFERENCES

[Differential] [Closed] D4425: Add support for flatpak portals

2017-02-08 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R289:64451eb248e2: Add support for flatpak portals (authored by jgrulich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=11052=11053 REVISION DETAIL

[Differential] [Updated] D4425: Add support for flatpak portals

2017-02-08 Thread Jan Grulich
jgrulich marked an inline comment as done. jgrulich added a comment. Patch updated to address all mentioned issues. Re-check it please. Thank you. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES

[Differential] [Updated, 390 lines] D4425: Add support for flatpak portals

2017-02-08 Thread Jan Grulich
jgrulich updated this revision to Diff 11052. jgrulich added a comment. Fix mentioned issues REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=10951=11052 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4425 AFFECTED FILES

[Differential] [Commented On] D4425: Add support for flatpak portals

2017-02-06 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > apol wrote in knotificationmanager.cpp:93 > Maybe instead of querying for dbus things we could figure out a what > QPlatformTheme is in use somehow? Not sure how that would help. It would help maybe to detect whether we are in sandbox if we

[Differential] [Updated, 392 lines] D4425: Add support for flatpak portals

2017-02-05 Thread Jan Grulich
jgrulich updated this revision to Diff 10951. jgrulich marked 11 inline comments as done. jgrulich added a comment. - Fix mentioned issues REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=10890=10951 BRANCH master REVISION DETAIL

[Differential] [Updated] D4425: Add support for flatpak portals

2017-02-03 Thread Jan Grulich
jgrulich added a reviewer: mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jgrulich, mck182 Cc: #frameworks

[Differential] [Request, 393 lines] D4425: Add support for flatpak portals

2017-02-03 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Creates a new flatpak notification plugin, which just forwards messages through DBus to xdg-desktop-portal service, otherwise there is

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-12-12 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 1e6412cebf140cdc7a165fd49ce64c859e572f71 by Jan Grulich to branch master. Repository: kio Description --- When running an app using KRun, check whether X-KDE-RunOnDiscreteGpu

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-12-12 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 303aa887d870972fa2c4dfffa104f92070949083 by Jan Grulich to branch master. Repository: kio Description --- This patch adds option to run certain application on a discrete

Re: Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-12-12 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 610bcdfd266518638df93147f26eb9c19a47fb33 by Jan Grulich to branch master. Repository: kinit Description --- When running an app using klauncher, check whether X-KDE

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-12-12 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 19ecb443b39833ac0c6ecc64eb3c03fdab94ec15 by Jan Grulich to branch master. Repository: kservice Description --- $SUMMARY says it all I guess, this patch allows to read X-KDE

Re: Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-11-29 Thread Jan Grulich
y. Diffs (updated) - src/klauncher/klauncher.cpp f1727df Diff: https://git.reviewboard.kde.org/r/129580/diff/ Testing --- Thanks, Jan Grulich

Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-11-29 Thread Jan Grulich
/ Testing --- Thanks, Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-29 Thread Jan Grulich
/129396/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-29 Thread Jan Grulich
://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png Thanks, Jan Grulich

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-29 Thread Jan Grulich
://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png Thanks, Jan Grulich

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-29 Thread Jan Grulich
(updated) - src/widgets/krun.cpp d93b1f2 Diff: https://git.reviewboard.kde.org/r/129399/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-27 Thread Jan Grulich
over time, there could be a static enum here (not > > check yet, present, absent) to avoid making a dbus blocking call every time. > > Jan Grulich wrote: > I'm not sure how to do that as static variables cannot be mutable thus I > need to initialize it immedia

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-27 Thread Jan Grulich
over time, there could be a static enum here (not > > check yet, present, absent) to avoid making a dbus blocking call every time. > > Jan Grulich wrote: > I'm not sure how to do that as static variables cannot be mutable thus I > need to initialize it immedia

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-27 Thread Jan Grulich
e else where even KRun could read it? - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/#review101129 ----------- On

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-22 Thread Jan Grulich
ffs (updated) - src/widgets/krun.cpp d93b1f2 Diff: https://git.reviewboard.kde.org/r/129399/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-22 Thread Jan Grulich
iff: https://git.reviewboard.kde.org/r/129396/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

2016-11-22 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks, David Edmundson and David Faure. Changes --- Submitted with commit 9d6e0065e9b787f8cb76cd06f613d3bd67486cb2 by Jan Grulich to branch master. Repository: kinit Description --- One more patch in the series adding support

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-22 Thread Jan Grulich
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png Thanks, Jan Grulich

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-22 Thread Jan Grulich
://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png Thanks, Jan Grulich

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-20 Thread Jan Grulich
, Jan Grulich

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

2016-11-15 Thread Jan Grulich
need to set required env variables which needs to be set to actually run the app on the discrete gpu. Diffs (updated) - src/klauncher/klauncher.cpp 828038b Diff: https://git.reviewboard.kde.org/r/129397/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-15 Thread Jan Grulich
> freedesktop standard? > > Did you talk to hadess about it, before we make it a de-facto standard > > with a weird name? > > > > > > And then why not standardize the name of the key in the .desktop file > > while at it? > > >

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-15 Thread Jan Grulich
name for backward compatibility, meanwhile I guess we have to keep this name. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review100845 ---------

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich
src/services/kservice.h 66525b4 src/services/kservice.cpp 6574367 Diff: https://git.reviewboard.kde.org/r/129396/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

2016-11-14 Thread Jan Grulich
need to set required env variables which needs to be set to actually run the app on the discrete gpu. Diffs (updated) - src/klauncher/klauncher.cpp 828038b Diff: https://git.reviewboard.kde.org/r/129397/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich
/kservice.cpp 6574367 Diff: https://git.reviewboard.kde.org/r/129396/diff/ Testing --- Thanks, Jan Grulich

Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-14 Thread Jan Grulich
--- Thanks, Jan Grulich

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-14 Thread Jan Grulich
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png Thanks, Jan Grulich

Review Request 129397: Set environment variables from KLaunchRequest when starting new process

2016-11-14 Thread Jan Grulich
- src/klauncher/klauncher.cpp 828038b Diff: https://git.reviewboard.kde.org/r/129397/diff/ Testing --- Thanks, Jan Grulich

Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich
into account and set required variable accordingly. Diffs - src/kdeinit/ktoolinvocation.cpp c9eb922 src/services/kservice.h 66525b4 src/services/kservice.cpp 6574367 Diff: https://git.reviewboard.kde.org/r/129396/diff/ Testing --- Thanks, Jan Grulich

Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-14 Thread Jan Grulich
/kpropertiesdialog.cpp 18c8479 src/widgets/krun.cpp d93b1f2 Diff: https://git.reviewboard.kde.org/r/129395/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129303: Fix include dir in pri file

2016-11-01 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129303/#review100460 --- Ship it! Ship It! - Jan Grulich On Lis. 1, 2016, 8:21

Re: Review Request 129302: Fix include dir in pri file

2016-11-01 Thread Jan Grulich
, they are used in many places. - Jan Grulich On Lis. 1, 2016, 8:24 dop., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123533: Add public dependency on NetworkManager

2016-10-20 Thread Jan Grulich
. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123533/#review100170 --- On Dub. 27, 2015, 2:42 odp., Jan Grul

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-30 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and Lamarque Souza. Changes --- Submitted with commit 00acf17a2071d86e218d3d49a0e53157eaa265dd by Jan Grulich to branch master. Repository: networkmanager-qt Description --- Uses

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich
t; &, const QVariant &) Unhandled property "S390Subchannels" > > ``` You can ignore that, that was there even before. For "AllDevices" and "Devices" properties we ignore them intentionally, because there is also "DeviceAdded" and "

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich
device.cpp fdfa297 src/vpnconnection.cpp 5dee6fc src/vpnconnection_p.h a8195ad src/wimaxdevice.cpp 6118f2f src/wireddevice.cpp 66bb649 src/wirelessdevice.cpp 3f2972b Diff: https://git.reviewboard.kde.org/r/129042/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Jan Grulich
297 src/vpnconnection.cpp 5dee6fc src/vpnconnection_p.h a8195ad src/wimaxdevice.cpp 6118f2f src/wireddevice.cpp 66bb649 src/wirelessdevice.cpp 3f2972b Diff: https://git.reviewboard.kde.org/r/129042/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Jan Grulich
device.cpp 6118f2f src/wireddevice.cpp 66bb649 src/wirelessdevice.cpp 3f2972b Diff: https://git.reviewboard.kde.org/r/129042/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks, Network Management and Lamarque Souza. Changes --- Submitted with commit 7671424efb02e7194a18a4913da16bc2044a4cb9 by Jan Grulich to branch master. Repository: networkmanager-qt Description --- Since NM 1.2.x they switched

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
> On Zář. 6, 2016, 12:01 odp., Lamarque Souza wrote: > > > > Jan Grulich wrote: > Every DeviceType inherits from Device, same as DeviceTypePrivate inherits > from DevicePrivate so when DeviceType is connected to PropertiesChanged > signal and doesn't i

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
ed signal. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98930 --- On Zář. 6, 2016, 11:56 dop., Jan Grul

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
these changes locally. I was messing with them when trying to find out why my active connections don't get notified about changed state. - Jan Grulich On Zář. 6, 2016, 11:56 dop., Jan Grulich wrote: > > --- > This is an auto

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
/vpnconnection_p.h 25ba589 src/wimaxdevice.cpp daec0a6 src/wireddevice.cpp af147b1 src/wirelessdevice.cpp dad918d Diff: https://git.reviewboard.kde.org/r/128843/diff/ Testing --- Thanks, Jan Grulich

Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
src/vlandevice.cpp 415dec9 src/vpnconnection.cpp d2d17e4 src/vpnconnection_p.h 25ba589 src/wimaxdevice.cpp daec0a6 src/wireddevice.cpp af147b1 src/wirelessdevice.cpp dad918d Diff: https://git.reviewboard.kde.org/r/128843/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
marked as submitted. Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik Haumann. Changes --- Submitted with commit c7096f60bbe094ba92456fd39ff3102435d9c677 by Jan Grulich to branch master. Repository: ktexteditor Description --- When using Indic locales

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
1e0f src/document/katedocument.cpp 73778a1 src/view/kateview.h 08db0df src/view/kateview.cpp fda6b2d Diff: https://git.reviewboard.kde.org/r/127843/diff/ Testing --- Thanks, Jan Grulich ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
/katedocument_test.h 8abbad9 autotests/src/katedocument_test.cpp dd41e0f src/document/katedocument.cpp 73778a1 src/view/kateview.h 08db0df src/view/kateview.cpp fda6b2d Diff: https://git.reviewboard.kde.org/r/127843/diff/ Testing ---

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Jan Grulich
. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95764 --- On Kvě. 5, 2016, 10:53 dop., Jan Grul

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
inter is possibly a nullptr? > > > > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution > > would be to expose this class so that proper text navigation is available > > everywhere (e.g. KTextEditor::ViewCursor, just like > > KTextEditor::Docu

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
inter is possibly a nullptr? > > > > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution > > would be to expose this class so that proper text navigation is available > > everywhere (e.g. KTextEditor::ViewCursor, just like > > KTextEditor::Docu

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
inter is possibly a nullptr? > > > > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution > > would be to expose this class so that proper text navigation is available > > everywhere (e.g. KTextEditor::ViewCursor, just like > > KTextEditor::Docu

Re: Review Request 127843: Properly remove composed characters

2016-05-09 Thread Jan Grulich
utomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95257 --- On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote: > > -

Re: Review Request 127843: Properly remove composed characters

2016-05-05 Thread Jan Grulich
posted them here: https://paste.kde.org/piptzo584 - Jan Grulich On Kvě. 5, 2016, 10:05 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 127843: Properly remove composed characters

2016-05-05 Thread Jan Grulich
ctly by one composed character so I was trying to find a way to do it similarly. Diffs - src/document/katedocument.cpp 73778a1 src/view/kateview.h 08db0df src/view/kateview.cpp fda6b2d Diff: https://git.reviewboard.kde.org/r/127843/diff/ Testing ---

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Jan Grulich
> On Kvě. 3, 2016, 2:30 odp., Jan Grulich wrote: > > That doesn't make much sense to me, if you are getting that error then it > > means either LastSeen property was introduced in older NM version or it was > > backported in your distribution. I'll

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Jan Grulich
that error then it means either LastSeen property was introduced in older NM version or it was backported in your distribution. I'll check that and update that NM_CHECK_VERSION accordingly. - Jan Grulich On Kvě. 3, 2016, 2:04 odp., Allen Winter wrote

Re: Solid/PowerManagement deprecation

2016-02-10 Thread Jan Grulich
://quickgit.kde.org/?p=solid-power.git[1] Regards, Jan -- Jan Grulich <jgrul...@redhat.com> Software Engineer, Desktop team Red Hat Czech On Wednesday 10 of February 2016 15:55:51 Aleix Pol wrote: > Hi, > I've been looking in the last days what applications and uses make our >

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

2015-09-24 Thread Jan Grulich
qt5 branch into master and > replacing the qt5 tarball with a new release that supports both qt4 > and qt5? > + 1, we added qca as dependency for plasma-nm and to be able to build it you need the latest fix I pushed to qca thus new release of qca before Plasma 5.5.0 release is needed. Rega

Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

2015-09-17 Thread Jan Grulich
/QtCrypto/qca_safetimer.h 68dde5c Diff: https://git.reviewboard.kde.org/r/125289/diff/ Testing --- Thanks, Jan Grulich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

2015-09-17 Thread Jan Grulich
marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Changes --- Submitted with commit 66b9754170759d9333d5fc1e348642814d0310dd by Jan Grulich to branch master. Repository: qca Description --- This is used also in other header files from include folder. I'm

Re: set passwords only if changed

2015-09-04 Thread Jan Grulich
used at all. > Thank in advance for your help. > > Best Regards > Heiko I hope that helps. Regards, Jan -- Jan Grulich <jgrul...@redhat.com> Software Engineer, Desktop team Red Hat Czech ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

<    1   2   3   4   >