D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH mimetype_handling REVISION DETAIL https://phabricator.kde.org/D16237 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16154: fix Service(Type)Browser documentation

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH master REVISION DETAIL https://phabricator.kde.org/D16154 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

broulik accepted this revision. broulik added a comment. Funny, I just noticed the same thing yesterday and was just about to make a patch but then saw this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc:

D16141: Disable unmount option for / or /home

broulik added a comment. Why would you be unable to unmount `/home`? If you're logged in as root (not saying that one should or can), whose home is `/root` you can surely unmount `/home` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks,

D16108: When re-using runners when reloading, reload their configuration

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When configuration is changed, runners are reloaded but their

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating QTemporaryFile (authored by broulik). Herald added projects:

D16060: Reduce double and triple lookups to the frames hash

broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:967 > if we're calling deref without it being paired with ref then we have bigger > problems. :D fair enough REPOSITORY R242 Plasma Framework (Library) BRANCH master

D16060: Reduce double and triple lookups to the frames hash

broulik added inline comments. INLINE COMMENTS > framesvg.cpp:967 > { > -references[svg] = references[svg] - 1; > -//qCDebug(LOG_PLASMA) << this << svg << references[svg]; > -if (references[svg] < 1) { > -references.remove(svg); > +auto it = references.find(svg); > +

D13867: [KMessageWidget] Pass widget to standardIcon()

broulik planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13867 To: broulik, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13757: Move parsing .desktop file for folder Comment to file KIO

broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15741: Use correct MaximumSize

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1b334712ed0f: Use correct MaximumSize (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15741?vs=42291=43306 REVISION DETAIL

D15638: force-finish canberra notifications on close()

broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D15638 To: sitter, broulik, jtamate Cc: kde-frameworks-devel, jtamate, michaelh, ngraham, bruns

D16043: Clean up unused QDebug/baloodebug.h includes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16043 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D16044: [Timeline] Use categorized logging

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16044 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

This revision was automatically updated to reflect the committed changes. Closed by commit R320:44f2852fb299: [Thumbnails] Paint larger one thumbnail tile only when needed (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D15932: [UDisks2] Power down drive on remove if supported

broulik accepted this revision. broulik added a comment. Please wait till after Frameworks tagging (due tomorrow) so we can have more test exposure as Solid changes are usually quite delicate REPOSITORY R245 Solid BRANCH udisks2_power_down REVISION DETAIL

D15941: Fix invalid char constant

broulik added a comment. I think you updated the wrong diff here REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941 To: poboiko, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15941: Fix invalid char constant

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941 To: poboiko, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15934: Add battery and bluetooth icons for other DE compatibility

broulik added a comment. > It is actual part of the Breeze Plasma theme though: Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be fixed to use that one instead. Not sure I would like the padlock when my headphones

D15931: [Places panel] use more appropriate network icon

broulik added a comment. +1 Oxygen uses a globe for "network-workgroup" and a folder with a cable as "folder-network", someone might wanted to have a globe icon here for recognizability ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc:

D15932: [UDisks2] Power down drive on remove if supported

broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:186 > Device drive(drivePath); > +QDBusConnection c = > QDBusConnection::connectToBus(QDBusConnection::SystemBus, > "Solid::Udisks2::Drive::" + drivePath); > + Why this change?

D15934: Add battery and bluetooth icons for other DE compatibility

broulik added a comment. For Bluetooth we currently use: - disabled: grayed out/softened icon - active: black icon - paired: black icon with dots next to each other That "padlock" doesn't communicate "paired" to me and is inconsistent with Plasma's icon REPOSITORY R266 Breeze

D15935: Don't show a emblem for mounted disks, only unmounted disks

broulik added a comment. I think that's a sensible idea. Can you also evaluate the implications for Device Notifier? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH device_notifier_qml_fix2 REVISION DETAIL https://phabricator.kde.org/D15892 To: bruns, #frameworks, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot,

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

broulik added a comment. I think this makes sense INLINE COMMENTS > devicenotificationsengine.cpp:39 > { > -const QString source = QStringLiteral("notification %1").arg(m_id++); > +const QString source = QStringLiteral("%1 notification").arg(udi); > This potentially breaks

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15873 To: madcatx, elvisangelaccio, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef,

D15853: Change drive-harddisk to more adaptable style

broulik added a comment. In D15853#334609 , @mart wrote: > What's that white blob on top of the hard disk? it looks really weird Hard drives typically have this swivel elevated section that this tries to simulate. For a lack of a

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15871 To: madcatx, elvisangelaccio, sitter Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

broulik added a comment. Did you test this with other icon sets, such as Oxygen? It may work with SVG ones but not pixel-based iconsets. Oxygen only has 8x8 emblems. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg

D15818: [Exe Thumbnailer] Ignore depth > 32

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5943efcfed8d: [Exe Thumbnailer] Ignore depth 32 (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15818?vs=42492=42638 REVISION DETAIL

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f7be890d3acd: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

broulik edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15819 To: broulik, ngraham, anthonyfieroni Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

broulik created this revision. broulik added reviewers: ngraham, anthonyfieroni. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ico files mostly contain PNGs these days which

D15818: [Exe Thumbnailer] Ignore depth > 32

broulik created this revision. broulik added a reviewer: anthonyfieroni. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The depth information is read unaltered from the `ico` file

D15814: show all borders for pop up windows in a dock

broulik added a comment. The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on all side for regular panel popups REPOSITORY R242 Plasma Framework (Library) REVISION

D15805: [Fstab] Remove Tru64 (__osf__) support

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL https://phabricator.kde.org/D15805 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15806: [Fstab] Remove AIX support

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL https://phabricator.kde.org/D15806 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Oh, I thought `kdebugsettings` was somehow magical. REPOSITORY R245 Solid BRANCH fstab_support_non_networkshares REVISION DETAIL https://phabricator.kde.org/D15800 To: bruns,

D15799: [Fstab] Add support for categorized logging

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15799 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, ship it REPOSITORY R245 Solid BRANCH ensure_nonempty_nfs_exportname REVISION DETAIL https://phabricator.kde.org/D15798 To: bruns, #frameworks, broulik Cc:

D15798: [Fstab] Show non-empty share name in case root fs is exported

broulik added inline comments. INLINE COMMENTS > fstabdevice.cpp:45 > m_product = m_device.mid(m_device.indexOf(":/") + 2); > +if (m_product.isEmpty()) { > +m_product = QStringLiteral("/"); This should probably be moved outside this if, you get the same bug when you

D15705: Also raise configuration window when reusing it

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ea6cf10f4250: Also raise configuration window when reusing it (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D15763: Set correct image attributes on directory thumbnail

broulik created this revision. broulik added reviewers: Frameworks, dfaure, anthonyfieroni, jtamate. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise `PreviewJob` will

D15745: Implement Media and MediaEndpoint API

broulik added inline comments. INLINE COMMENTS > media_p.h:35 > + > +class MediaPrivate : public QObject > +{ I think this needs `Q_DECL_HIDDEN` > media_p.h:37 > +{ > +Q_OBJECT > + Any particular reason this class must inherit `QObject`, you don't seem to be using `signal` or `slot` in

D15745: Implement Media and MediaEndpoint API

broulik added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15740: Use non deprecated fastInsert in baloo

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15740 To: jtamate, dfaure, #frameworks, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15741: Use correct MaximumSize

broulik created this revision. broulik added reviewers: Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The maximum size for local thumbnails was raised form 5

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

broulik added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15402 To: broulik, #dolphin, ngraham Cc: kde-frameworks-devel, kfm-devel,

D15739: [Places panel] Don't show Root by default

broulik added a comment. +1 it's an entry I always hide when I setup someone's computer REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15687 To: bruns, #frameworks, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15705: Also raise configuration window when reusing it

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It seems `requestActivate` only implies unminimizing but not raising if already

D15645: [WIP] Add scheme selection menu with a "System" entry.

broulik added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:203 > +QAction *const resetAction = new > QAction(index.data(Qt::DecorationRole).value(), > + QStringLiteral("System > (%1)").arg(systemScheme), > +

D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

broulik added a comment. I also would prefer to do the `fastInsert` change separately as to not clutter the diff REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15635 To: jtamate, dfaure, #baloo, #frameworks Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh,

D15635: Use String to store UDS_USER and UDS_GROUP de tipo String

broulik added a comment. Fine in general, `file` KIO caches the username and groupname to avoud `KUser` having to query it every time. It also uses the `uid` as string if `loginName` is empty (if that can ever happen..?) REPOSITORY R293 Baloo REVISION DETAIL

D15623: Finish the notification before removing it from the hash

broulik added a reviewer: sitter. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D15623 To: jtamate, #frameworks, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15611: [KCollapsibleGroupBox] Respect styles that disable widget animations

broulik added a comment. `SH_Widget_Animate` is deprecated in favor of `SH_Widget_Animation_Duration` introduced in Qt 5.10, so perhaps this needs an `ifdef` REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks Cc: broulik, ngraham,

D15364: Plasma style: Remove hardcoded textFormat

broulik added a comment. I thought we did that consciously and intentionally since we could break compat here and the `AutoText` which tries to guess from the contents and even allows injecting `img` was something we wanted to avoid? REPOSITORY R242 Plasma Framework (Library) REVISION

D15591: Add Open Document thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6828ff113ac3: Add Open Document thumbnailer (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41926=41934 REVISION DETAIL

D15591: Add Open Document thumbnailer

broulik added a reviewer: wbauer. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer

D15591: Add Open Document thumbnailer

broulik updated this revision to Diff 41926. broulik added a reviewer: fvogt. broulik added a comment. - Add missing desktop file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41905=41926 REVISION DETAIL https://phabricator.kde.org/D15591

D15591: Add Open Document thumbnailer

broulik planned changes to this revision. broulik added a comment. > ...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called that ;) I wanted to say `Ko` classes as that's what they're prefixed with but I didn't

D15591: Add Open Document thumbnailer

broulik added a comment. > Does this thumbnailer ask for password for password protected files, No. I don't know how a password-protected document work but if it's encrypted like a ZIP file the file will just fail to open and generate, like you cannot open an encrypted file in `zip:/`

D15591: Add Open Document thumbnailer

broulik created this revision. broulik added reviewers: Frameworks, VDG. broulik requested review of this revision. REVISION SUMMARY Provides thumbnails for ODT, ODS, ODP, ODG, ODF files as well as their template counterparts TEST PLAN Some code I had written a while ago, not knowing there

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

broulik added inline comments. INLINE COMMENTS > wbauer wrote in previewjob.cpp:641 > That line is commented out. Is this intentional? > I don't see how this will change anything... ;-/ Aw, crap, that's what happens when you have unstaged changes, I was testing stuff and acceidentally pushed

D12520: [PasteJob] Emit KDirNotify on paste

This revision was automatically updated to reflect the committed changes. Closed by commit R241:681501c276ee: [PasteJob] Emit KDirNotify on paste (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12520?vs=33081=41885 REVISION DETAIL

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b582cd477f65: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15096?vs=40495=41883#toc REPOSITORY

D15557: Improve "insufficient disk space" error messgae

broulik added a comment. +1 REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: broulik, abetts, kde-frameworks-devel, michaelh,

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D15576 To: sitter, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

broulik added inline comments. INLINE COMMENTS > copyjob.cpp:887 > qCDebug(KIO_COPYJOB_DEBUG)<<"Stating finished. To > copy:"< -//TODO warn user beforehand if space is not enough > +if (m_totalSize > m_freeSpace) { > +q->setError(ERR_DISK_FULL); Please

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik created this revision. broulik added reviewers: Frameworks, dfaure, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Lets the view load the correctly scaled icon on demand. TEST PLAN

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D15407: Fix OCS provider URL in about dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R263:229ae4f1add4: Fix OCS provider URL in about dialog (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15407?vs=41349=41463 REVISION DETAIL

Re: Quality of Frameworks announcements

Hi, if you have any commits where the heading is a very technical description, consider using the CHANGELOG: tag, for instance Look up foo directly instead of doing bar When doing foo we needlessly ended up doing bar which comes with a huge overhead. CHANGELOG: Significantly sped up doing

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

broulik created this revision. broulik added reviewers: Frameworks, TheAssassin, anthonyfieroni. broulik requested review of this revision. REVISION SUMMARY Instead use new API that returns a buffer to avoid writing to the file system TEST PLAN Built libappimage with

D15407: Fix OCS provider URL in about dialog

broulik created this revision. broulik added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Fixes loading provider information TEST PLAN The URL stored at

D15177: Emit signals when a package is installed/uninstalled

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D15177 To: davidedmundson, #plasma, broulik Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

D15177: Emit signals when a package is installed/uninstalled

broulik added inline comments. INLINE COMMENTS > packagejob.cpp:90 > +if (ok) { > +const QString pluginId = d->package->metadata().pluginId(); > +const QStringList serviceTypes = > d->package->metadata().serviceTypes(); Can this be invalid or does `install`

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

broulik abandoned this revision. broulik added a comment. Was an idea :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15242 To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15330: [autotests] Compare booleans to booleans

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-build REVISION DETAIL https://phabricator.kde.org/D15330 To: zzag, #kwin, romangg, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Note that Plasma 5.14 depends on 5.50 which is already released, so any change that requires this property can only go in once 5.14 was branched off REPOSITORY R242 Plasma Framework

D15328: kfilewidget: convert connect syntax

broulik added inline comments. INLINE COMMENTS > kfilewidget.cpp:440 > +connect(d->ops, ::urlEntered, this, > +[&](const QUrl ){d->_k_urlEntered(url);}); > +connect(d->ops, ::fileHighlighted, this, Shouldn't this be using the `url` from the signal? Also, please prefer

D15283: Move SMB KCM to Network Settings category

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:ace6f726eaf5: Move SMB KCM to Network Settings category (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE

D15318: Automatically re-upload saved files located on samba shares instead of asking first

broulik added a comment. I would like to have some sanity checks there, like if the file is empty, or its mime type changed, it should ask. Also what if the file changes, is uploaded, and then changes again midflight? I'm a person that mashes Ctrl+S usually. REPOSITORY R241 KIO REVISION

D15309: [Calendar] Wrap day name index around

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:020d3e3ebea5: [Calendar] Wrap day name index around (authored by broulik). REPOSITORY R242 Plasma Framework

D15309: [Calendar] Wrap day name index around

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

broulik added a reviewer: Zren. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise when the week starts on a day other than Sunday or Monday we access

D15071: Don't draw frames and shadows around images with transparency

broulik accepted this revision. broulik added a comment. Alright let's go with this REPOSITORY R241 KIO BRANCH thumbnail-frame-refinement (branched from master) REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc:

D15283: Move SMB KCM to Network Settings category

broulik added a comment. I investigated once but the SMB kio slave actually still reads these properties. Why it doesn't work, I have no idea. SMB browsing is completely broken in newer distros thanks to switch to SMB >= 2 .. REPOSITORY R241 KIO REVISION DETAIL

D15213: Provide icons for 2x scaling

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, Dolphin patches merged to stable. This can go in now, thanks! REPOSITORY R266 Breeze Icons BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 To:

D15283: Move SMB KCM to Network Settings category

broulik created this revision. broulik added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The "Connectivity" category is empty and makes it show up on the root level

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f27ac45b52c0: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D15213: Link 16px icon folders to 16@2

broulik added a comment. Thanks a lot! There's a quirk in Dolphin where it wouldn't pick up the 22px places icons as in `KStandardItemListWidget::pixmapForIcon` it scales the size (22→44) first and then clamps it to an icon size (48) and so it won't find the fixed 22. Also, the problem

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

broulik created this revision. broulik added reviewers: Frameworks, VDG, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The former knows high dpi scaling TEST PLAN Before

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

broulik created this revision. broulik added reviewers: dfaure, elvisangelaccio, fvogt, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids creating a `QFileInfo` which might block

D15213: Link 16px icon folders to 16@2

broulik added a comment. About the `index.theme`, what you want to do is, for every folder duplicate the non-2x entry and add a `Scale=2` to it, e.g. [places/16] Size=16 Context=Places Type=Fixed add after it [places/16@2x] Size=16 Scale=2

D15213: Link 16px icon folders to 16@2

broulik added a comment. I think the suffix should be `@2x`, not just `@2`. Also, I don't think it's neccessary for the `animation` folder. Anyway, without the `ScalableIcons` entry in `index.theme` testing this is difficult REPOSITORY R266 Breeze Icons REVISION DETAIL

D15177: Emit signals when a package is installed/uninstalled

broulik added a comment. +1 INLINE COMMENTS > packagejob.cpp:93 > +for (auto packageType: serviceTypes) { > +auto msg = > QDBusMessage::createSignal(QStringLiteral("/KPackage/") + packageType, > QStringLiteral("org.kde.plasma.kpackage"), >

D15180: kioexecd: watch for creations or modifications of the temporary files

broulik added inline comments. INLINE COMMENTS > jtamate wrote in kioexecd.cpp:58 > Why not? > It should be just removing the temporary file copy and it's backups. If you can be sure kioexec creates a folder per temp file (it might does), then this is probably fine. Also check kioexec what it

D15180: kioexecd: watch for creations or modifications of the temporary files

broulik added inline comments. INLINE COMMENTS > kioexecd.cpp:58 > qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" > << info.fileName(); > -QFile::remove(it.key()); > -QDir().rmdir(parentDir); > +QDir(parentDir).removeRecursively(); > }

<    5   6   7   8   9   10   11   12   13   14   >