> Macs however always have two-fingers secondary click; their magic mouse have
> both (it's mouse-touchpad hybrid).
If all else fails you could still Control click on Mac iirc.
This feature would be useful for Plasma on touchscreens though, faking a right
click on *touch* long-press. Maybe
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
These fstab options allows an administrator to specify names and icons
intended for the user, shown in a GUI.
For
broulik added inline comments.
INLINE COMMENTS
> broulik wrote in fstabdevice.cpp:40-41
> I wondered that too, that's in the original patch, though, didn't really look
> into where this will end up, though :D
Just checked, this way round it makes more sense.
The vendor will be the host name
broulik updated this revision to Diff 12456.
broulik edited the summary of this revision.
broulik added a comment.
- Use QStringRef
- Drop swap of vendor/product, this will be done in a separate patch
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 12457.
broulik added a comment.
- Cache mountOptions or else it falls out of scope and QStringRef crashes
(now I know why I should cache it :D)
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5034?vs=12456=12457
broulik added inline comments.
INLINE COMMENTS
> dhaumann wrote in fstabdevice.cpp:40-41
> Did you intentionally switch vendor and product?
I wondered that too, that's in the original patch, though, didn't really look
into where this will end up, though :D
REPOSITORY
R245 Solid
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:badf8acfe2c0: [Breeze Plasma Theme] Improve
action-overlay icons (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dfbf2c1c302e: Port away from setRoleNames where easily
possible (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4917
To: broulik, #plasma, #vdg, andreask, alex-l
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:94a6a168cf45: [Containment Interface] Trigger context
menus on pressing "Menu" key (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik added a dependent revision: D4962: [Folder View] Open context menu when
pressing Menu key.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4924
To: broulik, #plasma, #vdg, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai,
broulik added a comment.
The icons are copied from the Breeze icon set. Granted, it's an "emblem" icon
and not one from "actions" which is arguably wrong but I wanted to be
consistent with Dolphin here… also, I expressed my frustration with our current
visual design workflow numerous times,
broulik added a comment.
> only a draft based on the old design with the new semantic.
The graphic is missing some states (add-hover, add-pressed, open-normal,
open-hovered, remove-hover, remove-pressed). Not a fan of having a blue remove
icon. Also, I was told the arrow isn't a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102713
---
This superseds Review 127281?
- Kai Uwe Broulik
On März
://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png
Thanks,
Kai Uwe Broulik
broulik added reviewers: andreask, alex-l.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4917
To: broulik, #plasma, #vdg, andreask, alex-l
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The current ones aren't really descriptive and vastly different from what
Dolphin uses.
BUG: 376321
TEST PLAN
broulik edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4917
To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/collapse
REVISION DETAIL
https://phabricator.kde.org/D4866
To: mart, #plasma, broulik
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
broulik added a comment.
+1
INLINE COMMENTS
> fadingnode.cpp:57
> {
> -return "varying highp vec2 v_coord;"
> -"uniform sampler2D u_src;"
> -"uniform sampler2D u_target;"
> -"uniform highp float u_transitionProgress;"
> -"uniform lowp float qt_Opacity;"
> -"void
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This way one can just add a KCM as-is without having to worry about a
potentially diverging translation or icon from
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e0b719f1e71: [Containment Interface] always emit
contextualActionsAboutToShow for containment (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik retitled this revision from "added back lines to void
Dialog::componentComplete() to fix an issue where the notifications will show
as 1 pixel line if the primary screen wasn't the most left one." to "Fix issue
where notifications will show as 1 pixel line if primary screen wasn't the
broulik edited the summary of this revision.
broulik added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7071
To: matank, #plasma
Cc: ltoscano, #frameworks
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7117
To: vkrause, #frameworks, broulik
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
QFile does not support special attributes like sticky. This would cause us to
always discard them.
BUG: 365795
TEST PLAN
Comes with
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9ac7832b859b: [File KIO slave] Fix applying special file
attributes (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7326?vs=18184=18187
REVISION
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kstyle.cpp:419
> just QIcon::fromTheme(directionalThemeName, "edit-clear")
You mean `QIcon::fromTheme(directionalThemeName,
QIcon::fromTheme("edit-clear"));`?
REPOSITORY
R252 Framework Integration
REVISION DETAIL
broulik added a comment.
Another idea would be to check it in `aboutToShow` of the menu?
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks
Cc: broulik
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Qt just returns a 16px pixmap by default leading to blurry results when
larger icon sizes for small icons are configured by the user.
TEST
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We're passing it an absolute path to a file in our install directory anyway,
so we probably don't want inheritance.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cf8ae465e430: [Theme] Use KConfig SimpleConfig (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7362?vs=18281=18284
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Use lambdas instead.
TEST PLAN
This is slightly faster.
Verified that applet actions are still added and can be
broulik added a comment.
+1
(for others reading this: Explicitly turning it into `StyledText` prevents
Qt's `AutoText` from deciding to use `PlainText` in some cases which will then
again look broken. Note that `StyledText` uses a basic string parser so it's
nowhere near as heavy as
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6751
To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Depending on icon theme the implicit size of the icon may be huge.
BUG:
FIXED-IN: 5.10.4
TEST PLAN
Used
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28deb6f4ab2: [Task Manager] Fix icon size in launcher
tooltips (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6751?vs=16809=16820
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:21f954d94dc5: [PlasmaComponents Menu] Don't crash on null
action (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 16491.
broulik added a comment.
When assigning an action, match the item's visibility and enabled
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6608?vs=16452=16491
REVISION DETAIL
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Especially in frequently created items. Shoves off a couple of milliseconds
of startup time.
TEST PLAN
- Changing
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c00069c43db4: Use new connect syntax in more places
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6614?vs=16471=16472
broulik updated this revision to Diff 16444.
broulik added a comment.
- Fix all tooltip flag checks in dialog
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6554?vs=16309=16444
REVISION DETAIL
https://phabricator.kde.org/D6554
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a19701c2529d: [Plasma Dialog] Fix flag conditions
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6554?vs=16444=16445
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Ensure the style knows what widget its painting focus for.
Also take the widget's style (as is done in the delegate paint method)
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f3dcff28b8fb: [Containment Interface] Keep containment in
RequiresAttentionStatus while… (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It doesn't store any state but contains only functions.
TEST PLAN
Only one instance of this script is created in
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d8f1d44a493c: Declare AppManager.js as pragma library
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6676?vs=16643=16644
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:abe58c287c32: [KPageListViewDelegate] Pass widget to
drawPrimitive in drawFocus (authored by broulik).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
You can assign a `QAction` as "action", this way you can just pass it e.g.
`plasmoid.action("configure")`.
However,
broulik updated this revision to Diff 16452.
broulik edited the summary of this revision.
broulik added a comment.
- For simplicitly just always delete the current action if it's ours before
proceeding. Then either use the one passed in or create a new one. As a (neat)
side-effect,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The code wants to check whether we're not a tooltip. This didn't work.
TEST PLAN
My Alternatives popup now slides in
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6554
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The applet context menu contains containment actions which might be outdated
if we don't call this.
TEST PLAN
Right
broulik added a comment.
Yes
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6894
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
broulik added a comment.
Also, your property is `X-KDE-PluginInfo-OnlySupportedPlatform` but you check
for `X-KDE-OnlyShowOnQtPlatforms`
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #frameworks, #plasma
Cc: broulik, #frameworks
broulik added inline comments.
INLINE COMMENTS
> kded.cpp:328
> +{
> +const QStringList supportedPlatforms =
> module.rawData().value(QStringLiteral("X-KDE-OnlyShowOnQtPlatforms")).toVariant().toString().split(QStringLiteral(";"),
> QString::SkipEmptyParts);
> +
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CCBUG: 381479
TEST PLAN
The device templates are no longer installed since the move from
kde-baseapp's libkonq to KIO, the menu is empty
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ddbae1c69cae: [KNewFileMenu] Hide "Link To Device" menu
if it would be empty (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6446?vs=16048=16051
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6453
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6480
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks,
broulik added a comment.
Cool stuff!
A bunch of nitpicks but then it's good to go.
INLINE COMMENTS
> dbusrunnertest.cpp:45
> +void testMatch();
> +//
> +private:
Remove
> dbusrunnertest.cpp:52
> +{
> +m_process = new QProcess(this);
> +
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This ensures the panel does not auto-hide then.
It also forces a re-evaluation of auto-hide status when the menu
broulik added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1073
> +
> +connect(desktopMenu, ::aboutToHide, m_containment, [this,
> oldStatus] {
> +m_containment->setStatus(oldStatus);
Not sure if we should use `this` (and then check `if m_containment` as context
or
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
dbusrunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5597
To: hein, #plasma, mart, broulik
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Created a file named `hello` and no longer get my dialog broken by
it formatting the file name in huge letters :)
REPOSITORY
R241 KIO
REVISION
broulik added inline comments.
INLINE COMMENTS
> entryinternal.cpp:169
> {
> d->mCategory = category;
> }
Detach here also
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7194
To: apol, leinir
Cc: broulik, #frameworks
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:1045
>
> +if (re->size().isEmpty() || re->size() != re->oldSize()) {
> +return;
So it will never update its size? Shouldn't it be size == oldSize?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> abstractrunner.cpp:204
> {
> -Q_UNUSED(match)
> -return nullptr;
> +if (match.urls().isEmpty()) {
> +return nullptr;
Weird indentation
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is less cumbersome than having to select an item and then clicking "Edit
Entry"
TEST PLAN
- Verified that double-clicking one of
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1419135a5d99: Get rid of QSignalMapper (authored by
broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7361?vs=18280=18327
REVISION
broulik added a comment.
Dolphin supposedly also made use of this feature at one point: cf. Bug 358649
- given I can middle click almost anything in Dolphin (Places, Folders,
Breadcrumbs) I would expect Back/Forward/Up to also open in a new tab.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Had a file `foo` and no longer get it turning into huge letters in
the dialog.
REPOSITORY
R241 KIO
REVISION DETAIL
broulik added a comment.
BUG: 381124
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6192
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6192
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Since Qt 5.9 there's a ScaledPixmapHook in QIconEngine which is called when
device pixel ratio is > 1 and it wants a
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:487
> +}
> +Q_ASSERT(mainItem);
> +Q_ASSERT(mainItemLayout);
Those asserts are redundant now
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5912
To: mart, #plasma, hein,
broulik added a comment.
In `onPressed` I would expect `pressed` to be also true which this patch
ensures.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D5979
To: apol, #frameworks
Cc: broulik, davidedmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6b7115ce7016: [RenameDialog] Enforce plain text format
(authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5611?vs=13859=14941
REVISION DETAIL
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Workaround for QTBUG-59017
CHANGELOG: Addressed an issue where certain elements in applications (e.g.
Dolphin's file view) would
broulik added a comment.
Shouldn't left click scroll up and down a bit with middle click jumping to
position - that's the behavior of Qt's scroll bars.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6086
To: sars, #ktexteditor, #kate, dhaumann
Cc: broulik,
broulik added a comment.
Fair enough, +1
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6086
To: sars, #ktexteditor, #kate, dhaumann
Cc: broulik, kwrite-devel, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:90c1f7c8a9d6: [KOpenWithDialog] HTML-escape file name
(authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6149?vs=15275=15370
REVISION DETAIL
broulik abandoned this revision.
broulik added a comment.
Superseded by https://phabricator.kde.org/D7774
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D5034
To: broulik, #plasma, dhaumann, dfaure
Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, progwolff,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7815
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
Hi,
either of the following reverts fix the problem for me:
KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d
or
KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and
32526718eae99ccb594360627586eebdf793372b
but perhaps both KGlobalAccel and KWindowSystem to be sure.
Cheers
Kai
Am 2017-09-13 20:28, schrieb Kai Uwe Broulik:
> Hi,
>
> either of the following reverts fix the problem for me:
>
> KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d
>
> or
>
> KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and
> 32526718ea
broulik created this revision.
broulik added reviewers: kde-frameworks-devel, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Using initializer_lists for QList we reserve the right amount of memory in
advance
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
fix_crash_pendingfilequeue
REVISION DETAIL
https://phabricator.kde.org/D7926
To: chehrlic, broulik
Cc: #frameworks
broulik planned changes to this revision.
broulik added inline comments.
INLINE COMMENTS
> mwolff wrote in kconfiggroup.cpp:187
> use `splitRef` instead, also below
Was my first reflex do to so but `string` confusingly is a `QByteArray`
REPOSITORY
R237 KConfig
REVISION DETAIL
broulik added a comment.
I don't understand this. RoundToIconSize is supposed to round down and that's
it. If I pass it 100 px because I'm on a high dpi screen, it will still return
100. Only if I pass it e.g. 34 it will change it to 32.
REVISION DETAIL
https://phabricator.kde.org/D7849
broulik added a comment.
Doesn't fix Meta+Shift+PrintScr for me
REVISION DETAIL
https://phabricator.kde.org/D7829
To: dfaure, graesslin, jriddell, martinkostolny, broulik
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb15e56857ca: [KConfigGroup] reserve() more and add some
C++11 (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7879?vs=19671=19727#toc
REPOSITORY
R237 KConfig
CHANGES
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in server_decoration_interface.h:147
> is it a paletteName or palettePath? IIRC we set complete paths?
I think we support both (doing a KService lookup if no complete path given),
imho "name" would also be consistent with what
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
isplatform-internal
REVISION DETAIL
https://phabricator.kde.org/D8210
To: graesslin, #frameworks, #kwin, broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
frame->fooHeight is the same as frame->fooFixedHeight if the border is
enabled, we
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8135?vs=20332=20851
broulik added a comment.
> This is getting deprecated
yay...
global menu also uses it
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8159
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
broulik added a comment.
+1
However I fear this might cause "shortcut xyz is ambiguous" messages after
update for some users :/
Perhaps also consult VDG / usability
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks
Cc: broulik,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
QPixmap::alphaChannel() is deprecated.
TEST PLAN
Corners of popups still nicely rounded (tested with Oxygen which has
401 - 500 of 2150 matches
Mail list logo
