Re: Review Request 114158: Use Sonnet::SpellCheckDecorator internally in KTextEdit

2013-11-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114158/#review44610 --- Ship it! Ship It! - Kevin Ottens On Nov. 27, 2013, 6:02

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/#review44524 --- Ship it! Ship It! - Kevin Ottens On Nov. 26, 2013, 4:30

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
> On Nov. 26, 2013, 5:23 p.m., Kevin Ottens wrote: > > tier1/kimageformats/src/CMakeLists.txt, line 1 > > <http://git.reviewboard.kde.org/r/114141/diff/2/?file=220425#file220425line1> > > > > No need for this extra sub-folder IMO. Just put it all under src/

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/114141/#comment31796> No need for this extra sub-folder IMO. Just put it all under src/ - Kevin Ottens On Nov. 26, 2013, 4:30 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 114116: [tier3/kservice] Improve dependency specification

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114116/#review44518 --- Ship it! Ship It! - Kevin Ottens On Nov. 25, 2013, 6:58

Re: Review Request 114129: Move kfileaudiopreview to tier4

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114129/#review44517 --- Ship it! Ship It! - Kevin Ottens On Nov. 26, 2013, 12:44

Re: Review Request 114128: Move kmediaplayer to tier3

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114128/#review44516 --- Ship it! Ship It! - Kevin Ottens On Nov. 26, 2013, 12:06

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-26 Thread Kevin Ottens
ce to see progress or should it be discarded? - Kevin Ottens On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 114127: Fix KIO superbuild dependencies

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114127/#review44511 --- Ship it! Ship It! - Kevin Ottens On Nov. 25, 2013, 10:50

KF5 Update Meeting Minutes 2013-w48

2013-11-26 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 48 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, markg85, mgraesslin, miroslav, randomguy3, Riddell, sebas, svuorela, teo and myself. Announcement: * We're close to be ready

Re: imageformat plugins

2013-11-26 Thread Kevin Ottens
On Tuesday 26 November 2013 15:00:08 Aurélien Gâteau wrote: > Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : > > What do other people think about this? > > Having the imageformat plugins in their own repositories make sense to me. > I think they can go in tier1, but I am not the master of

Re: further coinstallability

2013-11-26 Thread Kevin Ottens
On Tuesday 26 November 2013 15:04:09 Aurélien Gâteau wrote: > Le samedi 23 novembre 2013 18:19:53 Jonathan Riddell a écrit : > > some libs with an soname of 5 in kdelibs4 keep an soname of 5 in KF5. I > > found libkhtml.so.5 which is now libKHtml.so.5 which will clash for > > package names which a

Re: Review Request 113910: Add basic KArchive examples

2013-11-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44416 --- Ship it! Ship It! - Kevin Ottens On Nov. 25, 2013, 2:46

Re: Review Request 113910: Add basic KArchive examples

2013-11-25 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/113910/#comment31755> Put the } and the else if on the same line please. Sorry I didn't spot it the previous time... - Kevin Ottens On Nov. 25, 2013, 12:35 p.m., Maarten De Meyer wrote: > >

Re: Review Request 114090: [tier2/ki18n] Improve dependency specification

2013-11-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/#review44404 --- Ship it! Ship It! - Kevin Ottens On Nov. 24, 2013, 10:17

Re: Review Request 114050: Add manual test app for enableBlurBehind.

2013-11-25 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/114050/#comment31754> Space before * and not after please (applies to the whole file). - Kevin Ottens On Nov. 23, 2013, 12:15 a.m., Nicolás Alvarez wrote: > > --- > This is an automatically generated e

Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer

2013-11-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/#review44401 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 5:52

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-11-25 Thread Kevin Ottens
> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote: > > After discussion on the mailing list, let's get that in for the time being. > > It is to be considered as a temporary solution and will be removed when > > CMake 3 will be available. Please push it ASAP, we nee

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-25 Thread Kevin Ottens
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

2013-11-25 Thread Kevin Ottens
now. - Kevin Ottens On Nov. 18, 2013, 6:04 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

KF5 Update Meeting 2013-w48 Reminder

2013-11-25 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed messa

Re: [Kde-pim] PIM Sprint: Porting PIM to Frameworks

2013-11-25 Thread Kevin Ottens
On Sunday 24 November 2013 21:36:02 Stephen Kelly wrote: > Kevin Ottens wrote: > >> Tiers above 1 are not especially relevant. A tier is a fluid label. It > >> doesn't matter when we are using split repos. > > > > If you could stop spreading that it'd be

Re: RFC Rules for installation of header files

2013-11-25 Thread Kevin Ottens
On Monday 25 November 2013 00:43:52 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Looks like we have an agreement then. Let me recap: > > > > # Installation dir > > > > All header files are installed in $PREFIX/include/KF5/$Framework. > > This includes 'k' prefixed headers like kfoo and KFoo, >

Re: [Kde-pim] PIM Sprint: Porting PIM to Frameworks

2013-11-24 Thread Kevin Ottens
Hello, On Tuesday 19 November 2013 22:59:15 Stephen Kelly wrote: > John Layt wrote: > > It was agreed that the ideal plan for kdepimlibs was to split all the > > libraries up and make them all stand-alone Frameworks, aiming for Tier > > 2 or even Tier 1 where possible. > > Tiers above 1 are not es

Re: Review Request 114052: Skip tests which need a window manager running

2013-11-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114052/#review44276 --- Ship it! Ship It! - Kevin Ottens On Nov. 23, 2013, 11:18

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44238 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 6:23

Re: Review Request 113910: Add basic KArchive examples

2013-11-22 Thread Kevin Ottens
at, if no file is given just show a error message to explain the syntax and exit. tier1/karchive/examples/tarlocalfiles/main.cpp <http://git.reviewboard.kde.org/r/113910/#comment31671> No need to take this into account. - Kevin Ottens On Nov. 20, 2013, 6:50 p.m.,

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

2013-11-22 Thread Kevin Ottens
. :-) - Kevin Ottens On Nov. 21, 2013, 5:35 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 113975: Make some KSSL files public API

2013-11-22 Thread Kevin Ottens
stead. This patch wouldn't be needed anymore. - Kevin Ottens On Nov. 20, 2013, 7:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-22 Thread Kevin Ottens
KMimeTypeResolver. Turns out it's used by nobody! So no need to install defaultviewadapter_p.h - Kevin Ottens On Nov. 22, 2013, 11:40 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Having a Tier 0 for cmake and git submodules

2013-11-22 Thread Kevin Ottens
On Friday 22 November 2013 10:55:09 David Faure wrote: > On Tuesday 12 November 2013 22:56:47 Alexander Neundorf wrote: > > 4) > > find_package(KArchive) > > find_package(Solid) > > find_package(KConfig) > > find_package(ECM) > > include(KDECMakeSettings) > > include(KDEInstallDirs) > > include(KDE

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-21 Thread Kevin Ottens
> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h > > Kevin Ottens wrote: > Alexander? Any chance to see this comment addressed? > > Alexander Richardson wrote: > Oops somehow didn't see that commen

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-21 Thread Kevin Ottens
. KService probably does > make the most sense out of what we have, although it's still a bit mismatched > (I wouldn't expect to need KService if my application didn't use plugins). > Is there maybe a use for a framework that provides things to help make apps > behave

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/#review44129 --- Ship it! Ship It! - Kevin Ottens On Nov. 19, 2013, 4:10

Re: Review Request 113949: Workaround for dependency issues when generating .json from .desktop files

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113949/#review44130 --- Ship it! Ship It! - Kevin Ottens On Nov. 19, 2013, 6:19

Re: Reporting bugs against frameworks/plasma2

2013-11-21 Thread Kevin Ottens
Hello, On Thursday 21 November 2013 15:59:17 David Edmundson wrote: > Long term, I disagree with using the version "frameworks" everywhere. Agreed... > We want to have a split between Frameworks5.0 and Plasma2.0 and they > may not be on the same release cycle. > > That said; you can rename a ver

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-11-21 Thread Kevin Ottens
> On Nov. 15, 2013, 6:20 p.m., Kevin Ottens wrote: > > Any chance to see Stephen's comments addressed or this patch is abandoned? Last warning, I'll close it as discarded if it's not updated on my next roun

Re: Review Request 113975: Make some KSSL files public API

2013-11-21 Thread Kevin Ottens
look at it. - Kevin Ottens On Nov. 20, 2013, 7:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 113968: Make KFileAudioPreview use its own config group

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113968/#review44132 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 11:36

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44131 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 7:39

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

2013-11-21 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/113996/#comment31617> Actually makes no sense anymore to keep it private IMO. Please rename it in the process to make it a proper public header. - Kevin Ottens On Nov. 21, 2013, 12:29 p.m., Aleix Pol Gonzalez

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

2013-11-21 Thread Kevin Ottens
> On Nov. 21, 2013, 4:21 p.m., Aurélien Gâteau wrote: > > Ship It! Hold your horses people... I'd like to get a chance to look at this one. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.k

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/#review44136 --- Ship it! Ship It! - Kevin Ottens On Nov. 21, 2013, 4:28

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-21 Thread Kevin Ottens
ivate headers? Gives me an uneasy feeling. - Kevin Ottens On Nov. 21, 2013, 4:23 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: [kdelibs/frameworks] /: Always generate documentation

2013-11-20 Thread Kevin Ottens
On Wednesday 20 November 2013 16:15:20 Aleix Pol wrote: > Git commit f14b4f3ee2d3c41b64aeaeb021b02df45dbd35cf by Aleix Pol. > Committed on 20/11/2013 at 16:15. > Pushed by apol into branch 'frameworks'. > > Always generate documentation > > DocBook generation tools should be working, just make sure

KF5 Update Meeting Minutes 2013-w47

2013-11-19 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 47 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, jpwhiting, mgraesslin, randomguy3, sebas, teo and myself. Announcement: * We're not yet ready for the splitting so it's postponed by

KF5 Update Meeting 2013-w47 Reminder

2013-11-19 Thread Kevin Ottens
Hello all, I forgot (again) to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: Thi

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-11-18 Thread Kevin Ottens
that in for the time being. It is to be considered as a temporary solution and will be removed when CMake 3 will be available. - Kevin Ottens On Sept. 17, 2013, 7:56 p.m., Jeremy Whiting wrote: > > --- > This is an automatical

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Monday 18 November 2013 17:41:49 Aleix Pol wrote: > On Mon, Nov 18, 2013 at 4:17 PM, Kevin Ottens wrote: > > Right, we need to cater to that need too. Since that's tied to ki18n use, > > what about putting that wrapper macro in ki18n for the time being? > > > >

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Monday 18 November 2013 13:27:19 Aleix Pol wrote: > So would it be that bad to have a macro of ours that ends up being just a > wrapper to qt5_wrap_ui? > > Otherwise, this delays the possibility to help the ongoing porting process > by extending a mandatory dependency on KDE4Support. Right, we

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Monday 18 November 2013 12:49:39 Stephen Kelly wrote: > Stephen Kelly wrote: > >> It'd need to be released quite a bit before us to > >> be something we can consider as a dependency. At that point I'm > >> considering having 2.8.12 as dependency for the release (so that it got > >> time to sprea

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Sunday 17 November 2013 18:53:36 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Friday 15 November 2013 16:28:10 Stephen Kelly wrote: > >> Aleix Pol wrote: > >> > I see that Stephen Kelly has been doing some work on Qt and cmake to > >> > make it

Re: New Runtime Organization

2013-11-15 Thread Kevin Ottens
On Friday 15 November 2013 11:40:09 Jonathan Riddell wrote: > I've completed the wiki page for runtime organisation with a list of > everything in kde-runtime. There's quite a few dusty corners here. > https://community.kde.org/Frameworks/Epics/New_Runtime_Organization > > This page duplicates som

Re: RFC Rules for installation of header files

2013-11-15 Thread Kevin Ottens
On Friday 15 November 2013 15:01:03 Nicolás Alvarez wrote: > Would they be in a separate directory such as 'kde4support'? In a > case-insensitive file system you can't have both /usr/include/KF5/kio and > /usr/include/KF5/KIO... Yes, definitely what I had in mind. Regards. -- Kévin Ottens, http:/

Re: Review Request 113863: Remove WINCE specific cmake code paths

2013-11-15 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/113863/#comment31436> Shouldn't that line still be there? - Kevin Ottens On Nov. 15, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-15 Thread Kevin Ottens
eyes look at it. - Kevin Ottens On Nov. 15, 2013, 5:34 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

2013-11-15 Thread Kevin Ottens
> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote: > > Why do you need to drop the version? In similar cases we've been bumping to > > 5... Yeah I'm surprised as well... OTOH that's a regular library, we don't mention the version name for those (unlike for executables like kded) - Kev

Re: Review Request 113881: Standardise d-pointer classes of kmediaplayer

2013-11-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113881/#review43758 --- Ship it! Ship It! - Kevin Ottens On Nov. 15, 2013, 12:20

Re: Review Request 113882: Make constructors in KMediaPlayer explicit

2013-11-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113882/#review43760 --- Ship it! Ship It! - Kevin Ottens On Nov. 15, 2013, 12:21

Re: Review Request 113860: Improve dependency specification in karchive

2013-11-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113860/#review43756 --- Ship it! Ship It! - Kevin Ottens On Nov. 14, 2013, 2:37

Re: Review Request 113862: Improve dependency specification in kcodecs

2013-11-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113862/#review43757 --- Ship it! Ship It! - Kevin Ottens On Nov. 14, 2013, 3:01

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-15 Thread Kevin Ottens
the lambda to prepare for the fillRect calls. - Kevin Ottens On Nov. 14, 2013, 5:50 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-15 Thread Kevin Ottens
. KService probably does > make the most sense out of what we have, although it's still a bit mismatched > (I wouldn't expect to need KService if my application didn't use plugins). > Is there maybe a use for a framework that provides things to help make apps > behave

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-15 Thread Kevin Ottens
> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h Alexander? Any chance to see this comment addressed? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://gi

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-11-15 Thread Kevin Ottens
patch is abandoned? - Kevin Ottens On Oct. 30, 2013, 10:08 a.m., Sune Vuorela wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: RFC Rules for installation of header files

2013-11-15 Thread Kevin Ottens
On Friday 15 November 2013 17:24:00 Aurélien Gâteau wrote: > On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: > > On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: > >> Looks like we have an agreement then. Let me recap: > >> > >> # Installatio

Re: Wrapping up about KI18n and UIC

2013-11-15 Thread Kevin Ottens
On Friday 15 November 2013 16:28:10 Stephen Kelly wrote: > Aleix Pol wrote: > > I see that Stephen Kelly has been doing some work on Qt and cmake to make > > it possible to integrate these properly, but also those changes will get > > in cmake 3 and Qt 5.3 which are not among our dependencies. > >

Re: Fwd: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:43:59 Aleix Pol wrote: > On 14.11.2013 18:31, Aleix Pol wrote: > > On Thu, Nov 14, 2013 at 5:04 PM, Aurélien Gâteau > [3]> > > > > wrote: > >> On 10.11.2013 18:27, Kevin Ottens wrote: > >>> Hello, > >>>

Re: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: > Looks like we have an agreement then. Let me recap: > > # Installation dir > > All header files are installed in $PREFIX/include/KF5/$Framework. > This includes 'k' prefixed headers like kfoo and KFoo, I assume you meant kfoo.h here.

Re: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:04:57 Aurélien Gâteau wrote: > On 10.11.2013 18:27, Kevin Ottens wrote: > > Hello, > > > > On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: > >> Yesterday frameworks meeting spawned a discussion regarding folders > &g

Re: Review Request 113847: Remove unnecessary dependency in dnssd

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113847/#review43636 --- Ship it! Ship It! - Kevin Ottens On Nov. 13, 2013, 5:53

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-13 Thread Kevin Ottens
> On Nov. 13, 2013, 4:41 p.m., David Faure wrote: > > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93 > > > > > > this is still a C++11 initializer list, which isn't in the wiki page of > > allowed C++11

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

2013-11-13 Thread Kevin Ottens
ttp://git.reviewboard.kde.org/r/113830/#comment31363> to be emitted - Kevin Ottens On Nov. 13, 2013, 5:09 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request 113845: Remove unnecessary dependencies in kauth

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113845/#review43633 --- Ship it! Ship It! - Kevin Ottens On Nov. 13, 2013, 5:33

Re: Review Request 113834: Use FindOpenEXR.cmake from ECM

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113834/#review43632 --- Ship it! Once 113828 is in of course - Kevin Ottens On Nov

Re: Review Request 113827: CMake: refer to target directly instead of getting LOCATION property

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113827/#review43631 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 10:29

Re: Review Request 113825: Move kmediaplayer to staging (and fix its CMake files)

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113825/#review43630 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 10:09

Re: Review Request 113683: Fix kdeclarative standalone build

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43629 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 7:52

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

2013-11-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/#review43628 --- Ship it! Ship It! - Kevin Ottens On Nov. 11, 2013, 1:32

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-13 Thread Kevin Ottens
. 11, 2013, 4:37 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113798/ > ------- > &

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

2013-11-13 Thread Kevin Ottens
On Wednesday 13 November 2013 14:20:45 Christoph Feck wrote: > On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: > > Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin > > Ottens. Committed on 12/11/2013 at 17:09. > > Pushed by ervin into branch 'frame

Re: Optional QtGui dependency for KDBusAddons?

2013-11-12 Thread Kevin Ottens
On Wednesday 13 November 2013 06:38:44 Martin Gräßlin wrote: > On Tuesday 12 November 2013 23:42:36 Alex Merry wrote: > > The latter is my personal preference (and I don't see any real issue > > with KDBusAddons optionally using something from Qt Essentials), but > > what are other people's thought

Re: Getting ecm files from the ECM package

2013-11-12 Thread Kevin Ottens
On Tuesday 12 November 2013 20:04:38 Sune Vuorela wrote: > On 2013-11-11, Aaron J. Seigo wrote: > > would that work for everyone? > > I don't think it solves the actual hard point: > > Where should the final home for the stuff in ecm/kde-modules be ? Agreed. Although that's from the KF5 perspecti

KF5 Update Meeting Minutes 2013-w46

2013-11-12 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 46 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, dMaggot, jpwhiting, mdemeyer, mgraesslin, randomguy3, Riddell, sebas, svuorela and myself. Announcement: * I plan to open the

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Kevin Ottens
Hwllo, On Monday 11 November 2013 15:43:08 Jeremy Whiting wrote: > I see, and agree. So the way forward with kspeech would be to make it > it's own framework. then at some point turn the header/dbus interface > into a library that can hide the implementation details of using the > dbus interface d

KF5 Update Meeting 2013-w46 Reminder

2013-11-11 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Kevin Ottens
On Monday 11 November 2013 11:13:37 David Faure wrote: > On Sunday 10 November 2013 15:28:27 Kevin Ottens wrote: > > On Sunday 10 November 2013 11:15:58 Dominik Haumann wrote: > > > On Sunday 10 November 2013 09:47:41 David Faure wrote: > > > > On Sunday 10 Novembe

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 17:12:02 Sune Vuorela wrote: > Why move it out of e-c-m ? To make e-c-m a neutral ground again, not something purely for KDE needs. I can understand that positioning. > And if a distribution need to patch whatever is in the 'submodule', they > have a enormous useless p

Re: Getting ecm files from the ECM package

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 17:30:23 Alexander Neundorf wrote: > On Sunday 10 November 2013, Kevin Ottens wrote: > > Now I guess we could do it for both, but it looks tricky for something > > which would have a separate release cycle like ECM. While for the tier0 > > the releas

Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Kevin Ottens
Hello, Since there's been several times discussions about having a kind of "Tier 0" for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra dependency it'd bring, I looked a bit at the git submodule o

Re: RFC Rules for installation of header files

2013-11-10 Thread Kevin Ottens
Hello, On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: > Yesterday frameworks meeting spawned a discussion regarding folders in > header files. I think there's an aspect missing in your proposal. There's the convention we want for #include and where we install. That's in the end tw

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43366 --- Ship it! Ship It! - Kevin Ottens On Nov. 8, 2013, 9:04 p.m

Re: Review Request 113708: Make kcmutils build standalone

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/#review43365 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 3:36 p.m

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/#review43364 --- Ship it! Ship It! - Kevin Ottens On Nov. 6, 2013, 7:17 p.m

Re: Review Request 113694: Fix KNewStuff standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43363 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 1:04 p.m

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43362 --- Ship it! Ship It! - Kevin Ottens On Nov. 8, 2013, 12:12

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-10 Thread Kevin Ottens
. - Kevin Ottens On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 113695: Fix KDEWebKit standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43360 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 12:38

Re: Review Request 113686: Fix KParts standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43359 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 1:04 p.m

Re: Review Request 113713: Solid UDisks2 backend: fixes to propertiesChanged signal handling

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/#review43358 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 7:08 p.m

<    5   6   7   8   9   10   11   12   13   14   >