mlaurent abandoned this revision.
mlaurent added a comment.
commited in kcoreaddons
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
7fef375
>
> Can someone please fix this?
>
> At the moment it's breaking the build of various components which
> depend on KHTML and as a consequence has left the CI system in an
> inconsistent state. At this time both Applications and Plasma have
> been negatively impac
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
Le vendredi 15 décembre 2017, 18:47:40 CET Ben Cooksley a écrit :
> On Fri, Dec 15, 2017 at 7:41 PM, laurent Montel wrote:
> > Le vendredi 15 décembre 2017, 03:38:32 CET Ben Cooksley a écrit :
> >> Hi Laurent, all,
> >
> > Hi,
> > Indeed fixed now.
>
mlaurent added a comment.
Not commited ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
mlaurent added a comment.
Could you paste you compile error here please.
INLINE COMMENTS
> CMakeLists.txt:1
> -remove_definitions(-DQT_NO_CAST_FROM_ASCII)
> +#remove_definitions(-DQT_NO_CAST_FROM_ASCII)
>
Better to remove it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabri
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
KAboutData aboutData2(QString::fromLatin1(AppName2),
QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2));
use QString::fromLatin1 is will work
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mla
mlaurent added a comment.
Arguiment from method use QString and not QLatin1String()
QString::fromLatin1 returns a QString
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdatatest.cpp:48
>
> -static const char AppName[] ="app";
> -static const char ProgramName[] ="ProgramName";
> -static const cha
mlaurent added a comment.
Missing all patch... please see
"https://community.kde.org/Infrastructure/Phabricator";
"Step 2: Updating your diff.
After you upload the code the reviewer will take a look and give you some
comments. If you get a thumbs up, you can skip this step. But ofte
mlaurent added inline comments.
INLINE COMMENTS
> desktoptojsontest.cpp:84
> QByteArray input =
> -// include an insignificant group
> -"[Some Group]\n"
> -"Foo=Bar\n"
> -"\n"
> -"[Desktop Entry]\n"
> -// only data insid
mlaurent added inline comments.
INLINE COMMENTS
> velurimithun wrote in kprocesstest.cpp:93
> These strings are going as arguments for QStringList() method that why I used
> QString::FromLatin1()
?
QStringLiteral works fine with QStringList
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
http
mlaurent created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
TEST PLAN
Generate kmail categories file
REPOSITORY
R240 Extra CMake Modules
BRANCH
autogenerate_categories_file
REVISION DE
mlaurent added a comment.
IT's a WIP as I use file(APPEND...) because I want to generate several
categories in one file.
But it doesn't work as I don't have idea how to reset file when cmake is
started...
Do you have an idea ?
I will implement autotest and co if we have a solution
mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure
Cc: #frameworks, #build_system
mlaurent added a comment.
You still missing all patch...
Please use arc diff so we are sure that all patch is updated.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Good thanks !
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9491
To: dfaure, sandsmark, mlaurent
Cc: #kde_pim, #frameworks
mlaurent added a comment.
no news ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kprocesstest.cpp:47
> p.setProcessChannelMode(QProcess::MergedChannels);
> -p.start(gargv[0], QStringList() << QString::number(how) <<
> QStringLiteral("--nocrashhandler"));
> +p.start(QString::fromLatin1(gargv[0]), QStringList() <<
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
BRANCH
UseOverride (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9571
To: dhaumann, kfunk, mlaurent
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann,
mlaurent added a comment.
indeed code will be broken if we don't use QString::fromUtf8.
Could you fix it please ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
When I try to compile your patch I have this compile error:
Do you are sure that you rebuild all ?
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest
mlaurent added a comment.
Ok I understand why you don't have this problem you need to rebase patch with
last kcoreaddons version.
So code was added.
Please rebase, make sure that it builds and upload patch.
Regards.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kd
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
indeed good catch
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Otherwise all is good. +2 with the QVERIFY(...)
INLINE COMMENTS
> kdatecomboboxtest.cpp:182
> +combo->activateWindow();
> +QTest::qWaitForWindowActive(combo.data());
> +
QVERIF
mlaurent added a comment.
Ping ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8908
To: dfaure, cfeck, dvratil, mlaurent
Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim
mlaurent added a comment.
Ping bis ?:)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
You still forgot to launch autotest...
see:
"laurent@linux-5nvn:/compile/kde5/framework/frameworks/kcoreaddons/build>
./bin/kaboutdatatest
- Start testing of KAboutDat
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R244 KCoreAddons
BRANCH
complieWithoutRemoveDef
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent added a comment.
I made a fix. I wait a rebuild on windows to see if it's ok
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: bcooksley, dfaure, #frameworks
mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:8
> set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
> +set(CMAKE_AUTORCC ON)
>
Just curious it's not default in ECM ? I never used it.
REPOSITORY
R17
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kpluginfactory.h:211
> + */
> +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile)
> K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json,
> registerP
mlaurent abandoned this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system, michaelh, ngraham
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems good for me
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10744
To: vonreth, mlaurent, dfaure, leinir
Cc: #frameworks, michaelh
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:44
> +struct FileInfo {
> +quint32 deviceId;
> +quint32 inode;
initialize value by default please
> databasesa
mlaurent added a comment.
Is it possible to create an autotest for this class ?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,
a
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:46
> +public:
> +FileInfo(const quint32 d = 0, const quint32 i = 0,
> +const QString& u = QString(), con
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
+2 for me but I don't know baloo code :)
REPOSITORY
R293 Baloo
BRANCH
sanitize-class (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #bal
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.cpp:103
> +QStringLiteral("devices"),
> +i18n("List devices "),
> +QStringList{},
extra space at the end of i18n
> main.cpp
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:16
> +
> +install(TARGETS baloodb DESTINATION ${BIN_INSTALL_DIR})
install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
> main.cpp:
mlaurent added inline comments.
INLINE COMMENTS
> michaelh wrote in CMakeLists.txt:16
> @mlaurent Is it worth the effort to change this for the other cli tools
> accordingly?
It's the default variable.
But don't chnage it in this patch.
Perhaps in the future as you are the baloo maintainer :)
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
sanitize-cmd (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh,
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Thanks
can you commit it ? Do you have commit access ?
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssl
mlaurent added a comment.
I will commit for you. what is your email address ?
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, asti
mlaurent closed this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
mlaurent added a comment.
done.
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
mlaurent accepted this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6513
To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure,
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel,
#knewstuff, michaelh, Zr
mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags
REPOSITORY
R240 Extra CMak
mlaurent added a reviewer: dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
mlaurent added a comment.
I fixed 2 repos.
Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some
module is not compiles on my computer)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks
mlaurent added a comment.
Ping?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT
as default compile flags (authored by mlaurent).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kwalletd.cpp:685
> +const auto errorStr =
> KWallet::Backend::openRCToString(rc);
> +qWarn
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D15778
To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mtpstorage.cpp:176
> +case LIBMTP_FILETYPE_UNDEF_AUDIO:
> +return QStringLiteral("");
> +case LIBMTP_FILETYPE_WMV:
QString() directly no ?
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R310 KTextWidgets
BRANCH
lazy-qtexttospeech (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D16001
To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
mtp_next (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15277
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-
mlaurent added a reviewer: dfaure.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D16306
To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,
bruns, abrahams
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems ok for me
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D16350
To: yurchor, #documentation, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-de
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:65
> + rename/batchrenamedialog.cpp
> +rename/batchrenamedialogmodel_p.cpp
> +rename/batchrenametypes_p.cpp
fix indent
>
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> batchrenamedialog.cpp:40
> +#include
> +#include
> +#include
remove QtWidget
> batchrenamedialog.cpp:41
> +#include
> +#include
> +
remove QtGui pr
mlaurent added inline comments.
INLINE COMMENTS
> emateli wrote in batchrenamedialog.h:69
> You mean to initialize them to nullptr on the header file or using a
> constructor initialization list? Also see what problem?
in header file.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricato
mlaurent added a comment.
For me seems good +1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14631
To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel,
michaelh, bruns
mlaurent accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14631
To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel,
michaelh, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
opt-i18n
REVISION DETAIL
https://phabricator.kde.org/D16966
To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Fix mem when I used dolphin
#0 0x7fa8cd24d900 in operator new(unsigned long)
(/usr/lib64/libasan.so.5+0xed
mlaurent added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17065
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent added a comment.
Indeed a very good training "debugging and profiling"
I fixed some potential other mem leak in kinfocenter/ark/libksysguard
yesterday.
Very useful indeed.
REPOSITORY
R241 KIO
BRANCH
fix_mem_leak (branched from master)
REVISION DETAIL
https://phabricato
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8fb6431784e2: Fix mem leak found with asan (authored by
mlaurent).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17065?vs=45928&id=45935
REVISION DETAIL
https://pha
mlaurent added a comment.
no commited yet ?:)
REPOSITORY
R290 KPackage
BRANCH
opt-i18n
REVISION DETAIL
https://phabricator.kde.org/D16966
To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18424
To: sdepiets, #baloo, bruns, poboiko, mlaurent
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spo
5.777Z] * Qt5Core
> [2019-06-12T05:25:25.777Z]
> [2019-06-12T05:25:25.777Z] -- The following features have been disabled:
> [2019-06-12T05:25:25.777Z]
> [2019-06-12T05:25:25.777Z] * QCH, API documentation in QCH format (for e.g.
> Qt Assistant, Qt Creator & KDevelop) [2019-06-12T
mlaurent added a comment.
I will look at it
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20489
To: mlaurent, dfaure
Cc: kossebau, cfeck, aacid, cgiboudeaux, kde-frameworks-devel, LeGast00n,
michaelh, ngraham, bruns
mlaurent added a comment.
will it fix this bug "https://bugs.kde.org/show_bug.cgi?id=407600"; ?
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D22488
To: mart, #frameworks, #plasma
Cc: mlaurent, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,
ngra
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R310 KTextWidgets
BRANCH
createdesignerplugin
REVISION DETAIL
https://phabricator.kde.org/D22791
To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngrah
mlaurent added a comment.
Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) in
cmake toplevel ?
or 5.14 value ? so we can be sure that it builds without deprecated method
until it.
(I prefere QT_DISABLE_DEPRECATED_BEFORE=0x06 so we can fix it each time
tha
mlaurent added a comment.
"This kind of thing should only be added to the developer's personal build
flags, or to CI."
on CI without this flags in module is just not a good idea.
After that I use in pim* and it's not a problem. If a people wants to use new
qt (as David :) ) he will fix
mlaurent added a comment.
"If a user of the last PIM release (as in, a person or a distro) wants to use
Qt 5.14, they'll get compilation errors, unnecessarily." and he will fix it :)
not a bad idea :)
"if (EXISTS "${CMAKE_SOURCE_DIR}/.git")" I like this idea.
REPOSITORY
R237 KConfig
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
It seems ok for me. +2
REPOSITORY
R276 KItemViews
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23816
To: dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24468
To: kossebau, #frameworks, cfeck, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, micha
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R306 KParts
BRANCH
deprecatedapi
REVISION DETAIL
https://phabricator.kde.org/D24467
To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
deprecatedapi
REVISION DETAIL
https://phabricator.kde.org/D24466
To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D23802
To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R310 KTextWidgets
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24595
To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R103 KMenu Editor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24603
To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampalo
mlaurent added reviewers: dvratil, vkrause.
REPOSITORY
R7 Konversation
REVISION DETAIL
https://phabricator.kde.org/D24597
To: ahmadsamir, #konversation, dvratil, vkrause
Cc: kde-frameworks-devel, #konversation
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems ok for me
REPOSITORY
R302 KIconThemes
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24608
To: kossebau, #frameworks, cfeck, mlaurent
Cc: m
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R279 ThreadWeaver
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24651
To: kossebau, #frameworks, mirko, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michael
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R268 KGlobalAccel
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24643
To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems ok for me
REPOSITORY
R304 KNewStuff
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24681
To: kossebau, #frameworks, leinir, mlaurent
Cc: ml
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems ok for me
REPOSITORY
R265 KConfigWidgets
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24497
To: kossebau, #frameworks, mlaurent
Cc: mlaur
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R269 BluezQt
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24707
To: kossebau, #frameworks, drosca, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R301 KEmoticons
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24710
To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R284 KCompletion
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24495
To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24611
To: kossebau, #frameworks, bruns, mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lot
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24600
To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michael
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems ok for me
REPOSITORY
R235 Attica
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24650
To: kossebau, #frameworks, gladhorn, leinir, mlaurent
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems ok for me
REPOSITORY
R237 KConfig
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24496
To: kossebau, #frameworks, mlaurent
Cc: mlaurent, kd
501 - 600 of 806 matches
Mail list logo
