lbeltrame added a reviewer: Frameworks.
lbeltrame added a subscriber: kde-frameworks-devel.
REPOSITORY
R563 Polkit-1 Qt Library
REVISION DETAIL
https://phabricator.kde.org/D18845
To: mgerstner, #frameworks
Cc: kde-frameworks-devel
lbeltrame added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19001
To: mgerstner, dhaumann, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
lbeltrame added reviewers: dhaumann, cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19001
To: mgerstner, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM!. Annoyed me for a long time (and made hard to debug some issues).
INLINE COMMENTS
> externalextractor.cpp:120
> extractorProcess.start(d->mainPath, QStringList(), QIODevice
lbeltrame added reviewers: Frameworks, Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D19698
To: mlaurent, dfaure, #frameworks, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
agree. I can't speak for seasoned developers, but I've found
myself in a situation (more than once) where the fix is trivial (compile
error, missing ";", etc) and being forced to go through review would (IMO)
unnecessarily raise friction.
--
Luca Beltrame
GPG key ID: A2
to shreds)
Pre-commit CI (i.e. once the switch to GitLab occurs) and perhaps direct
mailing to the user (as I suggested earlier) in case of continuous failures
will also help.
If this thing works, one can gradually ramp up the requirements of things that
go through review when the "muscle me
s
repositories managed by different groups. Some are very used to reviews,
others not (and not necessarily PIM).
Hence the (even debatable, if you may) proposal.
--
Luca Beltrame
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
im it may work 100%, but I've seen other communities (many, many
years ago) where a "semi anarchy" replaced by "iron-gripped rules" from one
day to another actually killed them.
--
Luca Beltrame
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
7;m neither on the side of "review all the things" nor on the
anarchist side. I just want to make sure we don't engage in policies that can
be (potentially, just potentially) harmful for some parts of KDE (while they
are perfectly OK for others).
--
Luca Beltrame
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
openSUSE, where I usually don't subscribe to failure notifications
(almost 300 packages is overkill) but a bot starts pestering me with mails the
moment build failures go unfixed (granted, the time scale is different).
For the first, I'd like people more involved in the development to s
lbeltrame added a comment.
+1.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20465
To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
lbeltrame added reviewers: apol, vkrause.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20509
To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D20594
To: broulik, #plasma, mart, hein, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame added a reviewer: Frameworks.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D20659
To: fvogt, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame added a comment.
I confirm there are no more issues in valgrind after adding this patch.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D20659
To: fvogt, #frameworks
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame added a subscriber: cgiboudeaux.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D21313
To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh,
ngraham, bruns
lbeltrame removed a subscriber: cgiboudeaux.
lbeltrame added a reviewer: cgiboudeaux.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D21313
To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns
lbeltrame added a comment.
+1
REPOSITORY
R311 KWallet
REVISION DETAIL
https://phabricator.kde.org/D21002
To: bruns, #frameworks, cfeck, ngraham
Cc: lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham,
bruns
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R824 Baloo Widgets
BRANCH
bulk_query
REVISION DETAIL
https://phabricator.kde.org/D21004
To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame
Cc: domson, ashaposhnikov, astippich, spoorun
Il giorno Tue, 24 Jan 2017 00:01:29 -0800
John Salatas ha scritto:
Hello,
> I just built a trigram data file (attached) for Greek language using
> a wikipedia dump as corpus. Can I just push it to sonnet's git or do
> I need to generate a differential review in phabricator or something?
I had
lbeltrame added reviewers: Build System, skelly, Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, skelly, #frameworks
Cc: #frameworks
lbeltrame added reviewers: skelly, Build System, Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4510
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, skelly, #build_system, #frameworks
Cc: #frameworks
lbeltrame added a comment.
> - Does that affect other platforms such as Windows in any way? I.e., does
KAuth exist on Windows?
KAuth had backends for OSX and Windows. Whether they are working or just
stubs however, I don't know.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://ph
lbeltrame added a comment.
+1, we have the same problem in openSUSE.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5289
To: heikobecker, #frameworks, #build_system, skelly, kfunk
Cc: lbeltrame
lbeltrame added a comment.
In https://phabricator.kde.org/D4847#101088, @ivan wrote:
> @lbeltrame
>
> I don't really see 'reasoning' in that report more than something that
sounds like 'polkit is a hack to replace suid for setting the system time and
time zone'.
That said, th
lbeltrame added a comment.
Notice from downstream integration: this feature is considered an "abuse" of
the Polkit system and at least openSUSE will explicitly disable it. See
https://bugzilla.suse.com/show_bug.cgi?id=1033055 for the reasoning.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
ranches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n/
_log
[2] https://marc.info/?t=14910810231&r=1&w=2
--
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto:
> https://build.opensuse.org/build/
> home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n/
> _log
As these build logs are only available to users logged in the OBS, the
error is pasted here as
thrown by ki18n (when it does not build) or I'd
have attempted to fix it myself...
--
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
lbeltrame added a comment.
+1, I assume there are no tests for this functionality already present?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks
Cc: lbeltrame
lbeltrame added a reviewer: andreaska.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5646
To: patrickelectric, #kate, andreaska
Cc: #frameworks
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Looks fairly harmless to me. Perhaps wait one or two days more to see if
anyone chimes in.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D563
ce the code to find the problem?
From a quick discussion on #opensuse-kde, it may have to do with
QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII (which means that we have
strings somewhere).
I'll try to test later.
--
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B
signature.asc
Des
In data venerdì 5 maggio 2017 22:47:45 CEST, Luca Beltrame ha scritto:
> From a quick discussion on #opensuse-kde, it may have to do with
> QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII (which means that we have
My initial test suggests that indeed we have a problem somehow with strin
In data sabato 6 maggio 2017 00:01:09 CEST, Luca Beltrame ha scritto:
> I'll try rebuilding a few more times (the result is unreliable) and I'll
> report back.
False alarm: it wasn't the problem at all. I can't see what could be wrong
from the generated files.
--
lbeltrame added a comment.
Unfortunately this change causes crashes in KPart-using applications that do
stuff with their QActions with Qt 5.9. okular and kontact are affected, at
least.
This is a typical backtrace (got this from Eike, but I have the same):
#0 QAction::setEnabled
lbeltrame added a comment.
I'll test this and see how it goes.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart
Cc: lbeltrame, #frameworks
lbeltrame added a reviewer: lbeltrame.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart, lbeltrame
Cc: lbeltrame, #frameworks
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Tested, works (neither kontact nor okular crash with this change).
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart, lbeltrame
lbeltrame added a reviewer: lbeltrame.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D5981
To: aacid, lbeltrame
Cc: lbeltrame, #frameworks
lbeltrame added a comment.
I'll try to test and report back.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D5981
To: aacid
Cc: lbeltrame, #frameworks
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5981
To: aacid, lbeltrame
Cc: lbeltrame, #frameworks
lbeltrame added a comment.
A small number of reviews (this thing is huge). One question: would it be
possible to have the bindings per-framework, rather than a single, long list?
This is also what made PyKDE4 unwieldy. IOW, each Framework should ship their
(optional) bindings.
We can put
Git commit db3bc821814117d765acec2d773ca6a1a40fddcd by Luca Beltrame.
Committed on 18/09/2017 at 13:03.
Pushed by lbeltrame into branch 'master'.
Relicense some files to LGPL2.1+
This has been done with approval from the original authors (including
myself).
Some are still GPL-2
In data lunedì 18 settembre 2017 15:32:16 CEST, Martin Klapetek ha scritto:
> Absolutely, I hereby give you the permission to relicense those files to
> LGPL2.1+.
> CC'ing frameworks devel to retain a public record of that.
Thanks a lot!
--
Luca Beltrame - KDE Forums team
KDE Sci
Git commit 62b8e461f2e5979180e1753651cc34dc5f3eb3b7 by Luca Beltrame.
Committed on 18/09/2017 at 13:39.
Pushed by lbeltrame into branch 'master'.
Relicense to LGPL2.1+ (part 2)
Permission granted by the author (Martin Klapetek)
CCMAIL: martin.klape...@gmail.com
CCMAIL: kde-framew
lbeltrame added a comment.
A screenshot before/after (or just after, since it is an addition) would be
helpful in this case, since it is a visual change.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7929
To: fvogt, #frameworks
Cc: lbeltrame, #frameworks
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Trivial change, LGTM.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8069
To: fvogt, #frameworks, graesslin, lbeltrame
Cc: lbeltrame,
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM.
REPOSITORY
R291 KPty
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8070
To: fvogt, #frameworks, lbeltrame
Cc: lbeltrame, #frameworks
ng through the comments...)
Is it added at compile time? I didn't read through the diff yet, but
how would you define a "development" build?
This is to make sure that no such things are put in released versions,
which would cause problems with reproducible builds.
--
Luca Beltrame
lbeltrame added reviewers: Frameworks, svuorela.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D8546
To: vkrause, #frameworks, svuorela
Cc: #frameworks
Hello,
thanks to kdebugsettings and category files, now it is possible to easily
enable/disable debugging at runtime. However, there are a few shortcomings to
this approach, which emerged when I tried to package KF5 5.41 for openSUSE:
1. There should be a macro in ECM to unify the installation
lbeltrame added a reviewer: fvogt.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system
lbeltrame added a comment.
For those who wonder why this would be necessary, see
https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudea
Git commit 029da62886e0571dfbe54cc4433af8ae8ac3433d by Luca Beltrame.
Committed on 12/01/2018 at 12:41.
Pushed by lbeltrame into branch 'master'.
Do not cache root password for the whole session
With something as KIO, this is *really* bad as further actions will
*not* get any password
ouble prompts are bad UX, but better than a program potentially making abuse
of a persistent file action as root.
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
w I do this again in the same session, after removing the file:
kioclient5 copy /mnt
No password prompt and the file is copied anyway.
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B
signature.asc
Description: This is a digitally signed message part.
In data venerdì 12 gennaio 2018 14:42:39 CET, Luca Beltrame ha scritto:
> No password prompt and the file is copied anyway.
To clarify, this happened before my change to Persistence.
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B
signature.asc
Description: T
Il giorno Fri, 12 Jan 2018 19:10:07 +0530
chinmoy ranjan ha scritto:
> Persistence =session or always both are same and will cache the
> password for 5 mins.
I'll do another check by adjusting again the persistence. However I'm
still not sure about caching passwords in file operations. KIO can d
nt state we can not recommend anyone to enable this.
However, we hope that those issues can be addressed, it does provide some
useful functionality.
Luca Beltrame
on behalf of the openSUSE KDE Team
Il giorno Sun, 14 Jan 2018 11:12:15 +0100
Elvis Angelaccio ha scritto:
> No, it's not. Despite the name, 'Persistence=session' just means the
> privilege is kept for a few minutes.
As discussed on IRC, this is an "issue" due to the fact that KIO can do
much more than other KAuth-enabled program
lbeltrame added inline comments.
INLINE COMMENTS
> statuscommand.cpp:111
> + if (tr.hasDocument(id)) {
> + out << i18n("Basic indexing done");
> + } else if (cfg.shouldBeIndexed(filePath)) {
If we want output of `balooctl status ` to be parseable, then
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
translated
REVISION DETAIL
https://phabricator.kde.org/D9712
To: michaelh, #frameworks, vhanda, smithjd, lueck, lbeltrame
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure
lbeltrame added a comment.
Examples of each output would be nice.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9958
To: michaelh, #frameworks, vhanda, smithjd, lbeltrame
Cc: ngraham
lbeltrame added a comment.
I'm not too fond of assembling JSON by hand, but I guess it was done to avoid
dependencies for a tool that's supposed to be simple. I'll let others weigh in
on this.
Did you test this change also with filenames with Unicode characters or
non-Latin characters?
IN
lbeltrame added a comment.
+1. @broulik How does it look on your side wrt the QJsonDocument usage?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9958
To: michaelh, #frameworks, vhanda, smithjd, lbeltrame
Cc: broulik, ngraham
lbeltrame added a comment.
In https://phabricator.kde.org/D9958#192860, @michaelh wrote:
>
> The --format look like a global switch. I don't like that. Couldn't find
a(n easy) way to avoid that. Do you know one?
> The subcommands are defined as posititional arguments afte
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone
objects, then you can land this.
REPOSITORY
R293 Baloo
BRANCH
formatting
REVISION DETAIL
https://
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM.
REPOSITORY
R293 Baloo
BRANCH
search-summary
REVISION DETAIL
https://phabricator.kde.org/D9959
To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame
lbeltrame added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9983
To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
translate-all (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9989
To: michaelh, smithjd, #frameworks, vhanda, lueck, lbeltrame
Cc: ngraham
lbeltrame added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Ping? Why this has not been committed even if in "accepted" state?
REPOSITORY
R127 KWayland
BRANCH
subsurface-parent-destroyed
REVISION DETAIL
https://phabricator.kde.org/D10300
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Looks OK to me with some changes (for readability).
INLINE COMMENTS
> fileindexerconfig.h:50
> /**
> - * The folders to search for files to analyze. Cached and cleaned up.
>
lbeltrame added inline comments.
INLINE COMMENTS
> fileindexerconfig.h:25
> +#include
> +#include
>
I just noticed this. Can you do the #include changes as part of a separate
commit?
REPOSITORY
R293 Baloo
BRANCH
publicdescriptions (branched from master)
REVISION DETAIL
https://phab
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
For what it's worth, LGTM .
REPOSITORY
R293 Baloo
BRANCH
expose_canbesearched (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10661
To: michaelh, #baloo, #
lbeltrame added a comment.
+1 from me, fixes the issue I had.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10764
To: broulik, #plasma, mart, lbeltrame
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, ab
lbeltrame added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10273
To: chinmoyr, #frameworks, dfaure
Cc: ossi, thiago, dfaure, michaelh
lbeltrame added a reviewer: Frameworks.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D10824
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks, michaelh
lbeltrame created this revision.
lbeltrame added reviewers: Frameworks, ochurlaud.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Documentation.
lbeltrame requested review of this revision.
REVISION SUMMARY
A number of distributions u
This revision was automatically updated to reflect the committed changes.
Closed by commit R281:d3c573483257: cmake: don't flag libnm-util as found
when ModemManager is found (authored by aleksanderm, committed by lbeltrame).
REPOSITORY
R281 ModemManagerQt
CHANGES SINCE LAST UPDATE
https://p
lbeltrame created this revision.
lbeltrame added reviewers: Frameworks, ochurlaud.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Documentation.
lbeltrame requested review of this revision.
REVISION SUMMARY
These files are meant to be
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:27a1126b1d79: Look first for qhelpgenerator-qt5 for help
generation (authored by lbeltrame).
REPOSITORY
R264 KApiDox
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11315?vs=29468&id=29538
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:642fd8a06fca: Remove shebangs from non-executable files
(authored by lbeltrame).
REPOSITORY
R264 KApiDox
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11330?vs=29501&id=29539
REVISION DE
lbeltrame added a comment.
+1
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15113
To: fvogt, #frameworks
Cc: lbeltrame
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM.
INLINE COMMENTS
> sip_generator.py:752
> #
> -return "".join(extract).replace("\n", " ")
> +return b''.join(extract).decode('utf-8').replace("\r\n", "
lbeltrame added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15426
To: fvogt, #frameworks, elvisangelaccio, dfaure
Cc: ngraham, bruns, kde-frameworks-devel, michaelh
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Looks OK to me.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15867
To: bruns, #frameworks, apol, lbeltrame
Cc: lbeltrame, kde-frameworks-devel
lbeltrame added a comment.
+1, looks fine to me as far as I understand.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D16255
To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, br
lbeltrame added a comment.
+1, but I'd like to hear people more experienced than me.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16311
To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
The changes look sane to me. Perhaps wait a couple more days until any other
objection is raised, then if not, commit away.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabrica
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
indexer_cleanup
REVISION DETAIL
https://phabricator.kde.org/D16255
To: bruns, #baloo, #frameworks, poboiko, ngraham, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov
lbeltrame added a comment.
Generally looks OK to me, one note on `QDir::separator()` usage.
INLINE COMMENTS
> xmlextractortest.cpp:38
> +{
> +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) +
> QDir::separator() + fileName;
> +}
IIRC you shouldn't use `QDir::separator()`. See
ht
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
qdir_separator
REVISION DETAIL
https://phabricator.kde.org/D16505
To: bruns, #frameworks, #baloo, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,
lbeltrame added a comment.
In general (for my limited Baloo knowledge) this makes sense. You might want
to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham
or someone from the bugsquad may help).
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.o
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
extractor
REVISION DETAIL
https://phabricator.kde.org/D16524
To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astip
lbeltrame added a comment.
+1.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D16305
To: fvogt, #frameworks
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
extractor
REVISION DETAIL
https://phabricator.kde.org/D16523
To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, mich
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D17090
To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippic
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM; just a minor change needed.
INLINE COMMENTS
> basicindexingjob.cpp:153
> +//{"application/vnd.ms-excel", Type::Document},
> +//{"application/vnd.ms-excel", Type:
101 - 200 of 232 matches
Mail list logo
