graesslin accepted this revision.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6974
To: dfaure, graesslin, mart
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart,
graesslin added inline comments.
INLINE COMMENTS
> datadevice_interface.cpp:206
> +if (!otherSelection) {
> +return sendClearSelection();
> +}
please use a dedicated line for the return here.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To:
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Nevertheless I still think we should also ship my review. Rather a null check
too many than too few.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7296
To: dfaure, graesslin
Cc: #frameworks
graesslin added a comment.
ping! This is a crash fix.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To: graesslin, #kwin, #plasma, #frameworks
Cc: plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, eliasp, sebas, apol,
graesslin added a comment.
> the send_selection spec says we should be passing a null resource if we
have no selection, whereas this version creates a data offer with nothing in it.
But we have a selection, that's the point. We just don't have a datasource on
the selection.
graesslin added a comment.
Sorry for having missed your pings. I have something like 1000 unread mails
in the frameworks folder :-(
Your change caused a regression in KWin and now a unit test is failing.
Please see:
graesslin added a comment.
I like that refactoring - though processAt might not be the best fitting
name. Don't have a good name idea, maybe findChildSurfaceAt?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: subdiff, #frameworks, graesslin
Cc:
graesslin added a comment.
> If your patch works, then mine would too. It's checking the exact same
pointer, just one frame earlier.
But then it's an easy thing: let's do both. Your patch and mine.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To:
graesslin added a comment.
In https://phabricator.kde.org/D7078#135036, @davidedmundson wrote:
> > So from KWayland Server side we have a selection
>
> from KWayland server side we have a Seat:selection, we don't check if that
has a DDI::selection
>
>
>
> If a client
graesslin added a comment.
@dfaure please note that I already worked around the regression in KWin
master.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: bcooksley, graesslin, #frameworks
graesslin added a comment.
To me the question is rather: can we ensure that other users of KKeyServer
didn't get broken by the change. What KWin did could be considered a bug or an
application misuse. KWin used the Qt key and compared it directly to
Qt::Key_Enter. That one doesn't work
graesslin updated this revision to Diff 16660.
graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Make this compile. Looks like kdevelop fooled me and compiled KWin instead of
KWayland (that happens all the time to me)
REPOSITORY
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930.
When Qt closes a window due to a key press
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client
destroys the focused surface (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6683?vs=16755=16775#toc
REPOSITORY
graesslin added a comment.
I like the idea! That would basically allow us to abandon
https://phabricator.kde.org/D6571 and would also solve the issues we see with
the kwayland-integration plugin which can crash applications on exit.
May I ask for a small unit test for the new
graesslin added a comment.
In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote:
> We still need https://phabricator.kde.org/D6571, with my proposed change.
That's a special case where we delete the connection before the QPA.
It might be that we don't need it. Also
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
ASAN found a heap-use-after-free when deleting the focused keyboard
surface in the client library. Keyboard did not
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff
just for pointer.
REPOSITORY
R127
graesslin updated this revision to Diff 16406.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Use mutex to protect the potentially shared data structure
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin added a comment.
@davidedmundson if you have another idea how to tackle the problem I'm
absolutely open to it.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6569
To: graesslin, #frameworks, #plasma, #kwin
Cc: davidedmundson, dfaure, plasma-devel,
graesslin added a comment.
Erm why was this pushed although it was in state changes requested?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot,
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is change needed by KWin. KWin has the problem that it destroys its
internal Wayland connection (KWin as client
graesslin added a comment.
In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote:
> I don't think this is necessary.
>
> The only times we want need to delete the connection ourselves is when
client code is creating it via ConnectionThread::fromApplication. If they
graesslin added a dependent revision: D6571: Delete all Wayland connections by
plugins prior to own Wayland connection.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6569
To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot, progwolff,
graesslin planned changes to this revision.
graesslin added a comment.
Causes crash in KWayaland when closing a window.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6683
To: graesslin, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
graesslin updated this revision to Diff 16755.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Add nullptr check to prevent crash
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:bea87753629e: [client] Properly track enteredSurface in
Keyboard (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6741?vs=16786=16797
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff
just for text input.
TEST PLAN
graesslin added a comment.
Your commit message has a typo where X is written but Wayland is meant.
INLINE COMMENTS
> dialog.cpp:1160
>
> -if (ee->region().isNull()) {
> +if (ee->region().isNull() || KWindowSystem::isPlatformX11()) {
> return
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:706a4771803d: [server] Send text input leave if focused
surface gets unbound (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:e4c90bf90717: [client] Track all created
ConnectionThreads and add API to access them (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D6727
To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6946
To: davidedmundson, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a00a5d5e1c97: [server] Send pointer leave if focused
surface gets unbound (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
please add a test case for the problem.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc:
graesslin added a comment.
But then the root problem of not having an ifdef branch as fallback is also
not fixed.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah, graesslin
Cc: graesslin, bshah
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Sorry to say, but the approach is wrong in general. The problem is that the
platform is runtime selected and not compile time. This patch fixes a very
special case which
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please verify that this does not break Qt! (Qt has a very special handling of
subsurfaces and we have lots of workarounds for Qt there)
Also please add a unit test
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This crash got triggered in KWin when sending the selection to XWayland.
While the test handles condition of not yet
graesslin added a comment.
In https://phabricator.kde.org/D7078#134111, @davidedmundson wrote:
> Isn't the real bug from that trace here:
>
> datadevice_interface.cpp:204
> void DataDeviceInterface::sendSelection(DataDeviceInterface *other)
>
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
mart/xdgforeign
REVISION DETAIL
https://phabricator.kde.org/D7460
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff,
graesslin added a comment.
I'm still in favor of pushing this one too.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To: graesslin, #kwin, #plasma, #frameworks
Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot,
progwolff, lesliezhai,
graesslin added inline comments.
INLINE COMMENTS
> registry.h:938-939
> +
> +XdgExporterUnstableV1 *createXdgExporterUnstableV1(quint32 name, quint32
> version, QObject *parent = nullptr);
> +XdgImporterUnstableV1 *createXdgImporterUnstableV1(quint32 name, quint32
> version, QObject
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7379
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
graesslin added a comment.
In https://phabricator.kde.org/D5747#108916, @apol wrote:
> Who is going to be setting this pid? Because note that containerized
applications don't know their own pid (see kdbusaddons & knotifications patches
for big shrug).
It's KWin. Who gets the
graesslin added a comment.
In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote:
> It makes absolutely no sense to have a pidChanged signal and then say
clients shouldn't be using it.
>
> Either window has no reason to have a pidChanged signal or we should
connect to
graesslin added inline comments.
INLINE COMMENTS
> plasmawindowmodel.cpp:84
>
> +QObject::connect(window, ::pidChanged, q,
> +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }
In the original report I critized that we connect to a pid changed signal. That
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Are you sure the API is so compatible that you can run it like that?
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D5801
graesslin added inline comments.
INLINE COMMENTS
> plasmawindowmodel.cpp:84-86
> +QObject::connect(window, ::pidChanged, q,
> +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }
> +);
I consider it as impossible that the PID changes.
REPOSITORY
R127
graesslin added inline comments.
INLINE COMMENTS
> test_plasma_window_model.cpp:214
>
> void PlasmaWindowModelTest::testRoleNames_data()
> {
Please extend this
> test_plasma_window_model.cpp:306
>
> void PlasmaWindowModelTest::testDefaultData_data()
> {
Please extend this
REPOSITORY
graesslin added inline comments.
INLINE COMMENTS
> test_plasma_window_model.cpp:215
>
> void PlasmaWindowModelTest::testRoleNames_data()
> {
Please extend this
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc:
graesslin added a comment.
Forget my last two comments - confused the review
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
graesslin added a comment.
In https://phabricator.kde.org/D5757#108706, @hein wrote:
> Martin, did you mix things up here maybe? The patch has changes to
autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't
related to QAIM. It's a row of test data.
no, I
graesslin added a comment.
In https://phabricator.kde.org/D5757#108115, @mart wrote:
> In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
>
> > Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
>
>
> isn't it covered by
no,
graesslin requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr,
graesslin added a comment.
In https://phabricator.kde.org/D5872#109962, @hein wrote:
> I'm fine with no change signal, but heads-up that libtaskmanager has code
connecting to it, so if you remove it from kwayland please also adapt
plasma-workspace or the build breaks.
I highly
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R127 KWayland
BRANCH
asdfasdf
REVISION DETAIL
https://phabricator.kde.org/D5887
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel,
graesslin added a comment.
Your tests in plasma window management do not test the new requests.
INLINE COMMENTS
> test_wayland_windowmanagement.cpp:483
> +using namespace KWayland::Server;
> +// this test verifies setting the showing desktop state
> +
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> plasmawindowmodel.cpp:84
>
> +
> QObject::connect(window, ::activeChanged, q,
Unrelated newline
> plasma-window-management.xml:263
> +
>
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
sebas/processid
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
graesslin reopened this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Can reproduce the failing test locally. Please fix ASAP! Broken tests is not
acceptable in KWayland. This change has been on review so long, I find it quite
disappointing that it was
graesslin added a comment.
like David explained: we don't need the change signal and IMHO we shouldn't
expose "wrong API". I consider having a changed signal for a PID wrong API as
it indicates that the PID could change. But it won't ever change, so we
shouldn't expose it. I know that all
graesslin added a comment.
could you please upload a version with context?
INLINE COMMENTS
> mart wrote in xdgshell_interface.h:80
> from kwin, client.cpp:
> i guess that's the kwin part that will have to use this.
> it uses a single timer, and tries for a couple of timeout, as soon as the
graesslin added a comment.
In https://phabricator.kde.org/D6047#119698, @mart wrote:
> trying to implement the kwin part of ping btw, will do in a branch of the
branch kwin/xdgv6
no need to hurry with it. IMHO the way ping works is completely broken and
won't work. At least Qt
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Eh what? That is not thread save?!? Oh sh*** I didn't expect that. Good catch
and a nice solution.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kkeyserver.cpp:160-180
> +{ Qt::Key_Space, XK_KP_Space },
> +{ Qt::Key_Tab,XK_KP_Tab },
> +{ Qt::Key_Enter, XK_KP_Enter },
graesslin added a comment.
I need to point out that this creates a functional difference to Wayland and
according to the latest rules of Plasma such changes are no longer allowed
unless the implementation is done first for Wayland.
Personally I am not really comfortable with such a
graesslin added a comment.
> I need to point out that this creates a functional difference to Wayland
and according to the latest rules of Plasma such changes are no longer allowed
unless the implementation is done first for Wayland.
After reading through KWin code together with your
graesslin added inline comments.
INLINE COMMENTS
> kkeyserver.cpp:976-980
> +if (*keyQt != Qt::Key_Tab) { // KKeySequenceWidget does not map
> shift+tab to backtab
> +static const int FirstLevelShift = 1;
> +keySymX = xcb_key_symbols_get_keysym(symbols,
graesslin added a comment.
> Man it's demotivating to contribute to KDE. Users say all sorts of bad
things about KDE, and then future-ex-maintainers reject your contribution.
Great.
Yes sure, and you can imagine how many angry mails and bug reports I get when
things break. I made the
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please also extend the autotests/client/test_wayland_windowmanagement.cpp
INLINE COMMENTS
> plasmawindowmanagement.h:385
> + * @returns The process id this window
Am 2017-05-05 18:37, schrieb Detlef Eppers:
File indexing tools encounter all different types of files, both of
trusted and untrusted origin, and last November it was demonstrated by
Chris Evans how this can potentially be exploited*. In order to
provide a means for mitigation, I have written a
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart,
graesslin added a comment.
How do we know that this doesn't break other code? This code is for example
used in KWin's Alt+Tab handling which is it's own fair beast. Any changes here
might break the code as it might be bug-to-bug compatible.
We had the changes one month in master and
graesslin added a comment.
In https://phabricator.kde.org/D6233#145981, @dfaure wrote:
> Qt (at shortcut recording time) sees this as Meta+Shift+Print while
KWindowSystem (xcbKeyPressEventToQt) sees it as Meta+Shift+SysReq.
>
> Qt does xkb_state_key_get_one_sym( state=51 , code=6b )
on this release we must act quickly
and do a bug fix release for frameworks even if this is uncommon and
against the practice.
Sorry for any inconveniences.
Martin Flöser
KGlobalAccel maintainer
[1] https://bugs.kde.org/show_bug.cgi?id=384597
be someone on an X11 system to test what helps (maybe
Kai-Uwe?).
Cheers
Martin
Jonathan
On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote:
Hi all,
unfortunately I have to inform you that KGlobalAccel has a severe
regression [1] in the latest framework release resulting in many
Am 2017-09-13 20:28, schrieb Kai Uwe Broulik:
Hi,
either of the following reverts fix the problem for me:
KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d
or
KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and
32526718eae99ccb594360627586eebdf793372b
but perhaps both
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
What surprises me is that BlurManager recreates for Output changes. That
sounds like a bug in KWin (or an area which could be improved).
REPOSITORY
R127 KWayland
BRANCH
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in blur_interface.cpp:49
> I don't get that. So your patch is quite enough, treat this note as a noise :)
The cast method here is only called from callbacks. Wayland works by having a
global callback table where one just
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7885
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
graesslin added a comment.
I'm fine with the change, but when I thought about it, I was wondering
whether it would be better to have a dedicated interface. There is at least one
other Wayland compositor out there which implements the protocol and I got
several requests about upstreaming it.
graesslin added inline comments.
INLINE COMMENTS
> broulik wrote in server_decoration_interface.h:147
> I think we support both (doing a KService lookup if no complete path given),
> imho "name" would also be consistent with what KConfig uses
Nothing better than looking into the source:
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KWindowSystem has an API to know which platform it is on. It's better to
use that one instead of duplicating the logic again and again.
graesslin added inline comments.
INLINE COMMENTS
> desktopfileparser.cpp:547
> +
> +for(const auto : deserializeList(value)) {
> // some .desktop files still use the legacy ServiceTypes= key
Be careful with for and qt containers. This causes a detach. Either use
graesslin created this revision.
graesslin added reviewers: Frameworks, Flatpak, apol.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Flatpak isn't a real platform, but uses either "xcb" or "wayland". Thus
we need to detect which one it is. With
graesslin added a comment.
Do you have commit rights or should someone else push the patch? If the
latter could you please upload a patch as a git formatted patch? I just tried
to import this one and it fails due to no CMakeLists.txt.old in the repo.
REPOSITORY
R303 KInit
REVISION DETAIL
graesslin added a comment.
In https://phabricator.kde.org/D7369#153978, @mart wrote:
> In https://phabricator.kde.org/D7369#152358, @graesslin wrote:
>
> > Documentation is still missing, Unstable suffix is still in two many API
calls.
>
>
> i think the
graesslin added a comment.
One of our CI jobs is no longer happy:
13:02:41 -- The following REQUIRED packages have not been found:
13:02:41
13:02:41 * Wayland (required version >= 1.13) , C library implementation
of the Wayland protocol: a protocol for a compositor to talk to
graesslin added a comment.
In https://phabricator.kde.org/D8296#155363, @ngraham wrote:
> Sounds good. What's lxr?
lxr.kde.org
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik, #frameworks
graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The OSDs are positioned by the Wayland compositor. This fixed the issue
found in
graesslin added a comment.
@davidedmundson The CI image is updated, you can push this now.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8050
To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ecd00a565a99: Dont position a Dialog if its
of type OSD (authored by graesslin).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8321
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
graesslin added a comment.
Agree with Kai - this needs good testing that it is not used anywhere. Best
by looking through lxr which apps use this framework.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik,
graesslin added a comment.
I'm sorry but it still deadlocks, see
https://bugs.kde.org/show_bug.cgi?id=385867
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8321
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff,
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Ahhh. That's of course tricky to spot in this change ;-)
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson,
graesslin added a comment.
I don't see in the change what you describe. This seems to be just a
refactoring.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
graesslin accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot,
alexeymin, progwolff, lesliezhai, ali-mohamed,
1 - 100 of 244 matches
Mail list logo
