D5712: Validate surface is valid when sending TextInput leave event

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Thanks for adding the test! REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D5712 To: davidedmundson, #plasma, graesslin Cc: apol,

D5712: Validate surface is valid when sending TextInput leave event

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please add a unit test case. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5712 To: davidedmundson, #plasma, graesslin Cc: graesslin,

Re: KWallet::openWallet and 0-WinId ?

Am 2017-05-01 17:33, schrieb Martin Koller: Hi, the Wallet::openWallet() documentation says for the WinId argument: "The window id to associate any dialogs with. You can pass 0 if you don't have a window the password dialog should associate with." However passing 0 gives a runtime warning

D5556: build: Remove KService dependency

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: #frameworks

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. In https://phabricator.kde.org/D5521#103818, @palokisa wrote: > In https://phabricator.kde.org/D5521#103810, @graesslin wrote: > > > The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. > > > I've

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. oh and yes for removing service dependency please open a separate review. The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. So a possibility could be to move the binary out and replace it by a binary which

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. In https://phabricator.kde.org/D5521#103778, @palokisa wrote: > In https://phabricator.kde.org/D5521#103775, @cfeck wrote: > > > Btw, libKF5GlobalAccel is actually Tier1, so applications needing global shortcuts will not have any (additional) KF5

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. In https://phabricator.kde.org/D5521#103661, @palokisa wrote: > > Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE > > Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt`

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. I don't really understand what this change is supposed to fix. Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE. If kglobalaccel is shipped without KCrash support I would consider this as a

D5503: No "KDE Daemon" in password dialogs

graesslin added a comment. not that "KDE Daemon" is a good name, but what about i18n it? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks Cc: graesslin, apol, mck182

Re: KAuth buildability: new CI architecture

Am 2017-04-17 06:49, schrieb Ben Cooksley: On Mon, Apr 17, 2017 at 12:48 AM, Martin Gräßlin <mgraess...@kde.org> wrote: Am 2017-04-16 13:52, schrieb Ben Cooksley: On Sun, Apr 16, 2017 at 11:09 PM, Harald Sitter <sit...@kde.org> wrote: Not particularly related to the issue at

Re: KAuth buildability: new CI architecture

Am 2017-04-16 13:52, schrieb Ben Cooksley: On Sun, Apr 16, 2017 at 11:09 PM, Harald Sitter wrote: Not particularly related to the issue at hand (which is probably polkitqt having meh cmake files), but relocating stuff in general is sper unreliable and I would absolutely

D5405: Create desktop file name based on organization domain unless set explicitely

graesslin added a comment. In https://phabricator.kde.org/D5405#101628, @stikonas wrote: > Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. My comment was not meant as a stop-this-effort comment. If we can

D5405: Create desktop file name based on organization domain unless set explicitely

graesslin added a comment. In https://phabricator.kde.org/D5405#101626, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > > > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > > > In https://phabricator.kde.org/D5405#101615,

D5405: Create desktop file name based on organization domain unless set explicitely

graesslin added a comment. In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are

D5405: Create desktop file name based on organization domain unless set explicitely

graesslin added a comment. The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application

D5174: Add support for wl_shell_surface::set_popup and popup_done

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c89a61d2d17: Add support for wl_shell_surface::set_popup and popup_done (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D5174: Add support for wl_shell_surface::set_popup and popup_done

graesslin added a dependent revision: D5177: Initial support for popup window handling. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5174 To: graesslin, #plasma_on_wayland, #frameworks, #kwin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5174: Add support for wl_shell_surface::set_popup and popup_done

graesslin created this revision. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This extends the client side API to support creating popup ShellSurface windows and the server side API to send out

D5134: Don't exit if $DISPLAY is not set

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. As I stumbled over that years ago: sorry I don't think that this is the proper solution. This is basically https://phabricator.kde.org/T4431 which is not yet implemented.

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Am 13. März 2017 16:15:34 MEZ schrieb Kai Uwe Broulik : >‎ >> Macs however always have two-fingers secondary click; their magic >mouse have both (it's mouse-touchpad hybrid). > >If all else fails you could still Control click on Mac iirc. > >This feature would be useful

[Differential] [Changed Subscribers] D4847: KAuth integration in document saving

graesslin added subscribers: davidedmundson, graesslin. graesslin added a comment. I really like what I see here! Just a thought: what happens if the file is not owned by root, but e.g. by www-data? If I understand the code correctly it might change to be owned by root due to the usage

Re: kwin requires qt5.7.0

Am 2017-02-26 18:00, schrieb Allen Winter: I thought Qt5.6 was the minimum required? Just asking. I don't care that much but I need to install Qt5.7 , which of course I can do. As Luigi already wrote: wrong list for this topic. KWin is part of Plasma and follows Plasma's minimum Qt

Re: Review Request 126724: Expose callingUser in HelperSupport if available

iew102607 --- On Jan. 12, 2016, 10:36 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

graesslin added a comment. I would say it is enough to just make plasma grab the interface early enough. It would result in the popups not show. We don't need to show those notifications. It is a bug in ksplash that the popups are visible at all. Another alternative could be to

Re: Review Request 129967: Make KGlobalaccel X11 track XInput events to still work when an application grabs the keyboard

and the key event is not handled and one of the special keys which the application does not care about, it could close the context menu and XTest the event again. Then kglobalaccel would be able to handle it. - Martin Gräßlin On Feb. 24, 2017, 5:26 p.m., David Edmundson wrote

Re: Review Request 129967: Make KGlobalaccel X11 track XInput events to still work when an application grabs the keyboard

around X11 limitations. - Martin Gräßlin On Feb. 24, 2017, 5:26 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

Am 19. Februar 2017 18:00:07 MEZ schrieb David Faure <fa...@kde.org>: >On dimanche 19 février 2017 12:51:39 CET Martin Gräßlin wrote: >> Am 19. Februar 2017 11:21:18 MEZ schrieb David Faure <fa...@kde.org>: >> >Result: the test app shows the keypress events f

[Differential] [Accepted] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc:

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added inline comments. INLINE COMMENTS > kcolorscheme.h:316-318 > + * from the given KConfig. If null, the application's > KDE_COLOR_SCHEME_PATH > + * property will be used to load a KConfig. If this is also unset, the > + * system colors will be used. I wouldn't mention

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added a comment. > That's not new, the property's been set here since at least the kdelibs split. I know, I was the one adding it :-) That's also why I think we could do that better than a property: it was intended as a way to communicate with the QStyle - the aim of the

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added a comment. This is a sensible idea, though I wonder whether we should put it into something more concrete than a QProperty on the qApp. INLINE COMMENTS > kcolorscheme.h:33-37 > +KSharedConfigPtr defaultConfig() { > +// Read from the application's color scheme file (as

[Differential] [Commented On] D4587: [ContainmentInterface] Ungrab mouse on context menu close

graesslin added a comment. > Looks like Qt 5.8 has a grabber bug Then Qt should fix and not we workaround it. Also: how do you know whether your change will still work in Qt 5.7? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL

Re: Trusting .desktop files

Am 2017-02-10 19:56, schrieb Fabian Vogt: Hi, The reddit post "How to easily trick $FILE_MANAGER users to execute arbitrary code" (https://www.reddit.com/r/linux/comments/5r6va0) spawned a discussion about .desktop files. Thanks for bringing up this important topic! (Although I get more and

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

graesslin added a comment. In https://phabricator.kde.org/D4416#83019, @mck182 wrote: > In https://phabricator.kde.org/D4416#82951, @hein wrote: > > > Gnome-only spec? Why aren't they contributing to fd.o? > > > "Galago is dead, we took over, deal with it." > >

Re: Phabricator: All repositories registered - upcoming workflow changes

Am 1. Februar 2017 20:34:52 MEZ schrieb Ben Cooksley : >On Wed, Feb 1, 2017 at 9:48 PM, Milian Wolff wrote: >> On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote: >>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin > >>

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

documentation. I remember me cursing about the documentation being wrong quite often during the Qt 5 port. - Martin Gräßlin On Jan. 15, 2017, 6:10 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126758: Drop support for building with Qt 4

/CMakeLists.txt bc439658a623160522259485c89b39661e61 Diff: https://git.reviewboard.kde.org/r/126758/diff/ Testing --- compiles Thanks, Martin Gräßlin

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

graesslin added a comment. In https://phabricator.kde.org/D4201#78639, @apol wrote: > In https://phabricator.kde.org/D4201#78631, @graesslin wrote: > > > I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help?

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

graesslin added a comment. I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help? INLINE COMMENTS > kstartupinfoplugin.cpp:26 > +{ > +Q_OBJECT\ > +Q_PLUGIN_METADATA(IID "org.kde.KCrashHandlerPlugin") is the \

[Differential] [Changed Subscribers] D4175: Introduce a QCommandLineParser for kglobalaccel5

graesslin added inline comments. INLINE COMMENTS > main.cpp:63 > > +{ > +QCommandLineParser parser; Why did you scope the parser? REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D4175 EMAIL PREFERENCES

[Differential] [Accepted] D4141: Allow Tab as being modified by Shift

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D4141 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin Cc: #frameworks

[Differential] [Closed] D3690: Generate an instance with KSharedConfig::Ptr for singleton and arg

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e0db24223622: Generate an instance with KSharedConfig::Ptr for singleton and arg (authored by graesslin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

[Differential] [Changed Subscribers] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

graesslin added inline comments. INLINE COMMENTS > job.h:50 > KIOCORE_EXPORT QString buildHTMLErrorString(int errorCode, const QString > , > -const QUrl *reqUrl = 0, int method = -1); > +const QUrl *reqUrl = nullptr, int method = -1); > Question: is this change API and ABI

Re: Enabling Clang's -Wdocumentation in Frameworks...?

Am 2017-01-05 20:01, schrieb Kevin Funk: Heya, we all like up-to-date apidocs, right. I was pondering whether it would be feasible to globally activate Clang's - Wdocumentation warning in KDEFrameworkCompilerSettings.cmake in ECM, but we're running into too many issues at the moment, thus I

Re: CI Requirements - Lessons Not Learnt?

Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin <pri...@martin-graesslin.com> wrote: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI

Re: CI Requirements - Lessons Not Learnt?

Sorry picked wrong from address Am 2017-01-05 10:28, schrieb Martin Gräßlin: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system have gone completely unnoticed by (some) members

Re: Review Request 129648: New widget: tooltip that contains another widget

was what I meant. - Martin Gräßlin On Dec. 30, 2016, 11:27 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: To C++11 or not?

Am 2016-12-30 15:25, schrieb David Faure: On vendredi 30 décembre 2016 12:56:09 CET Albert Astals Cid wrote: El divendres, 30 de desembre de 2016, a les 12:24:38 CET, Luigi Toscano va escriure: > Il 30 dicembre 2016 10:30:22 CET, Kevin Funk ha scritto: > >Following-up on this

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

> On Dez. 30, 2016, 7:39 vorm., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to hav

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

. - Martin Gräßlin On Dec. 30, 2016, 12:48 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129648: New widget: tooltip that contains another widget

> On Dec. 29, 2016, 5:01 p.m., Martin Gräßlin wrote: > > src/ktooltipwidget.cpp, line 101 > > <https://git.reviewboard.kde.org/r/129648/diff/11/?file=488230#file488230line101> > > > > this won't work on Wayland, there is no global cursor pos. > > Elvi

[Differential] [Closed] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

This revision was automatically updated to reflect the committed changes. Closed by commit R268:4ea7687b11ec: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable (authored by graesslin). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE

Re: Review Request 129648: New widget: tooltip that contains another widget

tps://git.reviewboard.kde.org/r/129648/#comment68089> this won't work on Wayland, there is no global cursor pos. - Martin Gräßlin On Dec. 29, 2016, 11:11 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 129648: New widget: tooltip that contains another widget

out manually deleting it ;-) - Martin Gräßlin On Dec. 21, 2016, 7:43 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

c/platforms/osx/plugin.cpp (line 2) <https://git.reviewboard.kde.org/r/126291/#comment68038> Also not the author of this file. - Martin Gräßlin On Dec. 27, 2016, 5 p.m., René J.V. Bertin wrote: > > --

Re: Review Request 129706: Don't focus progress windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129706/#review101604 --- Ship it! Ship It! - Martin Gräßlin On Dec. 27, 2016

[Differential] [Closed] D3812: Deprecate Plasma::Package API in PluginLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4798310ed788: Deprecate Plasma::Package API in PluginLoader (authored by graesslin). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3812?vs=9366=9395

Re: Review Request 129706: Don't focus progress windows

- Martin Gräßlin On Dec. 26, 2016, 4:15 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Differential] [Request, 15 lines] D3812: Deprecate Plasma::Package API in PluginLoader

graesslin created this revision. graesslin added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As Plasma::Package is deprecated API using Plasma::Package should also be deprecated.

[Differential] [Accepted] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fixFileDialogDirectoryWithSelectUrl REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL

[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

graesslin added a comment. In https://phabricator.kde.org/D3689#70685, @aacid wrote: > > We can adjust the shortcuts without having side effects on other tests. > > Why not just delete the test file on start of each test? I like my tests not affecting other tests. If for

[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Dec. 18, 2016, 9:51 a.m., Martin Gräßlin wrote: > > src/kstatusnotifieritem.cpp, line 980 > > <https://git.reviewboard.kde.org/r/129665/diff/1/?file=487738#file487738line980> > > > > AFAIK show and showNormal is the same. What is the difference

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

tps://git.reviewboard.kde.org/r/129665/#comment67935> please don't mix coding style changes with other changes. src/kstatusnotifieritem.cpp (line 979) <https://git.reviewboard.kde.org/r/129665/#comment67936> AFAIK show and showNormal is the same. What is the difference here? - Martin Gräß

[Differential] [Closed] D3636: [kconfig_compiler] Improve documentation about Inherits

This revision was automatically updated to reflect the committed changes. Closed by commit R237:b4206d635444: [kconfig_compiler] Improve documentation about Inherits (authored by graesslin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9049=9112

Re: Review Request 129648: New widget: tooltip that contains another widget

> On Dec. 14, 2016, 8:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same

[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

graesslin updated this revision to Diff 9049. graesslin added a comment. Add missing "(" REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9046=9049 BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636 AFFECTED

[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

graesslin updated this revision to Diff 9046. graesslin added a comment. Constructor instead of ctor REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9018=9046 BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636

[Differential] [Request, 194 lines] D3690: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin created this revision. graesslin added reviewers: Frameworks, dfaure, mdawson. REVISION SUMMARY In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an

[Differential] [Updated] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

graesslin retitled this revision from "[runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable" to "KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable". REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D3689: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

graesslin created this revision. graesslin added a reviewer: Frameworks. REVISION SUMMARY The idea behind the env variable is to put kgloabalacceld into test mode and let it operate on a in-memory KConfig instead of the normal rc file. From auto tests in KWin we know that the

Re: Review Request 129648: New widget: tooltip that contains another widget

> On Dec. 14, 2016, 8:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same featur

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 27, 2016, 7:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM > > David Edmundson wrote: > To this specific patch, or the concept in general? To this s

Re: Review Request 129648: New widget: tooltip that contains another widget

behind. src/ktooltipwidget.cpp (lines 8 - 11) <https://git.reviewboard.kde.org/r/129648/#comment67922> Should we update the license header to the LGPLv2.1+ as in https://community.kde.org/Policies/Licensing_Policy#LGPL_Header Obviously applies for other files as well. - Martin G

[Differential] [Updated, 5 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

graesslin updated this revision to Diff 9018. graesslin added a comment. - fix typos - default instead of empty - add information about what the ctor is for - refer to KConfigSkeleton documentation REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

[Differential] [Request, 3 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

graesslin created this revision. graesslin added reviewers: Frameworks, dfaure. REVISION SUMMARY Better specify the requirements the parent class needs to have. KConfigCompiler generates different variants of ctors taking either: - a QStringLiteral argument (name set in - a

Re: Review Request 129607: Display Application version in About dialog header

rsions tab, > > when the version is already displayed. > > Luigi Toscano wrote: > Change "Version" tab to "Environment"? > Merge Version into the main info tab (even if I have the feeling that > this we discussed)? > > Martin Gräßlin wrote: >

Re: Review Request 129607: Display Application version in About dialog header

> On Dec. 3, 2016, 2:29 p.m., Sebastian Kügler wrote: > > I understand the problem, but I don't like the duplication you're > > introducing with this patch: The version number is now on the screen two > > times when you open the versions tab, and also, why have a versions tab, > > when the

Re: Review Request 129607: Display Application version in About dialog header

> On Dec. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. > &

Re: Review Request 129607: Display Application version in About dialog header

> On Dec. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. I thin

Re: Review Request 129607: Display Application version in About dialog header

note that this change was done in coordination with the usability group. So please add our usability experts to this review request. - Martin Gräßlin On Dec. 3, 2016, 12:55 p.m., Jean-Baptiste Mardelle wrote

[Differential] [Closed] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cd4e6504dfbd: Generate an instance with KSharedConfig::Ptr for singleton and arg (authored by graesslin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin added reviewers: dfaure, mdawson. REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson Cc: apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin added a comment. ping! REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks Cc: apol

Re: Review Request 129460: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129460/#review100984 --- Ship it! Ship It! - Martin Gräßlin On Nov. 20, 2016

Re: Review Request 129417: Add metainfo.yaml

addressed. - Martin Gräßlin On Nov. 16, 2016, 6:02 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Differential] [Updated, 194 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin updated this revision to Diff 8228. graesslin added a comment. Added a test case CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3386?vs=8220=8228 BRANCH kconfigcompiler-instance-ksharedconfig REVISION DETAIL https://phabricator.kde.org/D3386 AFFECTED FILES

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin added a comment. Just checked: the only test with a combination of arg="true" and singleton is signals_test_singleton.kcfgc which is used by kconfigcompiler_test_signals.cpp, but there is no code comparison in that test. The only other arg="true" case is test8a.kcfg, but that

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin added a comment. In https://phabricator.kde.org/D3386#63201, @apol wrote: > How can tests still pass? they compare the generated code. eh no idea. I did a make clean, make, make test in the folder. Maybe there is no test for the singleton + arg="true" combination?

[Differential] [Request, 33 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin created this revision. graesslin added a reviewer: Frameworks. REVISION SUMMARY In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and

To C++11 or not?

Hi framework devs, recently we started to see the first patches for frameworks to silence warnings for not used features of C++11. In particular to add override to methods of inheriting classes. Now I find this weird from the perspective of our C++ requirements. On the one side we say that

Re: Review Request 129385: kwindowsystem add overrides

++ variant or none. But not this stupid dance of we require C++11 but no we don't so -2 from my side for this achappro - Martin Gräßlin On Nov. 12, 2016, 4:41 nachm., Allen Winter wrote: > > --- > This is an automatically generat

Re: Review Request 129362: [KWindowInfo] Add pid()

) <https://git.reviewboard.kde.org/r/129362/#comment67653> Lucky you that Qt is smart - Martin Gräßlin On Nov. 11, 2016, 11:35 vorm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 129362: [KWindowInfo] Add pid()

/kwindowinfox11test.cpp with a test method for pid. - Martin Gräßlin On Nov. 10, 2016, 3:30 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

oard.kde.org/r/129327/#review100732 --- On Nov. 7, 2016, 7:29 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 129362: [KWindowInfo] Add pid()

an extension dance as my last commit. - Martin Gräßlin On Nov. 8, 2016, 12:47 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

, Martin Gräßlin

Review Request 129327: Expose desktopFileName in KWindowInfo

eca607e18a979439593e05e1da232548d0e7d139 src/platforms/xcb/kwindowinfo_p_x11.h 68805765fd630c2bc7cf0d77be688333b4a363f7 Diff: https://git.reviewboard.kde.org/r/129327/diff/ Testing --- Thanks, Martin Gräßlin

Re: Review Request 129222: ClipboardUpdater: fix crash on Wayland

> On Oct. 28, 2016, 9:23 a.m., David Faure wrote: > > So we won't be able to use the clipboard at all, on wayland? > > > > This seems to me like a Qt bug. of course we can use the clipboard on Wayland. I'm happily copy'n'pasting between windows here. What is different on Wayland is that

  1   2   3   4   5   6   7   8   9   10   >