marked as submitted.
Review request for KDE Frameworks, kwin and David Faure.
Changes
---
Submitted with commit e333a13fc52c28aac3c0d28cd5b85e16428fcff7 by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
Implementation for the new hint
a -2 to adding to
ECM
- Martin Gräßlin
On Oct. 26, 2016, 11:17 a.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
ly, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
>
> (Updated Oct. 25, 2016, 1:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
&g
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100255
---
+1
- Martin Gräßlin
On Oct. 25, 2016, 1:21 p.m., Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128913/#review99184
---
Ship it!
Ship It!
- Martin Gräßlin
On Sept. 15, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98834
---
Ship it!
Ship It!
- Martin Gräßlin
On Sept. 2, 2016, 6
- 492)
<https://git.reviewboard.kde.org/r/128763/#comment66521>
what about these commented lines?
- Martin Gräßlin
On Sept. 1, 2016, 12:50 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98684
---
Ship it!
Ship It!
- Martin Gräßlin
On Aug. 26, 2016, 3
> On Aug. 26, 2016, 9:49 a.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686
> > <https://git.reviewboard.kde.org/r/128763/diff/1/?file=475422#file475422line682>
> >
> > we probably need to do the same for EGL, don
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128764/#review98674
---
Ship it!
Ship It!
- Martin Gräßlin
On Aug. 26, 2016, 4
- 684)
<https://git.reviewboard.kde.org/r/128763/#comment66464>
we probably need to do the same for EGL, don't we?
- Martin Gräßlin
On Aug. 26, 2016, 3:04 a.m., David Edmundson wrote:
>
> ---
> This is an automatica
if it's a
QApplication? I'm not sure whether it makes sense to patch out all places where
a QWidget dependency is used. In the end it will be broken in the runtime
anyway.
- Martin Gräßlin
On Aug. 21, 2016, 7:36 p.m., David Faure wrote
marked as submitted.
Review request for KDE Frameworks, Bhushan Shah and Marco Martin.
Changes
---
Submitted with commit e4ce18500c672521861fdb84c5c3f4350ba871ab by Martin
Gräßlin to branch master.
Repository: knotifications
Description
---
The ProtocolVersion property was read
iff: https://git.reviewboard.kde.org/r/128681/diff/
Testing
---
Thanks,
Martin Gräßlin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review98219
---
Ship it!
Ship It!
- Martin Gräßlin
On July 21, 2016, 3
siting != s_d->compositingEnable) {
why do you think so?
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128576/#review98056
-------
wboard.kde.org/r/128576/#review98051
---
On Aug. 3, 2016, 11:34 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 4d355569eea2fae76ed67f791db8abeec1e794f0 by Martin
Gräßlin to branch master.
Bugs: 362531
https://bugs.kde.org/show_bug.cgi?id=362531
Repository: kwindowsystem
Description
marked as submitted.
Review request for KDE Frameworks, Plasma and Marco Martin.
Changes
---
Submitted with commit 9814aff6b9e41f5c890736499802280b72d94633 by Martin
Gräßlin to branch master.
Repository: plasma-framework
Description
---
The added test case simulates
/kwindowsystem.cpp fbff381b61116c6eef47d5c7fa1fc5730857328c
src/platforms/xcb/kwindowsystem_p_x11.h
72df642bef4b3562dd44882a94661476a9772c2b
Diff: https://git.reviewboard.kde.org/r/128566/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks
src/platforms/xcb/kwindowsystem.cpp fbff381b61116c6eef47d5c7fa1fc5730857328c
Diff: https://git.reviewboard.kde.org/r/128576/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
799533fdbb779503bdb3c0941610807a29718e47
autotests/themetest.cpp d6fa78fdca4106461a739eaffe2241851a94763f
Diff: https://git.reviewboard.kde.org/r/128572/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde
://git.reviewboard.kde.org/r/128572/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 67b95225136ea540d2c2a9fe4bd74285f40fdc73 by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
A common pattern for our applications which have to do platform specific
d6ed24db4a9e0f19da25d0437ca272ad0d6b44bc
autotests/themetest.h 799533fdbb779503bdb3c0941610807a29718e47
autotests/themetest.cpp d6fa78fdca4106461a739eaffe2241851a94763f
Diff: https://git.reviewboard.kde.org/r/128572/diff/
Testing
---
Thanks,
Martin Gräßlin
552
src/kwindowsystem.h 551b01f5831e2fbdf0d0ad30f3debf0955da189e
src/kwindowsystem.cpp 4dfcce8bbfeed09f3f6ddec10a1eb5fd2d418313
Diff: https://git.reviewboard.kde.org/r/128567/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128567/#review97984
---
On Aug. 1, 2016, 5:27 p.m., Martin Gräßlin wrote:
>
> -
system.cpp 4dfcce8bbfeed09f3f6ddec10a1eb5fd2d418313
Diff: https://git.reviewboard.kde.org/r/128567/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-
> On Aug. 1, 2016, 3:42 p.m., Martin Gräßlin wrote:
> > For testing against a stable version, please also include the following two
> > commits:
> > 7b24b834384a1524d8c2126416916a62048107cc
> > e5b2a8b2506adbfa2a659afd5d8cb9aa28db22dd
patch with those commits incl
the following two
commits:
7b24b834384a1524d8c2126416916a62048107cc
e5b2a8b2506adbfa2a659afd5d8cb9aa28db22dd
- Martin Gräßlin
On Aug. 1, 2016, 3:33 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail.
/kwindowsystem_p_x11.h
72df642bef4b3562dd44882a94661476a9772c2b
Diff: https://git.reviewboard.kde.org/r/128566/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
t; What do you think would it be possible to reimplement the tests in that
> way? Or would that break the tests?
>
>
>
> [Please note, this is not an attack on you personally, but on the really
> scary stuff the tests do].
>
> Martin Gräßlin wrote:
>
> On July 18, 2016, 11:30 p.m., David Faure wrote:
> > Wow, it never occured to me that someone might run this test as root. I
> > thought it was well known that development should not be done as root ;)
> > But I can see how it might happen when creating packages with unittests
> > enabled or
> On July 12, 2016, 8:07 a.m., Martin Gräßlin wrote:
> > What about shader variants for GLES? There are also two versions, one being
> > like the old one and one like core. In KWin we can handle this with the
> > same shader code and rewriting e.g. the version state
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.
nice one.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2142
EMAIL PREFERENCES
426/#comment65693>
varying doesn't exist in core profile. It's "out"
src/declarativeimports/core/fadingnode.cpp (line 93)
<https://git.reviewboard.kde.org/r/128426/#comment65694>
s/varying/in
- Martin Gräßlin
On July 12, 2016, 1:34 a.m.,
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 7f3aa5344ad5e2b336284fb95f140f3fe44a1f76 by Martin
Gräßlin to branch master.
Repository: plasma-framework
Description
---
In order to have support for tooltip window type in Wayland
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit e7249deae417cdf9fb2983b06aa118c4ae4e22df by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
Foreign window support is not available on all platforms. E.g. on
Wayland
gt;
> > why is this not enough?
>
> Martin Gräßlin wrote:
> This depends on https://phabricator.kde.org/D2031
>
> Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything
> with the flag. It's just being ignored. We need to manuall
:
https://git.reviewboard.kde.org/r/128300/#review96911
-------
On June 28, 2016, 1:43 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-m
Diff: https://git.reviewboard.kde.org/r/128300/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/#review96407
---
Ship it!
Ship It!
- Martin Gräßlin
On June 13, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128161/#review96404
---
Ship it!
Ship It!
- Martin Gräßlin
On June 13, 2016, 9
and.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127694/#review96376
---
On May 3, 2016, 12:34 p.m., Marti
.
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
g/r/128161/#comment65127>
nitpick: whitespaces
- Martin Gräßlin
On June 13, 2016, 9:41 a.m., Christoph Cullmann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
> On June 13, 2016, 7:39 a.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 76-78
> > <https://git.reviewboard.kde.org/r/128161/diff/1/?file=468328#file468328line76>
> >
> > instead of adding a definition could you make it a configure file?
>
&g
tps://git.reviewboard.kde.org/r/128161/#comment65120>
instead of adding a definition could you make it a configure file?
- Martin Gräßlin
On June 12, 2016, 6:55 p.m., Christoph Cullmann wrote:
>
> ---
> This is an automatically generated e
marked as submitted.
Review request for KDE Frameworks and Michael Pyne.
Changes
---
Submitted with commit 02cb750752e9f83635b8d3897a3de74e68f4c2df by Martin
Gräßlin to branch master.
Repository: kinit
Description
---
If for whatever reason the child process does not get SIGUSR1
> On June 6, 2016, 11:33 p.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have
> > these in Frameworks 5.23
I don't want to disappoint you, but it's too late for 5.23
- Martin
---
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote:
> > I suggest to look at
> > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html
> > which does something similar just for color schemes. Might make sense to
> > have the API struct
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote:
> > -2
> >
> > kdevelop should use the global widget style. if you don't want that, change
> > it via systemsettings
>
> Aleix Pol Gonzalez wrote:
> Well, it's not far-fetching to understand that on non-plasma systems this
> KCM will be
/kconfigwidgets/html/classKColorSchemeManager.html
which does something similar just for color schemes. Might make sense to have
the API structured very similar
- Martin Gräßlin
On May 31, 2016, 10:48 a.m., René J.V. Bertin wrote
the "Donate" into
applications which don't have a help menu, like Plasma or KWin?
- Martin Gräßlin
On May 26, 2016, 12:55 a.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To re
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 0f50e128929bc208ee672590a1a8db285335d3e5 by Martin
Gräßlin to branch master.
Repository: kglobalaccel
Description
---
KCrash is only used by the kglobalacceld5 binary, but not in the
private
50f64935657fda61b246610246977c19c6563147
Diff: https://git.reviewboard.kde.org/r/127988/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated
> > osx-integration repository for it as well.
>
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I'
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95638
---
Ship it!
Sorry for the hard review.
- Martin Gräßlin
of the cases. E.g.
plasma-framework showed that the files are just incorrectly licensed.
- Martin Gräßlin
On May 19, 2016, 2:51 p.m., Maximiliano Curia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
of the cases. E.g.
plasma-framework showed that the files are just incorrectly licensed.
- Martin Gräßlin
On May 19, 2016, 2:06 p.m., Maximiliano Curia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
are LGPLv2+. If we have
files which don't match that we need to either change copyright or remove the
files.
- Martin Gräßlin
On May 19, 2016, 4:37 p.m., Maximiliano Curia wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On May 17, 2016, 4:44 p.m., Martin Gräßlin wrote:
> > src/platforms/xcb/kwindowsystem.cpp, lines 730-732
> > <https://git.reviewboard.kde.org/r/127809/diff/5/?file=464409#file464409line730>
> >
> > this change looks not really needed. Looking at the cod
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated
> > osx-integration repository for it as well.
>
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I'
> On May 17, 2016, 4:36 p.m., Martin Gräßlin wrote:
> > > I saw that one of the justifications for the move was a dependency on
> > > Plasma library/ies, but I don't see any such dependencies in the latest
> > > version before the move (commit 07548ac1fe
, so I think we could just focus on the icon
size change.
src/platforms/xcb/kwindowsystem.cpp (line 744)
<https://git.reviewboard.kde.org/r/127809/#comment64741>
why 56 - that's not a normal icon size. Maybe 64?
- Martin Gräßlin
On May 6, 2016, 11:08 a.m., Anthony F
to create a dedicated
osx-integration repository for it as well.
- Martin Gräßlin
On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
ation.git=commit=70049ac737aad8a8a6e5025fdd326981959c70fd
which fixes the not specified dependency to breeze.
- Martin Gräßlin
On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mai
on making this a proper
cmake option.
- Martin Gräßlin
On May 12, 2016, 7:16 a.m., Nick Shaforostoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
)
<https://git.reviewboard.kde.org/r/127809/#comment64606>
I'm not considering this patch unless you turn it back into a readable
if-else structure!
- Martin Gräßlin
On May 6, 2016, 9:02 a.m., Anthony Fieroni
> On May 4, 2016, 10:18 a.m., Martin Gräßlin wrote:
> > src/platforms/xcb/kwindowsystem.cpp, lines 711-717
> > <https://git.reviewboard.kde.org/r/127809/diff/2/?file=462316#file462316line711>
> >
> > This changes the behavior of the method. Now alw
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 5ddb0b262dc409071f556dbd3f94799136b60909 by Martin
Gräßlin to branch master.
Repository: frameworkintegration
Description
---
The platformthem plugin got split out of frameworksintegration
)
<https://git.reviewboard.kde.org/r/127809/#comment64573>
This changes the behavior of the method. Now always NETWM is preferred,
even if it doesn't provide the best icon.
By returning early at this point you cannot evaluate what's the best
fitting size.
- Martin Gräßlin
On May 2
> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote:
> > What is the "best" size if it's not specified? Why is your change better
> > than how it was?
> >
> > This change adjusts a very important part of the icon lookup functionality
> > used
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 49357d093e8280a50df13ebc8afa9bcde69a7f7a by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
Makes the test more reliable, our side blocks till the server is
fully
> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote:
> > What is the "best" size if it's not specified? Why is your change better
> > than how it was?
> >
> > This change adjusts a very important part of the icon lookup functionality
> > used
222b5b1e959fa44bb2b242757ff32abf31b63be7
autotests/netwininfotestwm.cpp 9670a14dcb8faebf2ac6af8d56ead3681fa11715
Diff: https://git.reviewboard.kde.org/r/127819/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
these protocols can depend
on the package instead of needing a copy of the xml in their source
tree.
Diffs
-
find-modules/FindWaylandProtocols.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127694/diff/
Testing
---
Added a dependency in KWayland, it was found.
Thanks,
Martin
> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote:
> > What is the "best" size if it's not specified? Why is your change better
> > than how it was?
> >
> > This change adjusts a very important part of the icon lookup functionality
> > used
reviewboard.kde.org/r/127809/
> ---
>
> (Updated May 1, 2016, 10:07 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
>
>
> Bugs: 362324
> https://bugs.kde.org/show_bug.cgi?id=362324
>
>
> Repository: kwindowsystem
>
>
> Desc
r/126362/#review94847
---
On Dec. 15, 2015, 11:19 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
> On April 25, 2016, 1:55 p.m., Martin Gräßlin wrote:
> > The change looks wrong to me. The functionality of that poller
> > implementation is not bound to the availability of the dbus interface, but
> > on the XScreenSaver X11 extension. The dbus interface
graesslin added a comment.
+1
REPOSITORY
rCONFBUILD build.kde.org jenkins build configuration
REVISION DETAIL
https://phabricator.kde.org/D1489
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: aacid, bcooksley, scarlettclark, graesslin
Cc:
of that poller implementation
is not bound to the availability of the dbus interface, but on the XScreenSaver
X11 extension. The dbus interface is only used to emit a resumeFromIdle when
the screen saver deactivated.
- Martin Gräßlin
On April 20, 2016, 6:54 p.m., Paulo Lieuthier wrote
(lines 76 - 77)
<https://git.reviewboard.kde.org/r/127586/#comment64315>
maybe move m_lastRequestedEventsStartDate below m_agendaNeedsUpdate? Then
you don't have the reordering in the cpp file.
- Martin Gräßlin
On April 15, 2016, 4:28 a.m., Martin Klapetek
marked as submitted.
Review request for KDE Frameworks and David Edmundson.
Changes
---
Submitted with commit a58ca7e4bccfa872e3260ade6b35daa965c35021 by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
This test application extracts all possible icons
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit cdbb3857bd31d68efb09b76795b966985cb26e22 by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
Just verifies that reading the property on the root window works
: https://git.reviewboard.kde.org/r/127597/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/127613/diff/
Testing
---
File Attachments
Example for a Firefox window
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/08/9c410547-b724-4cf9-a710-d9dd34f76cc5__Spectacle.Z13835.png
Thanks,
Martin Gräßlin
> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote:
> > src/kwindowsystem.cpp, lines 495-496
> > <https://git.reviewboard.kde.org/r/124648/diff/1/?file=390797#file390797line495>
> >
> > This part looks wrong to me and I think is the reason why reading ico
> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote:
> > src/kwindowsystem.cpp, lines 495-496
> > <https://git.reviewboard.kde.org/r/124648/diff/1/?file=390797#file390797line495>
> >
> > This part looks wrong to me and I think is the reason why reading ico
Description
---
Just verifies that reading the property on the root window works as
expected.
Diffs
-
autotests/kwindoweffectstest.cpp 06a52a1e6e3d0fb4c967ff9c5295bb3a0381ee51
Diff: https://git.reviewboard.kde.org/r/127602/diff/
Testing
---
Thanks,
Martin Gräßlin
ugh.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/#review94371
---
On April 7, 2016, 9:55 a.m., Marti
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 66b178c6981a71dbd33c0e6cd965483a0947864f by Martin
Gräßlin to branch master.
Repository: kwindowsystem
Description
---
Code cleanup now that we can use Qt 5.4.
Diffs
-
CMakeLists.txt
Description
---
The path was wrong which is the reason why X11 windows don't have
icons in kwin_wayland.
Diffs
-
src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164
Diff: https://git.reviewboard.kde.org/r/127597/diff/
Testing
---
Thanks,
Martin Gräßlin
needs to be done by the user of the API.
src/kwindowsystem.cpp (line 588)
<https://git.reviewboard.kde.org/r/124648/#comment64159>
This looks wrong to me! This method is supposed to return the actual work
area as set on X11, not something multiplied by magic values.
- Martin Gräßlin
On
> On April 4, 2016, 6:26 p.m., Kai Uwe Broulik wrote:
> > Should we add a property "supported" or similar so we can check whether the
> > item works?
> >
> > I know we don't want to go down the "make tons of adjustments for 2d
> > renderer"-route but so at least Plasma NM could hide the tab
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127573/#review94243
---
Ship it!
Ship It!
- Martin Gräßlin
On April 4, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93986
---
Ship it!
Ship It!
- Martin Gräßlin
On March 20, 2016
> On March 24, 2016, 8:45 p.m., Dominik Haumann wrote:
> > Given the feedback I got, I will submit tomorrow (Friday), independent on
> > whether I have a ship-it or not.
> > The patch is tested both on Windows and Linux, and imo correct (the changes
> > are rather trivial now).
> >
> > If you
101 - 200 of 1168 matches
Mail list logo
