Taking over maintainer role for KConfig/KDNSSD

2014-02-06 Thread Matthew Dawson
Hi all, Just to let everyone know, I'm taking over the role of maintainer for both KConfig and KDNSSD. I'm most contactable at this email address ( matt...@mjdsystems.ca ). I'm usually idling on IRC with a nick of MJD, but I'm not always watching IRC. I'll do my best to watch over the

Re: Taking over maintainer role for KConfig/KDNSSD

2014-02-06 Thread Matthew Dawson
On February 6, 2014 12:12:18 PM Alex Merry wrote: On 06/02/14 07:38, Matthew Dawson wrote: I'll do my best to watch over the frameworks, but I'm not sure how much I'll be able to push them forward in the near future. At the very least I'll keep an eye on any review requests that come

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

2014-02-25 Thread Matthew Dawson
On February 23, 2014 11:15:47 AM David Faure wrote: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config(). I had thought that when dealing with smart pointers, one should in general always pass around the smart pointer and not the raw pointer behind it.

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-06 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
::openConfig() is used - Matthew Dawson On March 10, 2014, 4:36 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: src/core/kcoreconfigskeleton.cpp, line 990 https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990 Also, can you change the documentation for KCoreConfigSkeleton to reflect this change? Specifically

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52913 --- Ship it! Ship It! - Matthew Dawson On March 13, 2014, 4

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116845: Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-16 Thread Matthew Dawson
this function, can you also kill this line please? - Matthew Dawson On March 16, 2014, 7:08 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
in as is. The rest can be done later. If you prefer, I'll revert the DelayedParsing commit after you commit this. - Matthew Dawson On March 17, 2014, 7:17 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Matthew Dawson
. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-28 Thread Matthew Dawson
Diff: https://git.reviewboard.kde.org/r/117010/diff/ Testing --- Unit tests continue to pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117486: Rewrite kiosk documentation

2014-04-10 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117486/#review55422 --- Ship it! Ship It! - Matthew Dawson On April 10, 2014, 12

Re: Review Request 117989: Store app config file in ~/.config/domain/apprc

2014-05-04 Thread Matthew Dawson
be made later. - Matthew Dawson On May 4, 2014, 2:32 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117989

Deprecation Defines

2014-05-05 Thread Matthew Dawson
Hi all, I was looking into my frameworks, to prepare them for the 5.0. One thing was looking into was the deprecation defines. In KConfig, there are a couple of defines to disable deprecated functions: - KDE_NO_DEPRECATED - KCONFIGCORE_NO_DEPRECATED - KCONFIGGUI_NO_DEPRECATED Where

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

2014-05-26 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118039/#review58433 --- Ship it! Excellent. Thanks for the patch! - Matthew Dawson

Re: Review Request 118332: Update usage of QVariant::type() for Qt5.

2014-05-26 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118332/#review58506 --- Ship it! Ship It! - Matthew Dawson On May 26, 2014, 2:38

Re: Review Request 118339: Update usage of QVariant::type() for Qt5.

2014-05-26 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118339/#review58533 --- Ship it! Ship It! - Matthew Dawson On May 26, 2014, 11:36

Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-26 Thread Matthew Dawson
b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Matthew Dawson
On May 27, 2014 07:53:03 AM Marko Käning wrote: On 27 May 2014, at 07:29 , Ben Cooksley bcooks...@kde.org wrote: Please try the following syntax instead. Note that I recommend you override this in config/build/darwin-mavericks.cfg instead to ensure all CMake projects on OS X are affected

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

2014-05-27 Thread Matthew Dawson
On May 27, 2014 04:03:03 PM Mark Gaiser wrote: I looked at this issue and it is introduced by commit: 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. Belonging to this review request: https://git.reviewboard.kde.org/r/118039/ It removes readCheck and writeCheck. I don't know what the

Re: Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

2014-05-27 Thread Matthew Dawson
. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58731 --- On May 27, 2014, 1:27 a.m., Matthew Dawson wrote

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Matthew Dawson
/#review58733 --- On May 27, 2014, 1:27 a.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-30 Thread Matthew Dawson
--- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Matthew Dawson
/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-01 Thread Matthew Dawson
the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
1dd9e7fc44a367165fedc2e7760c8b524ecd210e src/kconfig_compiler/kconfig_compiler.cpp 28b151c579c2c40e118b3b738a1e6ac81e461b3e Diff: https://git.reviewboard.kde.org/r/118489/diff/ Testing --- Unit tests still pass, regardless of whether or not deprecated features are enabled. Thanks, Matthew Dawson

Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
, visit: https://git.reviewboard.kde.org/r/118490/#review59066 --- On June 3, 2014, 2:59 a.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/#review59060 --- On June 3, 2014, 2:34 a.m., Matthew Dawson wrote: --- This is an automatically

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-04 Thread Matthew Dawson
., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 1, 2014, 5:03 p.m.) Review

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-04 Thread Matthew Dawson
tests all pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

2014-06-04 Thread Matthew Dawson
and Matthew Dawson. Changes --- New version, taking into account all comments. I'd appreciate it if someone can have a quick look over the comment to verify it makes sense. Summary (updated) - Properly mark ServiceBrowser::isRunning as deprecated. Repository: kdnssd

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

2014-06-05 Thread Matthew Dawson
marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kdnssd Description --- Properly mark ServiceBrowser::isRunning as deprecated. Fix the @deprecated notation to be correct. Also, make the function a simple inline function that always returns false

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Matthew Dawson
pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Matthew Dawson
pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-06 Thread Matthew Dawson
://git.reviewboard.kde.org/r/118564/#comment41428 Just to be safe, can you please save + restore the previous default? - Matthew Dawson On June 6, 2014, 7:43 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 118612: Fix KDirWatch's unit tests on certain file system.

2014-06-07 Thread Matthew Dawson
--- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

2014-06-08 Thread Matthew Dawson
7da1fdba8cd1a2e6a7d5bf9cef999d50b44ebf99 Diff: https://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-11 Thread Matthew Dawson
On June 7, 2014, 12:33 a.m., Matthew Dawson wrote: autotests/kconfigtest.cpp, line 930 https://git.reviewboard.kde.org/r/118564/diff/3/?file=279334#file279334line930 Similarly, can you just change the config object's locale to something (en seems fine here) instead of changing

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-11 Thread Matthew Dawson
/#comment41675 Whitespace - Matthew Dawson On June 11, 2014, 2:54 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

2014-06-13 Thread Matthew Dawson
7da1fdba8cd1a2e6a7d5bf9cef999d50b44ebf99 Diff: https://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

2014-06-13 Thread Matthew Dawson
://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Matthew Dawson
be GlobalSharedConfigList? Why not just put the logic in globalSharedConfigList? src/core/ksharedconfig.cpp https://git.reviewboard.kde.org/r/118739/#comment42038 Can you also please document the new behaviour of openConfig, that each instance is thread specific? - Matthew Dawson On June 14

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-17 Thread Matthew Dawson
. src/core/kconfigdata.h https://git.reviewboard.kde.org/r/118692/#comment42056 Another Q_NULLPTR src/core/kconfigini.cpp https://git.reviewboard.kde.org/r/118692/#comment42057 Another Q_NULLPTR. - Matthew Dawson On June 16, 2014, 4:26 a.m., Martin Gräßlin wrote

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-18 Thread Matthew Dawson
On June 18, 2014, 3:04 a.m., Oswald Buddenhagen wrote: i don't see that you are proactively excluding the @modifier. it would seem that it's effectively part of the country, and the test works only because it's expected to fall back to de instead of de_AT anyway. there is another

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-18 Thread Matthew Dawson
On June 17, 2014, 12:50 p.m., Matthew Dawson wrote: src/core/ksharedconfig.cpp, line 52 https://git.reviewboard.kde.org/r/118739/diff/1/?file=28#file28line52 Why create a template function here, when the T must be GlobalSharedConfigList? Why not just put the logic

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-20 Thread Matthew Dawson
On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: autotests/kdesktopfiletest.cpp, line 88 https://git.reviewboard.kde.org/r/118692/diff/2-3/?file=280487#file280487line88 Please add a test for both: - when both the country/language match and a modifier is included

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-20 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60621 --- Ship it! Ship It! - Matthew Dawson On June 20, 2014, 4:56

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-22 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60681 --- Ship it! Ship It! - Matthew Dawson On June 21, 2014, 5:37

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

2014-06-28 Thread Matthew Dawson
to be mainly an optimization to ensure the config is not unnecessarily deleted, I think it makes sense to still run this on alternate threads. - Matthew Dawson On June 27, 2014, 6:31 p.m., David Faure wrote

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-29 Thread Matthew Dawson
On June 28, 2014, 11:31 p.m., Matthew Dawson wrote: I'm not sure about moving the warning about immutable files to only happen on the main thread, as it is possible that an application may use it KSharedConfig on an alternate thread only. As this is mainly an optimization, I think

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-30 Thread Matthew Dawson
patch, feel free to commit it once fixed. src/core/ksharedconfig.cpp https://git.reviewboard.kde.org/r/118985/#comment42692 Whitespace. - Matthew Dawson On June 29, 2014, 9:55 a.m., David Faure wrote

Re: Review Request 119074: Fix reading of XDG style semicolon separated lists with escaped '; '

2014-07-01 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119074/#review61417 --- Ship it! Ship It! - Matthew Dawson On July 1, 2014, 2:35

Re: Deprecation Defines

2014-07-07 Thread Matthew Dawson
On July 7, 2014 11:39:38 PM David Faure wrote: On Monday 05 May 2014 13:14:07 Alex Merry wrote: On 05/05/14 07:27, Matthew Dawson wrote: Hi all, I was looking into my frameworks, to prepare them for the 5.0. One thing was looking into was the deprecation defines. In KConfig

Re: Deprecation Defines

2014-07-08 Thread Matthew Dawson
On July 8, 2014 11:20:37 AM David Faure wrote: I have a patch sitting in review for kconfig. What's the RR number? I can't see it in my k-f-d folder. 118489. It already has comments on it, with the decision that policy needs to be figured out before it is pushed. I'm waiting on a

Re: Deprecation Defines

2014-07-08 Thread Matthew Dawson
On July 8, 2014 10:50:18 PM David Faure wrote: I agree. I figured the first step was to come up with a draft policy and post to the list for comments, and as I said I'm trying to get a new contributer to help (they have lots of experience writing documents, and have a strong technical

Review Request 119577: Allow translations to have context again.

2014-08-02 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119577/ --- Review request for KDE Frameworks and Matthew Dawson. Bugs: 337979

Re: Review Request 119577: Allow translations to have context again.

2014-08-02 Thread Matthew Dawson
--- On Aug. 2, 2014, 1:07 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119577

Re: Review Request 119577: Allow translations to have context again.

2014-08-10 Thread Matthew Dawson
marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Bugs: 337979 https://bugs.kde.org/show_bug.cgi?id=337979 Repository: kconfig Description --- Allow translations to have context again. Switch to using QT_TRANSLATE_NOOP3 so that context information can

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-08-29 Thread Matthew Dawson
(or other interested parties) to watch their framework's comments, to be on the look out for any interesting conversation? Users may make comments about the API's that would be good to follow up on. Thanks for looking into this! - Matthew Dawson On Aug. 29, 2014, 10:16 a.m., Denis

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-08-30 Thread Matthew Dawson
a KConfig or a KConfigGroup and be able load/persist its settings would be good. - Matthew Dawson On Aug. 29, 2014, 5:42 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-08-31 Thread Matthew Dawson
On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: Thanks for taking a look at this. It appears KConfigBase isn't available on api.kde.org as it isn't documented, as kapidox hides such classes by default. As KConfigBase is used outside of KConfig, I'd prefer if KConfigBase gained

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-06 Thread Matthew Dawson
On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: Thanks for taking a look at this. It appears KConfigBase isn't available on api.kde.org as it isn't documented, as kapidox hides such classes by default. As KConfigBase is used outside of KConfig, I'd prefer if KConfigBase gained

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
On Sept. 8, 2014, 6:22 p.m., Ben Cooksley wrote: What is the status of this? Is there anything blocking it being shipped and made available on api.kde.org? Denis Steckelmacher wrote: It works locally, so I'm just waiting for a ship-it or other comments :-) Aleix Pol Gonzalez

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-11 Thread Matthew Dawson
On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: Thanks for taking a look at this. It appears KConfigBase isn't available on api.kde.org as it isn't documented, as kapidox hides such classes by default. As KConfigBase is used outside of KConfig, I'd prefer if KConfigBase gained

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/#review66315 --- Ship it! Ship It! - Matthew Dawson On Aug. 29, 2014, 10

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
wrote: Let's see if we can get this discussed in the KF5 BoF today. Aleix Pol Gonzalez wrote: I kind of forgot... :( Anyway, +1 for me. If there are no reasons to keep postponing it, I'd say let's just do this. Matthew Dawson wrote: The only issue I see

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-13 Thread Matthew Dawson
On September 12, 2014 03:19:13 AM Ben Cooksley wrote: On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: Matthew Dawson wrote: I don't think upstream would be happy with the patch, as it hijacks the moderator emails (which should link to the admin page) to send out

Re: Review Request 120283: make KConfigLoader more predictable by exposing a getter to KConfig's OpenFlags

2014-09-19 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120283/#review66958 --- Ship it! Ship It! - Matthew Dawson On Sept. 19, 2014, 7

Re: Non-coinstallable frameworks

2014-09-19 Thread Matthew Dawson
On September 18, 2014 01:15:51 PM Aleix Pol wrote: Hi Ivan, I've just learned that the KActivities framework is not co-installable with kdelibs4. Are you sure about this? I just double checked, and my distribution (Gentoo) has both installed right now, in the same prefix. And I'm running

Re: Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc

2014-11-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121272/#review71044 --- Ship it! Thanks! Will push shortly. - Matthew Dawson

Re: FAM in kdirwatch

2014-11-28 Thread Matthew Dawson
On November 28, 2014 01:16:02 PM Jonathan Riddell wrote: At Kubuntu we're trying to work out if we want kcoreaddons to build-dep on FAM. FAM isn't used if inotify is available and kdelibs never built against FAM. But we had this bug report about FAM being needed for NFS

Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
) and Matthew Dawson. Bugs: 1164383 https://bugs.kde.org/show_bug.cgi?id=1164383 Repository: kconfig Description --- As requested in bug #1164383, this adds a new standard shortcut for adding bookmarks for web pages. BUG: 1164383 I'm not sure if this is the best approach

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
, Localization and Translation (l10n) and Matthew Dawson. Changes --- Copy+paste error on bug number. Bugs: 341279 https://bugs.kde.org/show_bug.cgi?id=341279 Repository: kconfig Description --- As requested in bug #1164383, this adds a new standard shortcut for adding bookmarks

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/#review71585 --- On Dec. 6, 2014, 3:49 p.m., Matthew Dawson wrote

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-24 Thread Matthew Dawson
stay empty. Maybe add another conditional checking its empty in this if statement, and if it still is add some random value? - Matthew Dawson On Jan. 23, 2015, 5:39 p.m., David Faure wrote: --- This is an automatically

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-26 Thread Matthew Dawson
? Otherwise, everything looked go to me. autotests/ksharedconfig_in_global_object.cpp https://git.reviewboard.kde.org/r/122232/#comment51847 Line to comment out. For the final version this should work without this line. - Matthew Dawson On Jan. 26, 2015, 3:11 a.m., David Faure wrote

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-27 Thread Matthew Dawson
. 27, 2015, 3:10 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- kconfig_in_global_object.cpp comes from kdelibs4support (after porting to Q_GLOBAL_STATIC) ksharedconfig_in_global_object.cpp is new (but works with kdelibs4

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
the read call. Matthew Dawson wrote: The read call was removed to avoid changing the KCoreConfigSekleton during the save call, as it wasn't documented as doing that and may surprise some people that flushing their changes may load other unrelated changes. I would prefer to keep

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Matthew Dawson
the unit test refactoring out to a separate commit just before the bug fix commit? If not, just push it as is. - Matthew Dawson On Jan. 6, 2015, 5:41 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail

Re: Extra patch for KConfig 5.7 release

2015-02-14 Thread Matthew Dawson
On February 14, 2015 11:16:42 AM David Faure wrote: This is rather a behavior-incompatible change (and another one to revert). So, to avoid the packagers killing me for updating 5.7 two days *after* the supposed public release day (*), I would rather make a 5.7.1 kconfig release with this

Re: strange problem with KConfig

2015-02-08 Thread Matthew Dawson
On February 5, 2015 08:49:16 PM Marco Martin wrote: Hi all, I was investigating this bug.. https://bugs.kde.org/show_bug.cgi?id43583 but after digging and digging, it looks like more and more an issue in KConfig.. basically if there is a config file in a system-wide location (to give

Extra patch for KConfig 5.7 release

2015-02-13 Thread Matthew Dawson
Hi all, If it is not too late to sneak an extra patch into KConfig's 5.7 release, could commit 9eee15917e01a89d937d1cba2eebbe9d65daeb72 ( http://commits.kde.org/kconfig/9eee15917e01a89d937d1cba2eebbe9d65daeb72 ) be added in? This change reverts a SIC, which will break updating of

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-02-05 Thread Matthew Dawson
On Jan. 27, 2015, 3:55 p.m., Matthew Dawson wrote: Unforunately, this cause test system failures in the the kconfigskeletontest test suite. I'm not sure why this should create issues there. However, I have a partial solution that avoids creating a full KSharedConfig. Instead

Re: Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

2015-01-08 Thread Matthew Dawson
cc17ef6e3f3c0db3c4597105b32320f0aeb52b0f autotests/kstyle_unittest.cpp e0e0046100acc195b1a3c36bbbe67e5861d7b7ee Diff: https://git.reviewboard.kde.org/r/121908/diff/ Testing --- Executing the test suite locally now succeeds. Thanks, Matthew Dawson

Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

2015-01-07 Thread Matthew Dawson
e0e0046100acc195b1a3c36bbbe67e5861d7b7ee Diff: https://git.reviewboard.kde.org/r/121908/diff/ Testing --- Executing the test suite locally now succeeds. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated Jan. 4, 2015, 11:04 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:00:11 PM Mathias Kraus wrote: === KConfig config(QLatin1String(kminesrc)); config.reparseConfiguration(); === Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant using it against the global KSharedConfig, not a newly created KConfig.

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:29:25 PM Mathias Kraus wrote: Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: On March 21, 2015 04:00:11 PM Mathias Kraus wrote: === KConfig config(QLatin1String(kminesrc)); config.reparseConfiguration(); === Sorry, my suggestion

Re: [Kde-games-devel] Data migration issue

2015-03-22 Thread Matthew Dawson
On March 22, 2015 06:19:46 PM David Faure wrote: On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: Too late for KDE Applications 15.04 though now that i think, so maybe we actually have to suggest everybody using the migrator to add those extra lines? OK, that means: ---

Re: [Kde-games-devel] Data migration issue

2015-03-04 Thread Matthew Dawson
On March 3, 2015 10:59:21 PM Mathias Kraus wrote: Hi, I noticed a problem with the data migration in the kdegames transition from kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for advice. In short, when the migration is run after the QCoreApplication is created,

  1   2   >