D12197: autotests: Test for multiple values

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. The test for mp3 is failing to complete. I am investigating. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo,

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry, that was a local problem. REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks,

D10694: epubextractor: Handle multiple subjects better

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-subject REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks,

D11489: Make concatenated strings wrappable

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. You could even push directly for this kind of changes. REPOSITORY R286 KFileMetaData BRANCH wrappable REVISION DETAIL https://phabricator.kde.org/D11489 To: michaelh, mgallien,

D12320: add ability to read embedded cover files

mgallien added a comment. Thanks a lot to continue to push this work. In D12320#249433 , @bruns wrote: > Baloos DBs should only contain searchable data. So until someone teaches baloo how to compare images, it should be kept separate.

D12341: fix detection of taglib when compiling for Android

mgallien created this revision. mgallien added reviewers: Frameworks, Baloo. Restricted Application added projects: Frameworks, Baloo. mgallien requested review of this revision. REVISION SUMMARY fix detection of taglib when cross compiling for Android TEST PLAN tagib is properly found

D12341: fix detection of taglib when compiling for Android

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d497ffebe202: fix detection of taglib when compiling for Android (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12341?vs=32543=33035

D12320: add ability to read embedded cover files

mgallien added a comment. In D12320#249998 , @astippich wrote: > In D12320#249982 , @michaelh wrote: > > > -2 > > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. >

D12156: implement reading of rating tag

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. In D12156#249994 , @astippich wrote: > In D12156#249977 , @michaelh wrote: > >

D11365: also test for value types in taglibextractortest and fix errors

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Please fix the issues. INLINE COMMENTS > taglibextractor.cpp:363 > +if (!genresList.isEmpty()) { > +result->add(Property::Genre, genresList); > }

D10803: handle more tags in taglibextractor

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I am really sorry. I had missed that you had modified the diff to only include the safe set of changes. I should really apologize. Thanks for your work, it is very much appreciated.

D4911: add Baloo DBus signals for moved or removed files

mgallien added a comment. In D4911#199527 , @cullmann wrote: > @cullmann: T7860 lists some of my observations wrt samba shares. I don't know NFS, can you enlighten me regarding deviceids and inodes on NFS? >

D10803: handle more tags in taglibextractor

mgallien added a subscriber: dfaure. mgallien added inline comments. INLINE COMMENTS > astippich wrote in properties.h:168 > I noticed the typo as well, but I think this is a matter of API > compatibility, so I left it unchanged. Matthieu should know. It is part of the source compatibility

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#210509 , @michaelh wrote: > The only component I could find to be affected by this change is `baloo-widgets`. I have already adapted it to this change. And yes, it will handle both. > It will take a some

D16163: refactor taglibextractor to functions specific for metadata type

mgallien added a comment. In D16163#342046 , @astippich wrote: > To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? This page is a very good reference:

D16197: provide a list of supported mimetypes for embeddedimagedata

mgallien added inline comments. INLINE COMMENTS > embeddedimagedata.h:62 > + */ > +QStringList readMimetypes() const; > + You can make it static because you are returning a static member. It means that you should probably return by const reference (even if I do not remember if it is

D16618: add explicit to constructors

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH explicit REVISION DETAIL https://phabricator.kde.org/D16618 To: astippich, #frameworks, bruns, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov,

D16618: add explicit to constructors

mgallien added inline comments. INLINE COMMENTS > simpleextractionresult.h:42 > public: > -SimpleExtractionResult(const QString& url, const QString& mimetype = > QString(), const Flags& flags = ExtractEverything); > +explicit SimpleExtractionResult(const QString& url, const QString& >

D15614: remove usage of own TString to QString conversion function

mgallien added a comment. In D15614#328722 , @astippich wrote: > The removal of the convertWCharsToQString function is safe, right? It was never exported It is a static function. So it is absolutely safe to remove it. REPOSITORY R286

D8532: [WIP] Restrict file extractor with Seccomp

mgallien added a comment. In D8532#289500 , @davidk wrote: > I was asked in private about the current state of libseccomp integration and why there was no progress in a long time. > The current state is, that I have implemented seccomp support

Power Management and Inhibition by Applications

n also see some other features that could make sense to provide in libraries that music players could use (lyrics fetching, album art fetching, ...). This could be in a dedicated framework to help build media players. Best regards -- Matthieu Gallien

Power Management and Inhibition by Applications

n also see some other features that could make sense to provide in libraries that music players could use (lyrics fetching, album art fetching, ...). This could be in a dedicated framework to help build media players. Best regards -- Matthieu Gallien

Re: Power Management and Inhibition by Applications

ng to suspend has to check itself for any blocking inhibition for sleep. I can volunteer to add this to Powerdevil if this is deemed useful. I had checked the dbus interface for logind and there is still no any signals to know when an inhibition is added or removed. Best regards -- Matthieu Gallien

D17500: Restore mobipocket extractor

mgallien added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17046: Use the new FindExiv2 module from ECM.

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Please feel free to land this after solving my comment. INLINE COMMENTS > CMakeLists.txt:57 > -set_package_properties(Exiv2 PROPERTIES DESCRIPTION "Image Tag reader" > -

Re: Power Management and Inhibition by Applications

Hello, On samedi 19 janvier 2019 12:19:10 CET Elvis Angelaccio wrote: > On 16/01/19 22:07, Matthieu Gallien wrote: > > Hello, > > > > I am trying to work on a feature request to add the ability to suppress > > laptop sleep when playing music. > > > > Cu

D20219: Propose Stefan Bruns as KFileMetaData maintainer

mgallien added subscribers: bruns, mgallien. mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for all the work going on. I am really happy to see all the work done by @bruns REPOSITORY R286 KFileMetaData BRANCH master

D20310: Use nullptr instead of NULL

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH nullptr REVISION DETAIL https://phabricator.kde.org/D20310 To: nicolasfella, #frameworks, bruns, mgallien, astippich Cc:

D16579: Remove support for non-standard APE tag field names from the test files

mgallien added a comment. In D16579#428835 , @smithjd wrote: > The change was ack'ed in this review, and this review closed by the commit. > > There was no code that required further review, only binary changes. The posted concerns were

D20526: fix extracting of some properties to match what was writen

mgallien created this revision. mgallien added reviewers: astippich, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY Currently, one can write and read through taglib extractor

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien added a comment. In D21381#469617 , @apol wrote: > How about we test against both? I have just pushed a new diff to do that. I am not sure if it desirable to keep appstreamcli test given it fails to validate files that are

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien updated this revision to Diff 58628. mgallien added a comment. - use appstream-util and appstreamcli to validate appdata file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21381?vs=58595=58628 BRANCH master REVISION DETAIL

D21581: Detect valgrind, avoid database removal when using valgrind

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Very nice. Thank you REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien

D20526: fix extracting of some properties to match what was writen

mgallien added a comment. In D20526#483910 , @astippich wrote: > @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. > Or do you mind if I take over? I would

D21219: Don't try to index SQL database dumps

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH dont-try-to-index-database-dumps (branched from master) REVISION DETAIL https://phabricator.kde.org/D21219 To: ngraham, #frameworks, bruns, mgallien Cc: kde-frameworks-devel,

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien created this revision. mgallien added reviewers: aacid, yurchor. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should help having the same validation than

D12992: New elisa icon

mgallien added a comment. In D12992#486880 , @lshoravi wrote: > Using @abetts prototype: No blockers, incorporating the given teal and green colours given by mgallien is TODO. > > Otherwise, the blocker would be to find what visual profile

D12992: New elisa icon

mgallien added a comment. In D12992#533180 , @lshoravi wrote: > Bumping @abetts Thanks for keeping this on your todo list. This is very much appreciated. I am trying to move forward the process of having Elisa published on Windows

D25622: partial solution to accept accentuated characters on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9220e5045687: partial solution to accept accentuated characters on windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D26054: partial fix for accentuated characters in file name on Windows

mgallien created this revision. mgallien added reviewers: bruns, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY partial fix to try to get accentuated file names to work with

D26054: partial fix for accentuated characters in file name on Windows

mgallien updated this revision to Diff 71684. mgallien added a comment. sorry for the mess in the previous patch REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26054?vs=71683=71684 BRANCH fixWriterAccentuatedFileName REVISION DETAIL

D24598: Update elisa icon

mgallien accepted this revision. mgallien added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt,

D25622: partial solution to accept accentuated characters on windows

mgallien added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D25622: partial solution to accept accentuated characters on windows

mgallien created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY If filename contains accentuated characters, taglib fails to open it on windows if the QString is

D25622: partial solution to accept accentuated characters on windows

mgallien added a comment. I forgot to maybe give some explanations. The documentation of the constructor of TagLib::FileStream takes a char* and "file should be a be a C-string in the local file system encoding". This means that the proper fix would possibly involve doing changes in

D24406: Small performance improvements suggested by clang tidy

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D24406 To: aacid, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, lots0logs,

D24598: Update elisa icon

mgallien added a comment. In D24598#546135 , @astippich wrote: > I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer. > I was unsatisfied with the

D26054: partial fix for accentuated characters in file name on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8c066c834c64: partial fix for accentuated characters in file name on Windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D28682: export done signal in filecontentindexer

mgallien added a comment. This is the reason why it is so slow in Elisa? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo,

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. To be clear, I am fine with this change going in. I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having to

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. Sorry for the lack of time to do a proper review. I will need to have a thorough look at what Elisa is currently doing and what is working (or not). Is there another working way to get information about files that have moved without having an application

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. In D28980#652256 , @bruns wrote: > In D28980#652102 , @mgallien wrote: > > > To be clear, I am fine with this change going in. > > > > I would still like to work on a

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

On dimanche 5 novembre 2023 18:01:38 CET Nate Graham wrote: > On 11/5/23 07:42, Kevin Ottens wrote: > > I was clumsily advocating for this Akademy 2021 or 2022 (can't remember > > which). > > > > This way it's clearer to application authors when they tie themselves to a > > given workspace or

<    1   2   3