: https://git.reviewboard.kde.org/r/116866/diff/
Testing
---
Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
(32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On March 18, 2014, 10:25 a.m., Michael Hansen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866
/116866/diff/
Testing
---
Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
/
Testing
---
Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
(32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
., Michael Hansen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/
---
(Updated March 22, 2014, 10:13 a.m.)
Review
/116866/diff/
Testing
---
Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8
(Arch x86_64).
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
/116866/#review53877
---
On March 22, 2014, 1:54 p.m., Michael Hansen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866
;
boolz;
With Indent 4/Tab 8:
int x;
string y;
boolz;
With Indent 8/Tab 8 (single [tab] on the first line):
int x;
string y;
boolz;
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing
Ping?
On Thu, Oct 23, 2014 at 10:09 AM, Michael Hansen zrax0...@gmail.com wrote:
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120760/
Review request for KDE Frameworks and Christoph Cullmann.
By Michael Hansen.
*Repository
Tab mode is affected by this change.
With Indent 4/Tab 4:
int x;
string y;
boolz;
With Indent 4/Tab 8:
int x;
string y;
boolz;
With Indent 8/Tab 8 (single [tab] on the first line):
int x;
string y;
boolz;
Thanks,
Michael
;
Thanks,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
,
Michael Hansen
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
zrax added a comment.
Is anything else needed for this? I'm assuming installing the indexer would
go as a separate review and that nobody is waiting for me to add that here...
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7699
To: zrax, #kate,
zrax created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This allows applications to include application-specific syntax rules
and themes which don't necessarily make sense to install globally to be
zrax added a comment.
Installing the indexer might be more useful in the custom path case, since it
could be used to index bundled rules. If we just add the /syntax-extra search
path and a shared library installs an index there, we'd be right back where we
started with no way to bundle new
zrax retitled this revision from "Add support for custom search paths for
application-specific syntax and themedefinitions" to "Add support for custom
search paths for application-specific syntax and theme definitions".
zrax edited the summary of this revision.
zrax edited the test plan for this
zrax retitled this revision from "Add support for custom search paths for
application-specific syntax and theme
definitions" to "Add support for custom search paths for application-specific
syntax and themedefinitions".
zrax added reviewers: Kate, Framework: Syntax Hightlighting.
REPOSITORY
zrax added a comment.
Sorry, I missed some of the later discussion when updating the patch... I'm
fine with either solution, I just want to know which is preferred :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7699
To: zrax, #kate,
zrax added a comment.
@cullmann, I like that suggestion better... It's closer to what I originally
tried, but was unable to because of the index cache. Are the resource paths
documented anywhere that I should update?
INLINE COMMENTS
> dhaumann wrote in syntaxrepository_test.cpp:18
> Is
zrax updated this revision to Diff 19256.
zrax added a comment.
Updated original patch with fixes for @dhaumann
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19253=19256
BRANCH
master
REVISION DETAIL
zrax updated this revision to Diff 19253.
zrax added a comment.
Rework to search :/org.kde.syntax-highlighting/syntax-extra and
:<...>/themes-extra resource paths instead of introducing a new API.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
zrax updated this revision to Diff 19242.
zrax added a comment.
Adjust naming based on review comments; add test case for custom path.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19213=19242
BRANCH
master
REVISION DETAIL
zrax updated this revision to Diff 19243.
zrax added a comment.
Add input files for new test case.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19242=19243
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7699
zrax added a comment.
@dhaumann yes, your guess is correct. I was experimenting with replacing a
difficult-to-maintain qscintilla fork with some custom syntax lexers with
QTextEdit + KSyntaxHighlighting + easier-to-maintain custom Kate-style syntax
definitions, in a non-KDE application.
zrax created this revision.
Herald added projects: Frameworks, Documentation.
Herald added a subscriber: kde-doc-english.
zrax requested review of this revision.
REVISION SUMMARY
If a PERL_EXECUTABLE is passed on the CMake command line, e.g. because the
default one in PATH is insufficient,
zrax added a comment.
No, I do not have push permissions.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D15909
To: zrax, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
zrax added a comment.
PERL_EXECUTABLE is set by cmake's FindPerl module
(https://cmake.org/cmake/help/v3.0/module/FindPerl.html), so it should always
be defined. This only fixes the case where it's overridden on the command line
(or cmake-gui, etc).
REPOSITORY
R238 KDocTools
REVISION
zrax created this revision.
Herald added a project: Frameworks.
zrax requested review of this revision.
REVISION SUMMARY
Fix a compile failure on Windows due to the use of QSysInfo enums which are
not fully qualified.
REPOSITORY
R246 Sonnet
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:44baed407ac6: Several enhancements to gitolite syntax
definition. (authored by zrax).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.
REVISION SUMMARY
- Add more keywords, including access modes
- Highlight include directives properly
- Fix group
zrax updated this revision to Diff 70989.
zrax added a comment.
Fix "+" in keywords to not act as a word break.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25770?vs=70974=70989
BRANCH
gitolite-syntax (branched from master)
REVISION
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.
REVISION SUMMARY
Powershell uses the syntax ` or `u{hex} as escape sequences within
double-quoted strings. This adds
zrax updated this revision to Diff 69010.
zrax added a comment.
- Add test case for new escape sequences to powershell autotest
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25054?vs=68996=69010
BRANCH
ps-escape (branched from master)
zrax added a comment.
I do not have a KDE developer account, so I cannot land the change myself
presently.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ps-escape (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax, dhaumann
Cc: dhaumann, kwrite-devel,
zrax updated this revision to Diff 69011.
zrax added a comment.
- Add test case for new escape sequences to powershell autotest
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25054?vs=69010=69011
BRANCH
ps-escape (branched from master)
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
innosetup (branched from master)
REVISION DETAIL
zrax updated this revision to Diff 77133.
zrax added a comment.
Relicense as MIT.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27660?vs=76398=77133
BRANCH
innosetup (branched from master)
REVISION DETAIL
42 matches
Mail list logo
