D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62254. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated! REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62237=62254 BRANCH arcpatch-D22105 REVISION DETAIL

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62237. brute4s99 marked 3 inline comments as done. brute4s99 added a comment. updated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62187=62237 BRANCH arcpatch-D22105 REVISION DETAIL

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > dfaure wrote in kio_sftp.cpp:2257 > This is marked as Done, but it's not Done. In fact it matches my own > suggestion above, so I agree with Albert ;-) so sorry, it seems I updated a previous version of the diff. REPOSITORY R320 KIO Extras

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62187. brute4s99 added a comment. updated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62159=62187 BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 AFFECTED FILES

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 6 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in kio_sftp.cpp:2050-2051 > what is this commented code for? it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to handle this. For now I've commented out setting the file access time instruction for now.

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62159. brute4s99 marked 4 inline comments as done. brute4s99 added a comment. udpated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61972=62159 BRANCH arcpatch-D22105 REVISION DETAIL

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62069. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62051=62069 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. In D22554#497984 , @nicolasfella wrote: > Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case Which line number are you referring to? REPOSITORY R289 KNotifications REVISION DETAIL

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62051. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62048=62051 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 created this revision. brute4s99 added reviewers: nicolasfella, broulik. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY remove another dependency related to DBus from Windows builds

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > dfaure wrote in kio_sftp.cpp:2037 > Why ReadWrite, if we know it doesn't exist? > > Does setFileTime() even need open() first? I wouldn't have thought so. `setFileTime()` needs the file to be open. Source :

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61972. brute4s99 marked 7 inline comments as done. brute4s99 added a comment. updated wrt new comments. @dfaure please take another look!  REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61419=61972

D21660: remove dbus for windows build and change audio dep logic

This revision was automatically updated to reflect the committed changes. Closed by commit R289:be466180db21: remove dbus for windows build and change audio dep logic (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. landing it REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D21660: remove dbus for windows build and change audio dep logic

brute4s99 marked 8 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

brute4s99 updated this revision to Diff 61716. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61639=61716 BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: remove dbus for windows build and change audio dep logic

brute4s99 retitled this revision from "remove dbus and change audio dep logic" to "remove dbus for windows build and change audio dep logic". REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella

D21660: remove dbus and change audio dep logic

brute4s99 retitled this revision from "change audio dep logic wrt win32" to "remove dbus and change audio dep logic". brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99,

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61639. brute4s99 added a comment. no more dbus on Windows build of KNotifications REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61422=61639 BRANCH arcpatch-D21660_1 REVISION DETAIL

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > But this is KNotifications, not KDE Connect. So we need DBus for > KNotifications on Windows? ah, yeah we could bypass DBus on Windows in KNotifications REPOSITORY R289 KNotifications BRANCH

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > I'm looking into the DBus problem, we currently use DBus for the system tray > icon on Windows. Once that is resolved, I should be able to completely remove > DBus from the Windows build Update: nope. I

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > Yes. It is neither related to Windows nor audio. What you can to is to add > Windows to the condition to not look for DBus on Windows, but please do that > in a separate patch. Or move the find call

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61422. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61421=61422 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > This seems to be entirely urelated to audio? I was trying to simplify code there by removing `NOT`. Should I remove this change? REPOSITORY R289 KNotifications REVISION DETAIL

D21660: change audio dep logic wrt win32

brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61421. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59551=61421 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

brute4s99 added a comment. may I land this? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > kio_sftp.cpp:29 > #include > -#include > this builds without `utime.h` on my system (Arch Linux with latest Plasma, Qt and other packages), . Please inform if someone else has issues without this header. REPOSITORY R320 KIO Extras

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61419. brute4s99 added a comment. Updated with `QT_` pre-procs for S_IFDIR, S_IFLNK and others. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61225=61419 BRANCH arcpatch-D22105 REVISION DETAIL

D21660: change audio dep logic wrt win32

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 added a comment. In D21660#481421 , @bcooksley wrote: > Where possible D-Bus should be avoided on Windows. Thanks for taking a look, @bcooksley! We already use dbus-daemon.exe for a lot of talking with the notifications and (I

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:2257 > Does > https://code.woboq.org/qt5/qtbase/mkspecs/common/posix/qplatformdefs.h.html#111 > work? yes! thanks Hannah!  REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 9 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61225. brute4s99 added a comment. added handling for WIndows. I'll try it on linux and revert on this patch! REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61035=61225 BRANCH arcpatch-D22105 REVISION

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. `S_IFLNK` is not defined on WIndows REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. ah, gotcha! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. I believe I have covered all the issues with the patch now. (: REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 61084. brute4s99 added a comment. renamed variables (start with `m_` now) REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=60035=61084 BRANCH arcpatch-D21661 REVISION DETAIL

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. In D22105#489954 , @vonreth wrote: > Any reason why you skip the symlinks? > I mean displaying thm should be fine, dolphin probably can also follow them. > Creating them on windows is a bit more problematic.

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked an inline comment as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:402 > What about the QFileInfo? For my use case, I could not find any possibility of symlinks, (traversing Android filesystem) so I left it blank in here for any future

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:12 > What requires this bump? ah, I thought QFileDevice needs it. Reverting this. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61035. brute4s99 marked 6 inline comments as done. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=60701=61035 BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 AFFECTED FILES

D22221: updated

brute4s99 abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D1 To: brute4s99 Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D22221: updated

brute4s99 created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D1

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 created this revision. brute4s99 added reviewers: albertvaka, vonreth, sredman. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY CAUTION : Still WIP. The main

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 10 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:84 > well, I just found out the patch had broken functionality that I fixed just > after putting here an `else return`!  I have fixed the issue now. REPOSITORY R289 KNotifications REVISION DETAIL

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 60035. brute4s99 marked 9 inline comments as done. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59835=60035 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in notifybysnore.cpp:84 > if the notification is not found, this will be an uninitialized pointer; TBH > if the search for the notification with the specified id fails, then it > should be better to return earlier, as it means the

D21660: change audio dep logic wrt win32

brute4s99 marked an inline comment as done. brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:42 > We don't need DBus on Windows, do we? we don't, I guess, but dbus-daemon.exe still runs in the background so I can't say. The functionality doesn't seem to

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59835. brute4s99 added a comment. updated acc to workaround for MSVC2019 suggested by Hannah added inline comment for it at L92 -- notifybysnore.cpp REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59826. brute4s99 added a comment. rebased on upstream/master REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59774=59826 BRANCH win32 (branched from master) REVISION DETAIL

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59774. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59766=59774 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59766. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59765=59766 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59765. brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59574=59765 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 67 inline comments as done. brute4s99 added a comment. updated code incoming. I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead?

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59574. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59573=59574 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59573. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59572=59573 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. Oh! Apologies, Pino. Actually I accidentally referred to you as toscanos from IRC, so I deleted that comment. I'll avoid deleting them from now on. INLINE COMMENTS > pino wrote in notifybysnore.cpp:38 > `QCoreApplication` is enough (see below) Actually, I also

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59572. brute4s99 added a comment. updated acc to new reviews by Pino and Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59425=59572 BRANCH win32 (branched from master) REVISION DETAIL

D21660: change audio dep logic wrt win32

brute4s99 retitled this revision from "simplify conditions and remove audio dependency for win32" to "change audio dep logic wrt win32". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: apol, nicolasfella, kde-frameworks-devel,

D21660: simplify conditions and remove audio dependency for win32

brute4s99 updated this revision to Diff 59551. brute4s99 added a comment. fixed indentation REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59376=59551 BRANCH simplify (branched from master) REVISION DETAIL

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 4 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59425. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated acc to review by Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59401=59425 BRANCH win32 (branched from

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. updating acc to review by pino REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59401. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated wrt review by toscanos REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59379=59401 BRANCH win32 (branched from

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 22 inline comments as done and an inline comment as not done. brute4s99 added a comment. update incoming INLINE COMMENTS > pino wrote in CMakeLists.txt:48-49 > why are these two needed? if snoretoast require them, then its cmake config > file must require them, so that the

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59379. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated wrt review. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59377=59379 BRANCH win32 (branched from master)

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 5 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > sredman wrote in CMakeLists.txt:43 > Do you know whether this requires MSVC, or can SnoreToast.exe be built with > MSVC and KNotifications be built with an unspecified compiler? AFAIU it *should work

D21659: add .vscode to .gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e4461e0ba978: add .vscode to .gitignore (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21659?vs=59375=59378 REVISION DETAIL

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 edited the summary of this revision. brute4s99 added reviewers: broulik, sredman, vonreth, albertvaka. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: kde-frameworks-devel, LeGast00n,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a dependency: D21602: Add NSIS Script for KDE Connect. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99 Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: simplify conditions and remove audio dependency for win32

brute4s99 added a dependency: D21657: remove phonon from deps if building for win32. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661

D21660: simplify conditions and remove audio dependency for win32

brute4s99 retitled this revision from "simplify conditions" to "simplify conditions and remove audio dependency for win32". brute4s99 edited the summary of this revision. brute4s99 added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660

D21660: simplify conditions

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D21660

D21659: add .vscode to .gitignore

brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH vscode (branched from master) REVISION DETAIL

<    1   2