Re: Strange commit to FindKDE4Internal.cmake

2012-02-18 Thread Ralf Habacker
Am 17.02.2012 15:07, schrieb Alexander Neundorf: Hi Alex I saw a recent commit from you to FindKDE4Internal.cmake: http://quickgit.kde.org/index.php?p=kdelibs.gita=commitdiffh=ca501aa9f4c1e7adcd42accbd53538502ba50ce3hp=3186e7a5f3acfaa5b5ac1b5cce9315eb53f54655 with the commit message on win32

Re: kdelibs frameworks buildsystem under Windows

2013-02-17 Thread Ralf Habacker
Am 17.02.2013 15:37, schrieb Alexander Neundorf: On Sunday 17 February 2013, Ralf Habacker wrote: Am 16.02.2013 20:58, schrieb Alexander Neundorf: ... * What is this manifest stuff for ? When is this needed ? Which manifest stuff? This, and there's probably some macro going along

Re: kdelibs frameworks buildsystem under Windows

2013-02-17 Thread Ralf Habacker
Am 17.02.2013 15:35, schrieb Alexander Neundorf: On Sunday 17 February 2013, Laszlo Papp wrote: On Sun, Feb 17, 2013 at 2:39 PM, Ralf Habacker ralf.habac...@gmail.comwrote: Based on http://www.winkde.org/pub/kde/ports/win32/releases/stable/4.8.0/kdelibs-x 86-mingw4-4.8.0-2-bin.tar.bz2kdewin

Re: kdelibs frameworks buildsystem under Windows

2013-02-18 Thread Ralf Habacker
Am 17.02.2013 23:45, schrieb David Faure: On Sunday 17 February 2013 22:37:09 Ralf Habacker wrote: /lib/kde4/kio_file.dll: 26600 46 kdewin32_fopen 2662c 48 kdewin32_lstat 2664c 53 kdewin32_stat ./bin/libkio.dll: 36e944 43

Re: kdelibs frameworks buildsystem under Windows

2013-02-20 Thread Ralf Habacker
Am 17.02.2013 14:47, schrieb Laszlo Papp: Off-topic for now, but I would like to leave a note here: it would be nice to find the time to eliminate kdewin from as many places as possible. There are lots of things that are available in Qt nowadays. It would be worth the effort to give it a try

Re: Somebody interested in porting mingw manifest support into cmake ?

2013-03-26 Thread Ralf Habacker
Am 24.03.2013 16:19, schrieb Alexander Neundorf: Hi, in kdelibs in the frameworks branch, we are trying to get rid of KDE-specific extensions, both for Qt and for cmake. This means also no longer kde4_add_executable(), but plain cmake add_executable() instead. kde_add_executable is a hook to

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Ralf Habacker
tool png2ico, which is provided by the kdewin-tools binary package. Sources are available at https://projects.kde.org/projects/kdesupport/kdewin. Diffs - modules/ECMAddAppIcon.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121448/diff/ Testing --- Thanks, Ralf

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
indentation. WINCE sure, will update the patch Also missing indentation. To which area of the file are you refering ? Looking on other files in the module subdirectory I see 2 or 4 spaces indention for cmake code. The script uses 4 spaces. On Dez. 11, 2014, 5:02 nachm., Ralf Habacker wrote

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
/#comment50080 dito set(${appsources} ${${appsources}};${_outfilename}.icns PARENT_SCOPE) - Ralf Habacker On Dez. 11, 2014, 4:40 nachm., Ralf Habacker wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-15 Thread Ralf Habacker
/uploaded/files/2014/12/15/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake ECMAddAppIcon.cmake https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake Thanks, Ralf Habacker

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-18 Thread Ralf Habacker
be empty, and the icon would never be appended to _list. Ralf Habacker wrote: The doc in the origin cmake macro file seems to be out of sync with the official doc located in FindKDE4Internals.cmake, which is: --- # adds

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
be empty, and the icon would never be appended to _list. Ralf Habacker wrote: The doc in the origin cmake macro file seems to be out of sync with the official doc located in FindKDE4Internals.cmake, which is: --- # adds

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
be empty, and the icon would never be appended to _list. Ralf Habacker wrote: The doc in the origin cmake macro file seems to be out of sync with the official doc located in FindKDE4Internals.cmake, which is: --- # adds

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-24 Thread Ralf Habacker
/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake ECMAddAppIcon.cmake https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-01-05 Thread Ralf Habacker
src/lib/io/kdirwatch.cpp 71f1892180b51cf65426696b4ffe918a02debba0 src/lib/io/kdirwatch_p.h 12839fdf4af5312eae3a636cec73f9dd2a41057d src/lib/io/kdirwatch_win.cpp 846e91ab1c932fbe1117ca6e3de3008f7f3a2130 Diff: https://git.reviewboard.kde.org/r/121861/diff/ Testing --- Thanks, Ralf

Re: Review Request 121852: Fix cross compile error not using the correct case for windows api include file

2015-01-11 Thread Ralf Habacker
/r/121852/diff/ Testing --- Checked with building of https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF5/mingw32-kcoreaddons Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.

2015-01-05 Thread Ralf Habacker
/home:rhabacker:branches:windows:mingw:win32:KF5/mingw32-karchive Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-01-05 Thread Ralf Habacker
12839fdf4af5312eae3a636cec73f9dd2a41057d src/lib/io/kdirwatch_win.cpp 846e91ab1c932fbe1117ca6e3de3008f7f3a2130 Diff: https://git.reviewboard.kde.org/r/121861/diff/ Testing --- Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde

No version tags in KF5 repos ?

2015-07-04 Thread Ralf Habacker
Hi, the kde4 repos I know have git tags for all released versions, so I just tried to find out the changes in git repo kiconthemens between 5.10.0 and 5.11.0 but did not found the related git tag. git tag shows: v4.100.0-rc1 v4.100.0-rc2 v4.95.0 v4.96.0 v4.97.0 v4.99.0-rc1 v4.99.0-rc3 v5.0.0

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-07-19 Thread Ralf Habacker
://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/41da2dde-71f1-444c-8681-523aecb11edf__0001-Remove-obsolate-class-KFileSystemWatcher-which-is-ha.patch Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Question about goal of Windows/Mac frameworks

2015-10-22 Thread Ralf Habacker
Am 21.10.2015 um 01:19 schrieb Aleix Pol: > On Wed, Oct 21, 2015 at 1:12 AM, Ralf Habacker <r...@habacker.de> wrote: >>> Christoph Cullmann <cullm...@absint.com> hat am 20. Oktober 2015 um 16:49 >>> geschrieben: >>> That works only, if the applications b

Re: Question about goal of Windows/Mac frameworks

2015-10-25 Thread Ralf Habacker
> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 > geschrieben: > For Krita, we decided ages ago to simply open a browser on the userbase > manual of Krita. Yes, it is conceivable that there are people who use > Krita without internet access who still need help, it's just

Re: Question about goal of Windows/Mac frameworks

2015-10-26 Thread Ralf Habacker
Am 26.10.2015 um 10:33 schrieb Christoph Cullmann: > Hi, > >>> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 >>> geschrieben: >>> For Krita, we decided ages ago to simply open a browser on the userbase >>> manual of Krita. Yes, it is conceivable that there are people who use

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-11-08 Thread Ralf Habacker
Attachments KDE4 related patch https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/41da2dde-71f1-444c-8681-523aecb11edf__0001-Remove-obsolate-class-KFileSystemWatcher-which-is-ha.patch Thanks, Ralf Habacker ___ Kde-frameworks

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Ralf Habacker
> On Nov. 4, 2015, 1:43 vorm., Aleix Pol Gonzalez wrote: > > Bump? Anyone with docs.kde.org knowledge around? > > Ben Cooksley wrote: > As long as the application name is being submitted in lower case, it > should work fine. > > Examples: >

Re: Question about goal of Windows/Mac frameworks

2015-10-20 Thread Ralf Habacker
> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: > Regarding dbus especifically, I see the problem in 2). You can bundle > it, but then if it's already ran by another process the other one will > have to be used, which is where the dbus mess starts. There is work in

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Ralf Habacker
> Christoph Cullmann hat am 20. Oktober 2015 um 16:49 > geschrieben: > That works only, if the applications bundle their ui files in resources, too, > otherwise, they just won't be found > and the applications break, unless you patch again Qt to look in non-standard >

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Ralf Habacker
Am 21.10.2015 um 08:14 schrieb Christoph Cullmann: > Hi, > >>> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: >>> Regarding dbus especifically, I see the problem in 2). You can bundle >>> it, but then if it's already ran by another process the other one will >>> have

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 99f1d3db1e089f01bbe0c5b58868a7c968bc4b30 by Ralf Habacker to branch master. Repository: kcoreaddons Description --- Add cross compile support for desktoptojson. Diffs

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` >

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
ard.kde.org/r/126494/#review90552 --- On Jan. 4, 2016, 3:11 nachm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` >

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-03 Thread Ralf Habacker
> On Jan. 3, 2016, 4:22 nachm., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Review Request 126495: Install parsetrigrams tool for cross compiling.

2015-12-23 Thread Ralf Habacker
://git.reviewboard.kde.org/r/126495/diff/ Testing --- Cross compiled package build at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-sonnet Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde

Review Request 126494: Add cross compile support for desktoptojson.

2015-12-23 Thread Ralf Habacker
/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-kcoreaddons Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kconfig question

2016-01-28 Thread Ralf Habacker
Am 28.01.2016 um 09:48 schrieb David Faure: > On Wednesday 27 January 2016 10:32:50 Boudewijn Rempt wrote: >> On Sat, 23 Jan 2016, David Faure wrote: >> >>> Not sure this answers Boud's question, since he *is* seeing "Local" on >>> Windows. >>> He said: "I noticed that krita on windows wrote its

Re: Deadlock in kded whith Qt 5.6

2016-01-21 Thread Ralf Habacker
Am 21.01.2016 um 08:37 schrieb David Faure: > > With this patch applied, here's one log for the first call > (autostart+autoload, doesn't work) > > http://www.davidfaure.fr/2016/first_call.txt > > and one log for the second call (kded already started, autoload works) > >

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

2016-03-01 Thread Ralf Habacker
Am 01.03.2016 um 09:16 schrieb Nick Shaforostoff: > At the moment we're playing Battleship to see if an icon is present in > a subdirectory. This means that we are checking on every directory if > there's an icon that matches the size with a said name on every request. > > > This can be seen

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

2016-05-05 Thread Ralf Habacker
at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-sonnet Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

2016-09-26 Thread Ralf Habacker
last sentence part of another conversation that I missed? > > Ralf Habacker wrote: > This patch does it the same way as already implemented in kcoreaddons > https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11. > > Aleix Pol Gonzalez wrot

Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Ralf Habacker
/home:rhabacker:branches:KDE:Frameworks526/kdoctools Thanks, Ralf Habacker

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-09-21 Thread Ralf Habacker
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6f20bfd27cb486136f3dec7264085db1a077ad1c by Ralf Habacker to branch master. Repository: kcoreaddons Description --- Add cross compile support for desktoptojson. Diffs

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Ralf Habacker
mple mingw32-cross-gcc. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128969/#review99351 --- On Sept. 21, 2016,

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Ralf Habacker
> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote: > > src/CMakeLists.txt, line 173 > > <https://git.reviewboard.kde.org/r/128969/diff/1/?file=477241#file477241line173> > > > > docbookl10nhelper is not meant to be installed > > Ralf Habacker

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

2016-09-21 Thread Ralf Habacker
- On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128968/ >

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

2016-09-21 Thread Ralf Habacker
> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote: > > Would it make more sense to change meinproc5 to work like checkXML5 if > > invoked with that name (hardlink, copy, etc, a-la busybox)? > > Ralf Habacker wrote: > Sorry, I do not know the reasons why th

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

2016-09-22 Thread Ralf Habacker
marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 6d1485bece7ad3dbe4c64f517643c50076c68e7d by Ralf Habacker to branch master. Repository: kdoctools Description --- Convert checkxml5 into a qt executable

Re: Review Request 128970: Add cross compile support for meinproc5.

2016-09-26 Thread Ralf Habacker
ly, visit: https://git.reviewboard.kde.org/r/128970/#review99352 ------- On Sept. 21, 2016, 11:44 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 128970: Add cross compile support for meinproc5.

2016-09-26 Thread Ralf Habacker
marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit d6f7aa2a1641569e119ba81697fe29104b82fb5e by Ralf Habacker to branch master. Repository: kdoctools Description --- Add cross compile support for meinproc5

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Ralf Habacker
/CMakeLists.txt 48b61e95b0ec9f0b19dd312cc7bd805f9dd58fd2 Diff: https://git.reviewboard.kde.org/r/128969/diff/ Testing --- compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools Thanks, Ralf Habacker

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Ralf Habacker
> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote: > > src/CMakeLists.txt, line 173 > > <https://git.reviewboard.kde.org/r/128969/diff/1/?file=477241#file477241line173> > > > > docbookl10nhelper is not meant to be installed > > Ralf Habacker

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-27 Thread Ralf Habacker
marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit cbfaec415ea8fd3d0c6182de087763d6280f3aae by Ralf Habacker to branch master. Repository: kdoctools Description --- Add cross compiling support

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

2016-09-26 Thread Ralf Habacker
last sentence part of another conversation that I missed? > > Ralf Habacker wrote: > This patch does it the same way as already implemented in kcoreaddons > https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11. > > Aleix Pol Gonzalez wrot

Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

2016-09-26 Thread Ralf Habacker
--- Thanks, Ralf Habacker

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

2016-09-26 Thread Ralf Habacker
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/#review99539 --- On Sept. 26, 2016, 4:23 nachm., Ralf Habacker wrote: > > --- > This is an a

Review Request 129314: Setup targets for cross compiling.

2016-11-02 Thread Ralf Habacker
437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker
for valid docbooks'. BUG:371987 Diffs - src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup targets for cross compiling.

2016-11-04 Thread Ralf Habacker
generates html files in workdir for valid docbooks'. BUG:371987 Diffs (updated) - src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker
fixed with patch revision 2, where checkXML5 redirects meinproc5 stderr output to stderr. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100556 -

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker
ably uses revision 1 of this patch. This is fixed with patch > revision 2, where checkXML5 redirects meinproc5 stderr output to stderr. > > Burkhard Lück wrote: > You are right, sorry for the noise. > checkXML5+meinproc5 work now as before So I have a go ? - Ralf -

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker
marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 29c0ecf99c50bb4bed62a4d90f45e5c9e3899d1c by Ralf Habacker to branch master. Bugs: 371987 https://bugs.kde.org/show_bug.cgi?id=371987 Repository: kdoctools

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-27 Thread Ralf Habacker
habacker added a comment. > The question is, can you add libexec to the path (so that findExecutable works) only for kf5-based executables (so that kde4 apps don't break) ? no > If not, then your description of the problem was incorrect and this is not just about dbus-started

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-27 Thread Ralf Habacker
habacker added a comment. In any discussion about libexec related issues we keep hitting the fact that there is no standard env var for it. Maybe we need a custom one (which could then be KF5_LIBEXEC_PATH, so it won't conflict with KF6). Because every KDE application installers bundles a

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-26 Thread Ralf Habacker
habacker added a comment. I did not took a look into every location where an executable is installed into KDE_INSTALL_LIBEXECDIR_KF5, but I guess on Windows any application which may be started *only* by a KF5 provided api may be located in the libexec dir ; all other needs to stay into

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-26 Thread Ralf Habacker
habacker added inline comments. INLINE COMMENTS > kbugreport.cpp:527 > if (command.isEmpty()) { > -command = QFile::decodeName(CMAKE_INSTALL_PREFIX "/" > KF5_LIBEXEC_INSTALL_DIR "/ksendbugmail"); > +command = QFile::decodeName(CMAKE_INSTALL_PREFIX "/" >

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-26 Thread Ralf Habacker
habacker added a comment. You saw the related bug report at https://bugs.kde.org/show_bug.cgi?id=374347 ? "ksendbugmail is installed into KDE_INSTALL_LIBEXECDIR_KF5, which seems to be set on Windows to 'bin'. At KDE4 times all executables are installed in /bin to be findable by dbus

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

2017-03-25 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG:377686 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5175 AFFECTED FILES

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-25 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The executable is now named ksendbugmail5. BUG:374347 REPOSITORY R263 KXmlGui BRANCH 374347 REVISION DETAIL

Review Request 130228: Mingw32 compile fix

2017-08-16 Thread Ralf Habacker
Description --- Mingw32 compile fix Diffs - src/solid/networking_p.h 894f2fa9259ed3626c6a5e10970eca55afa8cd79 src/solid/networking_win.cpp 354ab3acf6e0d771907792270f209394065ae94b Diff: https://git.reviewboard.kde.org/r/130228/diff/ Testing --- Thanks, Ralf Habacker

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

2017-07-12 Thread Ralf Habacker
1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 Diff: https://git.reviewboard.kde.org/r/130177/diff/ Testing --- Thanks, Ralf Habacker

Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

2017-07-12 Thread Ralf Habacker
://git.reviewboard.kde.org/r/130177/diff/ Testing --- Thanks, Ralf Habacker

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

2017-07-14 Thread Ralf Habacker
Diffs (updated) - src/kdecore/kurl.h 1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 Diff: https://git.reviewboard.kde.org/r/130177/diff/ Testing --- Thanks, Ralf Habacker

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

2017-07-17 Thread Ralf Habacker
ard.kde.org/r/126495/#review95229 --- On Mai 5, 2016, 9:55 nachm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

2017-07-17 Thread Ralf Habacker
ch, but do not have access rights to upload the path, so I appended it here: commit ec98addbfbba62310e050046078380c10192b829 Author: Ralf Habacker <ralf.habac...@freenet.de> Date: Mon Jul 17 11:16:39 2017 +0200 Make building with QtDBus optional This patch adds an ENABLE_DBUS C

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-07-12 Thread Ralf Habacker
habacker added a comment. > So bin isn't in %PATH%, but found relatively to the app being run? yes > This makes me wonder if libexec could be bin/libexec/kf5/ on Windows, relative too. This requires to add support for finding executables located in libexec based on install

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

2017-07-14 Thread Ralf Habacker
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 95a3a5c54518168d5b6ef38a7698b0cf6cdc647b by Ralf Habacker to branch master. Bugs: 382242 https://bugs.kde.org/show_bug.cgi?id=382242 Repository: kdelibs4support Description

D7008: Don't export internal helper executables

2017-08-08 Thread Ralf Habacker
habacker added a comment. In https://phabricator.kde.org/D7008#133755, @sitter wrote: > In https://phabricator.kde.org/D7008#133644, @sitter wrote: > > > https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11

D7008: Don't export internal helper executables

2017-08-08 Thread Ralf Habacker
habacker added a comment. In https://phabricator.kde.org/D7008#133644, @sitter wrote: > (kind of off topic: This code should really be changed to use the `KF5_HOST_TOOLING` we use elsewhere You can show me a working example of this KF5_HOST_TOOLING support ? REPOSITORY R246

D7008: Don't export internal helper executables

2017-08-08 Thread Ralf Habacker
habacker added a comment. In https://phabricator.kde.org/D7008#133779, @sitter wrote: > > I think @apol wrote the initial implementation of this magic and can probably answer questions better than me though :) I guess no. He also did not provide a working example see

Re: relocatable kdoctools

2017-08-22 Thread Ralf Habacker
Hi, I'm using the following patch to cross build kdoctools for windows https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:KF536/mingw32-kdoctools/0001-Generate-xml-files-containing-relative-pathes-to-dtd.patch?expand=1 It requires only a little platform

Re: Compilation failure on Windows: kpeople

2017-05-28 Thread Ralf Habacker
Am 27.05.2017 um 23:31 schrieb Ben Cooksley: > On Wed, May 17, 2017 at 7:33 AM, Ralf Habacker <ralf.habac...@freenet.de> > wrote: >> Hi >>> When someone gets the chance, could they please look into the build >>> log at >>> https://build-sandb

Re: Compilation failure on Windows: kpeople

2017-05-16 Thread Ralf Habacker
Hi > When someone gets the chance, could they please look into the build > log at > https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console > to see why this Framework isn't building on Windows? from my recent experience with building kmymoney on Windows this

D7706: Use runtime install prefix instead of compile time install prefix.

2017-09-11 Thread Ralf Habacker
habacker added a comment. > If all you need is , you can use QCoreApplication::applicationDirPath(). Did a further look into this stuff and found https://cgit.kde.org/kinit.git/commit/src/kdeinit/kinit_win.cpp?id=6b0ddac715475d7ed36a15f180c755f0f978b7cf. In KDE times there were

Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-06 Thread Ralf Habacker
/130209/diff/ Testing --- Thanks, Ralf Habacker

D7706: Use runtime install prefix instead of compile time install prefix.

2017-09-06 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D7706 AFFECTED FILES src/kdeinit/kinit_win.cpp To: habacker Cc:

D7707: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-06 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG:382920 REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D7707 AFFECTED FILES

D7707: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-06 Thread Ralf Habacker
habacker edited the summary of this revision. habacker added a reviewer: cfeck. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7707 To: habacker, cfeck Cc: #frameworks

D7708: Use runtime install prefix instead of compile time install prefix.

2017-09-06 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY see title REPOSITORY R303 KInit BRANCH temp REVISION DETAIL https://phabricator.kde.org/D7708 AFFECTED FILES

D7706: Use runtime install prefix instead of compile time install prefix.

2017-09-10 Thread Ralf Habacker
habacker added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure Cc: dfaure, #frameworks

D7706: Use runtime install prefix instead of compile time install prefix.

2017-09-10 Thread Ralf Habacker
habacker added a comment. Does QStandardPaths provide a parameter to retrieve the runtime binary install location ? For example if kdeinit5.exe is located in /bin it should return or if is installed in and there is no 'bin' dir in path it should return ? With

D7707: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-10 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R303:f75926ea16f0: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe' (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7707?vs=19232=19364#toc

Re: relocatable kdoctools

2017-08-24 Thread Ralf Habacker
Am 23.08.2017 um 14:15 schrieb Harald Sitter: > On Tue, Aug 22, 2017 at 10:47 PM, Ralf Habacker > <ralf.habac...@freenet.de> wrote: >> Hi, >> >> I'm using the following patch to cross build kdoctools for windows >> >> ht

Re: relocatable kdoctools

2017-08-30 Thread Ralf Habacker
Am 29.08.2017 um 15:03 schrieb Harald Sitter: > On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano > wrote: >> Even without the if branch it would be still complicated. > Ah! I think I get the complexity now. At build time we need to run our > tools already and so the

Re: relocatable kdoctools

2017-08-31 Thread Ralf Habacker
Am 29.08.2017 um 14:16 schrieb Harald Sitter: > On Thu, Aug 24, 2017 at 3:20 PM, Ralf Habacker <ralf.habac...@freenet.de> > wrote: >> 10. The conclusion of 9. is that it might also be a solution on windows >> to patch only all generated files after 3. and before 4. > H

Re: KDE Frameworks on Android

2017-11-30 Thread Ralf Habacker
Am 30.11.2017 um 21:21 schrieb Aleix Pol: > Hi, > Recently I put together some CI for Android, where some frameworks are > being checked to _build_ for Android + ARM. > > Now there's many frameworks that can't be built at the moment, you can > see them listed here: >

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-12-17 Thread Ralf Habacker
habacker added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To: habacker, dfaure Cc: bcooksley, dfaure, aacid, #frameworks

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

2017-12-17 Thread Ralf Habacker
habacker added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure Cc: #frameworks

D9381: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml

2017-12-17 Thread Ralf Habacker
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compiled kwallet REPOSITORY R311 KWallet BRANCH master REVISION DETAIL

Re: KDE Frameworks on Android

2017-12-01 Thread Ralf Habacker
Am 01.12.2017 um 21:27 schrieb Aleix Pol: > On Thu, Nov 30, 2017 at 10:16 PM, Ralf Habacker > <ralf.habac...@freenet.de> wrote: >> Am 30.11.2017 um 21:21 schrieb Aleix Pol: >>> Hi, >>> Recently I put together some CI for Android, where some frameworks are >

  1   2   3   4   >