Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Raphael Kubo da Costa
into this case. - Raphael Kubo da Costa On Jan. 30, 2014, 1:18 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Raphael Kubo da Costa
On Feb. 3, 2014, 8:07 p.m., Raphael Kubo da Costa wrote: Please see the big comment below the elseif line, the link to the kde-core-devel and http://lists.kde.org/?l=kde-core-develm=138244424421211w=2: the issue here is that if you pass -fno-exceptions to clang you need to guarantee

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Raphael Kubo da Costa
land looks better than the one in KDE4. - Raphael Kubo da Costa On March 4, 2014, 11:02 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395

Review Request 119291: Use an input type=search for the search box.

2014-07-15 Thread Raphael Kubo da Costa
/templates/base.html 10f8aa6dae14e0ad6e649bdb28fcba81b7d39341 Diff: https://git.reviewboard.kde.org/r/119291/diff/ Testing --- Thanks, Raphael Kubo da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 119291: Use an input type=search for the search box.

2014-07-15 Thread Raphael Kubo da Costa
to get rid of the custom script to clean up its value. Diffs - src/kapidox/data/templates/base.html 10f8aa6dae14e0ad6e649bdb28fcba81b7d39341 Diff: https://git.reviewboard.kde.org/r/119291/diff/ Testing --- Thanks, Raphael Kubo da Costa

Re: Review Request 119289: Remove api_searchbox.html.

2014-07-15 Thread Raphael Kubo da Costa
/119289/diff/ Testing --- Thanks, Raphael Kubo da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119289: Remove api_searchbox.html.

2014-07-15 Thread Raphael Kubo da Costa
9fd1ade894680f7f41ca498d0bc4a8dd684c0e98 Diff: https://git.reviewboard.kde.org/r/119289/diff/ Testing --- Thanks, Raphael Kubo da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: ark fails to build on branch frameworks

2015-01-14 Thread Raphael Kubo da Costa
David Faure fa...@kde.org writes: On Wednesday 14 January 2015 08:49:15 Marko Käning wrote: What’s going on? I'm not sure the ark developers read kde-frameworks-devel... This is related to libarchive, and therefore unrelated to KF5 itself. That's true, thanks Marko for sending me an email

Re: OSX/CI: ark fails to build on branch frameworks

2015-01-16 Thread Raphael Kubo da Costa
Marko Käning mk-li...@email.de writes: Hi Raphael, On 14 Jan 2015, at 22:11 , Raphael Kubo da Costa rak...@freebsd.org wrote: Is the full build log available somewhere, preferably with `make VERBOSE=1'? This really smells like OS X having an older ( 3.0) version of libarchive in its base

Review Request 129246: validate_svg: Increase portability

2016-10-23 Thread Raphael Kubo da Costa
2591a3a0c9c397a729243ceb414251f296895888 validate_svg.sh adaf26f95a645b57f8a588fdd49d2281f24b684a Diff: https://git.reviewboard.kde.org/r/129246/diff/ Testing --- Configuration continues to work, as well as the `breeze-validate-svg` continues working. Thanks, Raphael Kubo da Costa

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

2017-06-03 Thread Raphael Kubo da Costa
rakuco added a comment. See also: https://git.reviewboard.kde.org/r/129246/ REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D6076 To: tcberner, #freebsd, winterz Cc: rakuco, #frameworks

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-12 Thread Raphael Kubo da Costa
rakuco requested changes to this revision. rakuco added a comment. This revision now requires changes to proceed. @kossebau's right: the problem lies in `lookandfeeltool` depending on `kcm.cpp`, while the `kcoreaddons_desktop_to_json()` call makes the `kcm_lookandfeel` target depend on the

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-17 Thread Raphael Kubo da Costa
rakuco added a comment. Per my previous comment, I still don't see how changing this to a target would solve anything. For one, the CMake implementation allows both files and targets to

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-17 Thread Raphael Kubo da Costa
rakuco added a comment. > This isn't just a problem on KDE Neon though, is it? I thought FreeBSD is also affected? To be clear, FreeBSD is affected by not having any fix in the tree (i.e. the json file not being present when moc is invoked), whereas Neon fails with D10485

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-18 Thread Raphael Kubo da Costa
rakuco added a comment. I agree this can be abandoned -- whatever solution we agree upon should probably be done in plasma-desktop. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco Cc: bcooksley,

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2016-12-29 Thread rakuco (Raphael Kubo da Costa)
rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES